is_this_used 0.1.4 → 0.1.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d781ed2774ddda32adf7b68b87cc0666e6c08de682b07ab2fbec2daa45f02789
-  data.tar.gz: fd32bc27fa9ece52099e5cc1214394c14753478c7677c70ab04e4b31ca92a3f6
+  metadata.gz: 6d99ea88778f65e0685fa42ec856e9a61b5414ad87e1963f21f8d8941ee62eea
+  data.tar.gz: 7f5bf7cb77f3688c14035480a1ed16130998f004a6add05afc125bd18f21b6fa
 SHA512:
-  metadata.gz: 9da3a8cfda9bc44da06b7732e205d410709a2166568cbaacd8c17020b2960f40cfd2043ea82cd6dc96eb8a37aa7c08ae616669683cde524087b88f6f083fdb3c
-  data.tar.gz: 8c0ae318620b3808a775c9c9d9301bc942d4426dea9981eba78433e5055d1b1484ddc717b836afdd9b9b12a5921b81cba39d839ee3bb3cb46af8d7a29600b4a9
+  metadata.gz: 5e7acfe828e892998c319ca07bc6bc2ff2bf91c5c2e9e65debbb67f7aacd9c07f9561af8e2fc37dfc140f2ade3d97530fcaf5b9e65a5c13b8a15c60320cc0c92
+  data.tar.gz: dc4363da4d9030568766e2d37cf2c932f5b5bf35d8c5b20d6587c45f12f3c4953357048155e9664523059da54e4d3f8e534578ebd9bc76d9e601c55bb46888b6

data/Dockerfile

@@ -0,0 +1,24 @@
+FROM ruby:2.7.5-slim-bullseye
+
+WORKDIR /app
+
+RUN apt-get update -qq \
+  && apt-get install --no-install-recommends -y \
+    less \
+    nano \
+    mariadb-client-10.5 \
+    libmariadb-dev-compat \
+    libmariadb-dev \
+    build-essential \
+    git \
+    shared-mime-info
+
+ARG BUNDLER_VERSION=2.1.4
+
+ENV BUNDLE_PATH /bundle
+ENV GEM_HOME /bundle
+
+RUN gem update --system \
+    && gem install bundler -v ${BUNDLER_VERSION}
+
+CMD /bin/bash

data/README.md

@@ -1,4 +1,4 @@
-Have you ever asked yourself, "Is this method even being used?!" Does your application use ActiveRecord? If the answers
+Have you ever asked yourself, "Is this method even being used?!" Does your application use Rails and ActiveRecord? If the answers
 to these two questions are yes, this gem may be of use to you!
 
 Large applications can accrue cruft; old methods that might once have been important, but are now unused. Unfortunately,
@@ -59,7 +59,6 @@ You're unsure if the `some_old_method` method is actually being used. You only n
 Here's an example:
 
 ```ruby
-
 class SomeOldClass
   include IsThisUsed::CruftTracker
 
@@ -74,9 +73,9 @@ end
 What do you get out of this? Well, as soon as Ruby loads the `SomeOldClass` class, is_this_used will create a new record
 in the `potential_crufts` table that looks like this:
 
-| id  | owner_name   | method_name     | method_type     | invocations | created_at          | updated_at          |
-| --- | ------------ | --------------- | --------------- | ----------- | ------------------- | ------------------- |
-| 1   | SomeOldClass | some_old_method | instance_method | 0           | 2022-01-21 14:07:48 | 2022-01-21 14:07:48 | 
+| id  | owner_name   | method_name     | method_type     | invocations | deleted_at | created_at          | updated_at          |
+| --- | ------------ | --------------- | --------------- | ----------- | ---------- | ------------------- | ------------------- |
+| 1   | SomeOldClass | some_old_method | instance_method | 0           | null       | 2022-01-21 14:07:48 | 2022-01-21 14:07:48 | 
 
 This is easily accessed using the `IsThisUsed::PotentialCruft` model class.
 
@@ -88,8 +87,9 @@ The fields are:
 - `method_type` - This is either "instance_method" or "class_method", which are the values of the corresponding
   constants, `IsThisUsed::CruftTracker::INSTANCE_METHOD` and `IsThisUsed::CruftTracker::CLASS_METHOD`.
 - `invocations` - The number of times the method has been invoked.
+- `deleted_at` - When set, this indicates that the method is no longer being tracked.
 - `created_at` - The date/time we started tracking the method.
-- `updated_at` - The last time this record was updated.
+- `updated_at` - The last time this record was updated. IE: the last time the tracked method was invoked.
 
 Looking at this, we can see that the `some_old_method` method has never been invoked. This is nice because it means that
 you can track uses of methods without changing their behavior. A similar record is created for every method you annotate
@@ -98,10 +98,12 @@ with `is_this_used?`.
 Assuming your production application eagerly loads classes, you should always have records for potentially crufty
 methods, even if the class itself is never explicitly used.
 
-So, having annotate the method, you can check this table after a while. If you see that there have been zero invocations
+So, having annotated the method, you can check this table after a while. If you see that there have been zero invocations,
 you have a reasonably good hint that the method may not actually be used. Of course, you should consider that there are
 some processes that are not run frequently at all, so this gem isn't a panacea. Think before you delete!
 
+### Tracking Stacks
+
 In the case that a method _is_ actually invoked, the `invocations` value is incremented and a record is created in
 the `potential_cruft_stacks` table for each unique invocation stacktrace. This can be used to determine which methods
 and blocks are responsible for calling the method and are themselves being used. This is the structure of
@@ -113,11 +115,11 @@ the `potential_cruft_stacks` table:
 - `stack_hash` - This is an MD5 hash of the stack trace for the method's invocation. This is indexed for speedy lookups
   of stacks.
 - `stack` - This is a JSON field that stores an array of hashes (more on this in a sec) that is the stack trace for the
-  method invocation. You can potentially use this to figure out what other methods and blocks involved in calling the
+  method invocation. You can potentially use this to figure out what other methods and blocks are involved in calling the
   not-actually-crufty method.
 - `occurrences` - This is the number of times the method has been invoked with exactly the same stack.
 - `created_at` - The date/time we first saw this stack.
-- `updated_at` - The last time this saw this stack.
+- `updated_at` - The last time we saw this stack.
 
 As a note, if any of the files referenced in the stack are edited sufficiently to change line numbers, the stack will be
 different and a new record will be created.
@@ -146,7 +148,58 @@ The `label` and `base_label` fields come from Ruby's `Thread::Backtrace::Locatio
 difference is, as the docs simply say this about `base_label`: "Usually same as label, without decoration". 🤷 Anyhow,
 it's there if you need it.
 
-The `IsThisUsed::PotentialCruftStack` model is handy for accessing this data.
+### Tracking Arguments
+
+In addition to tracking stacks, you can track details about arguments provided to tracked methods. For example, let's say you have the following method:
+
+```ruby
+def some_old_method(arg1, arg2)
+  # do things
+end
+```
+
+Let's say that, for some reason you want to know what arguments are provided to this method. You could add `track_arguments: true` to your `is_this_used?` invocation like so:
+
+```ruby
+is_this_used? :some_old_method, track_arguments: true
+```
+
+Now, as `some_old_method` is invoked, a record will be created in `potential_cruft_arguments` for each unique set of arguments. Similar to `potential_cruft_stacks`, the record contains a hash of the JSON-serialized arguments, the JSON-serialized arguments, and the number of occurrences of the particular combination of arguments.
+
+Tracking all arguments might be a really bad idea. Let's say your method actually gets invoked a lot and receives lots of different combinations of arguments, you could be writing a lot of potentially useless information into the `potential_cruft_arguments` table. For this reason arguments are not tracked by default.
+
+Instead of tracking all arguments, you can also provide a lambda to `track_arguments` to track only specific details about arguments. The lambda will receive an array of arguments that were provided to the tracked method. Whatever is returned from the lambda is what is tracked in the `potential_cruft_arguments` table. This might be useful in a situation where you have a method that receives an options hash. Maybe you want to know what keys are in that options hash. You could track the unique combination of keys like this:
+
+```ruby
+def ye_olde_method(some_argument, options_hash)
+  # do things
+end
+
+is_this_used? :some_old_method, track_arguments: ->(args) { args.last.keys.sort }
+```
+
+As `ye_olde_method` is invoked is_this_used will track the unique combination of keys in the `options_hash`. Let's say it's invoked as follows:
+
+
+```ruby
+ye_olde_method("Fred", favorite_color: "blue", locality: 'Antartica')
+ye_olde_method("Zelda", locality: 'Hyrule', favorite_color: "green")
+ye_olde_method("Korg", color: 'Rebecca Purple', locality: 'Sakaar')
+ye_olde_method("Liz", status: :favorite_person)
+```
+
+The above would result in the following records in `potential_cruft_arguments` (ignoring the id, potential cruft reference, and timestamps):
+
+| arguments_hash                   | arguments                      | occurrences |
+| -------------------------------- | ------------------------------ | ----------- |
+| d5d98f761a14b1845a74ce3f1a298c98 | ["favorite_color", "locality"] | 2           |
+| 1619ec6af47253461e87ebf1923a8a83 | ["color", "locality"]          | 1           |
+| 88c8205498de97d4ef06b249006bb68b | ["status"]                     | 1           |
+
+
+
+
+## Models
 
 ### `IsThisUsed::PotentialCruft`
 
@@ -158,8 +211,13 @@ invocations of the method, if any.
 This is a model representing potential cruft stacks. Its `potential_cruft` method provides an association back to the
 owning potentially-crufty method.
 
+### `IsThisUsed::PotentialCruftArgument`
+
+This model represents information about arguments provided to a specific `potential_cruft` method. It is conditionally populated when the `track_arguments` method is provided with either true or a lambda.
+
 ## Dependencies
 
+* Rails - Versions 5.2, 6, and 6.1 are supported.
 * ActiveRecord - ActiveRecord is used to persist information about potentially crufty methods. This gem should happily
   work with AR 5.2, 6, and 6.1.
 * MySQL - As of now, only MySQL is supported. PRs are welcome to add support for Postgres, etc.
@@ -208,6 +266,37 @@ bundle exec appraisal rails-6.0 rake
 
 bundle exec appraisal rails-6.1 rake
 
+## Developing with Docker
+
+A Docker / docker-compose environment is available to simplify development. Assuming you already have Docker installed, you can spin up a MySQL and open a bash console on a container with Ruby installed like this:
+
+```bash
+docker-compose run --rm ruby bash
+```
+
+The MySQL server has its port exposed as 13306. Note that the first time you spin up these containers it may take a moment for mysql to successfully spin up.
+
+The gem's source is mapped to `/app`, which is also the working directory.
+
+Once you have a bash console open, you can install dependencies with:
+
+```bash
+bundle install
+bundle exec appraisal install
+```
+
+You can copy the provided MySQL DB config file to be the one to use in the test app:
+
+```bash
+cp spec/dummy_app/config/database.mysql.yml spec/dummy_app/config/database.yml
+```
+
+And now you should be able to run tests against whichever version of Rails you wish, like so:
+
+```bash
+bundle exec appraisal rails-6.1 rake
+```
+
 ## Contributing
 
 Bug reports and pull requests are welcome on GitHub at https://github.com/dhughes/is_this_used.

data/Rakefile

@@ -1,6 +1,24 @@
-require "bundler/gem_tasks"
-require "rspec/core/rake_task"
+# frozen_string_literal: true
 
-RSpec::Core::RakeTask.new(:spec)
+require "fileutils"
+require "bundler"
+require './spec/support/is_this_used_spec_migrator'
+Bundler::GemHelper.install_tasks
 
-task :default => :spec
+desc "Create the database."
+task :create_db do
+  ENV['RAILS_ENV'] = 'test'
+  system "mysqladmin -f -h #{ENV.fetch('IS_THIS_USED_DB_HOST', 'localhost')} -P #{ENV.fetch('IS_THIS_USED_DB_PORT', 3306)} -u #{ENV.fetch('IS_THIS_USED_DB_USER', 'root')} --password=#{ENV.fetch('IS_THIS_USED_DB_PASSWORD', 'dev')} drop is_this_used_test"
+  system "mysqladmin -h #{ENV.fetch('IS_THIS_USED_DB_HOST', 'localhost')} -P #{ENV.fetch('IS_THIS_USED_DB_PORT', 3306)} -u #{ENV.fetch('IS_THIS_USED_DB_USER', 'root')} --password=#{ENV.fetch('IS_THIS_USED_DB_PASSWORD', 'dev')} create is_this_used_test"
+
+  Bundler.setup
+  require 'active_record/railtie'
+  require 'is_this_used'
+  require 'rspec/rails'
+
+  require File.expand_path('spec/dummy_app/config/environment', __dir__)
+  ::IsThisUsedSpecMigrator.new.migrate
+end
+
+desc "Default: run all available test suites"
+task default: :spec

data/docker-compose.yml

@@ -0,0 +1,39 @@
+version: '3'
+services:
+  mysql:
+    image: mysql:8
+    container_name: square-mysql
+    command: --default-authentication-plugin=mysql_native_password
+    volumes:
+      - db_data:/var/lib/mysql
+    environment:
+      MYSQL_ROOT_PASSWORD: dev
+      MYSQL_DATABASE: is_this_used_test
+    ports:
+      - "13306:3306"
+
+  ruby:
+    build:
+      context: .
+      dockerfile: ./Dockerfile
+    depends_on:
+      - mysql
+    working_dir: /app
+    volumes:
+      - .:/app
+      - bundle:/bundle
+      - ./wait-for-it.sh:/usr/sbin/wait-for-it.sh:ro
+    environment:
+      - IS_THIS_USED_DATABASE=is_this_used_test
+      - IS_THIS_USED_DB_USER=root
+      - IS_THIS_USED_DB_HOST=mysql
+      - IS_THIS_USED_DB_PASSWORD=dev
+    links:
+      - mysql
+    tty: true
+    stdin_open: true
+
+volumes:
+  db_data:
+  bundle:
+

data/gemfiles/rails_5.2.gemfile.lock

@@ -1,49 +1,49 @@
 PATH
   remote: ..
   specs:
-    is_this_used (0.1.4)
+    is_this_used (0.1.7)
       activerecord (>= 5.2)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    actioncable (5.2.4.6)
-      actionpack (= 5.2.4.6)
+    actioncable (5.2.6.2)
+      actionpack (= 5.2.6.2)
       nio4r (~> 2.0)
       websocket-driver (>= 0.6.1)
-    actionmailer (5.2.4.6)
-      actionpack (= 5.2.4.6)
-      actionview (= 5.2.4.6)
-      activejob (= 5.2.4.6)
+    actionmailer (5.2.6.2)
+      actionpack (= 5.2.6.2)
+      actionview (= 5.2.6.2)
+      activejob (= 5.2.6.2)
       mail (~> 2.5, >= 2.5.4)
       rails-dom-testing (~> 2.0)
-    actionpack (5.2.4.6)
-      actionview (= 5.2.4.6)
-      activesupport (= 5.2.4.6)
+    actionpack (5.2.6.2)
+      actionview (= 5.2.6.2)
+      activesupport (= 5.2.6.2)
       rack (~> 2.0, >= 2.0.8)
       rack-test (>= 0.6.3)
       rails-dom-testing (~> 2.0)
       rails-html-sanitizer (~> 1.0, >= 1.0.2)
-    actionview (5.2.4.6)
-      activesupport (= 5.2.4.6)
+    actionview (5.2.6.2)
+      activesupport (= 5.2.6.2)
       builder (~> 3.1)
       erubi (~> 1.4)
       rails-dom-testing (~> 2.0)
       rails-html-sanitizer (~> 1.0, >= 1.0.3)
-    activejob (5.2.4.6)
-      activesupport (= 5.2.4.6)
+    activejob (5.2.6.2)
+      activesupport (= 5.2.6.2)
       globalid (>= 0.3.6)
-    activemodel (5.2.4.6)
-      activesupport (= 5.2.4.6)
-    activerecord (5.2.4.6)
-      activemodel (= 5.2.4.6)
-      activesupport (= 5.2.4.6)
+    activemodel (5.2.6.2)
+      activesupport (= 5.2.6.2)
+    activerecord (5.2.6.2)
+      activemodel (= 5.2.6.2)
+      activesupport (= 5.2.6.2)
       arel (>= 9.0)
-    activestorage (5.2.4.6)
-      actionpack (= 5.2.4.6)
-      activerecord (= 5.2.4.6)
-      marcel (~> 0.3.1)
-    activesupport (5.2.4.6)
+    activestorage (5.2.6.2)
+      actionpack (= 5.2.6.2)
+      activerecord (= 5.2.6.2)
+      marcel (~> 1.0.0)
+    activesupport (5.2.6.2)
       concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (>= 0.7, < 2)
       minitest (~> 5.1)
@@ -66,27 +66,25 @@ GEM
       railties (>= 3.0.0)
     globalid (1.0.0)
       activesupport (>= 5.0)
-    i18n (1.8.11)
+    i18n (1.10.0)
       concurrent-ruby (~> 1.0)
-    loofah (2.13.0)
+    loofah (2.14.0)
       crass (~> 1.0.2)
       nokogiri (>= 1.5.9)
     mail (2.7.1)
       mini_mime (>= 0.1.1)
-    marcel (0.3.3)
-      mimemagic (~> 0.3.2)
+    marcel (1.0.2)
     method_source (1.0.0)
-    mimemagic (0.3.10)
-      nokogiri (~> 1)
-      rake
     mini_mime (1.1.2)
+    mini_portile2 (2.8.0)
     minitest (5.15.0)
     mysql2 (0.5.3)
     nio4r (2.5.8)
-    nokogiri (1.13.1-x86_64-darwin)
+    nokogiri (1.13.3)
+      mini_portile2 (~> 2.8.0)
       racc (~> 1.4)
     parallel (1.21.0)
-    parser (3.1.0.0)
+    parser (3.1.1.0)
       ast (~> 2.4.1)
     pry (0.13.1)
       coderay (~> 1.1)
@@ -98,47 +96,47 @@ GEM
     rack (2.2.3)
     rack-test (1.1.0)
       rack (>= 1.0, < 3)
-    rails (5.2.4.6)
-      actioncable (= 5.2.4.6)
-      actionmailer (= 5.2.4.6)
-      actionpack (= 5.2.4.6)
-      actionview (= 5.2.4.6)
-      activejob (= 5.2.4.6)
-      activemodel (= 5.2.4.6)
-      activerecord (= 5.2.4.6)
-      activestorage (= 5.2.4.6)
-      activesupport (= 5.2.4.6)
+    rails (5.2.6.2)
+      actioncable (= 5.2.6.2)
+      actionmailer (= 5.2.6.2)
+      actionpack (= 5.2.6.2)
+      actionview (= 5.2.6.2)
+      activejob (= 5.2.6.2)
+      activemodel (= 5.2.6.2)
+      activerecord (= 5.2.6.2)
+      activestorage (= 5.2.6.2)
+      activesupport (= 5.2.6.2)
       bundler (>= 1.3.0)
-      railties (= 5.2.4.6)
+      railties (= 5.2.6.2)
       sprockets-rails (>= 2.0.0)
     rails-dom-testing (2.0.3)
       activesupport (>= 4.2.0)
       nokogiri (>= 1.6)
     rails-html-sanitizer (1.4.2)
       loofah (~> 2.3)
-    railties (5.2.4.6)
-      actionpack (= 5.2.4.6)
-      activesupport (= 5.2.4.6)
+    railties (5.2.6.2)
+      actionpack (= 5.2.6.2)
+      activesupport (= 5.2.6.2)
       method_source
       rake (>= 0.8.7)
       thor (>= 0.19.0, < 2.0)
     rainbow (3.1.1)
     rake (10.5.0)
-    regexp_parser (2.2.0)
+    regexp_parser (2.2.1)
     rexml (3.2.5)
-    rspec (3.10.0)
-      rspec-core (~> 3.10.0)
-      rspec-expectations (~> 3.10.0)
-      rspec-mocks (~> 3.10.0)
-    rspec-core (3.10.1)
-      rspec-support (~> 3.10.0)
-    rspec-expectations (3.10.2)
+    rspec (3.11.0)
+      rspec-core (~> 3.11.0)
+      rspec-expectations (~> 3.11.0)
+      rspec-mocks (~> 3.11.0)
+    rspec-core (3.11.0)
+      rspec-support (~> 3.11.0)
+    rspec-expectations (3.11.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.10.0)
-    rspec-mocks (3.10.2)
+      rspec-support (~> 3.11.0)
+    rspec-mocks (3.11.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.10.0)
-    rspec-rails (5.0.2)
+      rspec-support (~> 3.11.0)
+    rspec-rails (5.0.3)
       actionpack (>= 5.2)
       activesupport (>= 5.2)
       railties (>= 5.2)
@@ -146,7 +144,7 @@ GEM
       rspec-expectations (~> 3.10)
       rspec-mocks (~> 3.10)
       rspec-support (~> 3.10)
-    rspec-support (3.10.3)
+    rspec-support (3.11.0)
     rubocop (1.22.3)
       parallel (~> 1.10)
       parser (>= 3.0.0.0)
@@ -156,8 +154,8 @@ GEM
       rubocop-ast (>= 1.12.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 1.4.0, < 3.0)
-    rubocop-ast (1.15.1)
-      parser (>= 3.0.1.1)
+    rubocop-ast (1.16.0)
+      parser (>= 3.1.1.0)
     rubocop-rails (2.12.4)
       activesupport (>= 4.2.0)
       rack (>= 1.1)
@@ -167,7 +165,7 @@ GEM
     rubocop-rspec (2.5.0)
       rubocop (~> 1.19)
     ruby-progressbar (1.11.0)
-    sprockets (4.0.2)
+    sprockets (4.0.3)
       concurrent-ruby (~> 1.0)
       rack (> 1, < 3)
     sprockets-rails (3.4.2)
@@ -188,7 +186,7 @@ PLATFORMS
 
 DEPENDENCIES
   appraisal (~> 2.4.1)
-  bundler (~> 1.17)
+  bundler (~> 2.1)
   generator_spec (~> 0.9.4)
   is_this_used!
   mysql2 (~> 0.5.3)
@@ -203,4 +201,4 @@ DEPENDENCIES
   rubocop-rspec (~> 2.5.0)
 
 BUNDLED WITH
-   1.17.2
+   2.1.4