irv 0.1.1 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b8a99789b0cbe5756c7d1dfd5666e9096102c748a82dc51c8b032f8c9667fe94
-  data.tar.gz: bf4f6f58576731266a3d825a7bdb910ec1ddd7b355f39f3647bd40262d1f0a01
+  metadata.gz: '094a4e98ba00996613d8394a7a784c5e42452ccec63ca480f8f0bbd1e23923ff'
+  data.tar.gz: e8303a420c2e50c800a8b42cb99e86d3e93a74e6e5d4bae6066d3dcc916304c9
 SHA512:
-  metadata.gz: c4e2ec30b5492857c20edc92587e62f81c0720d0c20005b7c3e1537e82d3d01b865393601fc567b8be517df25d70b25000721c0757ef8b6bdf8c1f31462bd934
-  data.tar.gz: 3125e2cf89fda760e11bc0102feec0411f08d58c16e9d0e5e73e4e633ba30f8200481562f5df071118d632948e0029de7acf3838f76a2e38f762744f3d7a047e
+  metadata.gz: 0ded7eb4aef961ae5e4a5a29bc7b5689ce5b3ae115b072272450e8dca849472164bb94daaed81dbc88dfd27550357814a79882fab9cd64639a9a69450577ab54
+  data.tar.gz: 5154140b71dcd1b5611ee95eb430f080317d96d1fe13c65b42ee22fb5aef7e21507a80d3107a534507f7315955aa0ef0f5c004aa82be36d90754dde935606a15

data/.rubocop.yml

@@ -1,7 +1,15 @@
 AllCops:
-  TargetRubyVersion: 2.6.3
+  TargetRubyVersion: 2.4
   DisplayCopNames: true
 
+Layout/ExtraSpacing:
+  Exclude:
+    - 'irv.gemspec'
+
+Layout/SpaceAroundOperators:
+  Exclude:
+    - 'irv.gemspec'
+
 Style/AsciiComments:
   Enabled: false
 
@@ -17,6 +25,10 @@ Style/RegexpLiteral:
 Style/NegatedWhile:
   Enabled: false
 
+Style/WordArray:
+  Exclude:
+    - 'spec/irv_spec.rb'
+
 Metrics/AbcSize:
   Enabled: false
 

data/.travis.yml

@@ -3,5 +3,10 @@ sudo: false
 language: ruby
 cache: bundler
 rvm:
-  - 2.6.3
+  - 2.4
+  - 2.5
+  - 2.6
 before_install: gem install bundler -v 1.17.2
+script:
+  - bundle exec rubocop
+  - bundle exec rake spec

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    irv (0.1.1)
+    irv (0.2.0)
 
 GEM
   remote: https://rubygems.org/

data/README.md

@@ -1,4 +1,6 @@
 # Irv
+[![Gem Version](https://badge.fury.io/rb/irv.svg)](https://badge.fury.io/rb/irv)
+[![Build Status](https://travis-ci.org/highwide/irv.svg?branch=master)](https://travis-ci.org/highwide/irv)
 
 This gem provides [Instant-Runoff Voting](https://en.wikipedia.org/wiki/Instant-runoff_voting) for Ruby program.
 
@@ -25,16 +27,12 @@ require 'irv'
 
 irv = Irv.new(['John', 'Paul', 'Ringo', 'George'])
 
-ballots = []
-5.times { ballots << irv.issue_ballot }
-
-ballots[0].fill!(['John', 'George', 'Ringo'])
-ballots[1].fill!(['John', 'Ringo', 'George', 'Paul'])
-ballots[2].fill!(['Paul', 'George', 'Ringo', 'John'])
-ballots[3].fill!(['Ringo', 'Paul', 'George'])
-ballots[4].fill!(['George', 'Ringo', 'John'])
-
-ballots.each { |ballot| irv.poll!(ballot) }
+irv
+  .poll!(['John', 'George', 'Ringo'])
+  .poll!(['John', 'Ringo', 'George', 'Paul'])
+  .poll!(['Paul', 'George', 'Ringo', 'John'])
+  .poll!(['Ringo', 'Paul', 'George'])
+  .poll!(['George', 'Ringo', 'John'])
 
 puts irv.winner
 
@@ -79,7 +77,7 @@ So, Ringo got lose in this round
 
 George got three first ranked votes! It was a majority. So George became winner.
 
-#### If you know these stuff in a Ruby program
+#### If you want to know these stuff in a Ruby program
 
 ```ruby
 # After polled...

data/irv.gemspec

@@ -14,6 +14,7 @@ Gem::Specification.new do |spec|
   spec.description   = 'Instant-runoff Voting is a type of ranked preferential voting method. This gem makes it enable Ruby program.'
   spec.homepage      = 'https://github.com/highwide/irv'
   spec.license       = 'MIT'
+  spec.required_ruby_version = '>= 2.4.0'
 
   # Specify which files should be added to the gem when it is released.
   # The `git ls-files -z` loads the files in the RubyGem that have been added into git.

data/lib/irv.rb

@@ -10,5 +10,5 @@ module Irv
     Election.new(candidates)
   end
 
-  class FillingWithIncorrectCandidatesError < StandardError; end
+  class PollingWithIncorrectCandidatesError < StandardError; end
 end

data/lib/irv/election.rb

@@ -1,6 +1,5 @@
 # frozen_string_literal: true
 
-require 'irv/ballot'
 require 'irv/result'
 
 module Irv
@@ -12,12 +11,16 @@ module Irv
       @ballots = []
     end
 
-    def issue_ballot
-      Ballot.new(@candidates)
-    end
+    def poll!(ranked_candidates)
+      if incorrect_candidates?(ranked_candidates)
+        raise(
+          PollingWithIncorrectCandidatesError,
+          "Polling #{ranked_candidates}, but acceptable for only #{@candidates}"
+        )
+      end
 
-    def poll!(ballot)
-      @ballots << ballot
+      @ballots << ranked_candidates
+      self
     end
 
     def result
@@ -29,5 +32,13 @@ module Irv
     def winner
       result&.winner
     end
+
+    private
+
+    def incorrect_candidates?(ranked_candidates)
+      ranked_candidates.class != Array ||
+        ranked_candidates.count - ranked_candidates.uniq.count != 0 ||
+        ranked_candidates.any? { |c| !@candidates.include?(c) }
+    end
   end
 end

data/lib/irv/result.rb

@@ -9,7 +9,7 @@ module Irv
     def initialize(candidates, ballots)
       @process = []
       round_order = 1
-      round = Round.new(round_order, candidates, ballots.map(&:ranked_candidates))
+      round = Round.new(round_order, candidates, ballots)
 
       (candidates.count - 1).times do
         @process << round

data/lib/irv/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Irv
-  VERSION = '0.1.1'
+  VERSION = '0.2.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: irv
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.2.0
 platform: ruby
 authors:
 - highwide
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-06-24 00:00:00.000000000 Z
+date: 2019-08-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -88,7 +88,6 @@ files:
 - bin/setup
 - irv.gemspec
 - lib/irv.rb
-- lib/irv/ballot.rb
 - lib/irv/election.rb
 - lib/irv/result.rb
 - lib/irv/round.rb
@@ -105,7 +104,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 2.4.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="

data/lib/irv/ballot.rb

@@ -1,30 +0,0 @@
-# frozen_string_literal: true
-
-module Irv
-  class Ballot
-    attr_reader :candidates, :ranked_candidates
-
-    def initialize(candidates)
-      @candidates = candidates
-      @ranked_candidates = []
-    end
-
-    def fill!(ranked_candidates)
-      unless correct_candidates?(ranked_candidates)
-        raise(
-          FillingWithIncorrectCandidatesError,
-          "Filling #{ranked_candidates}, but acceptable for only #{@candidates}"
-        )
-      end
-
-      @ranked_candidates = ranked_candidates
-    end
-
-    private
-
-    def correct_candidates?(ranked_candidates)
-      ranked_candidates.all? { |c| @candidates.include?(c) } &&
-        (ranked_candidates.count == ranked_candidates.uniq.count)
-    end
-  end
-end