iron_hide 0.3.1 → 0.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0a326eeca3af2614b0635b9528484b4d5100bd24
-  data.tar.gz: bd4d3a1b41405a646b1ab4b32d02d4a1de2a0b12
+  metadata.gz: f96504f984094bdbc0cd59532575d48ea63690cd
+  data.tar.gz: f61e250b8bc7cfed8bc65e6f80891f9c28ddd0e5
 SHA512:
-  metadata.gz: 18b5b3bec2a8ba8dbe751466559cb74b693546fa1eb7b85d9877c5378e966e2cf73be8f795d76f9548d70c6fd29de69d93c77cfb58280ab9a68e68c813420753
-  data.tar.gz: d1275f59f86dc7d2ca4e0f6626908d8617c43089c30eb30b0bba987048adbcfaadd69c50fbfffde9438edfb314f318e7d48f1b7b3bc6ebb5c139159e21a2d9d9
+  metadata.gz: d8c0a108b078135cf5c069f456b250faac2d63d8b997e6988df46aa243512a786c6fae5671c8d41c9cd375d206da2afb52852394c537a4332dd08df98269d11a
+  data.tar.gz: 5e20a1309529d85d4b7615b8e5ed415ad10fce0b7176545890b3f014c57fe7b5b0e9a081e9a34d970a44cf5c4770968e18be74e168dce3c66e7ae993b42d40c4

data/lib/iron_hide/condition.rb

@@ -20,7 +20,7 @@ module IronHide
     # @return [EqualCondition, NotEqualCondition]
     # @raise [IronHide::InvalidConditional] for too many keys
     #
-    def self.new(params)
+    def self.new(params, cache = NullCache.new)
       if params.length > 1
         raise InvalidConditional, "Expected #{params} to have one key"
       end
@@ -30,7 +30,7 @@ module IronHide
       # See: http://ruby-doc.org/core-1.9.3/Class.html#method-i-allocate
       klass = VALID_TYPES.fetch(type){ raise InvalidConditional, "#{type} is not valid"}
       cond  = IronHide.const_get(klass).allocate
-      cond.send(:initialize, (conditionals))
+      cond.send(:initialize, conditionals, cache)
       cond
     end
 
@@ -41,11 +41,14 @@ module IronHide
     #    'user::user_role_ids' => ['8']
     #  }
     #
-    def initialize(conditionals)
+    # @param [IronHide::SimpleCache, IronHide::NullCache] cache
+    #
+    def initialize(conditionals, cache)
       @conditionals = conditionals
+      @cache        = cache
     end
 
-    attr_reader :conditionals
+    attr_reader :conditionals, :cache
 
     # @param user [Object]
     # @param resource [Object]
@@ -93,18 +96,20 @@ module IronHide
     def evaluate(expression, user, resource)
       Array(expression).flat_map do |el|
         if expression?(el)
-          type, *ary  = el.split('::')
-          if type == 'user'
-            Array(ary.inject(user) do |rval, attr|
-              rval.freeze.public_send(attr)
-            end)
-          elsif type == 'resource'
-            Array(ary.inject(resource) do |rval, attr|
-              rval.freeze.public_send(attr)
-            end)
-          else
-            raise "Expected #{type} to be 'resource' or 'user'"
-          end
+          cache.fetch(el) {
+            type, *ary  = el.split('::')
+            if type == 'user'
+              Array(ary.inject(user) do |rval, attr|
+                rval.freeze.public_send(attr)
+              end)
+            elsif type == 'resource'
+              Array(ary.inject(resource) do |rval, attr|
+                rval.freeze.public_send(attr)
+              end)
+            else
+              raise "Expected #{type} to be 'resource' or 'user'"
+            end
+          }
         else
           el
         end

data/lib/iron_hide/configuration.rb

@@ -1,11 +1,16 @@
 module IronHide
   class Configuration
 
-    attr_accessor :adapter, :namespace, :json
+    attr_accessor :adapter, :namespace, :json, :memoize
 
     def initialize
       @adapter   = :file
       @namespace = 'com::IronHide'
+      @memoize   = true
+    end
+
+    def memoizer
+      memoize ? SimpleCache : NullCache
     end
 
     # Extend configuration variables

data/lib/iron_hide/memoize.rb

@@ -0,0 +1,26 @@
+module IronHide
+
+  # The SimpleCache does not expire cache entries
+  # It is used only to memoize method calls during a single authorization
+  # decision.
+  #
+  class SimpleCache
+    attr_accessor :cache
+
+    def initialize
+      @cache = {}
+    end
+
+    def fetch(expression)
+      cache.fetch(expression) {
+        cache[expression] = yield
+      }
+    end
+  end
+
+  class NullCache
+    def fetch(_)
+      yield
+    end
+  end
+end

data/lib/iron_hide/rule.rb

@@ -1,16 +1,18 @@
+require 'iron_hide/memoize'
+
 module IronHide
   class Rule
     ALLOW     = 'allow'.freeze
     DENY      = 'deny'.freeze
 
-    attr_reader :description, :effect, :conditions, :user, :resource
+    attr_reader :description, :effect, :conditions, :user, :resource, :cache
 
-    def initialize(user, resource, params = {})
+    def initialize(user, resource, params = {}, cache = NullCache.new)
       @user        = user
       @resource    = resource
       @description = params['description']
       @effect      = params.fetch('effect', DENY) # Default DENY
-      @conditions  = Array(params['conditions']).map { |c| Condition.new(c) }
+      @conditions  = Array(params['conditions']).map { |c| Condition.new(c, cache) }
     end
 
     # Returns all applicable rules matching on resource and action
@@ -20,9 +22,10 @@ module IronHide
     # @param resource [Object]
     # @return [Array<IronHide::Rule>]
     def self.find(user, action, resource)
+      cache       = IronHide.configuration.memoizer.new
       ns_resource = "#{IronHide.configuration.namespace}::#{resource.class.name}"
       storage.where(resource: ns_resource, action: action).map do |json|
-        new(user, resource, json)
+        new(user, resource, json, cache)
       end
     end
 

data/lib/iron_hide/version.rb

@@ -1,6 +1,6 @@
 module IronHide
   MAJOR = "0"
-  MINOR = "3"
+  MINOR = "4"
   BUILD = "1"
   VERSION = [MAJOR, MINOR, BUILD].join(".")
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: iron_hide
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.4.1
 platform: ruby
 authors:
 - Alan Cohen
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-14 00:00:00.000000000 Z
+date: 2014-04-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: multi_json
@@ -119,6 +119,7 @@ files:
 - lib/iron_hide/condition.rb
 - lib/iron_hide/configuration.rb
 - lib/iron_hide/errors.rb
+- lib/iron_hide/memoize.rb
 - lib/iron_hide/rule.rb
 - lib/iron_hide/storage.rb
 - lib/iron_hide/storage/file_adapter.rb