iron_bank 4.0.1 → 4.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 067bac2c19999dd3a589b07a34e32626df11fbbd26fdad2083131928f06c1f2f
-  data.tar.gz: 3143662227f48f7446f72a4fee567bbb3a190243b7be0c184811d37f8d28c2f9
+  metadata.gz: 2eb89daa7f5b7a8a07c63cd2da6dbf61d815d43186068916a27bfba75b11454b
+  data.tar.gz: 794b52f7e1d01cd7096f89627fde936867ecc9d66df60f29985cbb0c1d722be1
 SHA512:
-  metadata.gz: be04e3c77d5391cf0e076cce35e5f92a281246605b9ff217d1a12046a803aec81c76ded39d40e39124b8544bd601782c4bc38f839c08188af64bae295ee56d9a
-  data.tar.gz: 993ad81b0fcbd3d5a31e15b76602c8d13c6a3113e59d86273dccee79b6f1bc79b7c772fe3988a89599c76c28dc3f9bdb3fa0999f0675cdf5569d1b55dd65b470
+  metadata.gz: 528398a47469aeb59ce99ff48f24800855a9b8200277972bcd8ace8cc41b1608f3bbbe8d210209421ed1ee9c15209727fa75978e22f5abce4023aa40c42477d6
+  data.tar.gz: 84a42db908a7016dcfb53ad161f2a99552adba4639d7f17679785e964bf51e28322c6cb13cd87bb0e43205e19eb6011789544bb9e5218b3a5246d24f08aaa596

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    iron_bank (4.0.1)
+    iron_bank (4.0.2)
       faraday (~> 0)
       faraday_middleware (~> 0)
       nokogiri (~> 1)

data/lib/iron_bank/describe/excluded_fields.rb

@@ -41,18 +41,18 @@ module IronBank
       def call
         remove_last_failure_fields until valid_query?
 
-        excluded_fields
+        excluded_fields - single_resource_query_fields
       end
 
       private
 
-      attr_reader :object_name, :excluded_fields, :last_failed_fields
+      attr_reader :object_name, :last_failed_fields
 
       def_delegators "IronBank.logger", :info
+      def_delegators :object, :single_resource_query_fields
 
       def initialize(object_name)
         @object_name        = object_name
-        @excluded_fields    = []
         @last_failed_fields = nil
       end
 
@@ -60,6 +60,10 @@ module IronBank
         IronBank::Resources.const_get(object_name)
       end
 
+      def excluded_fields
+        @excluded_fields ||= object.excluded_fields.dup
+      end
+
       def remove_last_failure_fields
         query_fields = object.query_fields
 
@@ -67,7 +71,7 @@ module IronBank
           last_failed_fields.any? { |failed| field.casecmp?(failed) }
         end
 
-        @excluded_fields += failed_fields
+        excluded_fields.push(*failed_fields)
 
         # Remove the field for the next query
         query_fields.delete_if { |field| failed_fields.include?(field) }

data/lib/iron_bank/metadata.rb

@@ -12,6 +12,13 @@ module IronBank
       fields.fetch(object_name, [])
     end
 
+    # NOTE: For some resources, fields are queryable with some restrictions,
+    #       e.g. the `Invoice#body` can only be added to the list of fields if
+    #       there is only one invoice in the query response.
+    def single_resource_query_fields
+      []
+    end
+
     def fields
       return [] unless schema
 

data/lib/iron_bank/resources/invoice.rb

@@ -8,7 +8,11 @@ module IronBank
     class Invoice < Resource
       # See the comment for the instance method `#body`
       def self.excluded_fields
-        super + %w[Body]
+        super + single_resource_query_fields
+      end
+
+      def self.single_resource_query_fields
+        %w[Body]
       end
 
       with_schema

data/lib/iron_bank/resources/product_rate_plan.rb

@@ -9,7 +9,11 @@ module IronBank
       # NOTE: Zuora doesn't let us query for more than one product rate plan
       #       `ActiveCurrencies` at a time
       def self.excluded_fields
-        super + %w[ActiveCurrencies]
+        super + single_resource_query_fields
+      end
+
+      def self.single_resource_query_fields
+        %w[ActiveCurrencies]
       end
 
       with_schema

data/lib/iron_bank/resources/rate_plan_charge.rb

@@ -6,7 +6,11 @@ module IronBank
     #
     class RatePlanCharge < Resource
       def self.excluded_fields
-        super + %w[RolloverBalance]
+        super + single_resource_query_fields
+      end
+
+      def self.single_resource_query_fields
+        %w[RolloverBalance]
       end
 
       with_schema

data/lib/iron_bank/version.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
 module IronBank
-  VERSION     = "4.0.1"
+  VERSION     = "4.0.2"
   API_VERSION = "v1"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: iron_bank
 version: !ruby/object:Gem::Version
-  version: 4.0.1
+  version: 4.0.2
 platform: ruby
 authors:
 - Mickael Pham
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-09-06 00:00:00.000000000 Z
+date: 2019-09-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bump