ircinch 2.4.1 → 2.4.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3e646f4e5f8d8281a86ddab9727f02ba9ee5c5ebcd874d12aa814a0691d63c9f
-  data.tar.gz: d1a798b6518cbabdfe928a6f56969a5fe1a70cd56ab00ae167da25ccacdae226
+  metadata.gz: d603bfc62bdd98e5a52cc6f56fea0a5ac42592df0d58c0ccf40a3197f95167b5
+  data.tar.gz: 271c967f694780843b98712454662782efcfc9145a0d015a7a3a5570af7303bd
 SHA512:
-  metadata.gz: c75cb5184abbe64e61277332f9d1e64c7c143a5767d7732455e608ba1c2d1f73eeaefbc4da64f27d252b4c755e591fc49ad024fb3524e0624b03ebd852bb2488
-  data.tar.gz: a7cfa92fcfd22caf28ee5d211db38a04533b7b845a8ffc562ae87ed34864d2a439294b76bd8018eeabdeded96d719a8b0ae91bf690a43a30c43f6851b9e7966b
+  metadata.gz: d192049a5f08179804fb74810d828ab4facfcada4ffbecdbc18c0e3d7474c2151298f7da2b287882fe8b3a71f40ba9e3f23d3e798f731008170fac47456b2174
+  data.tar.gz: 8a7693d15e83fef6b7716e1aca5d0cec0d942aa42ab8a99356a5a98fab1d1a1310f29f9a3d1546981df277f30d0b29fc57ef21b60f64124efaea3d9953f99e5a

data/.standard.yml

@@ -1,3 +1,4 @@
 # For available configuration options, see:
 #   https://github.com/testdouble/standard
-ruby_version: 3.4
+parallel: true
+ruby_version: 3.2

data/CHANGELOG.md

@@ -1,3 +1,13 @@
+* IRCinch 2.4.3, 27 December 2025
+  - Fix SASL auth time out by fixing IRC message parsing expression (fix by @janikrabe)
+  - Remove various duplicate methods
+  - Update standardrb configuration and lint files
+  - Improve CI build and steps
+
+* IRCinch 2.4.2, 3 April 2025
+  - Improve Gemspec metadata
+  - Performance and linting improvements
+
 * IRCinch 2.4.1, 1 April 2025
   - Gemspec updates for compatibility with Ruby >= 3.4.0
   - Minor readme and documentation updates

data/examples/plugins/autovoice.rb

@@ -8,6 +8,7 @@ require "ircinch"
 
 class Autovoice
   include Cinch::Plugin
+
   listen_to :join
   match(/autovoice (on|off)$/)
 

data/examples/plugins/google.rb

@@ -5,6 +5,7 @@ require "open-uri"
 
 class Google
   include Cinch::Plugin
+
   match(/google (.+)/)
 
   def search(query)

data/examples/plugins/last_nick.rb

@@ -2,6 +2,7 @@ require "ircinch"
 
 class Nickchange
   include Cinch::Plugin
+
   listen_to :nick
 
   def listen(m)

data/examples/plugins/multiple_matches.rb

@@ -2,6 +2,7 @@ require "ircinch"
 
 class MultiCommands
   include Cinch::Plugin
+
   match(/command1 (.+)/, method: :command1)
   match(/command2 (.+)/, method: :command2)
   match(/^command3 (.+)/, use_prefix: false)

data/examples/plugins/seen.rb

@@ -8,6 +8,7 @@ class Seen
   end
 
   include Cinch::Plugin
+
   listen_to :channel
   match(/seen (.+)/)
 

data/ircinch.gemspec

@@ -14,9 +14,14 @@ Gem::Specification.new do |spec|
   spec.license = "MIT"
   spec.required_ruby_version = ">= 3.2.0"
 
-  spec.metadata["homepage_uri"] = spec.homepage
-  spec.metadata["source_code_uri"] = "https://github.com/ircinchrb/ircinch"
-  spec.metadata["changelog_uri"] = "https://github.com/ircinchrb/ircinch/blob/main/CHANGELOG.md"
+  spec.metadata = {
+    "bug_tracker_uri" => "https://github.com/ircinchrb/ircinch/issues",
+    "changelog_uri" => "https://github.com/ircinchrb/ircinch/blob/main/CHANGELOG.md",
+    "documentation_uri" => "https://rubydoc.info/gems/ircinch",
+    "homepage_uri" => spec.homepage,
+    "source_code_uri" => "https://github.com/ircinchrb/ircinch",
+    "rubygems_mfa_required" => "true"
+  }
 
   # Specify which files should be added to the gem when it is released.
   # The `git ls-files -z` loads the files in the RubyGem that have been added into git.
@@ -36,6 +41,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "base64"
   spec.add_development_dependency "bundler-audit"
   spec.add_development_dependency "bundler-integrity"
+  spec.add_development_dependency "irb"
   spec.add_development_dependency "minitest"
   spec.add_development_dependency "rake"
   spec.add_development_dependency "simplecov"

data/lib/cinch/channel.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require "set"
-
 require_relative "target"
 
 module Cinch
@@ -25,7 +23,7 @@ module Cinch
     synced_attr_reader :users
 
     # @return [String] the channel's topic
-    attr_accessor :topic
+    attr_reader :topic
     synced_attr_reader :topic
 
     # @return [Array<Ban>] all active bans
@@ -309,7 +307,6 @@ module Cinch
       @bot.irc.send("INVITE #{user} #{@name}")
     end
 
-    undef_method(:topic=)
     # Sets the topic.
     #
     # @param [String] new_topic the new topic
@@ -418,12 +415,8 @@ module Cinch
         # allow colors.
         text = Cinch::Formatting.unformat(text)
       end
-      super(text, notice)
+      super
     end
-    alias_method :msg, :send # deprecated
-    alias_method :privmsg, :send # deprecated
-    undef_method(:msg) # yardoc hack
-    undef_method(:privmsg) # yardoc hack
 
     # @deprecated
     def msg(*args)
@@ -449,8 +442,6 @@ module Cinch
     def to_s
       @name
     end
-    alias_method :to_str, :to_s # deprecated
-    undef_method(:to_str) # yardoc hack
 
     def to_str
       Cinch::Utilities::Deprecation.print_deprecation("2.2.0", "Channel#to_str", "Channel#to_s")

data/lib/cinch/configuration.rb

@@ -14,7 +14,7 @@ module Cinch
 
     def initialize(base = nil)
       base ||= self.class.default_config
-      super(base)
+      super
     end
 
     # @return [Hash]

data/lib/cinch/exceptions.rb

@@ -32,7 +32,7 @@ module Cinch
     # doesn't support yet.
     class UnsupportedMode < Generic
       def initialize(mode)
-        super "Cinch does not support the mode '#{mode}' yet."
+        super("Cinch does not support the mode '#{mode}' yet.")
       end
     end
 

data/lib/cinch/handler_list.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require "set"
-
 require_relative "cached_list"
 
 module Cinch

data/lib/cinch/helpers.rb

@@ -182,8 +182,6 @@ module Cinch
     def Format(*settings, string)
       Formatting.format(*settings, string)
     end
-    alias_method :Color, :Format # deprecated
-    undef_method(:Color) # yardoc hack
 
     def Color(*args)
       Cinch::Utilities::Deprecation.print_deprecation("2.2.0", "Helpers.Color", "Helpers.Format")

data/lib/cinch/irc.rb

@@ -504,7 +504,7 @@ module Cinch
           end
         elsif direction == :add
           # channel options
-          msg.channel.modes_unsynced[mode] = param.nil? ? true : param
+          msg.channel.modes_unsynced[mode] = param.nil? || param
         else
           msg.channel.modes_unsynced.delete(mode)
         end

data/lib/cinch/logger.rb

@@ -133,7 +133,7 @@ module Cinch
     private
 
     def format_message(message, level)
-      __send__ "format_#{level}", message
+      __send__ :"format_#{level}", message
     end
 
     def format_general(message)

data/lib/cinch/message.rb

@@ -99,7 +99,7 @@ module Cinch
     # @api private
     # @return [void]
     def parse
-      match = @raw.match(/(?:^@([^:]+))?(?::?(\S+) )?(\S+)(.*)/)
+      match = @raw.match(/\A(?:@([^ ]+) )?(?::(\S+) )?(\S+)(.*)/)
       tags, @prefix, @command, raw_params = match.captures
 
       if @bot.irc.network.ngametv?
@@ -357,7 +357,7 @@ module Cinch
     end
 
     def parse_error
-      return @command.to_i if numeric_reply? && @command[/[45]\d\d/]
+      @command.to_i if numeric_reply? && @command[/[45]\d\d/]
     end
 
     def parse_message

data/lib/cinch/network.rb

@@ -41,13 +41,13 @@ module Cinch
     # @return [String, nil] The mode used for getting the list of
     #   channel owners, if any
     def owner_list_mode
-      return "q" if @ircd == :unreal || @ircd == :inspircd
+      "q" if @ircd == :unreal || @ircd == :inspircd
     end
 
     # @return [String, nil] The mode used for getting the list of
     #   channel quiets, if any
     def quiet_list_mode
-      return "q" if @ircd == :"ircd-seven"
+      "q" if @ircd == :"ircd-seven"
     end
 
     # @return [Boolean] Does WHOIS only support one argument?

data/lib/cinch/plugin.rb

@@ -163,11 +163,11 @@ module Cinch
         when 1
           # {:key => value, ...}
           args.first.each do |key, value|
-            send("#{key}=", value)
+            send(:"#{key}=", value)
           end
         when 2
           # key, value
-          send("#{args.first}=", args.last)
+          send(:"#{args.first}=", args.last)
         else
           raise ArgumentError # TODO proper error message
         end
@@ -367,7 +367,7 @@ module Cinch
         @bot.loggers.debug "[plugin] #{self.class.plugin_name}: Registering CTCP `#{ctcp}`"
         new_handler = Handler.new(@bot, :ctcp, Pattern.generate(:ctcp, ctcp)) do |message, *args|
           if self.class.call_hooks(:pre, :ctcp, nil, self, [message])
-            __send__("ctcp_#{ctcp.downcase}", message, *args)
+            __send__(:"ctcp_#{ctcp.downcase}", message, *args)
             self.class.call_hooks(:post, :ctcp, nil, self, [message])
           else
             @bot.loggers.debug "[plugin] #{self.class.plugin_name}: Dropping message due to hook"

data/lib/cinch/rubyext/module.rb

@@ -12,7 +12,7 @@ class Module
       attr(attribute)
     end
 
-    define_method("#{attribute}_unsynced") do
+    define_method(:"#{attribute}_unsynced") do
       attr(attribute, false, true)
     end
   end

data/lib/cinch/sasl/diffie_hellman.rb

@@ -40,7 +40,7 @@ module Cinch
         result = 1
         while e > 0
           result = (result * b) % m if e[0] == 1
-          e = e >> 1
+          e >>= 1
           b = (b * b) % m
         end
         result

data/lib/cinch/syncable.rb

@@ -33,7 +33,7 @@ module Cinch
       if data
         @data[attribute] = value
       else
-        instance_variable_set("@#{attribute}", value)
+        instance_variable_set(:"@#{attribute}", value)
       end
       @synced_attributes << attribute
     end
@@ -70,7 +70,7 @@ module Cinch
       if data
         @data[attribute]
       else
-        instance_variable_get("@#{attribute}")
+        instance_variable_get(:"@#{attribute}")
       end
     end
 

data/lib/cinch/target.rb

@@ -48,10 +48,6 @@ module Cinch
         end
       end
     end
-    alias_method :msg, :send # deprecated
-    alias_method :privmsg, :send # deprecated
-    undef_method(:msg) # yardoc hack
-    undef_method(:privmsg) # yardoc hack
 
     # @deprecated
     def msg(*args)
@@ -80,21 +76,17 @@ module Cinch
     def safe_send(text, notice = false)
       send(Cinch::Helpers.sanitize(text), notice)
     end
-    alias_method :safe_msg, :safe_send # deprecated
-    alias_method :safe_privmsg, :safe_msg # deprecated
-    undef_method(:safe_msg) # yardoc hack
-    undef_method(:safe_privmsg) # yardoc hack
 
     # @deprecated
     def safe_msg(*args)
       Cinch::Utilities::Deprecation.print_deprecation("2.2.0", "Target#safe_msg", "Target#safe_send")
-      send(*args)
+      safe_send(*args)
     end
 
     # @deprecated
     def safe_privmsg(*args)
       Cinch::Utilities::Deprecation.print_deprecation("2.2.0", "Target#safe_privmsg", "Target#safe_send")
-      send(*args)
+      safe_send(*args)
     end
 
     # Like {#safe_msg} but for notices.
@@ -138,7 +130,7 @@ module Cinch
     # @param [#to_s] message the ctcp message
     # @return [void]
     def ctcp(message)
-      send "\001#{message}\001"
+      send :"\001#{message}\001"
     end
 
     def concretize

data/lib/cinch/user.rb

@@ -135,13 +135,13 @@ module Cinch
     def unknown_unsynced
       attr(:unknown?, true, true)
     end
-    alias_method :"unknown?_unsynced", "unknown_unsynced"
+    alias_method :"unknown?_unsynced", :unknown_unsynced
 
     # @private
     def online_unsynced
       attr(:online?, true, true)
     end
-    alias_method :"online?_unsynced", "online_unsynced"
+    alias_method :"online?_unsynced", :online_unsynced
 
     # @private
     def channels_unsynced
@@ -152,14 +152,14 @@ module Cinch
     def secure_unsynced
       attr(:secure?, true, true)
     end
-    alias_method :"secure?_unsynced", "secure_unsynced"
+    alias_method :"secure?_unsynced", :secure_unsynced
 
     # @private
     # @since 2.1.0
     def oper_unsynced
       attr(:oper?, true, true)
     end
-    alias_method :"oper?_unsynced", "oper_unsynced"
+    alias_method :"oper?_unsynced", :oper_unsynced
 
     # By default, you can use methods like {#user}, {#host} and
     # alike – If you however fear that another thread might change
@@ -261,13 +261,11 @@ module Cinch
         @bot.irc.send "WHOIS #{@name} #{@name}"
       end
     end
-    alias_method :whois, :refresh # deprecated
-    undef_method(:whois) # yardoc hack
 
     # @deprecated
-    def whois
+    def whois(*args)
       Cinch::Utilities::Deprecation.print_deprecation("2.2.0", "User#whois", "User#refresh")
-      refresh
+      refresh(*args)
     end
 
     # @param [Hash, nil] values A hash of values gathered from WHOIS,

data/lib/cinch/version.rb

@@ -2,5 +2,5 @@
 
 module Cinch
   # Version of the library
-  VERSION = "2.4.1"
+  VERSION = "2.4.3"
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: ircinch
 version: !ruby/object:Gem::Version
-  version: 2.4.1
+  version: 2.4.3
 platform: ruby
 authors:
 - Matt Sias
 bindir: exe
 cert_chain: []
-date: 2025-04-02 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ostruct
@@ -65,6 +65,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: irb
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
@@ -235,9 +249,12 @@ homepage: https://github.com/ircinchrb/ircinch
 licenses:
 - MIT
 metadata:
+  bug_tracker_uri: https://github.com/ircinchrb/ircinch/issues
+  changelog_uri: https://github.com/ircinchrb/ircinch/blob/main/CHANGELOG.md
+  documentation_uri: https://rubydoc.info/gems/ircinch
   homepage_uri: https://github.com/ircinchrb/ircinch
   source_code_uri: https://github.com/ircinchrb/ircinch
-  changelog_uri: https://github.com/ircinchrb/ircinch/blob/main/CHANGELOG.md
+  rubygems_mfa_required: 'true'
 rdoc_options: []
 require_paths:
 - lib
@@ -252,7 +269,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.6
+rubygems_version: 4.0.3
 specification_version: 4
 summary: An IRC Bot Building Ruby Framework
 test_files: []