iqvoc 4.3.3 → 4.4.0

data/test/integration/user_management_test.rb

@@ -0,0 +1,51 @@
+# encoding: UTF-8
+
+# Copyright 2011-2013 innoQ Deutschland GmbH
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+require File.join(File.expand_path(File.dirname(__FILE__)), '../integration_test_helper')
+
+class UserManagementTest < ActionDispatch::IntegrationTest
+  setup do
+  end
+
+  test 'create user' do
+    login 'administrator'
+
+    visit users_path(lang: :en)
+    assert page.has_content?('Test User')
+    assert page.has_css?('.users-table-row', count: 1)
+    click_link 'New User'
+
+    fill_in 'Forename', with: 'Arnulf'
+    fill_in 'Surname', with: 'Beckenbauer'
+    fill_in 'Email', with: 'arnulf@beckenbauer.com'
+    fill_in 'Password', with: 'secret'
+    fill_in 'Password (Confirmation)', with: 'secret'
+    click_button 'Save'
+
+    assert page.has_content?('Arnulf Beckenbauer')
+    assert page.has_css?('.users-table-row', count: 2)
+  end
+
+  test 'delete user' do
+    login 'administrator'
+    visit users_path(lang: :en)
+    assert page.has_css?('.users-table-row', count: 1)
+    within '.users-table-row' do
+      click_on 'Delete'
+    end
+    assert page.has_css?('.users-table-row', count: 0)
+  end
+end

data/test/integration_test_helper.rb

@@ -13,10 +13,18 @@
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 # See the License for the specific language governing permissions and
 # limitations under the License.
-
+require File.expand_path('test_helper', File.dirname(__FILE__))
 require 'capybara/rails'
-require File.join(File.expand_path(File.dirname(__FILE__)), 'capybara_helper')
+require 'capybara/dsl'
+require 'capybara/poltergeist'
 require 'webmock'
+require File.expand_path('authentication', File.dirname(__FILE__))
+
+Capybara.javascript_driver = :poltergeist
 
 WebMock.allow_net_connect! # required for integration tests
 
+class ActionDispatch::IntegrationTest
+  include Capybara::DSL
+  include Authentication
+end

data/test/{unit → models}/concept_scheme_test.rb

@@ -17,7 +17,7 @@
 require File.join(File.expand_path(File.dirname(__FILE__)), '../test_helper')
 
 class ConceptSchemeTest < ActiveSupport::TestCase
-  test "singleton concept scheme" do
+  test 'singleton concept scheme' do
     assert_equal 0, Concept::SKOS::Scheme.count
 
     assert_difference 'Concept::SKOS::Scheme.count' do

data/test/models/concept_test.rb

@@ -0,0 +1,178 @@
+# encoding: UTF-8
+
+# Copyright 2011-2013 innoQ Deutschland GmbH
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+require File.join(File.expand_path(File.dirname(__FILE__)), '../test_helper')
+require 'iqvoc/rdfapi'
+
+class ConceptTest < ActiveSupport::TestCase
+  test 'blank concept' do
+    c = Concept::Base.new
+    assert c.valid?
+    refute c.publishable?
+    assert c.valid?
+  end
+
+  test 'should not allow identical concepts' do
+    origin = 'foo'
+    c1 = Concept::Base.new(origin: origin)
+    c2 = Concept::Base.new(origin: origin, published_at: Time.now)
+    assert c1.save
+    assert c2.save
+
+    origin = 'bar'
+    c1 = Concept::Base.new(origin: origin)
+    c2 = Concept::Base.new(origin: origin)
+    assert c1.save
+    assert_raise ActiveRecord::RecordInvalid do
+      c2.save!
+    end
+  end
+
+  test 'concept with no preflabel' do
+    concept = Iqvoc::RDFAPI.devour 'bear', 'a', 'skos:Concept'
+
+    assert concept.save
+    refute concept.publishable?
+    assert_raise ActiveRecord::RecordInvalid do
+      concept.publish!
+    end
+  end
+
+  test 'concepts without pref_labels should be saveable but not publishable' do
+    concept =  Iqvoc::RDFAPI.devour 'bear', 'a', 'skos:Concept'
+    assert_equal [], concept.pref_labels
+    assert concept.valid?
+    refute concept.publishable?
+  end
+
+  test 'published concept must have a pref_label of the first pref_label language configured (the main language)' do
+    concept = Iqvoc::RDFAPI.devour 'bear', 'a', 'skos:Concept'
+    Iqvoc::RDFAPI.devour concept, 'skos:prefLabel', '"Bear"@en'
+
+    assert concept.save
+
+    assert_equal 1, concept.pref_labels.count
+
+    assert concept.publishable?
+
+    concept.pref_labels.first.language = Iqvoc::Concept.pref_labeling_languages.second
+    assert !concept.publishable?
+  end
+
+  test 'one pref label per language' do
+    concept = Concept::SKOS::Base.new.tap do |c|
+      Iqvoc::RDFAPI.devour c, 'skos:prefLabel', '"Bear"@en'
+      c.publish
+      c.save
+    end
+
+    assert concept.valid?
+    Iqvoc::RDFAPI.devour concept, 'skos:prefLabel', '"Beaaar"@en'
+    concept.pref_labelings.reload
+    assert_equal 2, concept.pref_labelings.count
+    assert_equal concept.pref_labelings.first.target.language, concept.pref_labelings.second.target.language
+    assert concept.invalid?
+  end
+
+  test 'unique pref label' do
+    bear_one = Iqvoc::RDFAPI.devour 'bear_one', 'a', 'skos:Concept'
+    Iqvoc::RDFAPI.devour bear_one, 'skos:prefLabel', '"Bear"@en'
+
+    assert bear_one.save
+    assert bear_one.publishable?
+
+    bear_two = Iqvoc::RDFAPI.devour 'bear_two', 'a', 'skos:Concept'
+    Iqvoc::RDFAPI.devour bear_two, 'skos:prefLabel', '"Bear"@en'
+
+    bear_two.save!
+    refute bear_two.publishable?
+  end
+
+  test 'multiple pref labels' do
+    concept = Iqvoc::RDFAPI.devour 'bear', 'a', 'skos:Concept'
+    Iqvoc::RDFAPI.devour concept, 'skos:prefLabel', '"Bear"@en'
+    Iqvoc::RDFAPI.devour concept, 'skos:prefLabel', '"Bär"@de'
+
+    assert concept.save
+    concept.reload
+
+    assert_equal 2, concept.pref_labels.count
+    assert_not_equal concept.pref_labels.first.language, concept.pref_labels.second.language
+    assert concept.publishable?
+  end
+
+  test 'labelings_by_text setter' do
+    concept = Concept::SKOS::Base.new
+
+    concept.labelings_by_text = {
+      Iqvoc::Concept.pref_labeling_class_name.to_relation_name => {
+        Iqvoc::Concept.pref_labeling_languages.first => 'A new label'
+      }
+    }
+
+    assert concept.valid?
+    assert concept.save
+    concept.reload
+    assert_equal 'A new label', concept.pref_label.value
+    assert_equal Iqvoc::Concept.pref_labeling_languages.first, concept.pref_label.language.to_s
+
+    concept.labelings_by_text = {
+      Iqvoc::Concept.pref_labeling_class_name.to_relation_name => {
+        Iqvoc::Concept.pref_labeling_languages.first => 'A new label, Another Label in the same language'
+      }
+    }
+    refute concept.save
+  end
+
+  test 'labels including commas' do
+    labels_for = lambda do |concept, type|
+        type.includes(:target).where(owner_id: concept.id).
+            map { |ln| ln.target.value }
+    end
+
+    form_data = {
+      'labelings_by_text' => {
+        'labeling_skos_pref_labels' => { 'en' => 'lipsum' },
+        'labeling_skos_alt_labels' => { 'en' => 'foo, bar' }
+      }
+    }
+    concept = Iqvoc::Concept.base_class.create(form_data)
+
+    assert_equal ['lipsum'], labels_for.call(concept, Labeling::SKOS::PrefLabel)
+    assert_equal 'lipsum',
+        concept.labelings_by_text('labeling_skos_pref_labels', 'en')
+    assert_equal ['foo', 'bar'],
+        labels_for.call(concept, Labeling::SKOS::AltLabel)
+    assert_equal 'foo, bar',
+        concept.labelings_by_text('labeling_skos_alt_labels', 'en')
+
+    form_data = {
+      'labelings_by_text' => {
+        'labeling_skos_pref_labels' => { 'en' => 'lipsum' },
+        'labeling_skos_alt_labels' => { 'en' => 'lorem, "foo, bar", ipsum' }
+      }
+    }
+    concept = Iqvoc::Concept.base_class.create(form_data)
+
+    assert_equal ['lipsum'], labels_for.call(concept, Labeling::SKOS::PrefLabel)
+    assert_equal 'lipsum',
+        concept.labelings_by_text('labeling_skos_pref_labels', 'en')
+    assert_equal ['lorem', 'foo, bar', 'ipsum'],
+        labels_for.call(concept, Labeling::SKOS::AltLabel)
+    assert_equal 'lorem, "foo, bar", ipsum',
+        concept.labelings_by_text('labeling_skos_alt_labels', 'en')
+  end
+end

data/test/{unit → models}/hygiene_test.rb

@@ -14,22 +14,22 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-class HygieneTest < ActiveSupport::TestCase
+require File.join(File.expand_path(File.dirname(__FILE__)), '../test_helper')
 
-  test "trailing whitespace" do
-    assert_no_occurrence '[[:blank:]]$', "trailing whitespace"
+class HygieneTest < ActiveSupport::TestCase
+  test 'trailing whitespace' do
+    assert_no_occurrence '[[:blank:]]$', 'trailing whitespace'
   end
 
-  test "mixed whitespace" do
+  test 'mixed whitespace' do
     tab = "\t"
-    space = " "
-    assert_no_occurrence "#{space}#{tab}\|#{tab}#{space}", "mixed whitespace", true
+    space = ' '
+    assert_no_occurrence "#{space}#{tab}\|#{tab}#{space}", 'mixed whitespace', true
   end
 
   def assert_no_occurrence(pattern, error_message, extended = false)
-    extra_options = extended ? "E" : ""
+    extra_options = extended ? 'E' : ''
     lines = `git grep -In#{extra_options} '#{pattern}' | grep -v '^vendor/'`
     assert_not_equal 0, $?.to_i, "#{error_message}:\n#{lines}"
   end
-
 end

data/test/{unit → models}/inline_data_test.rb

@@ -17,36 +17,35 @@
 require File.join(File.expand_path(File.dirname(__FILE__)), '../test_helper')
 
 class InlineDataTest < ActiveSupport::TestCase
-
-  test "serialization" do
-    values = ["foo", "bar"]
-    assert_equal "foo, bar",
+  test 'serialization' do
+    values = ['foo', 'bar']
+    assert_equal 'foo, bar',
         Iqvoc::InlineDataHelper.generate_inline_values(values)
 
-    values = ["lorem", "foo, bar", "ipsum"]
+    values = ['lorem', 'foo, bar', 'ipsum']
     assert_equal 'lorem, "foo, bar", ipsum',
         Iqvoc::InlineDataHelper.generate_inline_values(values)
   end
 
-  test "deserialization" do
-    inline_values = "foo, bar"
-    assert_equal ["foo", "bar"],
+  test 'deserialization' do
+    inline_values = 'foo, bar'
+    assert_equal ['foo', 'bar'],
         Iqvoc::InlineDataHelper.parse_inline_values(inline_values)
 
     inline_values = 'lorem, "foo, bar", ipsum'
-    assert_equal ["lorem", "foo, bar", "ipsum"],
+    assert_equal ['lorem', 'foo, bar', 'ipsum'],
         Iqvoc::InlineDataHelper.parse_inline_values(inline_values)
 
     inline_values = 'lorem,"foo, bar",ipsum'
-    assert_equal ["lorem", "foo, bar", "ipsum"],
+    assert_equal ['lorem', 'foo, bar', 'ipsum'],
         Iqvoc::InlineDataHelper.parse_inline_values(inline_values)
 
     inline_values = 'foo, bar,baz' # inconsistent whitespace
-    assert_equal ["foo", "bar", "baz"],
+    assert_equal ['foo', 'bar', 'baz'],
         Iqvoc::InlineDataHelper.parse_inline_values(inline_values)
 
     inline_values = 'lorem,"foo, bar", ipsum' # inconsistent whitespace
-    assert_equal ["lorem", "foo, bar", "ipsum"],
+    assert_equal ['lorem', 'foo, bar', 'ipsum'],
         Iqvoc::InlineDataHelper.parse_inline_values(inline_values)
 
     inline_values = 'lorem, "foo, bar",ipsum' # inconsistent whitespace
@@ -57,5 +56,4 @@ class InlineDataTest < ActiveSupport::TestCase
     inline_values = ''
     assert_equal [], Iqvoc::InlineDataHelper.parse_inline_values(inline_values)
   end
-
 end

data/test/{unit → models}/instance_configuration_test.rb

@@ -17,7 +17,6 @@
 require File.join(File.expand_path(File.dirname(__FILE__)), '../test_helper')
 
 class InstanceConfigurationBrowsingTest < ActiveSupport::TestCase
-
   setup do
     @config = Iqvoc::InstanceConfiguration.instance
   end
@@ -27,32 +26,31 @@ class InstanceConfigurationBrowsingTest < ActiveSupport::TestCase
     # TODO: unset singleton?
   end
 
-  test "should require a setting to be registered upfront" do
+  test 'should require a setting to be registered upfront' do
     assert_raise Iqvoc::InstanceConfiguration::UnregisteredSetting do
-      @config["foo"] = "bar"
+      @config['foo'] = 'bar'
     end
   end
 
-  test "should register settings with defaults" do
-    @config.register_setting("ho", "yuken")
-    assert_equal "yuken", @config["ho"]
+  test 'should register settings with defaults' do
+    @config.register_setting('ho', 'yuken')
+    assert_equal 'yuken', @config['ho']
 
-    @config.register_settings("ha" => "douken")
-    assert_equal "douken", @config["ha"]
+    @config.register_settings('ha' => 'douken')
+    assert_equal 'douken', @config['ha']
   end
 
-  test "should deregister settings" do
-    @config.register_setting("country", "germany")
-    assert_equal "germany", @config.deregister_setting("country")
-    assert_nil @config["germany"]
+  test 'should deregister settings' do
+    @config.register_setting('country', 'germany')
+    assert_equal 'germany', @config.deregister_setting('country')
+    assert_nil @config['germany']
   end
 
-  test "should validate values" do
-    @config.register_setting("foo", "bar")
+  test 'should validate values' do
+    @config.register_setting('foo', 'bar')
 
-    assert_raise(TypeError) { @config["foo"] = nil }
-    assert_raise(TypeError) { @config.register_setting("foo", nil) }
-    assert_raise(TypeError) { @config.register_setting("foo", Hash.new) }
+    assert_raise(TypeError) { @config['foo'] = nil }
+    assert_raise(TypeError) { @config.register_setting('foo', nil) }
+    assert_raise(TypeError) { @config.register_setting('foo', Hash.new) }
   end
-
 end

data/test/{unit → models}/note_test.rb

@@ -17,16 +17,14 @@
 require File.join(File.expand_path(File.dirname(__FILE__)), '../test_helper')
 
 class NoteTest < ActiveSupport::TestCase
-
-  test "should parse turtle note annotations" do
+  test 'should parse turtle note annotations' do
     str = '[umt:source <aDisBMS>; umt:thsisn "00000001"; dct:date "2010-04-29"]'
-    concept = Concept::SKOS::Base.create(:origin => "_00000001", :published_at => Time.now)
+    concept = Concept::SKOS::Base.create(origin: '_00000001', published_at: Time.now)
     concept.note_skos_change_notes << ::Note::SKOS::ChangeNote.new.from_annotation_list!(str)
 
     assert_equal 1, Note::SKOS::ChangeNote.count, 1
     assert_equal 3, Note::SKOS::ChangeNote.first.annotations.count, 3
-    assert_equal 1, Note::Annotated::Base.where(:namespace => "umt",
-        :predicate => 'thsisn', :value => '"00000001"').count
+    assert_equal 1, Note::Annotated::Base.where(namespace: 'umt',
+        predicate: 'thsisn', value: '"00000001"').count
   end
-
 end

data/test/models/origin_test.rb

@@ -0,0 +1,83 @@
+# encoding: UTF-8
+
+# Copyright 2011-2013 innoQ Deutschland GmbH
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+require File.join(File.expand_path(File.dirname(__FILE__)), '../test_helper')
+
+class FoobarStripper < Iqvoc::Origin::Filters::GenericFilter
+  def call(obj, str)
+    str = str.gsub('foobar', '')
+    run(obj, str)
+  end
+end
+
+class OriginTest < ActiveSupport::TestCase
+  def test_should_replace_umlauts
+    assert_equal 'aauuooss', Iqvoc::Origin.new('ÄäÜüÖöß').to_s
+  end
+
+  def test_should_camelize_string
+    assert_equal 'a-weighting', Iqvoc::Origin.new("'A' Weighting").to_s
+  end
+
+  def test_should_handle_numbers_at_the_beginning
+    assert_equal '_123', Iqvoc::Origin.new('123').to_s
+  end
+
+  def test_should_handle_whitespaces_at_strange_positions
+    assert_equal 'test-12', Iqvoc::Origin.new('test 12 ').to_s
+  end
+
+  def test_should_preserve_underlines
+    assert_equal '_test', Iqvoc::Origin.new('_test').to_s
+    assert_equal 'a_test', Iqvoc::Origin.new('a_Test').to_s
+  end
+
+  def test_should_preserve_case
+    assert_equal 'test', Iqvoc::Origin.new('test').to_s
+    assert_equal 'test', Iqvoc::Origin.new('Test').to_s
+    assert_equal '_5test', Iqvoc::Origin.new('5test').to_s
+    assert_equal '_5test', Iqvoc::Origin.new('5Test').to_s
+  end
+
+  def test_should_replace_brackets
+    assert_equal 'energie-ressource',
+      Iqvoc::Origin.new('[Energie/Ressource]').to_s
+  end
+
+  def test_should_replace_comma
+    assert_equal 'ab-cd', Iqvoc::Origin.new('ab,cd').to_s
+  end
+
+  def test_should_replace_less_and_greater_chars
+    assert_equal 'test-123', Iqvoc::Origin.new('Test<123').to_s
+    assert_equal 'test-123', Iqvoc::Origin.new('Test>123').to_s
+  end
+
+  def test_should_merge_all_together
+    assert_equal 'energie-ressource',
+      Iqvoc::Origin.new('[Energie - Ressource]').to_s
+    assert_equal 'hydrosphare-wasser-und-gewasser',
+      Iqvoc::Origin.new('[Hydrosphäre - Wasser und Gewässer]').to_s
+    assert_equal '_12-hydrosphare-wasser-und-gewasser',
+      Iqvoc::Origin.new('12[Hydrosphäre - Wasser und Gewässer]').to_s
+  end
+
+  def test_register_custom_filter
+    Iqvoc::Origin::Filters.register(:strip_foobars, FoobarStripper)
+    assert_equal 'trololo_', Iqvoc::Origin.new('trololo_foobar').strip_foobars.to_s
+    assert_equal 'trololo_', Iqvoc::Origin.new('trololo_foobar').to_s
+  end
+end