iquest-simple_table 0.3.6 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9605388d187db1edcbc45d873ce710cbe8ae4c0b
-  data.tar.gz: 739f74b35c801f11e41f95ad1083f37fea20f360
+  metadata.gz: 45e5c0239f2c37302736ee01e5bd1465eea65bf2
+  data.tar.gz: b9172276ac0091318da04c4be5ff4a131f195c87
 SHA512:
-  metadata.gz: 1d61e21c206fbfab19317fad3d67c681dc284813815615db37cf8e0635cd99c5e4701a0b90b39499d33c047c4900ee6c092dfef17961ea749a5be4d35a2bcd7c
-  data.tar.gz: 8fa682beeef5041e90fb3e73e787833f0bb79108f0dacf048aba5528ef1a303fc4aae5830e63691fd8649167254b6bc60a023d76e93ccdc2dd97471ed5c403ac
+  metadata.gz: a5290739813210936128ea1be2e03298e431d74b9b973ed1745ed75cdf05da38457165ee89040f10a6ce51107981e54bd1bb25abd59a01983a3c547cda539eda
+  data.tar.gz: ec02416131cbafd96908be1eddd0fd968c945bfd062497db3093fdbd45e6412ff8eea1c3f390b28dbb426bd36d24761872e2ca2941ee27fac26b666fc2a78db5

data/.rubocop.yml

@@ -0,0 +1,2 @@
+inherit_gem:
+  relaxed-rubocop: .rubocop.yml

data/.ruby-version

@@ -1 +1 @@
-2.1.5
+2.2.7

data/bench/.ruby-version

@@ -0,0 +1 @@
+2.2.2

data/bench/bench.rb

@@ -0,0 +1,136 @@
+#!/usr/bin/env ruby
+# frozen_string_literal: true
+
+begin
+  require 'bundler/inline'
+rescue LoadError => e
+  $stderr.puts 'Bundler version 1.10 or later is required. Please update your Bundler'
+  raise e
+end
+
+require 'optparse'
+
+options = {}
+OptionParser.new do |opts|
+  opts.banner = "Usage: bench.rb [options]"
+
+  opts.on("-m", "--[no-]mem", "Memory profile") do |v|
+    options[:mem] = v
+  end
+  opts.on("-b", "--[no-]bench", "Benchmark IPS") do |v|
+    options[:bench] = v
+  end
+  opts.on("-t", "--[no-]time", "Method timing") do |v|
+    options[:time] = v
+  end
+end.parse!
+
+gemfile(true) do
+  source 'https://rubygems.org'
+
+  git_source(:github) { |repo| "https://github.com/#{repo}.git" }
+
+  # Activate the gem you are reporting the issue against.
+  gem 'rails', '5.2.0'
+  gem 'activerecord', '5.2.0'
+  gem 'benchmark-ips'
+  gem 'kaminari'
+  gem 'memory_profiler'
+  gem 'ransack', '1.8.8', require: false
+  gem 'iquest-simple_table', path: '../', require: false
+  gem 'timeasure'
+end
+
+require 'rails/all'
+
+class BenchApp < Rails::Application
+  config.root = __dir__
+  config.session_store :cookie_store, key: 'cookie_store_key'
+  secrets.secret_key_base = 'secret_key_base'
+
+  config.logger = Logger.new($stdout)
+  Rails.logger  = config.logger
+end
+
+require 'iquest/simple_table'
+
+class ApplicationController < ActionController::Base
+  layout false
+  prepend_view_path('templates')
+end
+
+class Foo
+  include ActiveModel::Model
+  ATTRIBUTES = %i(a b c d e f g h).freeze
+  attr_accessor *ATTRIBUTES
+  delegate :each, :map, to: :attributes
+
+  def attributes
+    ATTRIBUTES.map { |a| send(a) }
+  end
+end
+
+def render(template, **assigns)
+  ApplicationController.render(
+    template: template.to_s,
+    layout: nil,
+    locals: assigns
+  )
+end
+
+def memory_profile(title)
+  report = MemoryProfiler.report(top: 10, ingnore_files: /memory_profiler/) do
+    yield
+  end
+  puts '=' * 80
+  puts title
+  puts '=' * 80
+  report.pretty_print
+end
+
+today = Date.today
+now = Time.now
+collection = Array.new(100) { Foo.new(a: 0, b: 1, c: 2, d: 3, e: 4, f: 5, g: today, h: now) }
+table = Kaminari.paginate_array(collection).page(1).per(100)
+
+if options[:mem]
+  memory_profile 'table' do
+    render 'table', table: table
+  end
+
+  memory_profile 'simple_table' do
+    render 'simple_table', table: table
+  end
+end
+
+if options[:bench]
+  Benchmark.ips do |x|
+    x.report('table') { render 'table', table: table }
+    x.report('simple_table') { render 'simple_table', table: table }
+
+    x.compare!
+  end
+end
+
+if options[:time]
+  require 'timeasure'
+
+  module Iquest
+    module SimpleTable
+      class TableBuilder
+        include Timeasure
+        tracked_instance_methods :to_s
+        tracked_private_instance_methods :render_table_row, :attr_class
+      end
+    end
+  end
+
+  require 'pp'
+
+  Timeasure::Profiling::Manager.prepare
+  render 'simple_table', table: table
+  report = Timeasure::Profiling::Manager.export
+  report.each do |item|
+    pp item
+  end
+end

data/bench/templates/simple_table.html.erb

@@ -0,0 +1,10 @@
+<%= simple_table_for table do |t|
+  t.column :a
+  t.column :b
+  t.column :c
+  t.column :d
+  t.column :e
+  t.column :f
+  t.column :g
+  t.column :h
+end %>

data/bench/templates/table.html.erb

@@ -0,0 +1,15 @@
+
+<table>
+  <% table.each do |row| %>
+  <tr>
+    <td><%= row.a %></td>
+    <td><%= row.b %></td>
+    <td><%= row.c %></td>
+    <td><%= row.d %></td>
+    <td><%= row.e %></td>
+    <td><%= row.f %></td>
+    <td><%= l(row.g) %></td>
+    <td><%= l(row.h) %></td>
+  </tr>
+  <% end %>
+</table>

data/iquest-simple_table.gemspec

@@ -8,8 +8,8 @@ Gem::Specification.new do |spec|
   spec.version       = Iquest::SimpleTable::VERSION
   spec.authors       = ["Pavel Dusanek"]
   spec.email         = ["dusanek@iquest.cz"]
-  spec.description   = %q{Simple table helper}
-  spec.summary       = %q{Simple table helper, taht supports filtering through Ransack}
+  spec.description   = "Simple table helper"
+  spec.summary       = "Simple table helper, taht supports filtering through Ransack"
   spec.homepage      = "https://github.com/iquest/iquest-simple_table"
   spec.license       = "MIT"
 
@@ -21,4 +21,6 @@ Gem::Specification.new do |spec|
   spec.add_runtime_dependency 'ransack_simple_form', '>= 0.1.0'
   spec.add_development_dependency "bundler", "~> 1.3"
   spec.add_development_dependency "rake"
+  spec.add_development_dependency "relaxed-rubocop"
+  spec.add_development_dependency "rubocop"
 end

data/lib/iquest/simple_table/attribute_description.rb

@@ -1,12 +1,11 @@
 module Iquest
   module SimpleTable
     module AttributeDescription
-
       def human_attribute_description(attribute, options = {})
         parts     = attribute.to_s.split(".")
         attribute = parts.pop
         namespace = parts.join("/") unless parts.empty?
-        attributes_scope = "#{self.i18n_scope}.descriptions"
+        attributes_scope = "#{i18n_scope}.descriptions"
 
         if namespace
           defaults = lookup_ancestors.map do |klass|
@@ -24,7 +23,6 @@ module Iquest
         options[:default] = ''
         I18n.translate(defaults.shift, options)
       end
-
     end
   end
-end
+end

data/lib/iquest/simple_table/table_builder.rb

@@ -8,6 +8,19 @@ module Iquest
       delegate :sort_link, :search_form_for, to: :parent
       delegate :polymorphic_path, :polymorphic_url, to: :parent
       delegate :l, :t, :dom_id, to: :parent
+      delegate :render, :render_to_string, to: :parent
+      CLASS_DELIMITER = ' '.freeze
+      EMPTY_STRING = ''.freeze
+      DEFAULT_FORMATTER = ->(value) do
+        case value
+        when Time
+          l(value)
+        when Date
+          l(value)
+        else
+          value
+        end
+      end
 
       def initialize(parent, collection_or_search, options = {})
         @parent = parent
@@ -18,208 +31,146 @@ module Iquest
         elsif collection_or_search.is_a?(ActiveRecord::Relation) || collection_or_search.is_a?(ActiveRecord::AssociationRelation)
           @collection = collection_or_search
           @klass = @collection.klass
-        elsif collection_or_search.is_a?(Array) && (search = collection_or_search.detect {|o| o.is_a?(Ransack::Search)})
+        elsif collection_or_search.is_a?(Array) && (search = collection_or_search.detect { |o| o.is_a?(Ransack::Search) })
           @search = search
           @collection = search.result
           @klass = @collection.klass
-          options[:search_url] ||= polymorphic_path(collection_or_search.map {|o| o.is_a?(Ransack::Search) ? o.klass : o})          
-        elsif collection_or_search.is_a?(Array) && (collection = collection_or_search.detect {|o| o.is_a?(ActiveRecord::Relation) || o.is_a?(ActiveRecord::AssociationRelation)}) 
+          options[:search_url] ||= polymorphic_path(collection_or_search.map { |o| o.is_a?(Ransack::Search) ? o.klass : o })
+        elsif collection_or_search.is_a?(Array) && (collection = collection_or_search.detect { |o| o.is_a?(ActiveRecord::Relation) || o.is_a?(ActiveRecord::AssociationRelation) })
           @collection = collection
           @klass = @collection.klass
         elsif collection_or_search.is_a?(Array) && (collection_or_search.any? || options[:class])
           @collection = collection_or_search
           @klass = options[:class] || collection_or_search.first.class
-        else  
+        else
           raise TypeError, 'ActiveRecord::Relation, ActiveRecord::AssociationRelation, Ransack::Search or Array of ActiveModel like objects expected'
         end
         apply_pagination
-        #draper
+        # draper
         @collection = @collection.decorate if @collection.respond_to?(:decorate)
-        options[:search_url] ||= polymorphic_path(@klass) rescue NoMethodError        
+        options[:search_url] ||= begin
+                                   polymorphic_path(@klass)
+                                 rescue NoMethodError
+                                   nil
+                                 end
         @options = options
         @table_id = "table_#{@klass}".pluralize.parameterize
         @columns = {}.with_indifferent_access
         @actions = []
         @collection_actions = []
-        @search_input_default_options = {label: false, placeholder: false}.with_indifferent_access
+        @search_input_default_options = { label: false, placeholder: false }.with_indifferent_access
+        @attr_classes = {}
       end
 
       def column(*args, &block)
         attr = args.first
         options = args.extract_options!
-        search = options.delete(:search)                
+        search = options.delete(:search)
         @columns[attr] = options
         @columns[attr][:label] ||= column_label(attr)
-        #iniciaizce search options
+        # iniciaizce search options
         if search.is_a?(Symbol) || search.is_a?(String)
-          @columns[attr][:search] = {search.to_sym => {}}
+          @columns[attr][:search] = { search.to_sym => {} }
         elsif search.is_a? Array
-          @columns[attr][:search] = search.inject({}) {|h, s| h[s.to_sym] = {}; h}
+          @columns[attr][:search] = search.each_with_object({}) { |s, h| h[s.to_sym] = {}; }
         elsif search.is_a? Hash
           @columns[attr][:search] = search
         end
-        @columns[attr][:formatter] ||= block if block_given?
-        @columns[attr][:sort] ||= attr.to_s.tr('.','_') unless @columns[attr][:sort] == false #sort link attr
+        @columns[attr][:formatter] ||= block_given? ? block : DEFAULT_FORMATTER
+        @columns[attr][:sort] ||= attr.to_s.tr('.', '_') unless @columns[attr][:sort] == false # sort link attr
         @columns[attr][:html] ||= {}
+        @columns[attr][:html][:class] = @columns[attr][:html][:class].join(CLASS_DELIMITER) if @columns[attr][:html][:class].is_a?(Array)
+        @columns[attr][:html][:class] ||= ''
       end
 
       def action(*args, &block)
-        action = args.first
+        _action = args.first
         options = args.extract_options!
         options[:proc] = block if block_given?
         @actions << options
       end
 
-      def collection_action(*args, &block)
+      def collection_action(*args)
         action = args.first
         if action.is_a? String
           @collection_actions << action
         elsif block_given?
-          @collection_actions << block.call
-        end        
+          @collection_actions << yield
+        end
       end
 
-      def new_link(*args, &block)
+      def new_link(*_args)
         ActiveSupport::Deprecation.warn("Iquest::SimpleTable#new_link does nothing. Use collection_action")
       end
 
-      def search_link(*args, &block)
+      def search_link(*_args, &block)
         @search_button = block if block_given?
       end
 
-      def reset_link(*args, &block)
+      def reset_link(*_args, &block)
         @reset_button = block if block_given?
       end
 
+      WRAPPER_TEMPLATE = '<div class="filter-table-block">
+      <%= content %>
+      <div class="paginate-block"><%= paginate @collection if @collection.respond_to?(:current_page) %></div>
+      <div class="totals-block"><%= page_entries_info @collection, entry_name: @klass.model_name.human if @collection.respond_to?(:current_page) %></div>
+      </div>'.freeze
+      WRAPPER_ERB = ERB.new(WRAPPER_TEMPLATE)
+
       def to_s
-        if @search
-          content_tag :div, '', class: 'filter-table-block' do
-            render_table_with_search
-          end
-        else
-          content_tag :div, '', class: 'filter-table-block' do
-            render_table_without_search
-          end
-        end
+        content = render_table
+        WRAPPER_ERB.result(binding).html_safe
       end
 
       private
-      def render_table_without_search        
-        table = content_tag :table, id: @table_id, class: @options[:html][:class] << %w(table table-hover table-striped) do
-          render_table_header + render_table_body + render_table_footer
-        end
-
-        out = if @options[:responsive]
-          content_tag :div, class: 'table-responsive' do
-            table
-          end
-        else
-          table
-        end
-
-        out + render_pagination + render_footer_actions
-      end
 
+      TABLE_TEMPLATE = '
+      <% if  @options[:responsive] %><div class="table-responsive"><%end%>
+      <table id="<%= @table_id %>" class="<%= @options[:html][:class].join(CLASS_DELIMITER) %> table table-hover table-striped">
+      <thead>
+      <tr class="labels">
+      <th class="collection-actions"><%= @collection_actions.join %></th>
+      <% columns.each do |attr, options| %>
+        <%= content_tag :th, class: options[:class], data: options[:data] do
+          render_label(attr)
+        end %>
+      <% end %>
+      <% if @search %>
+        <%= render_search_inputs %>
+      <% end %>
+      </tr>
+      </thead>
+      <tbody class="rowlink" data-link="row" data-target="a.rowlink">
+      <% collection.each do |item| %>
+        <%= render_table_row(item) %>
+      <% end %>
+      </tbody>
+      <tfoot class=""><tr class=""></tr></tfoot>
+      </table>
+      <% if  @options[:responsive] %></div><%end%>
+      '.freeze
+      TABLE_ERB = ERB.new(TABLE_TEMPLATE)
       include RansackSimpleForm::FormHelper
 
-      def render_table_with_search
-        ransack_simple_form_for @search, url: @options[:search_url] do |f|
-          @search_form = f
-          render_table_without_search
-        end
-      end
-
-      def render_table_header
-        content_tag :thead, class: 'header' do
-          render_column_labels + render_search_inputs
-        end
-      end
-
-      def render_column_labels
-        content_tag :tr, class:'labels' do
-          rendered_columns = columns.map do |col, opts|
-            render_column_label(col)
-          end.join.html_safe
-          render_collection_actions + rendered_columns
-        end
-      end
-
-      def render_collection_actions
-        content_tag :th, class:'collection-actions' do
-          @collection_actions.join.html_safe
-        end
-      end
-
-      def render_search_inputs
-        return '' unless @search
-        content_tag :tr, class:'filters' do
-          rendered_columns = columns.map do |col, opts|
-            render_column_search_inputs(col, opts)
-          end.join.html_safe
-          render_buttons + rendered_columns
-        end
-      end
-
-      def render_column_search_inputs(column, options)
-        content_tag :th, class: options[:class], data: options[:data] do
-          if options[:search]
-            options[:search].map do |search, options|
-              render_search_input(search, options)
-            end.join.html_safe
-          end
-        end
-      end
-
-      def render_search_input(search, options = {})
-        input_options = @search_input_default_options.merge(options).symbolize_keys
-        search_form.input search.dup, input_options
-      end
-
-      def render_buttons
-        content_tag :th, class:'search-action' do
-          out = content_tag :div, class:'btn-group' do
-            link_to(t('simple_table.reset', default: 'reset').html_safe, '?' , class: 'search-reset btn btn-default') +
-            search_form.button( :submit, t('simple_table.search', default: 'search').html_safe, class: 'search-button btn btn-default')
+      def render_table
+        if @search
+          ransack_simple_form_for @search, url: @options[:search_url] do |f|
+            @search_form = f
+            TABLE_ERB.result(binding).html_safe
           end
-          # FIXME change link_to url
-        end
-      end
-
-      def render_table_body
-        content_tag :tbody, class: 'rowlink', data: {link: 'row', target: 'a.rowlink'} do
-          collection.map do |item|
-            render_table_row(item)
-          end.join.html_safe
-        end
-      end
-
-      def render_table_row(item)
-        row_id = "row_#{dom_id(item)}" rescue nil
-        content_tag :tr, id: row_id do
-          rendered_columns = columns.map do |col|
-            render_value_cell(col, item)
-          end.join.html_safe
-          render_actions(item) + rendered_columns
-        end
-      end
-
-
-      def render_column_label(column)
-        options = @columns[column]
-
-        content_tag :th, class: options[:class], data: options[:data] do
-          render_label(column)
+        else
+          TABLE_ERB.result(binding).html_safe
         end
       end
 
-      def render_label(column)
-        attr = column        
+      def render_label(attr)
         options = @columns[attr]
         label = options[:label] || attr.to_s
-        sort = options[:sort]        
+        sort = options[:sort]
         if @search && sort
           sort_attr = attr
-          sort_options = {}          
+          sort_options = {}
           if sort.is_a?(Hash)
             sort_attr = sort.keys.first
             sort_options = sort[sort_attr]
@@ -234,130 +185,132 @@ module Iquest
         end
       end
 
-      def render_value_cell(*args)
-        col = args.first
-        attr = col.first
-        options = col.second
-        obj = args.second
-        value = get_value(attr, obj)
-        formatter = options[:formatter]
-        cell_value = render_value(obj, value, &formatter)
-        cell_classes = []
-        cell_classes << "rowlink-skip" if include_link?(cell_value)
-        cell_classes << "#{options[:html][:class]}"
-        content_tag :td, class: cell_classes do
-          "#{cell_value}".html_safe
-        end
-      end
-
-      def get_value(attr, obj)
-        if attr.is_a? Symbol
-          obj.try(attr)
-        elsif attr.is_a? String
-          attr.split('.').inject(obj, :try)
+      def render_search_inputs
+        return EMPTY_STRING unless @search
+        content_tag :tr, class: 'filters' do
+          rendered_columns = columns.map do |col, opts|
+            render_column_search_inputs(col, opts)
+          end.join.html_safe
+          render_buttons + rendered_columns
         end
       end
 
-      def include_link?(string)
-        string.try(:include?, '<a')
-      end
-
-      def render_value(*args, &block)
-        object = args.first
-        value = args.second
-        if block_given?
-          case block.arity
-          when 1
-            block.call(value)
-          when 2
-            block.call(object, value)
-          else
-            block.call
+      def render_column_search_inputs(_column, options)
+        content_tag :th, class: options[:class], data: options[:data] do
+          if options[:search]
+            options[:search].map do |search, opts|
+              render_search_input(search, opts)
+            end.join.html_safe
           end
-        else
-          format_value(value)
         end
-
       end
 
-      def format_value(value)
-        case value
-          when Time
-            l(value)
-          when Date
-            l(value)
-          else
-            value
-        end
+      def render_search_input(search, options = {})
+        input_options = @search_input_default_options.merge(options).symbolize_keys
+        search_form.input search.dup, input_options
       end
 
-      def render_actions(item)
-         content_tag :td, class: 'rowlink-skip' do
-           @actions.map do |action|
-             render_action(item, action)
-           end.join.html_safe
-         end
-      end
+      BUTTONS_TEMPLATE = %q(<th class="search-action"><div class="btn-group">
+      <%= link_to(t('simple_table.reset', default: 'reset').html_safe, '?', class: 'search-reset btn btn-default') %>
+      <%= search_form.button( :submit, t('simple_table.search', default: 'search').html_safe, class: 'search-button btn btn-default') %>
+      </div></th>).freeze # FIXME change link_to url
+      BUTTONS_ERB = ERB.new(BUTTONS_TEMPLATE)
 
-      def render_action(*args)
-        obj = args.first
-        options = args.extract_options!
-        options[:proc].call(obj) if options[:proc].is_a? Proc
-      end
+      def render_buttons
+        BUTTONS_ERB.result(binding).html_safe
+      end
+
+      ROWLINK_SKIP = 'rowlink-skip'.freeze
+      TR_TEMPLATE = '<tr id="<%= row_id %>"><%= actions %>
+      <% columns.each do |attr, options| %>
+        <%
+        options = columns[attr]
+        value = get_value(attr, object)
+        html_class = options[:html][:class]
+        html_class << " #{ROWLINK_SKIP}" if include_link?(value)
+        %>
+        <td class="<%= html_class %>"><%= value %></td>
+      <% end %>
+      </tr>'.freeze
+      TR_ERB = ERB.new(TR_TEMPLATE)
+
+      def render_table_row(object)
+        row_id = begin
+                   "row_#{dom_id(object)}"
+                 rescue StandardError
+                   nil
+                 end
+        actions = render_actions(object)
+        TR_ERB.result(binding).html_safe
+      end
+
+      METHOD_DELIMITER = '.'.freeze
 
-      def render_table_footer
-        content_tag :tfoot, class: '' do
-          content_tag :tr, class: '' do
-          end
+      def get_value(attr, obj)
+        value = if attr.is_a? Symbol
+                  obj.send(attr) if obj.respond_to?(attr)
+                elsif attr.is_a? String
+                  attr.split(METHOD_DELIMITER).inject(obj, :try)
+                end
+        formatter = @columns[attr][:formatter] || DEFAULT_FORMATTER
+        case formatter.arity
+        when 1
+          parent.instance_exec value, &formatter
+        when 2
+          parent.instance_exec obj, value, &formatter
+        else
+          parent.instance_exec(&formatter)
         end
       end
 
-      def render_pagination
-        content_tag :div, '', class: 'paginate-block' do
-          paginate @collection if @collection.respond_to?(:current_page)
-        end
-
-      end
+      LINK_PATTERN = '<a'.freeze
 
-      def render_footer_actions
-        content_tag :div, '', class: 'totals-block' do
-          page_entries_info @collection, entry_name: @klass.model_name.human if @collection.respond_to?(:current_page)
-        end
+      def include_link?(string)
+        return false unless string.is_a?(String)
+        string.include?(LINK_PATTERN)
       end
 
-      private
-      def column_class(col)
+      ACTIONS_TEMPLATE = '<td class="rowlink-skip">
+      <% @actions.each do |action|
+        <%= options[:proc].call(obj) if options[:proc].is_a? Proc %>
+      </td>'
 
+      def render_actions(item)
+        content_tag :td, class: 'rowlink-skip' do
+          @actions.map do |action|
+            render_action(item, action)
+          end.join.html_safe
+        end
       end
 
-      def column_value(col, obj)
-        col.to_s.split('.').inject(obj, :try)
+      def render_action(obj, **options)
+        options[:proc].call(obj) if options[:proc].is_a? Proc
       end
 
-      def column_label(attr)        
+      def column_label(attr)
         if attr_class(attr).respond_to?(:human_attribute_name)
           attr_class(attr).try(:human_attribute_name, attr)
         elsif @search
-          Ransack::Translate.attribute(attr.to_s.tr('.','_'), context: @search.context)                  
+          Ransack::Translate.attribute(attr.to_s.tr(METHOD_DELIMITER, '_'), context: @search.context)
         else
           attr.to_s.humanize
         end
-      end  
+      end
 
       def description(attr)
-        if attr_class(attr).respond_to?(:human_attribute_description)
-          description = attr_class(attr).try(:human_attribute_description, attr)
-        end
+        return ''.html_safe unless attr_class(attr).respond_to?(:human_attribute_description)
+        description = attr_class(attr).try(:human_attribute_description, attr)
         if description.present?
           "<div class=\"description\">#{description}</div>".html_safe
         else
-          "".html_safe
+          ''.html_safe
         end
       end
 
       def attr_class(attr)
-        attr.to_s.split('.')[0..-2].inject(@klass) {|klass, assoc| klass.try(:reflect_on_association, assoc).try(:klass)}        
-      end  
+        return @attr_classes[attr] if @attr_classes.key?(attr)
+        @attr_classes[attr] ||= attr.to_s.split(METHOD_DELIMITER)[0..-2].inject(@klass) { |klass, assoc| klass.try(:reflect_on_association, assoc).try(:klass) }
+      end
 
       def column_count
         @columns.count
@@ -372,7 +325,6 @@ module Iquest
       def search_action
         :get
       end
-
     end
   end
 end

data/lib/iquest/simple_table/table_helper.rb

@@ -1,7 +1,7 @@
 module Iquest
   module SimpleTable
     module TableHelper
-      def simple_table_for(*args, &block)
+      def simple_table_for(*args)
         collection = args.first
         opts = args.extract_options!
 
@@ -17,4 +17,4 @@ module Iquest
       end
     end
   end
-end
+end

data/lib/iquest/simple_table/version.rb

@@ -1,5 +1,5 @@
 module Iquest
   module SimpleTable
-    VERSION = '0.3.6'
+    VERSION = '0.4.0'.freeze
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: iquest-simple_table
 version: !ruby/object:Gem::Version
-  version: 0.3.6
+  version: 0.4.0
 platform: ruby
 authors:
 - Pavel Dusanek
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-07-30 00:00:00.000000000 Z
+date: 2018-07-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ransack_simple_form
@@ -52,6 +52,34 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: relaxed-rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Simple table helper
 email:
 - dusanek@iquest.cz
@@ -60,11 +88,17 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".rubocop.yml"
 - ".ruby-version"
 - Gemfile
 - LICENSE.txt
 - README.md
 - Rakefile
+- bench/.ruby-version
+- bench/bench.rb
+- bench/templates/kaminari/_paginator.html.erb
+- bench/templates/simple_table.html.erb
+- bench/templates/table.html.erb
 - config/locale/en.yml
 - iquest-simple_table.gemspec
 - lib/iquest/simple_table.rb
@@ -92,7 +126,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.5.2
 signing_key: 
 specification_version: 4
 summary: Simple table helper, taht supports filtering through Ransack