ipizza 2.0.1 → 2.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 2d02b88f8dee566651de91c705c95c91e586d1de
-  data.tar.gz: 05caaaaa4d249c3ae8ffed1809cc6474254886ec
+SHA256:
+  metadata.gz: 5ed9393a3cf761d93af6cacfe5ab9f5290bd9f9fa07df805eba6e8923c302b80
+  data.tar.gz: 8543fd69e9b7c1c523bdbed2f20ac511b8fef3f3661987d4a960c27df9827bab
 SHA512:
-  metadata.gz: c1ce76b70d0e5e1e8ba12fb81e37904649533f7afad1dddb8f3faf875491099595e1c835de1353a29fa490c10b579ff93a7420635e6a8aaae6b5cc4c4e9a9100
-  data.tar.gz: 7a482f0d83491fc29ef7aa8bdd39d1d35dbfd3b6744a6a01df35ae3616d31a683f4979bb777b7354435e8fd99e4836ac56beefedd871d3725f6c4a6c4bd76990
+  metadata.gz: 9172fb1cbe9b620439a73b41b12d53f0e6bfd5f4ce2d219f0398ab6c4136716200463885ba692cf34b70675e4151f3536398c10a4bf59e9817b09f2c3b52eb69
+  data.tar.gz: 01010f397f8c724adcf89e9db463f7ba6ba9277501ef243957e58b8a7e2eb863c840d9a533e921ec4f953dd10d76479676b0ade0b7bf24da69891bc8fc6cfd7e

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    ipizza (2.0.1)
+    ipizza (2.2.0)
 
 GEM
   remote: http://rubygems.org/
@@ -46,3 +46,6 @@ DEPENDENCIES
   rake
   rb-fsevent
   rspec (~> 2.9.0)
+
+BUNDLED WITH
+   1.17.3

data/ipizza.gemspec

@@ -11,7 +11,7 @@ Gem::Specification.new do |s|
   s.homepage    = 'https://github.com/Voog/ipizza'
   s.summary     = 'Implements iPizza protocol to communicate with Estonian Banks'
   s.description = 'Simplifies generating payment requests and parsing responses from banks when using iPizza protocol.'
-  
+
   s.add_development_dependency 'rspec', '~> 2.9.0'
   s.add_development_dependency 'guard-rspec'
   s.add_development_dependency 'rb-fsevent'

data/lib/ipizza/authentication.rb

@@ -1,8 +1,8 @@
 module Ipizza
   class Authentication
-    
+
     attr_accessor :provider, :user, :message_time, :sender_id, :receiver_id, :user_name, :user_id, :country, :other, :authentication_identifier, :request_identifier
-    
+
     def initialize(attribs = {})
       attribs.each do |key, value|
         if self.respond_to?("#{key.to_s}=".to_sym)

data/lib/ipizza/authentication_response.rb

@@ -1,18 +1,18 @@
 module Ipizza
   class AuthenticationResponse < Ipizza::Response
-    
+
     def success?
       %w(3012 3013).include?(@params['VK_SERVICE'])
     end
-    
+
     def valid?
       @valid
     end
-    
+
     def info_social_security_id
       authentication_info.user_id
     end
-    
+
     def info_name
       authentication_info.user_name
     end

data/lib/ipizza/config.rb

@@ -8,10 +8,10 @@ module Ipizza
 
       def load_from_file(yaml_path)
         @certs_root = File.dirname(yaml_path)
-        
+
         load_from_hash(YAML::load_file(yaml_path))
       end
-      
+
       def load_from_hash(config)
         config.each do |bank, params|
           params.each do |param, value|
@@ -21,19 +21,19 @@ module Ipizza
           end
         end
       end
-      
+
       def configure
         yield self
       end
-      
+
       def method_missing(m, *args)
-        if /^(lhv|swedbank|seb|sampo|krediidipank|nordea)_(.*)=$/ =~ m.to_s
+        if /^(lhv|swedbank|seb|sampo|krediidipank|nordea|luminor)_(.*)=$/ =~ m.to_s
           clz = Ipizza::Provider.const_get($1.capitalize)
           key = $2
           value = args.first
-          
+
           value = load_certificate(value) if /^file_(cert|key)/ =~ key
-          
+
           if clz.respond_to?(:"#{key}=")
             return clz.send(:"#{key}=", *[value])
           end
@@ -41,23 +41,23 @@ module Ipizza
 
         super
       end
-      
+
       private
-      
+
       def load_certificate(file_path)
         if File.exist?(file_path)
           file_path
         else
           file_path = File.expand_path(File.join(certs_root, file_path))
         end
-        
+
         if File.exist?(file_path)
           file_path
         else
           raise "Could not load certificate from file '#{file_path}'"
         end
       end
-      
+
     end
   end
 end

data/lib/ipizza/payment.rb

@@ -1,8 +1,8 @@
 module Ipizza
   class Payment
-    
+
     attr_accessor :provider, :stamp, :amount, :currency, :refnum, :receiver_account, :receiver_name, :sender_account, :sender_name, :message, :transaction_id, :transaction_time
-    
+
     def initialize(attribs = {})
       attribs.each do |key, value|
         if self.respond_to?("#{key.to_s}=".to_sym)

data/lib/ipizza/payment_response.rb

@@ -3,15 +3,15 @@ class Ipizza::PaymentResponse < Ipizza::Response
   def success?
     %w(1111).include?(@params['VK_SERVICE'])
   end
-  
+
   def valid?
     @valid
   end
-  
+
   def automatic_message?
     @params['VK_AUTO'] == 'Y'
   end
-  
+
   def payment_info
     @payment_info ||= Ipizza::Payment.new(
       provider: @params['VK_SND_ID'],

data/lib/ipizza/provider/base.rb

@@ -4,7 +4,20 @@ module Ipizza::Provider
     SUPPORTED_ENCODINGS = %w(UTF-8 ISO-8859-1 WINDOWS-1257)
 
     class << self
-      attr_accessor :service_url, :return_url, :cancel_url, :file_key, :key_secret, :file_cert, :snd_id, :rec_id, :rec_acc, :rec_name, :encoding, :lang
+      attr_accessor :service_url,
+                    :return_url,
+                    :cancel_url,
+                    :file_key,
+                    :key_secret,
+                    :file_cert,
+                    :sign_algorithm,
+                    :verification_algorithm,
+                    :snd_id,
+                    :rec_id,
+                    :rec_acc,
+                    :rec_name,
+                    :encoding,
+                    :lang
     end
 
     def payment_request(payment, service_no = 1012)
@@ -40,7 +53,10 @@ module Ipizza::Provider
 
     def payment_response(params)
       response = Ipizza::PaymentResponse.new(params)
-      response.verify(self.class.file_cert)
+      response.verify(
+        self.class.file_cert,
+        self.class.verification_algorithm || Ipizza::Util::DEFAULT_HASH_ALGORITHM
+      )
       response
     end
 
@@ -77,7 +93,10 @@ module Ipizza::Provider
 
     def authentication_response(params)
       response = Ipizza::AuthenticationResponse.new(params)
-      response.verify(self.class.file_cert)
+      response.verify(
+        self.class.file_cert,
+        self.class.verification_algorithm || Ipizza::Util::DEFAULT_HASH_ALGORITHM
+      )
       response
     end
 

data/lib/ipizza/provider/luminor.rb

@@ -0,0 +1,4 @@
+module Ipizza::Provider
+  class Luminor < Ipizza::Provider::Base
+  end
+end

data/lib/ipizza/provider/nordea.rb

@@ -1,77 +1,4 @@
 module Ipizza::Provider
-
-  # TODO: configure whether use sha-1 or md5 for signing and verification
-  class Nordea
-
-    require 'ipizza/provider/nordea/payment_request'
-    require 'ipizza/provider/nordea/payment_response'
-    require 'ipizza/provider/nordea/authentication_request'
-    require 'ipizza/provider/nordea/authentication_response'
-
-    class << self
-      attr_accessor :payments_service_url, :payments_return_url, :payments_reject_url, :payments_cancel_url
-      attr_accessor :payments_rcv_id, :payments_language
-      attr_accessor :auth_service_url, :auth_return_url, :auth_reject_url, :auth_cancel_url, :auth_language
-      attr_accessor :auth_rcv_id
-      attr_accessor :file_key, :rcv_account, :rcv_name, :confirm, :keyvers
-    end
-
-    def payment_request(payment, service = 1002)
-      req = Ipizza::Provider::Nordea::PaymentRequest.new
-      req.service_url = self.class.payments_service_url
-      req.params = {
-        'VERSION' => '0003',
-        'STAMP' => payment.stamp,
-        'RCV_ID' => self.class.payments_rcv_id,
-        # 'RCV_ACCOUNT' => self.rcv_account,
-        # 'RCV_NAME' => self.rcv_name,
-        'LANGUAGE' => self.class.payments_language,
-        'AMOUNT' => sprintf('%.2f', payment.amount),
-        'REF' => Ipizza::Util.sign_731(payment.refnum),
-        'DATE' => 'EXPRESS',
-        'MSG' => payment.message,
-        'CONFIRM' => self.class.confirm,
-        'CUR' => payment.currency,
-        'KEYVERS' => self.class.keyvers,
-        'REJECT' => self.class.payments_reject_url,
-        'RETURN' => self.class.payments_return_url,
-        'CANCEL' => self.class.payments_cancel_url
-      }
-
-      req.sign(self.class.file_key)
-      req
-    end
-
-    def payment_response(params)
-      response = Ipizza::Provider::Nordea::PaymentResponse.new(params)
-      response.verify(self.class.file_key)
-      return response
-    end
-
-    def authentication_request
-      req = Ipizza::Provider::Nordea::AuthenticationRequest.new
-      req.service_url = self.class.auth_service_url
-      req.params = {
-        'ACTION_ID' => '701',
-        'VERS' => '0002',
-        'RCVID' => self.class.auth_rcv_id,
-        'LANGCODE' => self.class.auth_language,
-        'STAMP' => Time.now.strftime('%Y%m%d%H%M%S'),
-        'IDTYPE' => '02',
-        'KEYVERS' => self.class.keyvers,
-        'RETLINK' => self.class.auth_return_url,
-        'CANLINK' => self.class.auth_cancel_url,
-        'REJLINK' => self.class.auth_reject_url,
-        'ALG' => '01'
-      }
-      req.sign(self.class.file_key)
-      req
-    end
-
-    def authentication_response(params)
-      response = Ipizza::Provider::Nordea::AuthenticationResponse.new(params)
-      response.verify(self.class.file_key)
-      return response
-    end
+  class Nordea < Ipizza::Provider::Base
   end
 end

data/lib/ipizza/provider.rb

@@ -14,8 +14,8 @@ module Ipizza
           Ipizza::Provider::Sampo.new
         when 'krep', 'krediidipank'
           Ipizza::Provider::Krediidipank.new
-        when 'nordea'
-          Ipizza::Provider::Nordea.new
+        when 'luminor', 'testluminor'
+          Ipizza::Provider::Luminor.new
         end
       end
     end

data/lib/ipizza/request.rb

@@ -1,6 +1,6 @@
 module Ipizza
   class Request
-    
+
     attr_accessor :extra_params
     attr_accessor :sign_params
     attr_accessor :service_url
@@ -16,7 +16,7 @@ module Ipizza
       signature = Ipizza::Util.sign(privkey_path, privkey_secret, Ipizza::Util.mac_data_string(sign_params, order))
       self.sign_params[mac_param] = signature
     end
-    
+
     def request_params
       sign_params.merge(extra_params)
     end

data/lib/ipizza/response.rb

@@ -2,21 +2,21 @@ class Ipizza::Response
 
   attr_accessor :verify_params
   attr_accessor :verify_params_order
-  
+
   PARAM_ORDER = {
     '1111' => %w(VK_SERVICE VK_VERSION VK_SND_ID VK_REC_ID VK_STAMP VK_T_NO VK_AMOUNT VK_CURR VK_REC_ACC VK_REC_NAME VK_SND_ACC VK_SND_NAME VK_REF VK_MSG VK_T_DATETIME),
     '3012' => %w(VK_SERVICE VK_VERSION VK_USER VK_DATETIME VK_SND_ID VK_REC_ID VK_USER_NAME VK_USER_ID VK_COUNTRY VK_OTHER VK_TOKEN VK_RID),
     '3013' => %w(VK_SERVICE VK_VERSION VK_DATETIME VK_SND_ID VK_REC_ID VK_NONCE VK_USER_NAME VK_USER_ID VK_COUNTRY VK_OTHER VK_TOKEN VK_RID),
     '1911' => %w(VK_SERVICE VK_VERSION VK_SND_ID VK_REC_ID VK_STAMP VK_REF VK_MSG)
-  }  
-  
+  }
+
   def initialize(params)
     @params = params
   end
 
-  def verify(certificate_path)
+  def verify(certificate_path, hash_algorithm = Ipizza::Util::DEFAULT_HASH_ALGORITHM)
     mac_string = Ipizza::Util.mac_data_string(@params, PARAM_ORDER[@params['VK_SERVICE']])
 
-    @valid = Ipizza::Util.verify_signature(certificate_path, @params['VK_MAC'], mac_string)
+    @valid = Ipizza::Util.verify_signature(certificate_path, @params['VK_MAC'], mac_string, hash_algorithm)
   end
 end

data/lib/ipizza/util.rb

@@ -3,24 +3,33 @@ require 'openssl'
 
 module Ipizza
   class Util
-    
+
+    DEFAULT_HASH_ALGORITHM = 'sha1'
+
     class << self
-      
-      def verify_signature(certificate_path, signature, data)
+
+      def verify_signature(certificate_path, signature, data, hash_algorithm = DEFAULT_HASH_ALGORITHM)
         if !certificate_path.to_s.empty? && !signature.to_s.empty? && File.file?(certificate_path)
           certificate = OpenSSL::X509::Certificate.new(File.read(certificate_path).gsub(/  /, '')).public_key
-          certificate.verify(OpenSSL::Digest::SHA1.new, Base64.decode64(signature), data)
+          certificate.verify(
+            digest_class(hash_algorithm).new,
+            Base64.decode64(signature),
+            data
+          )
         else
           false
         end
       end
-      
-      def sign(privkey_path, privkey_secret, data)
+
+      def sign(privkey_path, privkey_secret, data, hash_algorithm = DEFAULT_HASH_ALGORITHM)
         privkey = File.open(privkey_path, 'r') { |f| f.read }
         privkey = OpenSSL::PKey::RSA.new(privkey.gsub(/  /, ''), privkey_secret)
 
-        signature = privkey.sign(OpenSSL::Digest::SHA1.new, data)
-        signature = Base64.encode64(signature).gsub(/\n/, '')
+        signature = privkey.sign(
+          digest_class(hash_algorithm).new,
+          data
+        )
+        Base64.encode64(signature).gsub(/\n/, '')
       end
 
       # Calculates and adds control number using 7-3-1 algoritm for Estonian banking account and reference numbers.
@@ -74,6 +83,16 @@ module Ipizza
           sprintf('%03i', val.bytesize)
         end
       end
+
+      def digest_class(hash_algorithm)
+        algorithm = (hash_algorithm || '').upcase
+
+        if OpenSSL::Digest.const_defined?(algorithm)
+          OpenSSL::Digest.const_get(algorithm)
+        else
+          raise ArgumentError, "Unknown hash algorithm OpenSSL::Digest::#{algorithm}"
+        end
+      end
     end
   end
 end

data/lib/ipizza/version.rb

@@ -1,3 +1,3 @@
 module Ipizza
-  VERSION = '2.0.1'
+  VERSION = '2.2.0'
 end

data/lib/ipizza.rb

@@ -16,3 +16,4 @@ require 'ipizza/provider/seb'
 require 'ipizza/provider/sampo'
 require 'ipizza/provider/krediidipank'
 require 'ipizza/provider/nordea'
+require 'ipizza/provider/luminor'

data/spec/certificates/pangalink_luminor_bank.cert.pem

@@ -0,0 +1,18 @@
+-----BEGIN CERTIFICATE-----
+MIIC+jCCAeICCQDuCELf8TcV7DANBgkqhkiG9w0BAQsFADA/MQswCQYDVQQGEwJF
+RTEOMAwGA1UECAwFVGFydHUxDjAMBgNVBAcMBVRhcnR1MRAwDgYDVQQKDAdNaWxl
+ZWRpMB4XDTIwMTIwMzA5NDkxMloXDTI1MTIwMTA5NDkxMlowPzELMAkGA1UEBhMC
+RUUxDjAMBgNVBAgMBVRhcnR1MQ4wDAYDVQQHDAVUYXJ0dTEQMA4GA1UECgwHTWls
+ZWVkaTCCASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEBALmozE2DIZyCddrW
+AVoVkNWYRYDytAi5lefa5+PEAQLGFzzfTBRnClla/Qerfe4NBGjyiwu8W6VeLGQ9
++GGDw5uEQumII2t0f1vpKWiauyfM+MlSOB6cobf9bwlgs9gBss/PEAa8E4MhpS60
+p7KNfR1qcq3AWgxpjE9ns7KheARW1q0vNZFzPkONyleZ4HJIC8rlta38/VMvbPnp
+PLbMnVOvrOsxeDMCgGpD9hupxVsFnhsv/Y4F14W7f4XHl36FhDjP8dkrgrkQE4E1
+dRnxx6GC4Lv71rQDu+gmgyKtZWmsym1b1Tzw3aCF27J1EReHvCxtkDfMH1VzQSad
+FGF4yXsCAwEAATANBgkqhkiG9w0BAQsFAAOCAQEAQfs7p7MLZqtm9QxBkGcYALDw
+q/f+5b+n1uPdFcXu8K26hG6RiVZTXUJrIqR71kGLG0mBJ3V6+vAM9gjsUJs20uiZ
+qvdV2xQglTpJlNTG4Je3Sq4Lbyz4w+8e9VVrE3atfARHxA5FIewCviJNdXS+xeuh
+GqKaGqLSf4sJlbe3hE69hzlDXmzUE+/OhoaSPS3zFAzcp9m50o7InhYy80eKDRFS
+hBIDbLnyzb+97If9BMOhqQ/nfCrsX6TiTiqhIFB+qNSIZt733fx9AD3AwSxM51RC
+V232swdtXx9d39S/DskhMkXkOiqpr+0P87Qyy8Y0/FoWO57i/jXb0uCccPatdw==
+-----END CERTIFICATE-----

data/spec/certificates/pangalink_luminor_bank_cert.pem

@@ -0,0 +1,17 @@
+-----BEGIN CERTIFICATE-----
+MIICnzCCAYegAwIBAgIBATANBgkqhkiG9w0BAQUFADATMREwDwYDVQQDDAhCYW5r
+bGluazAeFw0yMDEyMDMxMDUwNDJaFw0yMjEyMDMxMDUwNDJaMBMxETAPBgNVBAMM
+CEJhbmtsaW5rMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAgI7m13+Z
+2B3aBtXE4/2YmsG9koPpD7RHj5B7uEozBCNM1MhfYoE7R7vP1tPm7lD/oJxKk0G3
+gpODtGDqo+kMfI+TlJ/w2KzwS5YPEop7aliEQ1bbwjjjY2tXYwsBYa0uRvkbwizH
+lp3PHmr4DBl+JxyETIWGX623nZxZcHAvwcM6VpTtd9+KEpgToQ2gPHHj4/svQfwm
+mzhdEwFZjwjCaOEHssaUcLsyvKVoJ5OJqBWS1e0mVqWsuJJJnkeG7NVXY2LWDDfP
+iGogVz9hqqxfNKhCTLGMCG8k8VDQdLTaR+vvmXSUBLh+4TbFA7ZPLSvgbRu3995F
+CCY/wADRophRVQIDAQABMA0GCSqGSIb3DQEBBQUAA4IBAQAcTtcH4m//FyGrNC2h
+rcry6wt843xclEkLQSSNGz9wVCQW/D8I0VNjFPk4PgoUh4bTr+mKrZ6UrrIwBuO6
+oFj2Nh+Y1wgkpd3LMKae5DvWLE4taZ4ylBGSUXOpQ062+pOtUldZQxBiczaUJWm4
+4Ns+27Zi5oGyTNnlZXfguEnt54KA+63S4aiHWUSaaXkRN62LeNuyrX0ZdITEfTaz
+0ZvVcn6FbL6OnsqoZn2MF9+xZfMqlu/K5HfGl928v0fzY8/jQygxUoGFIBfxhn46
+NniPM9xtnPSu11ut1n0PQPP8K94+MUJz7GDw9o9z3X0zgy8SOFSpY8HNp0MEjN7l
+MT8n
+-----END CERTIFICATE-----

data/spec/config/config.yml

@@ -41,6 +41,19 @@ seb:
   key_secret: foobar
   encoding: UTF-8
   snd_id: sender
+  sign_algorithm: 'sha256'
+  verification_algorithm: 'sha256'
+
+luminor:
+  service_url: https://banklink.luminor.ee/test
+  return_url: http://test.local/seb
+  cancel_url: http://test.local/seb
+  login: dealer
+  file_cert: ../certificates/pangalink_seb_bank_cert.pem
+  file_key: ../certificates/pangalink_seb_user_key.pem
+  key_secret: foobar
+  encoding: UTF-8
+  snd_id: sender
 
 nordea:
   payments_service_url: https://netbank.nordea.com/pnbepaytest/epayn.jsp

data/spec/config/plain_config.yml

@@ -11,3 +11,5 @@ swedbank:
 
 seb:
   service_url: https://www.seb.ee/banklink
+  sign_algorithm: 'sha256'
+  verification_algorithm: 'sha1'

data/spec/ipizza/config_spec.rb

@@ -16,6 +16,8 @@ describe Ipizza::Config do
       Ipizza::Provider::Swedbank.encoding.should == 'UTF-8'
       
       Ipizza::Provider::Seb.service_url.should == 'https://www.seb.ee/banklink'
+      Ipizza::Provider::Seb.sign_algorithm.should == 'sha256'
+      Ipizza::Provider::Seb.verification_algorithm.should == 'sha1'
     end
   
     it 'should load certificates from path relative to configuration file' do

data/spec/ipizza/provider/luminor_spec.rb

@@ -0,0 +1,89 @@
+require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
+
+describe Ipizza::Provider::Luminor do
+  let(:response_time) { Ipizza::Util.time_to_iso8601(Time.now) }
+  let(:bank_key) { File.expand_path('../../../certificates/pangalink_seb_bank_key.pem', __FILE__) }
+
+  describe '#payment_request' do
+    let(:payment) { Ipizza::Payment.new(stamp: 1, amount: '123.34', refnum: 1, message: 'Payment message', currency: 'EUR') }
+
+    before(:each) do
+      req_time = Time.now
+      Time.stub!(:now).and_return(req_time)
+    end
+
+    it 'should sign the request' do
+      req = Ipizza::Provider::Luminor.new.payment_request(payment)
+      params = {
+        'VK_SERVICE' => '1012',
+        'VK_VERSION' => '008',
+        'VK_SND_ID' => Ipizza::Provider::Luminor.snd_id,
+        'VK_STAMP' => payment.stamp,
+        'VK_AMOUNT' => sprintf('%.2f', payment.amount),
+        'VK_CURR' => payment.currency,
+        'VK_REF' => Ipizza::Util.sign_731(payment.refnum),
+        'VK_MSG' => payment.message,
+        'VK_RETURN' => Ipizza::Provider::Luminor.return_url,
+        'VK_CANCEL' => Ipizza::Provider::Luminor.cancel_url,
+        'VK_DATETIME' => Ipizza::Util.time_to_iso8601(Time.now)
+      }
+      signature = Ipizza::Util.sign(Ipizza::Provider::Luminor.file_key, Ipizza::Provider::Luminor.key_secret, Ipizza::Util.mac_data_string(params, Ipizza::Request::PARAM_ORDER['1012']))
+      req.sign_params['VK_MAC'].should == signature
+    end
+  end
+
+  describe '#payment_response' do
+    let(:params) {
+      {
+        'VK_SERVICE' => '1111', 'VK_VERSION' => '008', 'VK_SND_ID' => 'LUMINOR', 'VK_REC_ID' => 'sender',
+        'VK_STAMP' => '20150111000004', 'VK_T_NO' => '1143', 'VK_AMOUNT' => '.17', 'VK_CURR' => 'EUR',
+        'VK_REC_ACC' => 'EE411010002050618003', 'VK_REC_NAME' => 'ÕILIS OÜ',
+        'VK_SND_ACC' => 'EE541010010046155012', 'VK_SND_NAME' => 'TÕÄGER Leõpäöld¸´¨¦',
+        'VK_REF' => '201501110000048', 'VK_MSG' => 'Invoice #20150111000004', 'VK_T_DATETIME' => response_time,
+        'VK_ENCODING' => 'UTF-8', 'VK_LANG' => 'EST', 'VK_AUTO' => 'N'
+      }
+    }
+
+    it 'should parse and verify the payment response from bank' do
+      signature = Ipizza::Util.sign(bank_key, nil, Ipizza::Util.mac_data_string(params, Ipizza::Response::PARAM_ORDER['1111']))
+      Ipizza::Provider::Luminor.new.payment_response(params.merge('VK_MAC' => signature)).should be_valid
+    end
+  end
+
+  describe '#authentication_request' do
+    before(:each) do
+      req_time = Time.now
+      Time.stub!(:now).and_return(req_time)
+    end
+
+    it 'should sign the request' do
+      req = Ipizza::Provider::Luminor.new.authentication_request
+      params = {
+        'VK_SERVICE' => '4011',
+        'VK_VERSION' => '008',
+        'VK_SND_ID' => Ipizza::Provider::Luminor.snd_id,
+        'VK_RETURN' => Ipizza::Provider::Luminor.return_url,
+        'VK_DATETIME' => Ipizza::Util.time_to_iso8601(Time.now),
+        'VK_RID' => '',
+        'VK_REPLY' => '3012'
+      }
+      signature = Ipizza::Util.sign(Ipizza::Provider::Luminor.file_key, Ipizza::Provider::Luminor.key_secret, Ipizza::Util.mac_data_string(params, Ipizza::Request::PARAM_ORDER['4011']))
+      req.sign_params['VK_MAC'].should == signature
+    end
+  end
+
+  describe '#authentication_response' do
+    let(:params) {
+      {
+        'VK_SERVICE' => '3012', 'VK_VERSION' => '008', 'VK_USER' => 'dealer', 'VK_DATETIME' => response_time,
+        'VK_SND_ID' => 'LUMINOR', 'VK_REC_ID' => 'sender', 'VK_USER_NAME' => 'TÕÄGER Leõpäöld¸´¨¦', 'VK_USER_ID' => '35511280268',
+        'VK_COUNTRY' => 'EE', 'VK_OTHER' => '', 'VK_TOKEN' => '7', 'VK_RID' => ''
+      }
+    }
+
+    it 'should parse and verify the authentication response from bank' do
+      signature = Ipizza::Util.sign(bank_key, nil, Ipizza::Util.mac_data_string(params, Ipizza::Response::PARAM_ORDER['3012']))
+      Ipizza::Provider::Luminor.new.authentication_response(params.merge('VK_MAC' => signature)).should be_valid
+    end
+  end
+end

data/spec/ipizza/provider/seb_spec.rb

@@ -45,7 +45,12 @@ describe Ipizza::Provider::Seb do
     }
 
     it 'should parse and verify the payment response from bank' do
-      signature = Ipizza::Util.sign(bank_key, nil, Ipizza::Util.mac_data_string(params, Ipizza::Response::PARAM_ORDER['1111']))
+      signature = Ipizza::Util.sign(
+        bank_key,
+        nil,
+        Ipizza::Util.mac_data_string(params, Ipizza::Response::PARAM_ORDER['1111']),
+        Ipizza::Provider::Seb.sign_algorithm
+      )
       Ipizza::Provider::Seb.new.payment_response(params.merge('VK_MAC' => signature)).should be_valid
     end
   end
@@ -82,7 +87,12 @@ describe Ipizza::Provider::Seb do
     }
 
     it 'should parse and verify the authentication response from bank' do
-      signature = Ipizza::Util.sign(bank_key, nil, Ipizza::Util.mac_data_string(params, Ipizza::Response::PARAM_ORDER['3012']))
+      signature = Ipizza::Util.sign(
+        bank_key,
+        nil,
+        Ipizza::Util.mac_data_string(params, Ipizza::Response::PARAM_ORDER['3012']),
+        Ipizza::Provider::Seb.sign_algorithm
+      )
       Ipizza::Provider::Seb.new.authentication_response(params.merge('VK_MAC' => signature)).should be_valid
     end
   end

data/spec/ipizza/provider_spec.rb

@@ -9,11 +9,11 @@ describe Ipizza::Provider do
     it 'returns swedbank provider for "swedbank" attribute' do
       Ipizza::Provider.get('swedbank').should be_a(Ipizza::Provider::Swedbank)
     end
-    
+
     it 'returns swedbank provider for "hp" attribute' do
       Ipizza::Provider.get('hp').should be_a(Ipizza::Provider::Swedbank)
     end
-    
+
     it 'returns seb provider for "eyp" attribute' do
       Ipizza::Provider.get('eyp').should be_a(Ipizza::Provider::Seb)
     end
@@ -22,6 +22,14 @@ describe Ipizza::Provider do
       Ipizza::Provider.get('seb').should be_a(Ipizza::Provider::Seb)
     end
 
+    it 'returns luminor provider for "luminor" attribute' do
+      Ipizza::Provider.get('luminor').should be_a(Ipizza::Provider::Luminor)
+    end
+
+    it 'returns luminor provider for "testluminor" attribute' do
+      Ipizza::Provider.get('luminor').should be_a(Ipizza::Provider::Luminor)
+    end
+
     it 'returns sampo provider for "sampo" attribute' do
       Ipizza::Provider.get('sampo').should be_a(Ipizza::Provider::Sampo)
     end
@@ -33,14 +41,10 @@ describe Ipizza::Provider do
     it 'returns krediidipank provider for "krep" attribute' do
       Ipizza::Provider.get('krep').should be_a(Ipizza::Provider::Krediidipank)
     end
-    
+
     it 'returns krediidipank provider for "krediidipank" attribute' do
       Ipizza::Provider.get('krediidipank').should be_a(Ipizza::Provider::Krediidipank)
     end
-    
-    it 'returns nordea provider for "nordea" attribute' do
-      Ipizza::Provider.get('nordea').should be_a(Ipizza::Provider::Nordea)
-    end
 
     it 'returns nothing for "unkn" attribute' do
       Ipizza::Provider.get('unkn').should be_nil

metadata

@@ -1,15 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: ipizza
 version: !ruby/object:Gem::Version
-  version: 2.0.1
+  version: 2.2.0
 platform: ruby
 authors:
 - Priit Haamer
 - Tanel Jakobsoo
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2015-02-12 00:00:00.000000000 Z
+date: 2023-09-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -98,6 +98,7 @@ files:
 - lib/ipizza/provider/base.rb
 - lib/ipizza/provider/krediidipank.rb
 - lib/ipizza/provider/lhv.rb
+- lib/ipizza/provider/luminor.rb
 - lib/ipizza/provider/nordea.rb
 - lib/ipizza/provider/nordea/authentication_request.rb
 - lib/ipizza/provider/nordea/authentication_response.rb
@@ -120,6 +121,8 @@ files:
 - spec/certificates/pangalink_lhv_bank_cert.pem
 - spec/certificates/pangalink_lhv_bank_key.pem
 - spec/certificates/pangalink_lhv_user_key.pem
+- spec/certificates/pangalink_luminor_bank.cert.pem
+- spec/certificates/pangalink_luminor_bank_cert.pem
 - spec/certificates/pangalink_seb_bank_cert.pem
 - spec/certificates/pangalink_seb_bank_key.pem
 - spec/certificates/pangalink_seb_user_key.pem
@@ -132,10 +135,7 @@ files:
 - spec/ipizza/config_spec.rb
 - spec/ipizza/provider/krediidipank_spec.rb
 - spec/ipizza/provider/lhv_spec.rb
-- spec/ipizza/provider/nordea/authentication_response_spec.rb
-- spec/ipizza/provider/nordea/payment_request_spec.rb
-- spec/ipizza/provider/nordea/payment_response_spec.rb
-- spec/ipizza/provider/nordea_spec.rb
+- spec/ipizza/provider/luminor_spec.rb
 - spec/ipizza/provider/sampo_spec.rb
 - spec/ipizza/provider/seb_spec.rb
 - spec/ipizza/provider/swedbank_spec.rb
@@ -146,7 +146,7 @@ files:
 homepage: https://github.com/Voog/ipizza
 licenses: []
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -161,9 +161,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.2.2
-signing_key: 
+rubygems_version: 3.0.8
+signing_key:
 specification_version: 4
 summary: Implements iPizza protocol to communicate with Estonian Banks
 test_files:
@@ -177,6 +176,8 @@ test_files:
 - spec/certificates/pangalink_lhv_bank_cert.pem
 - spec/certificates/pangalink_lhv_bank_key.pem
 - spec/certificates/pangalink_lhv_user_key.pem
+- spec/certificates/pangalink_luminor_bank.cert.pem
+- spec/certificates/pangalink_luminor_bank_cert.pem
 - spec/certificates/pangalink_seb_bank_cert.pem
 - spec/certificates/pangalink_seb_bank_key.pem
 - spec/certificates/pangalink_seb_user_key.pem
@@ -189,10 +190,7 @@ test_files:
 - spec/ipizza/config_spec.rb
 - spec/ipizza/provider/krediidipank_spec.rb
 - spec/ipizza/provider/lhv_spec.rb
-- spec/ipizza/provider/nordea/authentication_response_spec.rb
-- spec/ipizza/provider/nordea/payment_request_spec.rb
-- spec/ipizza/provider/nordea/payment_response_spec.rb
-- spec/ipizza/provider/nordea_spec.rb
+- spec/ipizza/provider/luminor_spec.rb
 - spec/ipizza/provider/sampo_spec.rb
 - spec/ipizza/provider/seb_spec.rb
 - spec/ipizza/provider/swedbank_spec.rb

data/spec/ipizza/provider/nordea/authentication_response_spec.rb

@@ -1,33 +0,0 @@
-require File.expand_path(File.dirname(__FILE__) + '/../../../spec_helper')
-
-describe Ipizza::Provider::Nordea::AuthenticationResponse do
-  before(:each) do
-    @valid_params = {
-      'B02K_CUSTNAME' => 'Demo kasutaja', 'B02K_IDNBR' => '87654321', 'B02K_TIMESTMP' => '20020101204145428720',
-      'B02K_STAMP' => '20101204155339', 'B02K_KEYVERS' => '0001', 'B02K_MAC' => 'A061E22312D7D63FDC2B0B52E16BC971',
-      'B02K_CUSTTYPE' => '01', 'B02K_ALG' => '01', 'B02K_CUSTID' => '37404280367', 'B02K_VERS' => '0002'
-    }
-    @response = Ipizza::Provider::Nordea::AuthenticationResponse.new(@valid_params)
-    @response.verify(Ipizza::Provider::Nordea.file_key)
-  end
-  
-  describe '#valid?' do
-    context 'given valid parameters' do
-      it 'returns true' do
-        @response.valid?.should be_true
-      end
-    end
-  end
-  
-  describe '#info_social_security_id' do
-    it 'should get user social security id from the response' do
-      @response.info_social_security_id.should == '37404280367'
-    end
-  end
-  
-  describe '#info_name' do
-    it 'should get user name from the response' do
-      @response.info_name.should == 'Demo kasutaja'
-    end
-  end
-end

data/spec/ipizza/provider/nordea/payment_request_spec.rb

@@ -1,4 +0,0 @@
-require File.expand_path(File.dirname(__FILE__) + '/../../../spec_helper')
-
-describe Ipizza::Provider::Nordea::PaymentRequest do
-end

data/spec/ipizza/provider/nordea/payment_response_spec.rb

@@ -1,4 +0,0 @@
-require File.expand_path(File.dirname(__FILE__) + '/../../../spec_helper')
-
-describe Ipizza::Provider::Nordea::PaymentResponse do
-end

data/spec/ipizza/provider/nordea_spec.rb

@@ -1,29 +0,0 @@
-require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
-
-describe Ipizza::Provider::Nordea do
-  describe '#authentication_request' do
-    before(:each) do
-      @req = Ipizza::Provider::Nordea.new.authentication_request
-    end
-    
-    it 'returns signed authentication request object' do
-      @req.request_params.fetch('A01Y_MAC').should be
-    end
-    
-    it 'adds service url to request' do
-      @req.service_url.should == Ipizza::Provider::Nordea.auth_service_url
-    end
-
-    it 'adds return url from configuration to request' do
-      @req.request_params.fetch('A01Y_RETLINK').should == Ipizza::Provider::Nordea.auth_return_url
-    end
-
-    it 'adds cancel url from configuration to request' do
-      @req.request_params.fetch('A01Y_CANLINK').should == Ipizza::Provider::Nordea.auth_cancel_url
-    end
-
-    it 'adds reject url from configuration to request' do
-      @req.request_params.fetch('A01Y_REJLINK').should == Ipizza::Provider::Nordea.auth_reject_url
-    end
-  end
-end