ipizza 2.0.0 → 2.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0d8d1718b8729dfa5e26d38c5bd91e6a3dc572e7
-  data.tar.gz: 4dde7b36c532ea40fca0a4d9ea982bc828d0c90a
+  metadata.gz: 2d02b88f8dee566651de91c705c95c91e586d1de
+  data.tar.gz: 05caaaaa4d249c3ae8ffed1809cc6474254886ec
 SHA512:
-  metadata.gz: 15b005e53850f6188f4721058da6db647015ac65e34be2707eb686dbcf953501e648a283a60d01b02b5b8cbc29838e7d5193f37442051cb741a88692f057802e
-  data.tar.gz: 0c3ef956c1fa6611cd25971aadd8a4b96c4527a78e256bbec019e93f3a635c3bfe838181c573386eb5f767f5795c16b0415c900c1eedc9b12a51528763e7c98c
+  metadata.gz: c1ce76b70d0e5e1e8ba12fb81e37904649533f7afad1dddb8f3faf875491099595e1c835de1353a29fa490c10b579ff93a7420635e6a8aaae6b5cc4c4e9a9100
+  data.tar.gz: 7a482f0d83491fc29ef7aa8bdd39d1d35dbfd3b6744a6a01df35ae3616d31a683f4979bb777b7354435e8fd99e4836ac56beefedd871d3725f6c4a6c4bd76990

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    ipizza (2.0.0)
+    ipizza (2.0.1)
 
 GEM
   remote: http://rubygems.org/

data/lib/ipizza/provider.rb

@@ -3,7 +3,7 @@ module Ipizza
 
     class << self
       def get(provider_name)
-        case provider_name.downcase
+        case provider_name.to_s.downcase
         when 'lhv'
           Ipizza::Provider::Lhv.new
         when 'swedbank', 'hp'
@@ -16,8 +16,6 @@ module Ipizza
           Ipizza::Provider::Krediidipank.new
         when 'nordea'
           Ipizza::Provider::Nordea.new
-        else
-          Ipizza::Provider::Base.new
         end
       end
     end

data/lib/ipizza/provider/base.rb

@@ -77,7 +77,7 @@ module Ipizza::Provider
 
     def authentication_response(params)
       response = Ipizza::AuthenticationResponse.new(params)
-      response.verify(self.class.file_cert, self.class.encoding)
+      response.verify(self.class.file_cert)
       response
     end
 

data/lib/ipizza/util.rb

@@ -7,8 +7,12 @@ module Ipizza
     class << self
       
       def verify_signature(certificate_path, signature, data)
-        certificate = OpenSSL::X509::Certificate.new(File.read(certificate_path).gsub(/  /, '')).public_key
-        @valid = certificate.verify(OpenSSL::Digest::SHA1.new, Base64.decode64(signature), data)
+        if !certificate_path.to_s.empty? && !signature.to_s.empty? && File.file?(certificate_path)
+          certificate = OpenSSL::X509::Certificate.new(File.read(certificate_path).gsub(/  /, '')).public_key
+          certificate.verify(OpenSSL::Digest::SHA1.new, Base64.decode64(signature), data)
+        else
+          false
+        end
       end
       
       def sign(privkey_path, privkey_secret, data)
@@ -45,12 +49,12 @@ module Ipizza
       #
       #   p(x1)||x1||p(x2)||x2||...||p(xn)||xn
       #
-      # Where || is string concatenation, p(x) is length of the field x represented by three digits.
+      # Where || is string concatenation, p(x) is length of the (stripped) field x represented by three digits.
       #
       # Parameters val1, val2, value3 would be turned into "003val1003val2006value3".
       def mac_data_string(params, sign_param_order)
-        sign_param_order.inject('') do |memo, param|
-          val = params[param].to_s
+        (sign_param_order || []).inject('') do |memo, param|
+          val = params[param].to_s.strip
           memo << func_p(val) << val
           memo
         end

data/lib/ipizza/version.rb

@@ -1,3 +1,3 @@
 module Ipizza
-  VERSION = '2.0.0'
+  VERSION = '2.0.1'
 end

data/spec/ipizza/provider_spec.rb

@@ -41,5 +41,9 @@ describe Ipizza::Provider do
     it 'returns nordea provider for "nordea" attribute' do
       Ipizza::Provider.get('nordea').should be_a(Ipizza::Provider::Nordea)
     end
+
+    it 'returns nothing for "unkn" attribute' do
+      Ipizza::Provider.get('unkn').should be_nil
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ipizza
 version: !ruby/object:Gem::Version
-  version: 2.0.0
+  version: 2.0.1
 platform: ruby
 authors:
 - Priit Haamer
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-02-03 00:00:00.000000000 Z
+date: 2015-02-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec