ip 0.1.0 → 0.1.1

data/lib/ip.rb

@@ -25,6 +25,11 @@
 # perhaps a distant, future release. Any patches that can correct this
 # issue are most welcome.
 #
+# Also: Thanks to Tim Howe, who did a lot of initial bug testing and
+# 'trial by fire' as this package came out of it's shell. Writing new
+# methods that made code easier to understand and/or clearer, and
+# making plenty of suggestions made creating this module much easier.
+#
 # ================================================================
 #
 # The compilation of software known as ip.rb is distributed under the
@@ -262,7 +267,24 @@ class IP
         raise IP::AddressException.new("Fed IP address is not String")
       end
       @ip_address = ip_address
-      @octets = ip_address.split(/\./).collect { |x| x.to_i }
+      
+      #
+      # Unbeknowest by me, to_i will not throw an exception if the string
+      # can't be converted cleanly - it just truncates, similar to atoi() and perl's int().
+      #
+      # Code below does a final sanity check.
+      #
+
+      octets = ip_address.split(/\./)
+      octets_i = octets.collect { |x| x.to_i }
+      
+      0.upto(octets.length - 1) do |octet|
+        if octets[octet] != octets_i[octet].to_s
+          raise IP::AddressException.new("Integer conversion failed")
+        end
+      end
+
+      @octets = octets_i
 
       # I made a design decision to allow 0.0.0.0 here.
       if @octets.length != 4 or @octets.find_all { |x| x > 255 }.length > 0

data/test/ip.rb

@@ -198,6 +198,25 @@ class AddressTest < Test::Unit::TestCase
     end
 
     assert(false, "init test #4") if ip
+
+    ip = nil
+    begin
+      ip = IP::Address.new("255.255.255.255aaaa")
+    rescue IP::AddressException => e
+      assert(true, "init test #5")
+    end
+
+    assert(false, "init test #5") if ip
+
+    ip = nil
+    begin
+      ip = IP::Address.new("255.255.255.")
+    rescue IP::AddressException => e
+      assert(true, "init test #6")
+    end
+
+    assert(false, "init test #6") if ip
+
   end
   
   def test_accessor

metadata

@@ -3,11 +3,11 @@ rubygems_version: 0.8.11
 specification_version: 1
 name: ip
 version: !ruby/object:Gem::Version 
-  version: 0.1.0
-date: 2006-01-20 00:00:00 -08:00
-summary: "Ruby classes to work with IP address, ranges, and netmasks"
+  version: 0.1.1
+date: 2006-02-08 00:00:00 -08:00
+summary: Ruby classes to work with IP address, ranges, and netmasks
 require_paths: 
-  - lib
+- lib
 email: erik@hollensbe.org
 homepage: 
 rubyforge_project: ip-address
@@ -18,23 +18,28 @@ bindir: bin
 has_rdoc: true
 required_ruby_version: !ruby/object:Gem::Version::Requirement 
   requirements: 
-    - 
-      - ">"
-      - !ruby/object:Gem::Version 
-        version: 0.0.0
+  - - ">"
+    - !ruby/object:Gem::Version 
+      version: 0.0.0
   version: 
 platform: ruby
 signing_key: 
 cert_chain: 
 authors: 
-  - Erik Hollensbe
+- Erik Hollensbe
 files: 
-  - lib/ip.rb
+- lib/ip.rb
 test_files: 
-  - test/ip.rb
+- test/ip.rb
 rdoc_options: []
+
 extra_rdoc_files: []
+
 executables: []
+
 extensions: []
+
 requirements: []
-dependencies: []
+
+dependencies: []
+