iodine 0.7.51 → 0.7.53

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 95f2aaf4cba29fd196558c215f6899964057cfb20520a4bd121e27bf4205520c
-  data.tar.gz: 2861b7b910a9094ab2500f98964dac4551ac0028845c72522ccfc909570595ef
+  metadata.gz: 2d908d42070e3a604c33e2ea2cb565339779046a5c17bb9e72f85417ad5eed5c
+  data.tar.gz: 91ac3e4939b3ea93bcaa548d8688cf54e15841560237ec3e8e864b483add5a74
 SHA512:
-  metadata.gz: 4cd6f2e365dc5944089bff7ca27f75b5a7912bbf7263895f75c0c6a493f225046fd86543b819646eabd5de0c60fc7f0c66e682ec760919b7faedbe9a30ef479f
-  data.tar.gz: b50eb0aef891a06d9d649120417010b418cdd31994108b3e09dc0062c5ef623f69c9111fcdd66c063948d317711a6cce348c7ab52e35ba1dee5d43222f30cc6b
+  metadata.gz: 9fbf367a02283bc139ff358ca383d596c68f2eebcae65f0f4bc4d47b2bf72f06dc19dc4a2418dd5d4b6864af857d693a7041fc4e25e4f2f08e92d57868590d79
+  data.tar.gz: 7e9f7fbdd64a134bc2a491d6ae5c1ed41a5d5995023135678d2905b5bd9662a09b9aea7fe07a0fd70c6d4935706a8a062ee948c7fd375307d64afe9e97180bf3

data/CHANGELOG.md

@@ -6,7 +6,21 @@ Please notice that this change log contains changes for upcoming releases as wel
 
 ## Changes:
 
-#### Change log v.0.7.50
+#### Change log v.0.7.53 2023-01-13
+
+**Fix**: Fixes Unix socket permission limitations, so unix sockets are not limited to the owner of the process. Credit to Patrik Rak (@raxoft) for opening issue #136.
+
+#### Change log v.0.7.52 (2022-12-10)
+
+**Fix**: Fixes `Iodine.unsubscribe` which failed when a symbol was supplied. Credit to Patrik Rak (@raxoft) for opening issue #134.
+
+**Fix**: Fixes `Iodine.is_worker` which gave an incorrect answer due to a copy & paste error. Credit to Patrik Rak (@raxoft) for opening PR #133.
+
+#### Change log v.0.7.51 (2022-12-03)
+
+**Fix**: Fixes CPU spin error caused by an uncaught integer overflow. Credit to Alexander Pavlenko (@AlexanderPavlenko) for opening issue #132.
+
+#### Change log v.0.7.50 (2022-10-29)
 
 **Fix**: Fixes some compatibility issues with Rack 3.0. Credit to @taku0 for opening issue #131.
 

data/ext/iodine/fio.c

@@ -3198,18 +3198,26 @@ static intptr_t fio_unix_socket(const char *address, uint8_t server) {
   }
   if (server) {
     unlink(addr.sun_path);
-    if (bind(fd, (struct sockaddr *)&addr, sizeof(addr)) == -1) {
-      // perror("couldn't bind unix socket");
+#ifndef FIO_SOCK_AVOID_UMASK
+    int org_umask = umask(0x1FF);
+    int btmp = bind(fd, (struct sockaddr *)&addr, sizeof(addr));
+    umask(org_umask);
+#else
+    int btmp = bind(fd, (struct sockaddr *)&addr, sizeof(addr));
+#endif
+    if (btmp == -1) {
+      // perror("couldn't bind unix socket");    
       close(fd);
       return -1;
     }
+    /* chmod for foreign connections... if possible */
+    if(chmod(addr.sun_path, 0x1FF))
+      FIO_LOG_WARNING("chmod failed for %s (%d: %s)", address, errno, strerror(errno));
     if (listen(fd, SOMAXCONN) < 0) {
       // perror("couldn't start listening to unix socket");
       close(fd);
       return -1;
     }
-    /* chmod for foreign connections */
-    fchmod(fd, 0777);
   } else {
     if (connect(fd, (struct sockaddr *)&addr, sizeof(addr)) == -1 &&
         errno != EINPROGRESS) {
@@ -6736,11 +6744,11 @@ static void fio_cluster_init(void) {
     if (cluster_data.name[tmp_folder_len - 1] != '/')
       cluster_data.name[tmp_folder_len++] = '/';
   }
-  memcpy(cluster_data.name + tmp_folder_len, "facil-io-sock-", 14);
-  tmp_folder_len += 14;
+  memcpy(cluster_data.name + tmp_folder_len, "fio-usock-", 10);
+  tmp_folder_len += 10;
   tmp_folder_len +=
       snprintf(cluster_data.name + tmp_folder_len,
-               FIO_CLUSTER_NAME_LIMIT - tmp_folder_len, "%d", (int)getpid());
+               FIO_CLUSTER_NAME_LIMIT - tmp_folder_len, "%08x", (int)getpid() + (int)(fio_rand64() & 0xAFFFFFFF));
   cluster_data.name[tmp_folder_len] = 0;
 
   /* remove if existing */

data/ext/iodine/iodine.c

@@ -312,7 +312,7 @@ static VALUE iodine_master_is(VALUE self) {
  * a single process mode (the master is also a worker), `false` otherwise.
  */
 static VALUE iodine_worker_is(VALUE self) {
-  return fio_is_master() ? Qtrue : Qfalse;
+  return fio_is_worker() ? Qtrue : Qfalse;
 }
 
 /**

data/ext/iodine/iodine_connection.c

@@ -497,6 +497,7 @@ Ruby Connection Methods - Pub/Sub
 ***************************************************************************** */
 
 typedef struct {
+  VALUE channel_org;
   VALUE channel;
   VALUE block;
   fio_match_fn pattern;
@@ -506,7 +507,7 @@ typedef struct {
 /** Tests the `subscribe` Ruby arguments */
 static iodine_sub_args_s iodine_subscribe_args(int argc, VALUE *argv) {
 
-  iodine_sub_args_s ret = {.channel = Qnil, .block = Qnil};
+  iodine_sub_args_s ret = {.channel_org = Qnil, .channel = Qnil, .block = Qnil};
   VALUE rb_opt = 0;
 
   switch (argc) {
@@ -534,7 +535,7 @@ static iodine_sub_args_s iodine_subscribe_args(int argc, VALUE *argv) {
     rb_raise(rb_eArgError, "method accepts 1 or 2 arguments.");
     return ret;
   }
-
+  ret.channel_org = ret.channel;
   if (ret.channel == Qnil || ret.channel == Qfalse) {
     rb_raise(rb_eArgError,
              "a target (:to) subject / stream / channel is required.");
@@ -652,7 +653,7 @@ static VALUE iodine_pubsub_subscribe(int argc, VALUE *argv, VALUE self) {
     iodine_sub_add(&sub_global, sub);
     fio_unlock(&sub_lock);
   }
-  return args.channel;
+  return args.channel_org;
 }
 
 // clang-format off
@@ -682,6 +683,9 @@ static VALUE iodine_pubsub_unsubscribe(VALUE self, VALUE name) {
     s_lock = &c->lock;
     subs = &c->subscriptions;
   }
+  if (TYPE(name) == T_SYMBOL)
+    name = rb_sym2str(name);
+  Check_Type(name, T_STRING);
   fio_lock(s_lock);
   ret = iodine_sub_unsubscribe(subs, IODINE_RSTRINFO(name));
   fio_unlock(s_lock);

data/lib/iodine/version.rb

@@ -1,3 +1,3 @@
 module Iodine
-  VERSION = '0.7.51'.freeze
+  VERSION = '0.7.53'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: iodine
 version: !ruby/object:Gem::Version
-  version: 0.7.51
+  version: 0.7.53
 platform: ruby
 authors:
 - Boaz Segev
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-12-03 00:00:00.000000000 Z
+date: 2023-01-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -246,7 +246,7 @@ licenses:
 metadata:
   allowed_push_host: https://rubygems.org
 post_install_message: |-
-  Thank you for installing Iodine 0.7.51.
+  Thank you for installing Iodine 0.7.53.
   Remember: if iodine supports your business, it's only fair to give value back (code contributions / donations).
 rdoc_options: []
 require_paths: