iodine 0.6.3 → 0.6.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2f20b276e0e954dffafad0952b0bc11d306dc521b83ffe31fada885e1218c7b4
-  data.tar.gz: 1c6bd56184c5f53a0b25e5cbe1863098063887a5bc158477ce4028e441a6e19b
+  metadata.gz: e70dc6f1a44784807a2fe31522003936cd257a324b44d933407c55d64e429721
+  data.tar.gz: cf01d140817c1ceba340047d77e22fbd7e833545360c36810e930105d5788ec2
 SHA512:
-  metadata.gz: 3c88074a686c61146cb6d6aabbbf293c978b5b37bb031daf69aa6ac597922655a49f7f3bfb0750ff59041b5129e8206ded38bd20caa3af411150cfd102777eb5
-  data.tar.gz: 5cc6299db78e362b668b7eaa9f481fd7d76bd5efdbb4e4ad0f232f5c882589e2e9897d5881f05185ef399e09b6cf3add7fca960a9c8186283224b9757fb664d7
+  metadata.gz: 10b65f02f7aab503d6bad1f5c8f5bcb16347a50a41c069e89059006373fbb9f7a74b9af1ce312c3c5be6a08c2bdb6a6b12da4b52a64c1a90488ad9261c464454
+  data.tar.gz: 72600bd45820eec9145d15cae4a5c7a9db9319116d85ec9e00506a8edf52fb66df95d0e1bbca4dd3afac18dd7dd1e70ba3b7bb707661f0168efec4312491c6ba

data/CHANGELOG.md

@@ -6,7 +6,11 @@ Please notice that this change log contains changes for upcoming releases as wel
 
 ## Changes:
 
-#### Change log v.0.6.2
+#### Change log v.0.6.4
+
+**Fix**: (HTTP/WebSockets) fixed an issue where negative status return values (such as ActionCable's `-1` status code) could cause iodine to assume an abnormal error and shut down the connection. Credit to @mdesantis (Maurizio De Santis) for opening issue #38.
+
+#### Change log v.0.6.3
 
 **Fix**: (WebSockets) fixed an issue where WebSocket message events would attempt to create a String object outside the GVL.
 

data/bin/test_with_faye

@@ -13,7 +13,7 @@ $LOAD_PATH.unshift File.expand_path(File.join('..', '..', 'lib'), __FILE__)
 require 'bundler/setup'
 require 'iodine'
 
-Iodine::Rack.app = lambda do |env|
+APP = lambda do |env|
   if Faye::WebSocket.websocket?(env)
     ws = Faye::WebSocket.new(env)
 
@@ -27,14 +27,18 @@ Iodine::Rack.app = lambda do |env|
     end
 
     # Return async Rack response
-    return ws.rack_response
-
+    response = ws.rack_response
+    p response
+    response
   else
     # Normal HTTP request
     [200, { 'Content-Type' => 'text/plain' }, ["Hello\n"]]
   end
 end
 
+Iodine.listen2http app: APP
+
+Iodine.threads = 4
 Iodine.start
 
 # ws = new WebSocket("ws://localhost:3000"); ws.onmessage = function(e) {console.log("Got message!"); console.log(e.data);}; ws.onclose = function(e) {console.log("closed")}; ws.onopen = function(e) {ws.send("hi");};

data/ext/iodine/iodine_http.c

@@ -683,7 +683,8 @@ static inline void *iodine_handle_request_in_GVL(void *handle_) {
   // review each header and write it to the response.
   rb_hash_foreach(response_headers, for_each_header_data, (VALUE)(h));
   // review for upgrade.
-  if (h->status < 300 && ruby2c_review_upgrade(handle, rbresponse, env))
+  if ((intptr_t)h->status < 300 &&
+      ruby2c_review_upgrade(handle, rbresponse, env))
     goto external_done;
   // send the request body.
   if (ruby2c_response_send(handle, rbresponse, env))

data/ext/iodine/iodine_store.c

@@ -65,6 +65,9 @@ static void storage_print(void) {
   spn_unlock(&lock);
 }
 
+/**
+ * Used for debugging purposes (when testing iodine for Ruby object "leaks").
+ */
 static VALUE storage_print_rb(VALUE self) {
   storage_print();
   return Qnil;

data/lib/iodine/connection.rb

@@ -26,6 +26,8 @@ module Iodine
   #       def on_drained client
   #          client.is_a?(Iodine::Connection) # => true
   #       end
+  #       # Allows the module to be used as a static callback object (avoiding object allocation)
+  #       extend self
   #     end
   #
   # All connection related actions can be performed using the methods provided through this class.

data/lib/iodine/version.rb

@@ -1,3 +1,3 @@
 module Iodine
-  VERSION = '0.6.3'.freeze
+  VERSION = '0.6.4'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: iodine
 version: !ruby/object:Gem::Version
-  version: 0.6.3
+  version: 0.6.4
 platform: ruby
 authors:
 - Boaz Segev
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-06-25 00:00:00.000000000 Z
+date: 2018-06-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack