iodine 0.6.2 → 0.6.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 18f2abd143126a74b278a1d082c1d177d383d0de0eec4252e3c78e94e862c9d1
-  data.tar.gz: 046fdb7171a8382d3376802514606c42dbd29f73ac6fbb224b2d87a52247dd3e
+  metadata.gz: 2f20b276e0e954dffafad0952b0bc11d306dc521b83ffe31fada885e1218c7b4
+  data.tar.gz: 1c6bd56184c5f53a0b25e5cbe1863098063887a5bc158477ce4028e441a6e19b
 SHA512:
-  metadata.gz: 00f6ac2019eb8a83579841e30aae3b8ab65fc1af0872542fa4f94c19feea16426d8f8de30e534ea88c06770a5abe9f2e73ccb244cb5cb2abf543efee55abf2f3
-  data.tar.gz: f494e6437a123bfef773214e6ff4a61da9ded0ea396209610d05c8d8e00d437cd17fcca1822e47bf8df3d937b2b7c4fddc6b75f4d149f77837a9c4f4d3e5a9ee
+  metadata.gz: 3c88074a686c61146cb6d6aabbbf293c978b5b37bb031daf69aa6ac597922655a49f7f3bfb0750ff59041b5129e8206ded38bd20caa3af411150cfd102777eb5
+  data.tar.gz: 5cc6299db78e362b668b7eaa9f481fd7d76bd5efdbb4e4ad0f232f5c882589e2e9897d5881f05185ef399e09b6cf3add7fca960a9c8186283224b9757fb664d7

data/CHANGELOG.md

@@ -8,6 +8,12 @@ Please notice that this change log contains changes for upcoming releases as wel
 
 #### Change log v.0.6.2
 
+**Fix**: (WebSockets) fixed an issue where WebSocket message events would attempt to create a String object outside the GVL.
+
+**Fix**: (`Iodine::Connection`) minor updated to the documentation and memory validation system.
+
+#### Change log v.0.6.2
+
 **Fix**: (`Iodine::PubSub`) fixed an issue where lazy initialization would cause the shutdown process to crash if no Pub/Sub engines were ever registered (fixes an attempt to seek within an uninitialized data structure). Credit to @sj26 (Samuel Cochran) for reporting the issue.
 
 #### Change log v.0.6.1

data/ext/iodine/iodine_connection.c

@@ -100,14 +100,17 @@ typedef struct {
 /* a callback for the GC (marking active objects) */
 static void iodine_connection_data_mark(void *c_) {
   iodine_connection_data_s *c = c_;
-  if (c->info.handler != Qnil) {
+  if (!c) {
+    return;
+  }
+  if (c->info.handler && c->info.handler != Qnil) {
     rb_gc_mark(c->info.handler);
   }
   if (c->info.env && c->info.env != Qnil) {
     rb_gc_mark(c->info.env);
   }
 }
-/* a callback for the GC (marking active objects) */
+/* a callback for the GC (freeing inactive objects) */
 static void iodine_connection_data_free(void *c_) {
   iodine_connection_data_s *data = c_;
   if (spn_sub(&data->ref, 1))
@@ -129,7 +132,7 @@ const rb_data_type_t iodine_connection_data_type = {
             .dsize = iodine_connection_data_size,
         },
     .data = NULL,
-    .flags = RUBY_TYPED_FREE_IMMEDIATELY,
+    // .flags = RUBY_TYPED_FREE_IMMEDIATELY,
 };
 
 /* Iodine::PubSub::Engine.allocate */
@@ -177,7 +180,9 @@ Ruby Connection Methods - write, close open? pending
 static VALUE iodine_connection_write(VALUE self, VALUE data) {
   iodine_connection_data_s *c = iodine_connection_validate_data(self);
   if (!c || sock_isclosed(c->info.uuid)) {
-    rb_raise(rb_eIOError, "Connection closed or invalid.");
+    // don't throw exceptions - closed connections are unavoidable.
+    return Qnil;
+    // rb_raise(rb_eIOError, "Connection closed or invalid.");
   }
   switch (c->info.type) {
   case IODINE_CONNECTION_WEBSOCKET:
@@ -231,7 +236,7 @@ static VALUE iodine_connection_close(VALUE self) {
   iodine_connection_data_s *c = iodine_connection_validate_data(self);
   if (c && !sock_isclosed(c->info.uuid)) {
     if (c->info.type == IODINE_CONNECTION_WEBSOCKET) {
-      websocket_close(c->info.arg);
+      websocket_close(c->info.arg); /* sends WebSocket close packet */
     } else {
       sock_close(c->info.uuid);
     }
@@ -250,6 +255,9 @@ static VALUE iodine_connection_is_open(VALUE self) {
 /**
  * Returns the number of pending `write` operations that need to complete
  * before the next `on_drained` callback is called.
+ *
+ * Returns -1 if the connection is closed and 0 if `on_drained` won't be
+ * scheduled (no pending `write`).
  */
 static VALUE iodine_connection_pending(VALUE self) {
   iodine_connection_data_s *c = iodine_connection_validate_data(self);

data/ext/iodine/iodine_connection.h

@@ -12,7 +12,7 @@ typedef enum {
 typedef struct {
   iodine_connection_type_e type;
   intptr_t uuid;
-  void *arg;
+  void *arg; /* holds the connection pointer (ws_s / sse_s) */
   VALUE handler;
   VALUE env;
 } iodine_connection_s;

data/ext/iodine/iodine_http.c

@@ -139,7 +139,7 @@ static void iodine_ws_on_message(ws_s *ws, char *data, size_t size,
       .is_text = is_text,
       .io = (VALUE)websocket_udata(ws),
   };
-  IodineCaller.leaveGVL(iodine_ws_fire_message, &msg);
+  IodineCaller.enterGVL(iodine_ws_fire_message, &msg);
 }
 /**
  * The (optional) on_open callback will be called once the websocket

data/ext/iodine/iodine_pubsub.c

@@ -242,7 +242,7 @@ const rb_data_type_t iodine_pubsub_data_type = {
             .dsize = iodine_pubsub_data_size,
         },
     .data = NULL,
-    .flags = RUBY_TYPED_FREE_IMMEDIATELY,
+    // .flags = RUBY_TYPED_FREE_IMMEDIATELY,
 };
 
 /* Iodine::PubSub::Engine.allocate */

data/lib/iodine/version.rb

@@ -1,3 +1,3 @@
 module Iodine
-  VERSION = '0.6.2'.freeze
+  VERSION = '0.6.3'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: iodine
 version: !ruby/object:Gem::Version
-  version: 0.6.2
+  version: 0.6.3
 platform: ruby
 authors:
 - Boaz Segev
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-05-30 00:00:00.000000000 Z
+date: 2018-06-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack
@@ -281,7 +281,7 @@ requirements:
 - Ruby >= 2.2.2 required for Rack 2.
 - Ruby >= 2.4.0 recommended.
 rubyforge_project: 
-rubygems_version: 2.7.3
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: iodine - a fast HTTP / Websocket Server with Pub/Sub support, optimized for