iodine 0.4.12 → 0.4.14

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: aca722c23efafe6e1253f5ab4f9cea5157ded7eb
-  data.tar.gz: 3cd0891b931b59d0474a8dc0f4acdb67a1775923
+  metadata.gz: 8110abd50ee8b728afb0b0bba32010636acae150
+  data.tar.gz: ccc3e4a8e25014e15bae41aadc343aa04c596586
 SHA512:
-  metadata.gz: fe7c754d170ec52fe96b77bcd2b18a79586e5d3cd6db4bff5f3ba834e32060b470fb3c5fce9799a9868af7cb832143d396ccc1216691f0a3a17887b06124b72a
-  data.tar.gz: '09be0eccb8cf2a065be75bb2ae96c4e4cc9ea79fc29a7864d122d59aa743ec709551fd345dbb6a79f0910685fc061edc8dee1e1c33649cd2992e931e0654eef4'
+  metadata.gz: 73e41e508c1b66928402ff515890394ddf36b62bbc11c309d924306310ed72ff67d3c0e0f0562f97ee22b235a71a91d32ff2a46e2c7e839ec4f60b2f2a1431b4
+  data.tar.gz: 34415df07c8f045a4f287334e012d9678bb1ad44e8355872183ee06df01e0fcbd7a5c17bba5f8648fbf0bf86762f2c6cc67cd7b3fbe060a4318d0679f6f87a30

data/CHANGELOG.md

@@ -6,6 +6,14 @@ Please notice that this change log contains changes for upcoming releases as wel
 
 ## Changes:
 
+#### Next
+
+**Fix**: (`facil.io`) fixes an issue where timer monitoring would report failure when the timer exists and is being monitored.
+
+#### Change log v.0.4.12
+
+**Fix**: (`facil.io`) fixes some lingering issues with the new Websocket parser, namely an issue where certain network packet lengths would cause the parser to fail. Credit to Tom Lahti (@uidzip) for exposing the issue.
+
 #### Change log v.0.4.11
 
 **Fix**: (`iodine`) use Ruby `fork` instead of system `fork`, allowing Ruby hooks to run before and after forking. This also fixes an issue where the Ruby timer thread isn't (re)initialized.

data/ext/iodine/evio.c

@@ -94,8 +94,7 @@ Adds a file descriptor to the polling object.
 int evio_add(int fd, void *callback_arg) {
   struct epoll_event chevent = {0};
   chevent.data.ptr = (void *)callback_arg;
-  chevent.events =
-      EPOLLOUT | EPOLLIN | EPOLLET | EPOLLERR | EPOLLRDHUP | EPOLLHUP;
+  chevent.events = EPOLLOUT | EPOLLIN | EPOLLET | EPOLLRDHUP | EPOLLHUP;
   return epoll_ctl(evio_fd, EPOLL_CTL_ADD, fd, &chevent);
 }
 
@@ -135,8 +134,7 @@ Adds a timer file descriptor, so that callbacks will be called for it's events.
 intptr_t evio_add_timer(int fd, void *callback_arg,
                         unsigned long milliseconds) {
   struct epoll_event chevent = {.data.ptr = (void *)callback_arg,
-                                .events = (EPOLLOUT | EPOLLIN | EPOLLET |
-                                           EPOLLERR | EPOLLRDHUP | EPOLLHUP)};
+                                .events = (EPOLLIN | EPOLLET)};
   struct itimerspec new_t_data;
   new_t_data.it_value.tv_sec = new_t_data.it_interval.tv_sec =
       milliseconds / 1000;
@@ -144,7 +142,10 @@ intptr_t evio_add_timer(int fd, void *callback_arg,
       (milliseconds % 1000) * 1000000;
   if (timerfd_settime(fd, 0, &new_t_data, NULL) == -1)
     return -1;
-  return epoll_ctl(evio_fd, EPOLL_CTL_ADD, fd, &chevent);
+  int ret = epoll_ctl(evio_fd, EPOLL_CTL_ADD, fd, &chevent);
+  if (ret == -1 && errno == EEXIST)
+    return 0;
+  return ret;
 }
 
 /** Rearms the timer. Required only by `epoll`.*/

data/ext/iodine/facil.c

@@ -641,17 +641,25 @@ int facil_run_every(size_t milliseconds, size_t repetitions,
   if (protocol == NULL)
     goto error;
   facil_attach(uuid, (protocol_s *)protocol);
-  if (evio_isactive() && evio_add_timer(fd, (void *)uuid, milliseconds) < 0)
+  if (evio_isactive() && evio_add_timer(fd, (void *)uuid, milliseconds) == -1)
     goto error;
   return 0;
 error:
-  if (uuid != -1)
+  if (uuid != -1) {
+    const int old = errno;
     sock_close(uuid);
-  else if (fd != -1)
+    errno = old;
+  } else if (fd != -1) {
+    const int old = errno;
     close(fd);
+    errno = old;
+  }
 error_fin:
-  if (on_finish)
+  if (on_finish) {
+    const int old = errno;
     on_finish(arg);
+    errno = old;
+  }
   return -1;
 }
 

data/ext/iodine/pubsub.h

@@ -189,13 +189,21 @@ struct pubsub_engine_s {
   unsigned push2cluster : 1;
 };
 
-/** The default pub/sub engine. */
+/** The default pub/sub engine.
+ * This engine performs pub/sub within a group of processes (process cluster).
+ *
+ * The process cluser is initialized by the `facil_run` command with `processes`
+ * set to more than 1.
+ */
 extern const pubsub_engine_s *PUBSUB_CLUSTER_ENGINE;
 
 /** An engine that performs pub/sub only within a single process. */
 extern const pubsub_engine_s *PUBSUB_PROCESS_ENGINE;
 
-/** Allows process wide changes to the default Pub/Sub Engine. */
+/** Allows process wide changes to the default Pub/Sub Engine.
+ * Setting a new default before calling `facil_run` will change the default for
+ * the whole process cluster.
+ */
 extern const pubsub_engine_s *PUBSUB_DEFAULT_ENGINE;
 
 /**

data/lib/iodine/version.rb

@@ -1,3 +1,3 @@
 module Iodine
-  VERSION = '0.4.12'.freeze
+  VERSION = '0.4.14'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: iodine
 version: !ruby/object:Gem::Version
-  version: 0.4.12
+  version: 0.4.14
 platform: ruby
 authors:
 - Boaz Segev
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-10-24 00:00:00.000000000 Z
+date: 2017-10-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack