invoicing_payments_processing 1.1.60 → 1.1.65

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: aa3e73d17b05d75e69025d7364460ee6045a46cb
-  data.tar.gz: 2579bdc5324a9288e41fa92c9f2f84048f0c27f2
+  metadata.gz: a6c823ecb08c6b06064463c50e00f8a392d31db4
+  data.tar.gz: 019aad76d9430a5e5ca28a960de182dd03956e3a
 SHA512:
-  metadata.gz: e3138f3c9a4721c504eba4376923717cf50af2382204020150d10fc480c3a6e536e6c09d7d56457d999aac9bcecf4b42388f2b686d91b5eb502291a4cbfed494
-  data.tar.gz: e3ef838af52b803608c1349a3e31b682afefb846716570e7fe38ee8070f73f96aaeecbf665b7b8d8641ae405b41859d60ccd43d1624c585ed5d2f6baa50e9074
+  metadata.gz: c82e69dc914a4ccf5a84dcaa55ebedb065aef47405bb99b83c9546f6ced35d95b12fe88c0efc608a49c4c721225555282952baa2126b0a1d55df47b912bcfafa
+  data.tar.gz: ec65bbcc0118e99f08299bea1e71b3a663bbd91068a02c2cd14b87db5e91c7ae6de0db5ce9fe7b4dfcbf45c0265dc916ee27958601126ad031623d499035a94b

data/lib/balance.rb

@@ -16,7 +16,7 @@ module BlackStack
         "from movement with (nolock) " +
         "where id_client='#{self.client.id}' " +
         "and product_code='#{self.product_code}' " +
-  			"and create_time < '#{self.up_time.to_time.to_sql}' "
+  			"and create_time <= '#{self.up_time.to_time.to_sql}' "
       else
         q = 
         "select cast(sum(cast(amount as numeric(18,12))) as numeric(18,6)) as amount, sum(credits) as credits " +
@@ -24,7 +24,7 @@ module BlackStack
         "where x.id_client='#{self.client.id}' " +
         "and x.product_code='#{self.product_code}' "
       end
-      
+#puts "Balance.calculate:q:#{q}:."
       row = DB[q].first
       self.amount = row[:amount].to_f
       self.credits = row[:credits].to_f

data/lib/extend_client_by_invoicing_payments_processing.rb

@@ -6,7 +6,30 @@ module BlackStack
     class Client < Sequel::Model(:client)
       one_to_many :paypal_subscriptions, :class=>:'BlackStack::PayPalSubscription', :key=>:id_client
       one_to_many :customplans, :class=>:'BlackStack::CustomPlan', :key=>:id_client
-      one_to_many :movements, :class=>:'BlackStack::Movement', :key=>:id_client
+
+      # This method replace the line:
+      # one_to_many :movements, :class=>:'BlackStack::Movement', :key=>:id_client
+      # 
+      # Because when you have a large number of records in the table movement, for a client, 
+      # then the call to this attribute client.movements can take too much time and generates
+      # a query timeout exception.
+      # 
+      # The call to this method may take too much time, but ti won't raise a query timeout.
+      # 
+      def movements
+        i = 0 
+        ret = []
+        BlackStack::Movement.where(:id_client=>self.id).each { |o| 
+          ret << o
+          i += 1
+          if i == 1000
+            i = 0
+            GC.start
+            DB.disconnect
+          end
+        }
+        ret
+      end
 
       # how many minutes ago should have updated the table stat_balance with the amount and credits of this client, for each product.
       def stat_balance_delay_minutes
@@ -51,7 +74,9 @@ module BlackStack
       end
 
       # crea/actualiza un registro en la tabla movment, reduciendo la cantidad de creditos y saldo que tiene el cliente, para el producto indicado en product_code. 
-      def consume(product_code, number_of_credits=1, description=nil)
+      def consume(product_code, number_of_credits=1, description=nil, datetime=nil)
+				dt = datetime.nil? ? now() : datetime.to_time.to_sql
+				
 				# create the consumtion
 				total_credits = 0.to_f - BlackStack::Balance.new(self.id, product_code).credits.to_f
 				total_amount = 0.to_f - BlackStack::Balance.new(self.id, product_code).amount.to_f
@@ -60,7 +85,7 @@ module BlackStack
 				cons = BlackStack::Movement.new
 				cons.id = guid()
 				cons.id_client = self.id
-				cons.create_time = now()
+				cons.create_time = dt
 				cons.type = BlackStack::Movement::MOVEMENT_TYPE_CANCELATION
 				cons.description = description.nil? ? 'Consumption' : description
 				cons.paypal1_amount = 0
@@ -135,7 +160,7 @@ module BlackStack
 				credits_paid = 0
 
 				#total_credits = 0.to_f - BlackStack::Balance.new(self.id, product_code).credits.to_f
-				#total_amount = 0.to_f - BlackStack::Balance.new(self.id, product_code).amount.to_f
+				#total_amount = 0.to_f - BlackStack::Balance.new(self.id, product_code).amount.to_f        
 
 				self.movements.select { |o| 
 					o.product_code.upcase == product_code.upcase

data/lib/movement.rb

@@ -121,28 +121,68 @@ module BlackStack
 
 		# Returns the number of credits assigned in the movement that have been consumed.
 		# The movment must be a payment or a bonus
-		def credits_consumed()
+		#
+		# registraton_time: consider only movements before this time. If it is nil, this method will consider all the movements.
+		# 
+		def credits_consumed(registraton_time=nil)
+      # le agrego 365 dias a la fecha actual, para abarcar todas las fechas ocurridas hasta hoy seguro
+      if registraton_time.nil?
+        registraton_time = (Time.now() + 365*24*60*60)
+      else
+        registraton_time = registraton_time.to_time if registraton_time.class != Time
+      end
+			# move time to the first second of the next day.
+			# example: '2020-11-12 15:49:43 -0300' will be converted to '2020-11-13 00:00:00 -0300'
+			registraton_time = (Date.strptime(registraton_time.strftime("%Y-%m-%d"), "%Y-%m-%d").to_time + 24*60*60)			
 			# the movment must be a payment or a bonus
 			raise 'Movement must be either a payment or a bonus' if self.type != MOVEMENT_TYPE_ADD_PAYMENT && self.type != MOVEMENT_TYPE_ADD_BONUS
 #puts
 #puts "product_code:#{self.product_code}:."
+
 			# itero los pagos y bonos hechos por este mismo producto, desde el primer dia hasta este movimiento.
+=begin
 			paid = 0
 			self.client.movements.select { |o| 
 				(o.type == MOVEMENT_TYPE_ADD_PAYMENT || o.type == MOVEMENT_TYPE_ADD_BONUS) &&
         o.credits.to_f < 0 &&
-        o.product_code.upcase == self.product_code.upcase
+        o.product_code.upcase == self.product_code.upcase &&
+        o.create_time.to_time < registraton_time.to_time
       }.sort_by { |o| o.create_time }.each { |o|
 				paid += (0.to_f - o.credits.to_f)
 				break if o.id.to_guid == self.id.to_guid
 			}
+=end
+      paid = 0 - DB[
+        "select ISNULL(SUM(ISNULL(m.credits,0)),0) AS n " +
+        "from movement m with (nolock) " +
+        "where isnull(m.type, #{BlackStack::Movement::MOVEMENT_TYPE_ADD_PAYMENT.to_s}) in (#{BlackStack::Movement::MOVEMENT_TYPE_ADD_PAYMENT.to_s}, #{BlackStack::Movement::MOVEMENT_TYPE_ADD_BONUS.to_s}) " +
+        "and m.id_client='#{self.client.id.to_guid}' " +
+        "and isnull(m.credits,0) < 0 " +
+        "and upper(isnull(m.product_code, '')) = '#{self.product_code.upcase}' " +
+        "and m.create_time < '#{registraton_time.to_time.strftime('%Y-%m-%d')}' " +
+        "and m.id <> '#{self.id.to_guid}' "
+      ].first[:n]
 #puts "paid:#{paid.to_s}:."
+
+=begin
       # calculo los credito para este producto, desde el primer dia; incluyendo cosumo, expiraciones, ajustes.
       consumed = self.client.movements.select { |o| 
         o.credits.to_f > 0 &&
-        o.product_code.upcase == self.product_code.upcase
+        o.product_code.upcase == self.product_code.upcase &&
+        o.create_time.to_time < registraton_time.to_time
       }.inject(0) { |sum, o| sum.to_f + o.credits.to_f }.to_f
-#puts "consumed:#{consumed.to_s}:."			
+=end
+      consumed = DB[
+        "select ISNULL(SUM(ISNULL(m.credits,0)),0) AS n " +
+        "from movement m with (nolock) " +
+        "where m.id_client='#{self.client.id.to_guid}' " +
+        "and isnull(m.credits,0) > 0 " +
+        "and upper(isnull(m.product_code, '')) = '#{self.product_code.upcase}' " +
+        "and m.create_time < '#{registraton_time.to_time.strftime('%Y-%m-%d')}' " +
+        "and m.id <> '#{self.id.to_guid}' "
+      ].first[:n]
+#puts "consumed:#{consumed.to_s}:."     
+
       # calculo los creditos de este movimiento que voy a cancelar
       credits = 0.to_f - self.credits.to_f
 #puts "credits:#{credits.to_s}:."
@@ -184,7 +224,10 @@ module BlackStack
 
 		# credits expiration
 		def expire(registraton_time=nil, desc='Expiration Because Allocation is Renewed')
-			credits_consumed = self.credits_consumed
+#puts
+#puts "registraton_time:#{registraton_time.to_s}:."
+			credits_consumed = self.credits_consumed(registraton_time)
+#puts "credits_consumed:#{credits_consumed.to_s}:."
 			# 
 			self.expiration_start_time = now()
 			self.expiration_tries = self.expiration_tries.to_i + 1
@@ -192,6 +235,8 @@ module BlackStack
 			# 
 			balance = BlackStack::Balance.new(self.client.id, self.product_code, registraton_time)
 			balance.calculate(false)
+#puts "balance.credits.to_s:#{balance.credits.to_s}:."
+#puts "balance.amount.to_s:#{balance.amount.to_s}:."
 			total_credits = 0.to_f - balance.credits.to_f
 			total_amount = 0.to_f - balance.amount.to_f
 			#
@@ -199,6 +244,8 @@ module BlackStack
 			#
 			credits_to_expire = credits - credits_consumed.to_i #- (0.to_f - self.credits.to_f)).to_i
 			amount_to_expire = total_credits.to_f == 0 ? 0 : credits_to_expire.to_f * ( total_amount.to_f / total_credits.to_f )
+#puts "credits_to_expire.to_s:#{credits_to_expire.to_s}:."
+#puts "amount_to_expire.to_s:#{amount_to_expire.to_s}:."
 			#
 			exp = BlackStack::Movement.new
 			exp.id = guid()

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: invoicing_payments_processing
 version: !ruby/object:Gem::Version
-  version: 1.1.60
+  version: 1.1.65
 platform: ruby
 authors:
 - Leandro Daniel Sardi
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-11-11 00:00:00.000000000 Z
+date: 2020-11-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: websocket