invoicing_payments_processing 1.1.47 → 1.1.52

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f3f824917a87ee4d35bcc8033c4cf6697d9aaef5
-  data.tar.gz: d07e483979caf36ea1b09a7c947dbd56eca8f8be
+  metadata.gz: a041204eaed01ab7a77e725d80a2097b8483304c
+  data.tar.gz: 8fb9df52feccc39824f57a4275541f8d40fe300f
 SHA512:
-  metadata.gz: aca60368b308f9f06cc8b5ca4e72f257db428b709652f8112cc404a07609b7bb07e704ce02caf66b1ba29659dab19616d32e80648338d0ffa45e85400ace6777
-  data.tar.gz: 7a281e9f26c5111adae3c82ed3424a82e2d6b8287e409ec1d2809fadb219ab58c2d888eaf0ef7925595f4167e2c283a43c8f25255986dc82ae9348c0bcbf4f46
+  metadata.gz: 429e8b18fcea87ba90503ce9080cce97dc26e9814ea3302fdf4aa20d5f1aa2a5839f76b20178d3e876ce2d40e994adba1f8a5b636a3bb088514d7149258a28f6
+  data.tar.gz: 2b1f92d1d307dba79c5db11f15a78fc99c1e457bba6b32d2fcb86db569ff20c6d5aae493753d027897b2a8babd1cf70dfa2e9178feccb89962cfb094e1f10c33

data/lib/bufferpaypalnotification.rb

@@ -41,6 +41,10 @@ module BlackStack
     # 3) haciendo coincidir el campo payer_email de alguna suscripcion existente con el BlackStack::BufferPayPalNotification.payer_email
     # 3) haciendo coincidir el primer guid en el codigo de invoice, con el id del cliente
     def get_client()
+puts
+puts "BlackStack::BufferPayPalNotification::get_client"
+puts 'debug info:'
+puts "self.invoice:#{self.invoice.to_s}:."
       # obtengo el cliente que machea con este perfil
       c = nil
       if c.nil?
@@ -49,12 +53,24 @@ module BlackStack
           c = i.client if !i.nil? 
         end
       end
+      if c.nil?
+        iid = self.invoice.split(".").last.to_s
+        if iid.guid?
+          i = BlackStack::Invoice.where(:id=>iid).first
+          c = i.client if !i.nil? 
+        end
+      end
       if c.nil?
         cid = self.invoice.split(".").first.to_s
         if cid.guid?
           c = BlackStack::Client.where(:id=>cid).first
         end
       end
+=begin
+# deprecated: debe obtenerse la factura (invoice), y de ahi el cliente,
+# => porque un mismo cuente puede usar su cuenta paypal en varias cuantas 
+# => de usuario.
+#  
       if c.nil?
         c = BlackStack::Client.where(:paypal_email=>self.payer_email).first
         if (c == nil)
@@ -83,6 +99,7 @@ module BlackStack
           c = BlackStack::Client.where(:id=>row[:cid]).first
         end
       end
+=end
       c
     end
   
@@ -316,10 +333,12 @@ module BlackStack
           j.next(i)
           
           # creo el milestone con todo el credito pendiente que tiene esta subscripcion
+=begin
+# deprecated  
           buff_payment = i.buffer_paypal_notification
           buff_signup = BlackStack::BufferPayPalNotification.where(:txn_type=>"subscr_signup", :subscr_id=>buff_payment.subscr_id).first
           subs = buff_signup == nil ? nil : BlackStack::PayPalSubscription.where(:id_buffer_paypal_notification => buff_signup.id).first
-              
+=end
         elsif (b.txn_type == BlackStack::BufferPayPalNotification::TXN_TYPE_SUBSCRIPTION_SIGNUP)
           # crear un registro en la tabla paypal_subscriptions
           if BlackStack::PayPalSubscription.load(b.to_hash) != nil
@@ -336,7 +355,7 @@ module BlackStack
             s.save
             
             # obtengo la factura que se creo con esta suscripcion
-            i = BlackStack::Invoice.where(:id=>b.item_number).first
+            i = BlackStack::Invoice.where(:id=>b.invoice.split(".").last.to_s).first
             
             # vinculo esta suscripcion a la factura que la genero, y a todas las facturas siguientes
             i.set_subscription(s)
@@ -384,7 +403,7 @@ module BlackStack
               "SELECT TOP 1 i.id " +
               "FROM buffer_paypal_notification b " +
               "JOIN invoice i ON ( b.id=i.id_buffer_paypal_notification AND i.status=#{BlackStack::Invoice::STATUS_PAID.to_s} ) " +
-              "WHERE b.invoice='#{b.invoice}' " +
+              "WHERE b.invoice='#{b.invoice.invoice.split(".").last.to_s}' " +
               "ORDER BY i.create_time DESC "
             ].first
             if row.nil?

data/lib/extend_client_by_invoicing_payments_processing.rb

@@ -35,7 +35,7 @@ module BlackStack
 				total_amount = 0.to_f - BlackStack::Balance.new(self.id, product_code).amount.to_f
 				sleep(2) # delay to ensure the time of the bonus movement will be later than the time of the consumption movement
 				if total_credits < 0
-					self.adjustment(product_code, total_amount, total_credits, 'Adjustment Because Quota Has Been Exceeded.')
+					self.adjustment(product_code, total_amount, total_credits, 'Adjustment Because Quota Has Been Exceeded (1).')
 				end
 				# recaculate amounts in both consumptions and expirations - CANCELADO - Se debe hacer offline
 				#self.recalculate(product_code) 
@@ -97,7 +97,7 @@ module BlackStack
 
 				self.movements.select { |o| 
 					o.product_code.upcase == product_code.upcase
-				}.sort_by { |o| o.create_time }.each { |o|
+				}.sort_by { |o| [o.create_time, o.type] }.each { |o| # se ordena por o.create_time, pero tmabien por o.type para procesar primero los pagos y bonos
 					#if o.credits.to_f < 0 # payment or bonus
 #					if o.credits.to_f > 0 && ( o.type==BlackStack::Movement::MOVEMENT_TYPE_CANCELATION || o.type==BlackStack::Movement::MOVEMENT_TYPE_EXPIRATION ) # consumption or expiration
 					# consumption or expiration or bonus
@@ -118,7 +118,7 @@ module BlackStack
 					total_credits = credits_paid
 					total_amount = amount_paid
 					if total_credits < 0
-						self.adjustment(product_code, total_amount, total_credits, 'Adjustment Because Quota Has Been Exceeded.', BlackStack::Movement::MOVEMENT_TYPE_ADJUSTMENT, o.create_time)
+						self. adjustment(product_code, total_amount, total_credits, 'Adjustment Because Quota Has Been Exceeded (2).', BlackStack::Movement::MOVEMENT_TYPE_ADJUSTMENT, o.create_time)
 						amount_paid = 0.to_f
 						credits_paid = 0.to_i
 					end

data/lib/invoice.rb

@@ -328,7 +328,7 @@ module BlackStack
 					# 
 					BlackStack::Movement.where(:id_invoice_item => item.id).all { |mov|
 						# 
-						mov.expire(self.billing_period_from) if mov.expiration_on_next_payment == true
+						mov.expire(self.billing_period_from, "Expiration of <a href='/member/record?rid=#{mov.id.to_guid}'>record:#{mov.id.to_guid}</a> because subscription renewal.") if mov.expiration_on_next_payment == true
 						#
 						DB.disconnect
 						GC.start
@@ -345,7 +345,7 @@ module BlackStack
 				# obtengo descriptor del producto
 				prod = BlackStack::InvoicingPaymentsProcessing.product_descriptor(plan[:product_code])
 				# registro el pago
-        BlackStack::Movement.new().parse(item, BlackStack::Movement::MOVEMENT_TYPE_ADD_PAYMENT, "Invoice Payment", payment_time, item.id).save()
+        BlackStack::Movement.new().parse(item, BlackStack::Movement::MOVEMENT_TYPE_ADD_PAYMENT, "Payment of <a href='/member/invoice?iid=#{self.id.to_guid}'>invoice:#{self.id.to_guid}</a>.", payment_time, item.id).save()
 				# agrego los bonos de este plan
 				if !plan[:bonus_plans].nil?
   				plan[:bonus_plans].each { |h|
@@ -359,7 +359,7 @@ module BlackStack
   					bonus.units = plan_bonus[:credits] * item.number_of_packages # agrego los creditos del bono, multiplicado por la cantiad de paquetes 
   					bonus.amount = 0
   					bonus.item_number = plan_bonus[:item_number]
-  					BlackStack::Movement.new().parse(bonus, BlackStack::Movement::MOVEMENT_TYPE_ADD_BONUS, 'Payment Bonus', payment_time, item.id).save()
+  					BlackStack::Movement.new().parse(bonus, BlackStack::Movement::MOVEMENT_TYPE_ADD_BONUS, "Bonus from the <a href='/member/invoice?iid=#{self.id.to_guid}'>invoice:#{self.id.to_guid}</a>.", payment_time, item.id).save()
   				}
         end # if !plan[:bonus_plans].nil?
         #
@@ -624,21 +624,47 @@ module BlackStack
           item1.detail = u.detail.to_s
           item1.description = u.description.to_s
           item1.save()
-          BlackStack::Movement.new().parse(item1, BlackStack::Movement::MOVEMENT_TYPE_REFUND_BALANCE, 'Full Refund').save()        
-					# si el balance quedo en negativo, entonces aplico otro ajuste
+          # hago el reembolso de este item
+          # si el balance quedo en negativo, entonces aplico otro ajuste
+          BlackStack::Movement.new().parse(item1, BlackStack::Movement::MOVEMENT_TYPE_REFUND_BALANCE, "Full Refund of <a href='/member/invoice?iid=#{self.id.to_guid}'>invoice:#{self.id.to_guid}</a>.").save()        
 					net_amount = 0.to_f - BlackStack::Balance.new(self.client.id, u.product_code.to_s).amount.to_f
 					net_credits = 0.to_f - BlackStack::Balance.new(self.client.id, u.product_code.to_s).credits.to_f
-					if net_amount < 0 && net_credits < 0
-						adjust = self.client.adjustment(u.product_code.to_s, net_amount, net_credits, 'Adjustment for Negative Balance after Refund')
+					if net_amount <= 0 && net_credits < 0
+						adjust = self.client.adjustment(u.product_code.to_s, net_amount, net_credits, "Adjustment for Negative Balance After Refund of <a href='/member/invoice?iid=#{self.id.to_guid}'>invoice:#{self.id.to_guid}</a>.")
 						adjust.id_invoice_item = item1.id
 						adjust.save			
 					end # if net_amount < 0
+          # hago el reembolso de cada bono de este item
+          # si el balance quedo en negativo, entonces aplico otro ajuste
+          h[:bonus_plans].each { |bonus|
+            i = BlackStack::InvoicingPaymentsProcessing::plans_descriptor.select { |obj| obj[:item_number] == bonus[:item_number] }.first
+            j = BlackStack::InvoicingPaymentsProcessing::products_descriptor.select { |obj| obj[:code] == i[:product_code] }.first
+            item2 = BlackStack::InvoiceItem.new()
+            item2.id = guid()
+            item2.id_invoice = self.id
+            item2.unit_price = 0
+            item2.units = -i[:credits]
+            item2.amount = 0
+            item2.product_code = i[:product_code].to_s
+            item2.item_number = i[:item_number].to_s
+            item2.detail = 'Bonus Refund'
+            item2.description = j[:description].to_s
+            item2.save()
+            BlackStack::Movement.new().parse(item2, BlackStack::Movement::MOVEMENT_TYPE_REFUND_BALANCE, "Bonus Refund of <a href='/member/invoice?iid=#{self.id.to_guid}'>invoice:#{self.id.to_guid}</a>.").save()        
+            net_amount = 0.to_f - BlackStack::Balance.new(self.client.id, i[:product_code].to_s).amount.to_f
+            net_credits = 0.to_f - BlackStack::Balance.new(self.client.id, i[:product_code].to_s).credits.to_f
+            if net_amount <= 0 && net_credits < 0
+              adjust = self.client.adjustment(i[:product_code].to_s, net_amount, net_credits, "Adjustment for Negative Balance After Bonus Refund of <a href='/member/invoice?iid=#{self.id.to_guid}'>invoice:#{self.id.to_guid}</a>.")
+              adjust.id_invoice_item = item1.id
+              adjust.save     
+            end # if net_amount < 0            
+          }
           # release resources
           DB.disconnect
           GC.start
         } # i.items.each { |u|
       # reembolso parcial de una factura con un unico item
-      elsif i.items.size == 1
+      elsif i.items.size == 1 # and we know that: total < -payment_gross, so it is a partial refund
         t = i.items.first
 				# 
         amount = -payment_gross.to_f
@@ -659,11 +685,11 @@ module BlackStack
         item1.detail = t.detail.to_s
         item1.description = t.description.to_s
         item1.save()
-        BlackStack::Movement.new().parse(item1, BlackStack::Movement::MOVEMENT_TYPE_REFUND_BALANCE, 'Partial Refund').save()
+        BlackStack::Movement.new().parse(item1, BlackStack::Movement::MOVEMENT_TYPE_REFUND_BALANCE, "Partial Refund of <a href='/member/invoice?iid=#{self.id.to_guid}'>invoice:#{self.id.to_guid}</a>.").save()
 				# agrego un ajuste por el redondeo a una cantidad entera de creditos
 				if float_units.to_f != units.to_f
 					adjustment_amount = unit_price.to_f * (units.to_f - float_units.to_f)
-					adjust = self.client.adjustment(t.product_code.to_s, adjustment_amount, 0, 'Adjustment for Partial Refund', BlackStack::Movement::MOVEMENT_TYPE_REFUND_ADJUSTMENT)
+					adjust = self.client.adjustment(t.product_code.to_s, adjustment_amount, 0, "Adjustment for Refund of <a href='/member/invoice?iid=#{self.id.to_guid}'>invoice:#{self.id.to_guid}</a>.", BlackStack::Movement::MOVEMENT_TYPE_REFUND_ADJUSTMENT)
 					adjust.id_invoice_item = item1.id
 					adjust.save
 				end
@@ -671,13 +697,43 @@ module BlackStack
 				net_amount = 0.to_f - BlackStack::Balance.new(self.client.id, t.product_code.to_s).amount.to_f
 				net_credits = 0.to_f - BlackStack::Balance.new(self.client.id, t.product_code.to_s).credits.to_f
 				if net_amount < 0 && net_credits < 0
-					adjust = self.client.adjustment(t.product_code.to_s, net_amount, net_credits, 'Adjustment for Negative Balance')
+					adjust = self.client.adjustment(t.product_code.to_s, net_amount, net_credits, "Adjustment for Negative Balance After Refund of <a href='/member/invoice?iid=#{self.id.to_guid}'>invoice:#{self.id.to_guid}</a>.")
 					adjust.id_invoice_item = item1.id
 					adjust.save			
 				end # if net_amount < 0
+				
 				# recalculo todos los consumos y expiraciones - CANCELADO - Debe hacerse offline
-				# self.client.recalculate(t.product_code.to_s)
-      else
+				# => self.client.recalculate(t.product_code.to_s)
+				
+        # si el cliente se quedo sin saldo luego del reembolso parcial 
+        if net_amount <= 0
+          # hago el reembolso de cada bono de este item
+          # si el balance quedo en negativo, entonces aplico otro ajuste
+          h[:bonus_plans].each { |bonus|
+            i = BlackStack::InvoicingPaymentsProcessing::plans_descriptor.select { |obj| obj[:item_number] == bonus[:item_number] }.first
+            j = BlackStack::InvoicingPaymentsProcessing::products_descriptor.select { |obj| obj[:code] == i[:product_code] }.first
+            item2 = BlackStack::InvoiceItem.new()
+            item2.id = guid()
+            item2.id_invoice = self.id
+            item2.unit_price = 0
+            item2.units = -i[:credits]
+            item2.amount = 0
+            item2.product_code = i[:product_code].to_s
+            item2.item_number = i[:item_number].to_s
+            item2.detail = 'Bonus Refund'
+            item2.description = j[:description].to_s
+            item2.save()
+            BlackStack::Movement.new().parse(item2, BlackStack::Movement::MOVEMENT_TYPE_REFUND_BALANCE, "Bonus Refund of <a href='/member/invoice?iid=#{self.id.to_guid}'>invoice:#{self.id.to_guid}</a>.").save()        
+            net_amount = 0.to_f - BlackStack::Balance.new(self.client.id, i[:product_code].to_s).amount.to_f
+            net_credits = 0.to_f - BlackStack::Balance.new(self.client.id, i[:product_code].to_s).credits.to_f
+            if net_amount <= 0 && net_credits < 0
+              adjust = self.client.adjustment(i[:product_code].to_s, net_amount, net_credits, "Adjustment for Negative Balance After Bonus Refund of <a href='/member/invoice?iid=#{self.id.to_guid}'>invoice:#{self.id.to_guid}</a>.")
+              adjust.id_invoice_item = item1.id
+              adjust.save     
+            end # if net_amount < 0            
+          }
+        end
+      else # we know that: i.items.size > 1 && total < -payment_gross
         raise "Refund amount is not matching with the invoice total (#{total.to_s}) and the invoice has more than 1 item."
       end
       # release resources

data/lib/movement.rb

@@ -42,9 +42,9 @@ module BlackStack
       elsif (t==MOVEMENT_TYPE_EXPIRATION)
         return "Expiration"
       elsif (t==MOVEMENT_TYPE_ADJUSTMENT)
-        return "Adjustement"
+        return "Credit Adjustement"
       elsif (t==MOVEMENT_TYPE_REFUND_ADJUSTMENT)
-        return "Adjustement"
+        return "Refund Adjustement"
       end
       '(unknown)'
     end
@@ -57,7 +57,7 @@ module BlackStack
       if (t==MOVEMENT_TYPE_ADD_PAYMENT)
         return "green"
       elsif (t==MOVEMENT_TYPE_ADD_BONUS)
-        return "orange"
+        return "green"
       elsif (t==MOVEMENT_TYPE_REASSIGN_BALANCE)
         return "black"
       elsif (t==MOVEMENT_TYPE_REFUND_BALANCE)
@@ -67,9 +67,9 @@ module BlackStack
       elsif (t==MOVEMENT_TYPE_EXPIRATION)
         return "blue"
       elsif (t==MOVEMENT_TYPE_ADJUSTMENT)
-        return "green"
+        return "orange"
       elsif (t==MOVEMENT_TYPE_REFUND_ADJUSTMENT)
-        return "green"
+        return "orange"
       end
     end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: invoicing_payments_processing
 version: !ruby/object:Gem::Version
-  version: 1.1.47
+  version: 1.1.52
 platform: ruby
 authors:
 - Leandro Daniel Sardi
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-10-22 00:00:00.000000000 Z
+date: 2020-11-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: websocket