invoicing 1.0.1 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9f3972f667d3265b67721b85f92ec36d6a112c53
-  data.tar.gz: 8a48030d2cec91e38d9cd13be8f689e0b255f563
+  metadata.gz: 9b3b02e1ae4b997cffc4823f0f96fb5d1fbe74d1
+  data.tar.gz: 5b5e0c157a51d75596479c1dd2d64a7b5eed7018
 SHA512:
-  metadata.gz: 0c24c29ba8dd15f8d65bf4d091a7e6edcc3e8bb7189173b6f647fa771f2926fe6f2ede2e106452a39fd647b106f11d3a7d0cc0060b3c81ecd73ff87761bbd907
-  data.tar.gz: cbafde8f986ec7a4b9fb8d4da1b8ea0e28743f09a65783dbcb73ed857ef295cfb9549e5b64797aa7d30cb9cb3f48af2a9744c185224d3173d7164e4560050b49
+  metadata.gz: a79dc673daa8e55e12b143c4b88f26ac6c6e57e8a8149780995fef4249cb20b294a9634e1c674c5cdf1f7759486ae4afc0bd314f669f4966705de85de4c1a52a
+  data.tar.gz: 8548ee48d350d046bd1b36eeb26d59ab5f671a1c5887d70e6694eb27ec1d51c33a4de31892765fd377b4912e983354c84820200a961512af90c0fe2cfa4dd2f7

data/lib/invoicing/currency_value.rb

@@ -119,7 +119,7 @@ module Invoicing
 
     included do
       # Register callback if this is the first time acts_as_currency_value has been called
-      before_save :write_back_currency_values, :if => "currency_value_class_info.previous_info.nil?"
+      before_save :write_back_currency_values, if: currency_value_class_info.previous_info.nil?
     end
 
     # Format a numeric monetary value into a human-readable string, in the currency of the
@@ -286,7 +286,7 @@ module Invoicing
 
         unless value
           raw_value = object.read_attribute(attr)
-          value = BigDecimal.new(raw_value.to_s) unless raw_value.nil?
+          value = BigDecimal(raw_value.to_s) unless raw_value.nil?
         end
         value
       end

data/lib/invoicing/find_subclasses.rb

@@ -89,43 +89,6 @@ module Invoicing
   # to be on the safe side you can ensure all subclasses are loaded when your application
   # initialises -- but that's not completely DRY ;-)
   module FindSubclasses
-
-    # Overrides <tt>ActiveRecord::Base.sanitize_sql_hash_for_conditions</tt> since this is the method
-    # used to transform a hash of conditions into an SQL query fragment. This overriding method
-    # searches for class method conditions in the hash and transforms them into a condition on the
-    # class name. All further work is delegated back to the superclass method.
-    #
-    # Condition formats are very similar to those accepted by +ActiveRecord+:
-    #   {:my_class_method => 'value'}     # known_subclasses.select{|cls| cls.my_class_method == 'value' }
-    #   {:my_class_method => [1, 2]}      # known_subclasses.select{|cls| [1, 2].include?(cls.my_class_method) }
-    #   {:my_class_method => 3..6}        # known_subclasses.select{|cls| (3..6).include?(cls.my_class_method) }
-    #   {:my_class_method => true}        # known_subclasses.select{|cls| cls.my_class_method }
-    #   {:my_class_method => false}       # known_subclasses.reject{|cls| cls.my_class_method }
-    def sanitize_sql_hash_for_conditions(attrs, table_name = quoted_table_name)
-      new_attrs = {}
-
-      attrs.each_pair do |attr, value|
-        attr = attr_base = attr.to_s
-        attr_table_name = table_name
-
-        # Extract table name from qualified attribute names
-        attr_table_name, attr_base = attr.split('.', 2) if attr.include?('.')
-
-        if columns_hash.include?(attr_base) || ![self.table_name, quoted_table_name].include?(attr_table_name)
-          new_attrs[attr] = value   # Condition on a table column, or another table -- pass through unmodified
-        else
-          begin
-            matching_classes = select_matching_subclasses(attr_base, value)
-            new_attrs["#{self.table_name}.#{inheritance_column}"] = matching_classes.map{|cls| cls.name.to_s}
-          rescue NoMethodError
-            new_attrs[attr] = value # If the class method doesn't exist, fall back to passing condition through unmodified
-          end
-        end
-      end
-
-      super(new_attrs, table_name)
-    end
-
     def expand_hash_conditions_for_aggregates(attrs)
       new_attrs = {}
 

data/lib/invoicing/taxable.rb

@@ -296,7 +296,7 @@ module Invoicing
           original_value = read_attribute("#{method_name}_taxed")
           return nil if original_value.nil? # Can only have a rounding error if the taxed attr was assigned
 
-          original_value = BigDecimal.new(original_value.to_s)
+          original_value = BigDecimal(original_value.to_s)
           converted_value = send("#{method_name}_taxed")
 
           return nil if converted_value.nil?
@@ -350,7 +350,7 @@ module Invoicing
       # +to_status+ must each be either <tt>:taxed</tt> or <tt>:untaxed</tt>.
       def convert(object, attr_without_suffix, value, from_status, to_status)
         return nil if value.nil?
-        value = BigDecimal.new(value.to_s)
+        value = BigDecimal(value.to_s)
         return value if from_status == to_status
 
         if to_status == :taxed

data/lib/invoicing/time_dependent.rb

@@ -195,7 +195,7 @@ module Invoicing
         # Create replaced_by association if it doesn't exist yet
         replaced_by_id = time_dependent_class_info.method(:replaced_by_id)
         unless respond_to? :replaced_by
-          belongs_to :replaced_by, :class_name => self, :foreign_key => replaced_by_id
+          belongs_to :replaced_by, class_name: name, foreign_key: replaced_by_id
         end
 
         # Create value_at and value_now method aliases

data/lib/invoicing/version.rb

@@ -1,8 +1,8 @@
 module Invoicing
   module Version
     MAJOR   = 1
-    MINOR   = 0
-    BUILD   = 1
+    MINOR   = 1
+    BUILD   = 0
 
     def to_a
       [MAJOR, MINOR, BUILD]

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: invoicing
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.1.0
 platform: ruby
 authors:
 - Martin Kleppmann
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-12 00:00:00.000000000 Z
+date: 2020-01-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -126,7 +126,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.6.14
 signing_key: 
 specification_version: 4
 summary: Ruby Invoicing Framework