invisible_captcha 0.9.0 → 0.9.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9e100c8a33e03c0cbf7db8c66f9319bf541848f5
-  data.tar.gz: 25593f083c4c23381d6d2cb25988b59fceb29a1f
+  metadata.gz: 6667c856fdf4fb2ae0147d0d2d3d0531f8fab862
+  data.tar.gz: 7d2dadae6a9010c3614166343221fc0064fe9bc2
 SHA512:
-  metadata.gz: 0b35f5a39151875efd7f02792c29b253f0e2a9e5136b7c3463959fec74320a055a819fac4a73480e7f88bae788de793e0a7faa2ad77f4f3b80502247a85513db
-  data.tar.gz: 907d391f3a01a0edfaf4926715c35ed981bf06cef8ded02138e60c6e3247f79b11a6ae593bb1e3d5488170a4560870e27d517d2974252d36413f5f26d75d87bf
+  metadata.gz: a76b88b892d95a1d72fcf5f2bffb2165c0608554feab107ca5a61e25db4a6b2e4eb3349ecba9b7e0c817d2766c23bb6ebd6723fa20717f8b3518ea38583ebab8
+  data.tar.gz: b15a66cfab3ec429aaafcdcd310e66f178cf17ab1375d58f0f0454b75b00059600295d5b54df404630ba8ceb0d596a84b6f688312bdeb2c04e696d7d211ddf04

data/README.md

@@ -90,15 +90,17 @@ You can customize:
 * `honeypots`: collection of default honeypots. Used by the view helper, called with no args, to generate a random honeypot field name.
 * `visual_honeypots`: make honeypots visible, also useful to test/debug your implementation.
 * `timestamp_threshold`: fastest time (in seconds) to expect a human to submit the form (see [original article by Yoav Aner](http://blog.gingerlime.com/2012/simple-detection-of-comment-spam-in-rails/) outlining the idea). By default, 4 seconds. **NOTE:** It's recommended to deactivate the autocomplete feature to avoid false positives (`autocomplete="off"`).
+* `timestamp_enabled`: option to disable the time threshold check at application level. Could be useful, for example, on some testing scenarios. By default, true.
 * `timestamp_error_message`: flash error message thrown when form submitted quicker than the `timestamp_threshold` value. It uses I18n by default.
 
 To change these defaults, add the following to an initializer (recommended `config/initializers/invisible_captcha.rb`):
 
 ```ruby
 InvisibleCaptcha.setup do |config|
-  config.honeypots              += 'fake_resource_title'
-  config.visual_honeypots        = false
-  config.timestamp_threshold     = 4
+  config.honeypots           << 'another_fake_attribute'
+  config.visual_honeypots    = false
+  config.timestamp_threshold = 4
+  config.timestamp_enabled   = true
   # Leave these unset if you want to use I18n (see below)
   # config.sentence_for_humans     = 'If you are a human, ignore this field'
   # config.timestamp_error_message = 'Sorry, that was too quick! Please resubmit.'

data/lib/invisible_captcha.rb

@@ -12,6 +12,7 @@ module InvisibleCaptcha
 
     attr_accessor :honeypots,
                   :timestamp_threshold,
+                  :timestamp_enabled,
                   :visual_honeypots
 
     def init!
@@ -27,6 +28,9 @@ module InvisibleCaptcha
       # Fastest time (in seconds) to expect a human to submit the form
       self.timestamp_threshold = 4
 
+      # Timestamp check enabled by default
+      self.timestamp_enabled = true
+
       # Default error message for validator when form submitted too quickly
       self.timestamp_error_message = -> { I18n.t('invisible_captcha.timestamp_error_message', default: 'Sorry, that was too quick! Please resubmit.') }
 

data/lib/invisible_captcha/controller_ext.rb

@@ -37,6 +37,10 @@ module InvisibleCaptcha
     end
 
     def invisible_captcha_timestamp?(options = {})
+      unless InvisibleCaptcha.timestamp_enabled
+        return false
+      end
+
       timestamp = session[:invisible_captcha_timestamp]
 
       # Consider as spam if timestamp not in session, cause that means the form was not fetched at all

data/lib/invisible_captcha/version.rb

@@ -1,3 +1,3 @@
 module InvisibleCaptcha
-  VERSION = "0.9.0"
+  VERSION = "0.9.1"
 end

data/lib/invisible_captcha/view_helpers.rb

@@ -6,7 +6,9 @@ module InvisibleCaptcha
     # @param scope [Symbol] name of honeypot scope, ie: topic => input name: topic[subtitle]
     # @return [String] the generated html
     def invisible_captcha(honeypot = nil, scope = nil, options = {})
-      session[:invisible_captcha_timestamp] ||= Time.zone.now.iso8601
+      if InvisibleCaptcha.timestamp_enabled
+        session[:invisible_captcha_timestamp] ||= Time.zone.now.iso8601
+      end
       build_invisible_captcha(honeypot, scope, options)
     end
 

data/spec/controllers_spec.rb

@@ -6,6 +6,7 @@ describe InvisibleCaptcha::ControllerExt, type: :controller do
   before do
     @controller = TopicsController.new
     InvisibleCaptcha.timestamp_threshold = 1
+    InvisibleCaptcha.timestamp_enabled = true
   end
 
   context 'without invisible_captcha_timestamp in session' do
@@ -18,6 +19,17 @@ describe InvisibleCaptcha::ControllerExt, type: :controller do
     end
   end
 
+  context 'without invisible_captcha_timestamp in session and timestamp_enabled=false' do
+    it 'does not fail like if it was submitted too fast' do
+      request.env['HTTP_REFERER'] = 'http://test.host/topics'
+      InvisibleCaptcha.timestamp_enabled = false
+      post :create, topic: { title: 'foo' }
+
+      expect(flash[:error]).not_to be_present
+      expect(response.body).to be_present
+    end
+  end
+
   context 'submission timestamp_threshold' do
     before do
       session[:invisible_captcha_timestamp] = Time.zone.now.iso8601

data/spec/view_helpers_spec.rb

@@ -35,6 +35,7 @@ describe InvisibleCaptcha::ViewHelpers, type: :helper do
   before do
     allow(Time.zone).to receive(:now).and_return(Time.zone.parse('Feb 19 1986'))
     InvisibleCaptcha.visual_honeypots = false
+    InvisibleCaptcha.timestamp_enabled = true
   end
 
   it 'with no arguments' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: invisible_captcha
 version: !ruby/object:Gem::Version
-  version: 0.9.0
+  version: 0.9.1
 platform: ruby
 authors:
 - Marc Anguera Insa
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-05-08 00:00:00.000000000 Z
+date: 2016-06-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -172,7 +172,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Simple honeypot protection for RoR apps