invisible_captcha 0.8.1 → 0.8.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b7eba6a0efa0ea67bedde6d91063e95c22d3ea6c
-  data.tar.gz: ea76244a1e88963ffe3ac27f492fb50d3ac63401
+  metadata.gz: 09a971b340dc4df300e6f158e631085f313501ac
+  data.tar.gz: c300f8cd9c6759b4d8e6f478d676e2b8f6990ace
 SHA512:
-  metadata.gz: 23c1ba38041202c3007b8f8283f19204d3487d0f6e32be065dea68ee35a39dd9eb11f14af4891a55053b4914f790de6dbb352e2a26c2b1f013573db56cfa598a
-  data.tar.gz: 12799ae4924800e64ffff0b50492e646e4aef7375eac687af9170732fb04c8ec2f6b56e9fb50d0c34c37fffc95235e3e108f7f15a77e675b760d2a6e9044ebbd
+  metadata.gz: e49701c76ee0586b6b30f5de9137d8e34ee59210d6ed37352937feab563d5e688e8a480dbc8fa2a837e3f8d807c6fb2583ea44c52c8ba507ac4852565266890b
+  data.tar.gz: 7657bcf22f0936068750a4c6ad321b762d56c78fe63818853c1607d8fcb708b277818a1a597b11cd5cbe1c1b9c9c88f02f2ec538f745a58d0faea7ddae072037

data/README.md

@@ -145,7 +145,7 @@ The `invisible_captcha` method accepts some options:
 * `honeypot`: name of honeypot.
 * `scope`: name of scope, ie: 'topic[subtitle]' -> 'topic' is the scope.
 * `on_spam`: custom callback to be called on spam detection.
-* `on_timestamp_spam`: custom callback to be called when form submitted too quickly.
+* `on_timestamp_spam`: custom callback to be called when form submitted too quickly. The default action redirects to `:back` printing a warning in `flash[:error]`
 
 ### View helpers options:
 

data/lib/invisible_captcha/controller_ext.rb

@@ -20,7 +20,7 @@ module InvisibleCaptcha
       if action = options[:on_timestamp_spam]
         send(action)
       else
-        flash[:error] = InvisibleCaptcha.timestamp_error_message
+        redirect_to :back, flash: { error: InvisibleCaptcha.timestamp_error_message }
       end
     end
 
@@ -38,14 +38,15 @@ module InvisibleCaptcha
 
     def invisible_captcha_timestamp?(options = {})
       timestamp       = session[:invisible_captcha_timestamp]
-      time_to_submit  = Time.zone.now - timestamp
+      return false unless timestamp.present?
+
+      time_to_submit  = Time.zone.now - DateTime.iso8601(timestamp)
 
       # Consider as spam if form submitted too quickly
-      if timestamp && time_to_submit < InvisibleCaptcha.timestamp_threshold
-        logger.warn("Potential spam detected for IP #{request.env['REMOTE_ADDR']}. Invisible Captcha timestamp threshold not reached (took #{time_to_submit.to_i}s).")
-        return true
-      end
-      false
+      return false if time_to_submit >= InvisibleCaptcha.timestamp_threshold
+
+      logger.warn("Potential spam detected for IP #{request.env['REMOTE_ADDR']}. Invisible Captcha timestamp threshold not reached (took #{time_to_submit.to_i}s).")
+      true
     end
 
     def invisible_captcha?(options = {})

data/lib/invisible_captcha/version.rb

@@ -1,3 +1,3 @@
 module InvisibleCaptcha
-  VERSION = "0.8.1"
+  VERSION = "0.8.2"
 end

data/lib/invisible_captcha/view_helpers.rb

@@ -6,7 +6,7 @@ module InvisibleCaptcha
     # @param scope [Symbol] name of honeypot scope, ie: topic => input name: topic[subtitle]
     # @return [String] the generated html
     def invisible_captcha(honeypot = nil, scope = nil, options = {})
-      session[:invisible_captcha_timestamp] ||= Time.zone.now
+      session[:invisible_captcha_timestamp] ||= Time.zone.now.iso8601
       build_invisible_captcha(honeypot, scope, options)
     end
 

data/spec/controllers_spec.rb

@@ -7,20 +7,21 @@ describe InvisibleCaptcha::ControllerExt, type: :controller do
 
   context 'submission timestamp_threshold' do
     before do
-      session[:invisible_captcha_timestamp] = Time.zone.now
+      session[:invisible_captcha_timestamp] = Time.zone.now.iso8601
     end
 
     it 'fails if submission before timestamp_threshold' do
-      post :create, topic: { title: 'foo' }
+      request.env['HTTP_REFERER'] = 'http://test.host/topics'
+      post :create, {topic: { title: 'foo' }}
 
-      expect(response).to redirect_to(new_topic_path)
       expect(flash[:error]).to eq(InvisibleCaptcha.timestamp_error_message)
+      expect(response).to redirect_to :back
     end
 
     it 'allow custom on_timestamp_spam callback', focus: true do
-      put :update, id: 1, topic: { title: 'bar' }
+      put :update, {id: 1, topic: { title: 'bar' }}
 
-      expect(response.body).to redirect_to(root_path)
+      expect(response).to redirect_to(root_path)
     end
 
     context 'successful submissions' do
@@ -40,7 +41,7 @@ describe InvisibleCaptcha::ControllerExt, type: :controller do
 
   context 'form field' do
     before do
-      session[:invisible_captcha_timestamp] = Time.zone.now
+      session[:invisible_captcha_timestamp] = Time.zone.now.iso8601
       # Wait for valid submission
       sleep InvisibleCaptcha.timestamp_threshold
     end

data/spec/view_helpers_spec.rb

@@ -64,6 +64,6 @@ describe InvisibleCaptcha::ViewHelpers, type: :helper do
   it 'should set spam timestamp' do
     InvisibleCaptcha.honeypots = [:foo_id]
     invisible_captcha
-    expect(session[:invisible_captcha_timestamp]).to eq(Time.zone.now)
+    expect(session[:invisible_captcha_timestamp]).to eq(Time.zone.now.iso8601)
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: invisible_captcha
 version: !ruby/object:Gem::Version
-  version: 0.8.1
+  version: 0.8.2
 platform: ruby
 authors:
 - Marc Anguera Insa
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-04-23 00:00:00.000000000 Z
+date: 2016-04-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails