invisible_captcha 0.10.0 → 0.11.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0b8877b6b9e63a8e3469df1b1e4d564c323798f4
-  data.tar.gz: aa93c8cd7004683493f06ba0513bc4cce274f261
+  metadata.gz: 8e681b453a7901d41d318ded90fa7ef465537654
+  data.tar.gz: 41f47473ce607a8610cdf784d60407c83d294cbf
 SHA512:
-  metadata.gz: 32dca9e9c96528181b6665854d07b2edba9441390613824975617f26d263e747475688979224f09d6b582c3c762fa4f438517924534f361ffc7d266ca78d3d39
-  data.tar.gz: f8a13ba2c4885e921668617788d751050ae47a86714c6537a645fbb40071996634a603f31f4a6ff1cdbe723bfc2dbf940a9f82874306baaf98728ea1f8c23cba
+  metadata.gz: 293b6539d38e67f8a95fc109aaf54d2d0f3af25695ab76c91b6427f8c132fb9bc7397c0aebef2bd2f78af65af65fc44a8468f9a6bd766294b496d781171d9104
+  data.tar.gz: f64232b5bbaf63be0a41b5996bbb97b2960b13c0c31b3d87f379444e6017420b32941310d891c52d613fadc8d2cf33bb5ea90b2839942692f8ccd5661b0c47bf

data/.travis.yml

@@ -3,29 +3,23 @@ cache: bundler
 sudo: false
 rvm:
   - ruby-head
-  - 2.4.2
-  - 2.3.5
-  - 2.2.8
-  - 2.1.10
+  - 2.5.1
+  - 2.4.4
+  - 2.3.6
+  - 2.2.9
 gemfile:
+  - gemfiles/rails_5.2.gemfile
   - gemfiles/rails_5.1.gemfile
   - gemfiles/rails_5.0.gemfile
   - gemfiles/rails_4.2.gemfile
-  - gemfiles/rails_4.1.gemfile
   - gemfiles/rails_3.2.gemfile
 matrix:
   exclude:
-    - rvm: 2.1.10
-      gemfile: gemfiles/rails_5.0.gemfile
-    - rvm: 2.1.10
-      gemfile: gemfiles/rails_5.1.gemfile
-    - rvm: 2.4.2
-      gemfile: gemfiles/rails_4.1.gemfile
-    - rvm: 2.4.2
-      gemfile: gemfiles/rails_3.2.gemfile
-    - rvm: ruby-head
-      gemfile: gemfiles/rails_4.1.gemfile
     - rvm: ruby-head
       gemfile: gemfiles/rails_3.2.gemfile
+    - rvm: 2.5.1
+      gemfile: gemfiles/rails_3.2.gemfile
+    - rvm: 2.4.4
+      gemfile: gemfiles/rails_3.2.gemfile
   allow_failures:
     - rvm: ruby-head

data/Appraisals

@@ -1,3 +1,7 @@
+appraise "rails-5.2" do
+  gem "rails", "~> 5.2.0"
+end
+
 appraise "rails-5.1" do
   gem "rails", "~> 5.1.0"
 end
@@ -10,10 +14,6 @@ appraise "rails-4.2" do
   gem "rails", github: 'rails/rails', branch: '4-2-stable'
 end
 
-appraise "rails-4.1" do
-  gem "rails", "~> 4.1.0"
-end
-
 appraise "rails-3.2" do
   gem "rails", "~> 3.2.0"
 end

data/CHANGELOG.md

@@ -0,0 +1,106 @@
+# Changelog
+
+All notable changes to this project will be documented in this file.
+
+## [0.11.0]
+
+- Improve logging (#40, #41)
+- Official Rails 5.2 support
+- Drop Ruby 2.1 from CI
+
+## [0.10.0]
+
+- New timestamp on each request to avoid stale timestamps (#24)
+- Allow to inject styles manually anywhere in the layout (#27)
+- Allow to change threshold per action
+- Dynamic css strategy to hide the honeypot
+- Remove Ruby 1.9 support
+- Random default honeypots on each restart
+- Allow to pass html_options to honeypot input (#28)
+- Improvements on demo application and tests
+- Better strong parameters interaction (#30, #33)
+
+## [0.9.3]
+
+- Rails 5.1 support (#29)
+- Modernize CI Rubies
+
+## [0.9.2]
+
+- Rails 5.0 official support (#23)
+- Travis CI matrix improvements
+
+## [0.9.1]
+
+- Add option (`timestamp_enabled`) to disable timestamp check (#22)
+
+## [0.9.0]
+
+- Remove model style validations (#14)
+- Consider as spam if timestamp not in session (#11)
+- Allow to define a different threshold per action (#8)
+- Appraisals integration (#8)
+- CI improvements: use new Travis infrastructure (#8)
+
+## [0.8.2]
+
+- Default timestamp action redirects to back (#19)
+- Stores timestamps as string in session (#17)
+
+## [0.8.1]
+
+- Time-sensitive form submissions (#7)
+- I18n integration (#13)
+
+## [0.8.0]
+
+- Better Rails integration with `ActiveSupport.on_load` callbacks (#5)
+- Allow to override settings via the view helper (#5)
+
+## [0.7.0]
+
+- Revamped code base to allow more customizations (#2)
+- Added basic specs (#2)
+- Travis integration (#2)
+- Demo app (#2)
+
+## [0.6.5]
+
+- Stop using Jeweler
+
+## [0.6.4]
+
+- Docs! (#1)
+
+## [0.6.3]
+
+- Internal re-naming
+
+## [0.6.2]
+
+- Fix gem initialization
+
+## [0.6.0]
+
+- Allow to configure via `InvisibleCaptcha.setup` block
+
+## [0.5.0]
+
+- First version of controller filters
+
+[0.11.0]: https://github.com/markets/invisible_captcha/compare/v0.10.0...v0.11.0
+[0.10.0]: https://github.com/markets/invisible_captcha/compare/v0.9.3...v0.10.0
+[0.9.3]: https://github.com/markets/invisible_captcha/compare/v0.9.2...v0.9.3
+[0.9.2]: https://github.com/markets/invisible_captcha/compare/v0.9.1...v0.9.2
+[0.9.1]: https://github.com/markets/invisible_captcha/compare/v0.9.0...v0.9.1
+[0.9.0]: https://github.com/markets/invisible_captcha/compare/v0.8.2...v0.9.0
+[0.8.2]: https://github.com/markets/invisible_captcha/compare/v0.8.1...v0.8.2
+[0.8.1]: https://github.com/markets/invisible_captcha/compare/v0.8.0...v0.8.1
+[0.8.0]: https://github.com/markets/invisible_captcha/compare/v0.7.0...v0.8.0
+[0.7.0]: https://github.com/markets/invisible_captcha/compare/v0.6.5...v0.7.0
+[0.6.5]: https://github.com/markets/invisible_captcha/compare/v0.6.4...v0.6.5
+[0.6.4]: https://github.com/markets/invisible_captcha/compare/v0.6.3...v0.6.4
+[0.6.3]: https://github.com/markets/invisible_captcha/compare/v0.6.2...v0.6.3
+[0.6.2]: https://github.com/markets/invisible_captcha/compare/v0.6.0...v0.6.2
+[0.6.0]: https://github.com/markets/invisible_captcha/compare/v0.5.0...v0.6.0
+[0.5.0]: https://github.com/markets/invisible_captcha/compare/v0.4.1...v0.5.0

data/README.md

@@ -18,7 +18,7 @@ It also comes with a time-sensitive :hourglass: form submission.
 
 ## Installation
 
-Invisible Captcha is tested against Rails `>= 3.2` and Ruby `>= 2.1`.
+Invisible Captcha is tested against Rails `>= 3.2` and Ruby `>= 2.2`.
 
 Add this line to you Gemfile:
 
@@ -121,7 +121,7 @@ The `invisible_captcha` method accepts some options:
 * `honeypot`: name of custom honeypot.
 * `scope`: name of scope, ie: 'topic[subtitle]' -> 'topic' is the scope.
 * `on_spam`: custom callback to be called on spam detection.
-* `timestamp_threshold`: enable/disable this technique at action level.
+* `timestamp_enabled`: enable/disable this technique at action level.
 * `on_timestamp_spam`: custom callback to be called when form submitted too quickly. The default action redirects to `:back` printing a warning in `flash[:error]`.
 * `timestamp_threshold`: custom threshold per controller/action. Overrides the global value for `InvisibleCaptcha.timestamp_threshold`.
 
@@ -179,6 +179,12 @@ $ bundle exec appraisal install
 $ bundle exec appraisal rspec
 ```
 
+Run specs against specific version:
+
+```
+$ bundle exec appraisal rails-5.2 rspec
+```
+
 ### Demo
 
 Start a sample Rails app ([source code](spec/dummy)) with `InvisibleCaptcha` integrated:

data/gemfiles/{rails_4.1.gemfile → rails_5.2.gemfile}

@@ -2,6 +2,6 @@
 
 source "https://rubygems.org"
 
-gem "rails", "~> 4.1.0"
+gem "rails", "~> 5.2.0"
 
 gemspec :path => "../"

data/lib/invisible_captcha/controller_ext.rb

@@ -57,7 +57,7 @@ module InvisibleCaptcha
 
       # Consider as spam if timestamp not in session, cause that means the form was not fetched at all
       unless timestamp
-        logger.warn("Potential spam detected for IP #{request.env['REMOTE_ADDR']}. Invisible Captcha timestamp not found in session.")
+        warn("Invisible Captcha timestamp not found in session.")
         return true
       end
 
@@ -66,7 +66,7 @@ module InvisibleCaptcha
 
       # Consider as spam if form submitted too quickly
       if time_to_submit < threshold
-        logger.warn("Potential spam detected for IP #{request.env['REMOTE_ADDR']}. Invisible Captcha timestamp threshold not reached (took #{time_to_submit.to_i}s).")
+        warn("Invisible Captcha timestamp threshold not reached (took #{time_to_submit.to_i}s).")
         return true
       end
 
@@ -82,6 +82,7 @@ module InvisibleCaptcha
         # - honeypot: params[:subtitle]
         # - honeypot with scope: params[:topic][:subtitle]
         if params[honeypot].present? || (params[scope] && params[scope][honeypot].present?)
+          warn("Invisible Captcha honeypot param '#{honeypot}' was present.")
           return true
         else
           # No honeypot spam detected, remove honeypot from params to avoid UnpermittedParameters exceptions
@@ -90,11 +91,18 @@ module InvisibleCaptcha
         end
       else
         InvisibleCaptcha.honeypots.each do |default_honeypot|
-          return true if params[default_honeypot].present?
+          if params[default_honeypot].present?
+            warn("Invisible Captcha honeypot param '#{default_honeypot}' was present.")
+            return true
+          end
         end
       end
 
       false
     end
+
+    def warn(message)
+      logger.warn("Potential spam detected for IP #{request.remote_ip}. #{message}")
+    end
   end
 end

data/lib/invisible_captcha/version.rb

@@ -1,3 +1,3 @@
 module InvisibleCaptcha
-  VERSION = "0.10.0"
+  VERSION = "0.11.0"
 end

data/spec/view_helpers_spec.rb

@@ -62,14 +62,14 @@ describe InvisibleCaptcha::ViewHelpers, type: :helper do
   context 'injectable_styles option' do
     it 'by default, render styles along with the honeypot' do
       expect(invisible_captcha).to match(/display:none/)
-      expect(helper.content_for(:invisible_captcha_styles)).to be_blank
+      expect(@view_flow.content[:invisible_captcha_styles]).to be_blank
     end
 
     it 'if injectable_styles is set, do not append styles inline' do
       InvisibleCaptcha.injectable_styles = true
 
       expect(invisible_captcha).not_to match(/display:none;/)
-      expect(helper.content_for(:invisible_captcha_styles)).to match(/display:none;/)
+      expect(@view_flow.content[:invisible_captcha_styles]).to match(/display:none;/)
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: invisible_captcha
 version: !ruby/object:Gem::Version
-  version: 0.10.0
+  version: 0.11.0
 platform: ruby
 authors:
 - Marc Anguera Insa
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-12-27 00:00:00.000000000 Z
+date: 2018-10-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -91,15 +91,16 @@ files:
 - ".gitignore"
 - ".travis.yml"
 - Appraisals
+- CHANGELOG.md
 - Gemfile
 - LICENSE
 - README.md
 - Rakefile
 - gemfiles/rails_3.2.gemfile
-- gemfiles/rails_4.1.gemfile
 - gemfiles/rails_4.2.gemfile
 - gemfiles/rails_5.0.gemfile
 - gemfiles/rails_5.1.gemfile
+- gemfiles/rails_5.2.gemfile
 - invisible_captcha.gemspec
 - lib/invisible_captcha.rb
 - lib/invisible_captcha/controller_ext.rb