inventory_refresh 0.2.3 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e7a23c438a97181e679731cb18607916042f0a7f86b0d1d6992c18cf0bba4b0c
-  data.tar.gz: baf5ace688468d39bac2fcb853509d18627349b8bd9d6699f79a2ac0b010b175
+  metadata.gz: 666554cf2d3928670cd6772706360d2c2523fc0475b63f2aead1e7e2bec675d7
+  data.tar.gz: 992aa863fdd2d020878f3bd18e0c83d7bf37aa79d6363814e10fdc5cd311a35a
 SHA512:
-  metadata.gz: 1bd6e088f308ea571c6d98b4c6d67504f9479a24b6c1a019d4d219e20d0ed864eff30851e3470e4cb729b95b527b7a687e59d21651f13a7fe026ae95df372514
-  data.tar.gz: 85b3003558c8916af43ab407c93619b2685328a9cefc5e03eabddf9ffbba68b222b40a33715243872258e2c8c175cf1675fe5143beb9d61d6b12f6874f4eb1b1
+  metadata.gz: 1ce760c31989eaa2ec3d230031c176007953b9d5790d7d5e0c85d7b62e43f6d7d45cbe88651a70df3ca77c11f4d7b5587348e2ba0d951add5d8d76a90ba9d0e0
+  data.tar.gz: 4084a11ccd8ab92142e44399159290d5b14be05aa111f5c681571c6ba034a4ecb55587f0d3c2dda9d0ef765e4c5aefa9f2ea9e4183c27b81d4547b3719ae8393

data/.codeclimate.yml

@@ -34,7 +34,6 @@ engines:
   rubocop:
     enabled: true
     config: '.rubocop_cc.yml'
-    channel: rubocop-0-69
 prepare:
   fetch:
   - url: "https://raw.githubusercontent.com/ManageIQ/guides/master/.rubocop_base.yml"

data/.travis.yml

@@ -1,12 +1,12 @@
----
+dist: xenial
 sudo: false
 language: ruby
 cache: bundler
 rvm:
-- 2.5.7
-- 2.6.5
+- 2.4.4
+- 2.3.6
 addons:
-  postgresql: '9.5'
+  postgresql: '10'
 env:
   global:
   - CC_TEST_REPORTER_ID=1ef1a3a3d007395b11083d634a6fdac1e3d979b6428c39d2cd8d58556cdd68f7
@@ -14,12 +14,10 @@ before_install:
 - gem install bundler -v 2.0.1
 - psql -c "CREATE USER root SUPERUSER PASSWORD 'smartvm';" -U postgres
 before_script:
-# Code Climate
-- curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-latest-linux-amd64 > ./cc-test-reporter
+- curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-latest-linux-amd64
+  > ./cc-test-reporter
 - chmod +x ./cc-test-reporter
 - "./cc-test-reporter before-build"
-# inventory_refresh
 - bundle exec rake spec:setup
 after_script:
-# Code Climate
 - "./cc-test-reporter after-build --exit-code $TRAVIS_TEST_RESULT"

data/inventory_refresh.gemspec

@@ -22,16 +22,14 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "activerecord", ">=5.0", "< 6.1"
-  spec.add_dependency "more_core_extensions", ">=3.5", "< 5"
+  spec.add_dependency "activerecord", "~> 5.0"
+  spec.add_dependency "more_core_extensions", "~> 3.5"
   spec.add_dependency "pg", "> 0"
 
   spec.add_development_dependency "ancestry"
-  spec.add_development_dependency "bundler", "~> 2.0"
+  spec.add_development_dependency "bundler", "~> 2.0.1"
   spec.add_development_dependency "factory_bot", "~> 4.11.1"
   spec.add_development_dependency "rake", "~> 10.0"
   spec.add_development_dependency "rspec", "~> 3.0"
-  spec.add_development_dependency "rubocop"
-  spec.add_development_dependency "rubocop-performance"
   spec.add_development_dependency "simplecov"
 end

data/lib/inventory_refresh/application_record_iterator.rb

@@ -1,20 +1,12 @@
 module InventoryRefresh
   class ApplicationRecordIterator
-    attr_reader :inventory_collection, :manager_uuids_set, :iterator, :query
+    attr_reader :inventory_collection
 
-    # An iterator that can fetch batches of the AR objects based on a set of manager refs, or just mimics AR relation
-    # when given an iterator. Or given query, acts as iterator by selecting batches.
+    # An iterator that can fetch batches of the AR objects based on a set of attribute_indexes
     #
     # @param inventory_collection [InventoryRefresh::InventoryCollection] Inventory collection owning the iterator
-    # @param manager_uuids_set [Array<InventoryRefresh::InventoryCollection::Reference>] Array of references we want to
-    #        fetch from the DB
-    # @param iterator [Proc] Block based iterator
-    # @query query [ActiveRecord::Relation] Existing query we want to use for querying the db
-    def initialize(inventory_collection: nil, manager_uuids_set: nil, iterator: nil, query: nil)
+    def initialize(inventory_collection: nil)
       @inventory_collection = inventory_collection
-      @manager_uuids_set    = manager_uuids_set
-      @iterator             = iterator
-      @query                = query
     end
 
     # Iterator that mimics find_in_batches of ActiveRecord::Relation. This iterator serves for making more optimized query
@@ -25,28 +17,19 @@ module InventoryRefresh
     # and relation.where(:id => 500ids)
     #
     # @param batch_size [Integer] A batch size we want to fetch from DB
+    # @param attributes_index [Hash{String => Hash}] Indexed hash with data we will be saving
     # @yield Code processing the batches
-    def find_in_batches(batch_size: 1000)
-      if iterator
-        iterator.call do |batch|
-          yield(batch)
-        end
-      elsif query
-        manager_uuids_set.each_slice(batch_size) do |batch|
-          yield(query.where(inventory_collection.targeted_selection_for(batch)))
-        end
-      else
-        manager_uuids_set.each_slice(batch_size) do |batch|
-          yield(inventory_collection.db_collection_for_comparison_for(batch))
-        end
+    def find_in_batches(batch_size: 1000, attributes_index: {})
+      attributes_index.each_slice(batch_size) do |batch|
+        yield(inventory_collection.db_collection_for_comparison_for(batch))
       end
     end
 
     # Iterator that mimics find_each of ActiveRecord::Relation using find_in_batches (see #find_in_batches)
     #
     # @yield Code processing the batches
-    def find_each
-      find_in_batches do |batch|
+    def find_each(attributes_index: {})
+      find_in_batches(:attributes_index => attributes_index) do |batch|
         batch.each do |item|
           yield(item)
         end

data/lib/inventory_refresh/exception.rb

@@ -0,0 +1,8 @@
+module InventoryRefresh
+  module Exception
+    class SweeperError < StandardError; end
+    class SweeperNonExistentScopeKeyFoundError < SweeperError; end
+    class SweeperNonUniformScopeKeyFoundError < SweeperError; end
+    class SweeperScopeBadFormat < SweeperError; end
+  end
+end

data/lib/inventory_refresh/inventory_collection/builder.rb

@@ -4,16 +4,16 @@ module InventoryRefresh
       class MissingModelClassError < StandardError; end
 
       def self.allowed_properties
-        %i(all_manager_uuids            arel                    association
+        %i(arel                         association
            attributes_blacklist         attributes_whitelist    batch_extra_attributes
            complete                     create_only             custom_save_block
-           custom_reconnect_block       default_values          delete_method
+           custom_reconnect_block       default_values
            dependency_attributes        check_changed           inventory_object_attributes
-           manager_ref                  manager_ref_allowed_nil manager_uuids
+           manager_ref                  manager_ref_allowed_nil
            model_class                  name                    parent
-           parent_inventory_collections retention_strategy      strategy
-           saver_strategy               secondary_refs          targeted
-           targeted_arel                update_only             use_ar_object
+           retention_strategy           strategy
+           secondary_refs
+           update_only                  use_ar_object
            assert_graph_integrity).to_set
       end
 

data/lib/inventory_refresh/inventory_collection/data_storage.rb

@@ -70,15 +70,6 @@ module InventoryRefresh
         build(hash)
       end
 
-      # Finds InventoryObject.
-      #
-      # @param hash [Hash] Hash that needs to contain attributes defined in :manager_ref of the InventoryCollection
-      # @return [InventoryRefresh::InventoryObject] Found or built InventoryObject object
-      def find_in_data(hash)
-        _hash, _uuid, inventory_object = primary_index_scan(hash)
-        inventory_object
-      end
-
       # Finds of builds a new InventoryObject. By building it, we also put in into the InventoryCollection's storage.
       #
       # @param hash [Hash] Hash that needs to contain attributes defined in :manager_ref of the

data/lib/inventory_refresh/inventory_collection/helpers/initialize_helper.rb

@@ -35,26 +35,14 @@ module InventoryRefresh
         #         - :local_db_find_missing_references => InventoryObject objects of the InventoryCollection will be saved to
         #                                                the DB. Then if we reference an object that is not present, it will
         #                                                load them from the db using :local_db_find_references strategy.
-        # @param saver_strategy [Symbol] A strategy that will be used for InventoryCollection persisting into the DB.
-        #        Allowed saver strategies are:
-        #        - :default => Using Rails saving methods, this way is not safe to run in multiple workers concurrently,
-        #          since it will lead to non consistent data.
-        #        - :batch => Using batch SQL queries, this way is not safe to run in multiple workers
-        #          concurrently, since it will lead to non consistent data.
-        #        - :concurrent_safe_batch => It uses atomic upsert to avoid data duplication and it uses timestamp based
-        #          atomic checks to avoid new data being overwritten by the the old data. The upsert/update queries are
-        #          executed as batched SQL queries, instead of sending 1 query per record.
         # @param retention_strategy [Symbol] A retention strategy for this collection. Allowed values are:
         #        - :destroy => Will destroy the inactive records.
         #        - :archive => Will archive the inactive records by setting :archived_at timestamp.
-        # @param delete_method [Symbol] A delete method that will be used for deleting of the InventoryObject, if the
-        #        object is marked for deletion. A default is :destroy, the instance method must be defined on the
-        #        :model_class.
-        def init_strategies(strategy, saver_strategy, retention_strategy, delete_method)
-          @saver_strategy     = process_saver_strategy(saver_strategy)
+        def init_strategies(strategy, retention_strategy)
+          @saver_strategy     = :concurrent_safe_batch
           @strategy           = process_strategy(strategy)
+          # TODO(lsmola) why don't we just set this strategy based on :archived_at column? Lets do that
           @retention_strategy = process_retention_strategy(retention_strategy)
-          @delete_method      = delete_method || :destroy
         end
 
         # @param manager_ref [Array] Array of Symbols, that are keys of the InventoryObject's data, inserted into this
@@ -67,42 +55,10 @@ module InventoryRefresh
         #        avoid this usecase by a proper modeling.
         #        Note that InventoryObject's data has to be build with <foreign_key> => nil, it means that key cannot be missing!
         # @param secondary_refs [Hash] TODO
-        # @param manager_uuids [Array|Proc] Array of manager_uuids of the InventoryObjects we want to create/update/delete. Using
-        #        this attribute, the db_collection_for_comparison will be automatically limited by the manager_uuids, in a
-        #        case of a simple relation. In a case of a complex relation, we can leverage :manager_uuids in a
-        #        custom :targeted_arel. We can pass also lambda, for lazy_evaluation.
-        def init_references(manager_ref, manager_ref_allowed_nil, secondary_refs,  manager_uuids)
+        def init_references(manager_ref, manager_ref_allowed_nil, secondary_refs)
           @manager_ref             = manager_ref || %i(ems_ref)
           @manager_ref_allowed_nil = manager_ref_allowed_nil || []
           @secondary_refs          = secondary_refs || {}
-          @manager_uuids           = manager_uuids || []
-        end
-
-        # @param all_manager_uuids [Array] Array of all manager_uuids of the InventoryObjects. With the :targeted true,
-        #        having this parameter defined will invoke only :delete_method on a complement of this set, making sure
-        #        the DB has only this set of data after. This :attribute serves for deleting of top level
-        #        InventoryCollections, i.e. InventoryCollections having parent_inventory_collections nil. The deleting of
-        #        child collections is already handled by the scope of the parent_inventory_collections and using Rails
-        #        :dependent => :destroy,
-        # @param all_manager_uuids_scope [Array] A scope limiting the :all_manager_uuids parameter. E.g. we can send
-        #        all_manager_uuids for 1 region, leading to delete a complement of the entities just under that 1
-        #        region.
-        #        If all_manager_uuids_scope is used with :all_manager_uuids => nil, it will do delete_complement of the
-        #        scope itself. E.g. sending a list of all active regions, we will delete complement entities not
-        #        belonging to those regions.
-        #        Example:
-        #          :all_manager_uuids       => [{:source_ref => x}, {:source_ref => y}],
-        #          :all_manager_uuids_scope => [{:region => regions.lazy_find(X)}, {:region => regions.lazy_find(Y)}]
-        #
-        #        Will cause deletion/archival or all entities that don't have source_ref "x" or "y", but only under
-        #        regions X and Y.
-        # @param all_manager_uuids_timestamp [String] A timestamp in UTC marking a time before we collected all of the
-        #        all_manager_uuids. Meaning we won't be archiving any newer entities.
-        def init_all_manager_uuids(all_manager_uuids, all_manager_uuids_scope, all_manager_uuids_timestamp)
-          # TODO(lsmola) Should we refactor this to use references too?
-          @all_manager_uuids           = all_manager_uuids
-          @all_manager_uuids_scope     = all_manager_uuids_scope
-          @all_manager_uuids_timestamp = all_manager_uuids_timestamp
         end
 
         # @param dependency_attributes [Hash] Manually defined dependencies of this InventoryCollection. We can use this
@@ -119,48 +75,9 @@ module InventoryRefresh
         #        This example is used in Example2 of the <param custom_save_block> and it means that our :custom_save_block
         #        will be invoked after the InventoryCollection :orchestration_stacks and :orchestration_stacks_resources
         #        are saved.
-        # @param parent_inventory_collections [Array] Array of symbols having a name pointing to the
-        #        InventoryRefresh::InventoryCollection objects, that serve as parents to this InventoryCollection. There are
-        #        several scenarios to consider, when deciding if InventoryCollection has parent collections, see the example.
-        #
-        #        Example:
-        #          taking inventory collections :vms and :disks (local disks), if we write that:
-        #          inventory_collection = InventoryCollection.new({
-        #                       :model_class                 => ::Disk,
-        #                       :association                 => :disks,
-        #                       :manager_ref                 => [:vm, :location]
-        #                       :parent_inventory_collection => [:vms],
-        #                     })
-        #
-        #          Then the decision for having :parent_inventory_collection => [:vms] was probably driven by these
-        #          points:
-        #          1. We can get list of all disks only by doing SQL query through the parent object (so there will be join
-        #             from vms to disks table).
-        #          2. There is no API query for getting all disks from the provider API, we get them inside VM data, or as
-        #             a Vm subquery
-        #          3. Part of the manager_ref of the IC is the VM object (foreign key), so the disk's location is unique
-        #             only under 1 Vm. (In current models, this modeled going through Hardware model)
-        #          4. In targeted refresh, we always expect that each Vm will be saved with all its disks.
-        #
-        #          Then having the above points, adding :parent_inventory_collection => [:vms], will bring these
-        #          implications:
-        #          1. By archiving/deleting Vm, we can no longer see the disk, because those were owned by the Vm. Any
-        #             archival/deletion of the Disk model, must be then done by cascade delete/hooks logic.
-        #          2. Having Vm as a parent ensures we always process it first. So e.g. when providing no Vms for saving
-        #             we would have no graph dependency (no data --> no edges --> no dependencies) and Disk could be
-        #             archived/removed before the Vm, while we always want to archive the VM first.
-        #          3. For targeted refresh, we always expect that all disks are saved with a VM. So for targeting :disks,
-        #             we are not using #manager_uuids attribute, since the scope is "all disks of all targeted VMs", so we
-        #             always use #manager_uuids of the parent. (that is why :parent_inventory_collections and
-        #             :manager_uuids are mutually exclusive attributes)
-        #          4. For automatically building the #targeted_arel query, we need the parent to know what is the root node.
-        #             While this information can be introspected from the data, it creates a scope for create&update&delete,
-        #             which means it has to work with no data provided (causing delete all). So with no data we cannot
-        #             introspect anything.
-        def init_ic_relations(dependency_attributes, parent_inventory_collections = nil)
-          @dependency_attributes        = dependency_attributes || {}
-          @dependees                    = Set.new
-          @parent_inventory_collections = parent_inventory_collections
+        def init_ic_relations(dependency_attributes)
+          @dependency_attributes = dependency_attributes || {}
+          @dependees             = Set.new
         end
 
         # @param complete [Boolean] By default true, :complete is marking we are sending a complete dataset and therefore
@@ -175,18 +92,13 @@ module InventoryRefresh
         # @param use_ar_object [Boolean] True or False. Whether we need to initialize AR object as part of the saving
         #        it's needed if the model have special setters, serialize of columns, etc. This setting is relevant only
         #        for the batch saver strategy.
-        # @param targeted [Boolean] True if the collection is targeted, in that case it will be leveraging :manager_uuids
-        #        :parent_inventory_collections and :targeted_arel to save a subgraph of a data.
-        def init_flags(complete, create_only, check_changed,
-                       update_only, use_ar_object, targeted,
-                       assert_graph_integrity)
+        def init_flags(complete, create_only, check_changed, update_only, use_ar_object, assert_graph_integrity)
           @complete               = complete.nil? ? true : complete
           @create_only            = create_only.nil? ? false : create_only
           @check_changed          = check_changed.nil? ? true : check_changed
           @saved                  = false
           @update_only            = update_only.nil? ? false : update_only
           @use_ar_object          = use_ar_object || false
-          @targeted               = !!targeted
           @assert_graph_integrity = assert_graph_integrity.nil? ? true : assert_graph_integrity
         end
 
@@ -230,7 +142,7 @@ module InventoryRefresh
           @attributes_whitelist             = Set.new
           @batch_extra_attributes           = batch_extra_attributes || []
           @inventory_object_attributes      = inventory_object_attributes
-          @internal_attributes              = %i(__feedback_edge_set_parent __parent_inventory_collections __all_manager_uuids_scope)
+          @internal_attributes              = %i(__feedback_edge_set_parent)
           @transitive_dependency_attributes = Set.new
 
           blacklist_attributes!(attributes_blacklist) if attributes_blacklist.present?
@@ -240,7 +152,6 @@ module InventoryRefresh
         def init_storages
           @data_storage       = ::InventoryRefresh::InventoryCollection::DataStorage.new(self, @secondary_refs)
           @references_storage = ::InventoryRefresh::InventoryCollection::ReferencesStorage.new(index_proxy)
-          @targeted_scope     = ::InventoryRefresh::InventoryCollection::ReferencesStorage.new(index_proxy).merge!(@manager_uuids)
         end
 
         # @param arel [ActiveRecord::Associations::CollectionProxy|Arel::SelectManager] Instead of :parent and :association
@@ -248,35 +159,18 @@ module InventoryRefresh
         #        doing create/update/delete.
         #
         #        Example:
-        #        for a targeted refresh, we want to delete/update/create only a list of vms specified with a list of
-        #        ems_refs:
-        #            :arel => manager.vms.where(:ems_ref => manager_refs)
-        #        Then we want to do the same for the hardwares of only those vms:
-        #             :arel => manager.hardwares.joins(:vm_or_template).where(
-        #               'vms' => {:ems_ref => manager_refs}
-        #             )
-        #        And etc. for the other Vm related records.
-        # @param targeted_arel [Proc] A callable block that receives this InventoryCollection as a first argument. In there
-        #        we can leverage a :parent_inventory_collections or :manager_uuids to limit the query based on the
-        #        manager_uuids available.
-        #        Example:
-        #          targeted_arel = lambda do |inventory_collection|
-        #            # Getting ems_refs of parent :vms and :miq_templates
-        #            manager_uuids = inventory_collection.parent_inventory_collections.collect(&:manager_uuids).flatten
-        #            inventory_collection.db_collection_for_comparison.hardwares.joins(:vm_or_template).where(
-        #              'vms' => {:ems_ref => manager_uuids}
+        #          add_collection(:cross_link_vms) do |builder|
+        #            builder.add_properties(
+        #              :arel        => Vm.where(:tenant => manager.tenant),
+        #              :association => nil,
+        #              :model_class => Vm,
+        #              :name        => :cross_link_vms,
+        #              :manager_ref => [:uid_ems],
+        #              :strategy    => :local_db_find_references,
         #            )
         #          end
-        #
-        #          inventory_collection = InventoryCollection.new({
-        #                                   :model_class                 => ::Hardware,
-        #                                   :association                 => :hardwares,
-        #                                   :parent_inventory_collection => [:vms, :miq_templates],
-        #                                   :targeted_arel               => targeted_arel,
-        #                                 })
-        def init_arels(arel, targeted_arel)
-          @arel                   = arel
-          @targeted_arel          = targeted_arel
+        def init_arels(arel)
+          @arel = arel
         end
 
         # @param custom_save_block [Proc] A custom lambda/proc for persisting in the DB, for cases where it's not enough
@@ -289,7 +183,7 @@ module InventoryRefresh
         #                hash = inventory_object.attributes # Loads possible dependencies into saveable hash
         #                obj = SomeModel.find_by(:attr => hash[:attr]) # Note: doing find_by for many models produces N+1
         #                                                              # queries, avoid this, this is just a simple example :-)
-        #                obj.update(hash) if obj
+        #                obj.update_attributes(hash) if obj
         #                obj ||= SomeModel.create(hash)
         #                inventory_object.id = obj.id # If this InventoryObject is referenced elsewhere, we need to store its
         #                                               primary key back to the InventoryObject
@@ -392,23 +286,6 @@ module InventoryRefresh
           @deleted_records = []
         end
 
-        # Processes passed saver strategy
-        #
-        # @param saver_strategy [Symbol] Passed saver strategy
-        # @return [Symbol] Returns back the passed strategy if supported, or raises exception
-        def process_saver_strategy(saver_strategy)
-          return :default unless saver_strategy
-
-          saver_strategy = saver_strategy.to_sym
-          case saver_strategy
-          when :default, :batch, :concurrent_safe_batch
-            saver_strategy
-          else
-            raise "Unknown InventoryCollection saver strategy: :#{saver_strategy}, allowed strategies are "\
-              ":default, :batch and :concurrent_safe_batch"
-          end
-        end
-
         # Processes passed strategy, modifies :data_collection_finalized and :saved attributes for db only strategies
         #
         # @param strategy_name [Symbol] Passed saver strategy
@@ -434,12 +311,26 @@ module InventoryRefresh
           strategy_name
         end
 
+        # Saves passed strategy, modifies :data_collection_finalized and :saved attributes for db only strategies
+        #
+        # @param strategy [Symbol] Passed saver strategy
+        # @return [Symbol] Returns back the passed strategy if supported, or raises exception
+        def strategy=(strategy)
+          @strategy = process_strategy(strategy)
+        end
+
         # Processes passed retention strategy
         #
         # @param retention_strategy [Symbol] Passed retention strategy
         # @return [Symbol] Returns back the passed strategy if supported, or raises exception
         def process_retention_strategy(retention_strategy)
-          return unless retention_strategy
+          unless retention_strategy
+            if supports_column?(:archived_at)
+              return :archive
+            else
+              return :destroy
+            end
+          end
 
           retention_strategy = retention_strategy.to_sym
           case retention_strategy

data/lib/inventory_refresh/inventory_collection/helpers/questions_helper.rb

@@ -50,11 +50,6 @@ module InventoryRefresh
           dependencies.all?(&:saved?)
         end
 
-        # @return [Boolean] true if we are using a saver strategy that allows saving in parallel processes
-        def parallel_safe?
-          @parallel_safe_cache ||= %i(concurrent_safe concurrent_safe_batch).include?(saver_strategy)
-        end
-
         # @return [Boolean] true if the model_class supports STI
         def supports_sti?
           @supports_sti_cache = model_class.column_names.include?("type") if @supports_sti_cache.nil?
@@ -81,50 +76,12 @@ module InventoryRefresh
           data_collection_finalized
         end
 
-        # @return [Boolean] true is processing of this InventoryCollection will be in targeted mode
-        def targeted?
-          targeted
-        end
-
         # True if processing of this InventoryCollection object would lead to no operations. Then we use this marker to
         # stop processing of the InventoryCollector object very soon, to avoid a lot of unnecessary Db queries, etc.
         #
         # @return [Boolean] true if processing of this InventoryCollection object would lead to no operations.
         def noop?
-          # If this InventoryCollection doesn't do anything. it can easily happen for targeted/batched strategies.
-          saving_noop? && delete_complement_noop?
-        end
-
-        # @return [Boolean] true if processing InventoryCollection will not lead to any created/updated/deleted record
-        def saving_noop?
-          saving_targeted_parent_collection_noop? || saving_targeted_child_collection_noop? || saving_full_collection_noop?
-        end
-
-        # @return true if processing InventoryCollection will not lead to deleting the complement of passed ids
-        def delete_complement_noop?
-          all_manager_uuids.nil?
-        end
-
-        private
-
-        # @return true if it's a noop parent targeted InventoryCollection
-        def saving_targeted_parent_collection_noop?
-          targeted_noop_condition && parent_inventory_collections.blank? && targeted_scope.primary_references.blank?
-        end
-
-        # @return true if it's a noop child targeted InventoryCollection
-        def saving_targeted_child_collection_noop?
-          targeted_noop_condition && parent_inventory_collections.present? &&
-            parent_inventory_collections.all? { |x| x.targeted_scope.primary_references.blank? }
-        end
-
-        # @return true if it's a noop full InventoryCollection refresh
-        def saving_full_collection_noop?
-          !targeted? && data.blank? && !delete_allowed? && skeletal_primary_index.blank?
-        end
-
-        def targeted_noop_condition
-          targeted? && custom_save_block.nil? && skeletal_primary_index.blank?
+          data.blank? && custom_save_block.nil? && skeletal_primary_index.blank?
         end
       end
     end

data/lib/inventory_refresh/inventory_collection/index/proxy.rb

@@ -64,14 +64,6 @@ module InventoryRefresh
           end
         end
 
-        def reindex_secondary_indexes!
-          data_indexes.each do |ref, index|
-            next if ref == primary_index_ref
-
-            index.reindex!
-          end
-        end
-
         def primary_index
           data_index(primary_index_ref)
         end
@@ -94,30 +86,16 @@ module InventoryRefresh
           end
         end
 
-        def find_by(manager_uuid_hash, ref: primary_index_ref)
-          # TODO(lsmola) deprecate this, it's enough to have find method
-          find(manager_uuid_hash, :ref => ref)
-        end
-
-        def lazy_find_by(manager_uuid_hash, ref: primary_index_ref, key: nil, default: nil)
-          # TODO(lsmola) deprecate this, it's enough to have lazy_find method
-
-          lazy_find(manager_uuid_hash, :ref => ref, :key => key, :default => default)
-        end
-
         def lazy_find(manager_uuid, ref: primary_index_ref, key: nil, default: nil, transform_nested_lazy_finds: false)
-          # TODO(lsmola) also, it should be enough to have only 1 find method, everything can be lazy, until we try to
-          # access the data
-          # TODO(lsmola) lazy_find will support only hash, then we can remove the _by variant
           return if manager_uuid.nil?
           assert_index(manager_uuid, ref)
 
           ::InventoryRefresh::InventoryObjectLazy.new(inventory_collection,
-                                                    manager_uuid,
-                                                    :ref                         => ref,
-                                                    :key                         => key,
-                                                    :default                     => default,
-                                                    :transform_nested_lazy_finds => transform_nested_lazy_finds)
+                                                      manager_uuid,
+                                                      :ref                         => ref,
+                                                      :key                         => key,
+                                                      :default                     => default,
+                                                      :transform_nested_lazy_finds => transform_nested_lazy_finds)
         end
 
         def named_ref(ref = primary_index_ref)
@@ -132,19 +110,13 @@ module InventoryRefresh
 
         delegate :association_to_foreign_key_mapping,
                  :build_stringified_reference,
-                 :parallel_safe?,
                  :strategy,
                  :to => :inventory_collection
 
         attr_reader :all_refs, :data_indexes, :inventory_collection, :primary_ref, :local_db_indexes, :secondary_refs
 
         def find_in_data_or_skeletal_index(reference)
-          if parallel_safe?
-            # With parallel safe strategies, we create skeletal nodes that we can look for
-            data_index_find(reference) || skeletal_index_find(reference)
-          else
-            data_index_find(reference)
-          end
+          data_index_find(reference) || skeletal_index_find(reference)
         end
 
         def skeletal_index_find(reference)

data/lib/inventory_refresh/inventory_collection/index/type/base.rb

@@ -27,14 +27,6 @@ module InventoryRefresh
             index[build_stringified_reference(inventory_object.data, attribute_names)] = inventory_object
           end
 
-          # Rebuilds the indexes for all InventoryObject objects
-          def reindex!
-            self.index = {}
-            data.each do |inventory_object|
-              store_index_for(inventory_object)
-            end
-          end
-
           # @return [Array] Returns index data
           def index_data
             index.values

data/lib/inventory_refresh/inventory_collection/references_storage.rb

@@ -45,23 +45,6 @@ module InventoryRefresh
         add_reference(reference_data)
       end
 
-      # Adds array of references to the storage. The reference can be already existing, otherwise we attempt to build
-      # it.
-      #
-      # @param references_array [Array] Array of reference objects acceptable by add_reference method.
-      # @param ref [Symbol] A key to specific reference, if it's a reference pointing to something else than primary
-      #        index.
-      # @return [InventoryRefresh::InventoryCollection::ReferencesStorage] Returns self
-      def merge!(references_array, ref: nil)
-        references_array.each { |reference_data| add_reference(reference_data, :ref => ref) }
-        self
-      end
-
-      # @return [Hash{String => InventoryRefresh::InventoryCollection::Reference}] Hash of indexed Reference objects
-      def primary_references
-        references[primary_index_ref]
-      end
-
       # Builds a Reference object
       #
       # @param reference_data [InventoryRefresh::InventoryCollection::References, Hash, Object] Either existing Reference