introspective_grape 0.2.2 → 0.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6af99e9a2be82ee669829ac17f9e84b767d74e12
-  data.tar.gz: eac78da439dd9c35844cbafd0cfd23428c3500de
+  metadata.gz: c030a296ffbf221b0efa559f3e7e6ab2d30afae4
+  data.tar.gz: 9eb9b3edc3fa75e0204de34d1b704700ed08f621
 SHA512:
-  metadata.gz: 4531fc66b10fd1f3e84778572f7ba2c0e6d9a6c27f902ae6d13ebe55da68c6ab87ad6f19a6e37883678fc3bddcaeeab4f31cc790509c9ab9041249b36ac0aafd
-  data.tar.gz: 82660a9b2cd9683e78b4f2aacb11430e66a9a68a171f0ab3fdb4811613f264d4ebea20d51a9d0b27f3dbd7af5fa363ed3d2f76180755a8abb07246a30759111c
+  metadata.gz: 1423ab9e477c4f022d0ddcb424ffccca23a778d393eb43cbaa060b86a5e11d366130227230686aedb4258a139d68577adfbde889531d4a6606e0d0938a477c8b
+  data.tar.gz: c683edd9b8fc4733e0cc05901e77775c4ef9a40997c44d8a81a7e5d357918decd12f0142e30fd9ec770a768db950e1928d4fcc263490a77527cb64bea4402994

data/CHANGELOG.md

@@ -1,4 +1,13 @@
 
+0.2.3 10/21/2016
+==============
+### Bug Fix
+
+We have to modify request.params and then re-assign @params to request.params before
+validation in order to work with Grape's habit of mucking with both independently.
+
+This makes Grape validations work properly again against camel inputs.
+
 0.2.2 10/20/2016
 ==============
 

data/lib/introspective_grape/api.rb

@@ -52,11 +52,16 @@ module IntrospectiveGrape
           self.send(IntrospectiveGrape::API.authentication_method(self))
         end
 
-        child.after_validation do
-          # Convert incoming camel case params to snake case: grape will totally blow this
-          # if the params hash does not come back as a Hashie::Mash.
-          @params = (params||Hashie::Mash.new).with_snake_keys if IntrospectiveGrape.config.camelize_parameters
-        end
+        child.before_validation do
+          # We have to snake case the Rack params then re-assign @params to the
+          # request.params, because of the I-think-very-goofy-and-inexplicable
+          # way Grape interacts with both independently of each other
+          (params.try(:with_snake_keys)||{}).each do |k,v|
+            request.delete_param(k.camelize(:lower))
+            request.update_param(k, v)
+          end
+          @params = request.params 
+        end if IntrospectiveGrape.config.camelize_parameters
       end
 
       # We will probably need before and after hooks eventually, but haven't yet...

data/lib/introspective_grape/version.rb

@@ -1,3 +1,3 @@
 module IntrospectiveGrape
-  VERSION = "0.2.2".freeze
+  VERSION = "0.2.3".freeze
 end

data/spec/rails_helper.rb

@@ -3,6 +3,7 @@ Coveralls.wear!('rails')
 ENV["RAILS_ENV"] = 'test'
 require File.expand_path("../dummy/config/environment", __FILE__)
 require 'rspec/rails'
+#require 'byebug'
 require 'support/request_helpers'
 require 'support/pundit_helpers'
 Dir[Rails.root.join("../support/**/*.rb")].each { |f| require f }

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: introspective_grape
 version: !ruby/object:Gem::Version
-  version: 0.2.2
+  version: 0.2.3
 platform: ruby
 authors:
 - Josh Buermann