introspective_admin 0.9.0 → 1.0.0

data/introspective_admin.gemspec

@@ -1,34 +1,29 @@
-$:.push File.expand_path("../lib", __FILE__)
+# frozen_string_literal: true
+
+$LOAD_PATH.push File.expand_path('lib', __dir__)
 
 # Maintain your gem's version:
-require "introspective_admin/version"
-require "introspective_admin/base"
+require 'introspective_admin/version'
+require 'introspective_admin/base'
 
 # Describe your gem and declare its dependencies:
 Gem::Specification.new do |s|
-  s.name        = "introspective_admin"
+  s.name        = 'introspective_admin'
   s.version     = IntrospectiveAdmin::VERSION
-  s.authors     = ["Josh Buermann"]
-  s.email       = ["buermann@gmail.com"]
-  s.homepage    = "https://github.com/buermann/introspective_admin"
-  s.summary     = "Set up basic ActiveAdmin screens for an ActiveRecord model."
-  s.description = "Set up basic ActiveAdmin screens for an ActiveRecord model."
-  s.license     = "MIT"
+  s.authors     = ['Josh Buermann']
+  s.email       = ['buermann@gmail.com']
+  s.homepage    = 'https://github.com/buermann/introspective_admin'
+  s.summary     = 'Set up basic ActiveAdmin screens for an ActiveRecord model.'
+  s.description = 'Set up basic ActiveAdmin screens for an ActiveRecord model.'
+  s.license     = 'MIT'
 
-  s.files         = `git ls-files`.split("\n").sort
-  s.test_files    = `git ls-files -- spec/*`.split("\n")
+  s.files = `git ls-files`.split("\n").sort
 
-  s.required_ruby_version = '>= 2.7.0'
+  s.required_ruby_version = '>= 3.0', '< 4'
 
-  s.add_dependency 'rails'
   s.add_dependency 'activeadmin'
-  s.add_dependency 'sass-rails'
   s.add_dependency 'sass'
+  s.add_dependency 'sass-rails'
 
-  if RUBY_PLATFORM == 'java'
-    s.add_development_dependency "activerecord-jdbcsqlite3-adapter"
-  else
-    s.add_development_dependency "sqlite3"
-  end
+  s.metadata['rubygems_mfa_required'] = 'true'
 end
-

data/lib/introspective_admin/base.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module IntrospectiveAdmin
   class Base
     # Generate an active admin interface by introspecting on the models.
@@ -19,35 +21,39 @@ module IntrospectiveAdmin
     # end
 
     class << self
-
       def exclude_params
         [] # do not display the field in the index page and forms.
       end
 
       def include_virtual_attributes
-        [] #
+        []
       end
 
-      def polymorphic?(model,column)
-        (model.reflections[column.sub(/_id$/,'')].try(:options)||{})[:polymorphic]
+      def polymorphic?(model, column)
+        (model.reflections[column.sub(/_id$/, '')].try(:options) || {})[:polymorphic]
       end
 
-      def column_list(model, extras=[])
-        model.columns.map {|c|
-          ref_name = c.name.sub(/(_type|_id)$/,'')
+      def column_list(model, extras = [])
+        model.columns.map { |c|
+          ref_name = c.name.sub(/(_type|_id)$/, '')
           model.reflections[ref_name] ? ref_name : c.name
-        }.uniq-['created_at','updated_at']-exclude_params+extras
+        }.uniq - %w[created_at updated_at] - exclude_params + extras
       end
 
-      def params_list(model, extras=[])
-        model.columns.map {|c|
-          polymorphic?(model,c.name) ? c.name.sub(/_id$/,'')+"_assign" : c.name
-        }+extras
+      def params_list(model, extras = [])
+        model.columns.map { |c|
+          polymorphic?(model, c.name) ? "#{c.name.sub(/_id$/, '')}_assign" : c.name
+        } + extras
       end
 
       def link_record(dsl, record)
         link_text = record.try(:name) || record.try(:title) || record.class.to_s
-        link_href = begin dsl.send("admin_#{record.class.name.underscore}_path", record.id) rescue false end
+        link_href = begin begin
+          dsl.send("admin_#{record.class.name.underscore}_path", record.id)
+        rescue StandardError
+          false
+        end
+        end
         if link_href
           dsl.link_to link_text, link_href
         elsif link_text
@@ -59,13 +65,18 @@ module IntrospectiveAdmin
 
       def register(model, &block)
         # Defining activeadmin pages will break pending migrations:
-        begin ActiveRecord::Migration.check_all_pending! rescue return end
+        begin begin
+          ActiveRecord::Migration.check_all_pending!
+        rescue StandardError
+          return
+        end
+        end
 
         klass         = self
         model_name    = model.to_s.underscore
-        nested_config = Hash[model.nested_attributes_options.reject {|name,o|
+        nested_config = model.nested_attributes_options.reject { |name, _o|
           klass.exclude_params.include?("#{name}_attributes")
-        }.map {|assoc,options|
+        }.to_h do |assoc, options|
           reflection       = model.reflections[assoc.to_s]
           reflection_class = reflection.class_name.constantize
           # merge the options of the nested attribute and relationship declarations
@@ -76,10 +87,10 @@ module IntrospectiveAdmin
           options[:reflection]            = reflection
           options[:polymorphic_reference] = reflection.options[:as].to_s
           [assoc, options]
-        }]
+        end
 
         ActiveAdmin.register model do
-          instance_eval &block if block_given? # Evalutate the passed black for overrides to the defaults
+          instance_eval(&block) if block_given? # Evalutate the passed black for overrides to the defaults
 
           controller do
             def scoped_collection
@@ -89,12 +100,12 @@ module IntrospectiveAdmin
 
           index do
             selectable_column
-            cols = model.columns.map(&:name)-klass.exclude_params
-            cols.each_with_index do |c,i|
-              reflection = model.reflections.detect {|k,v| v.foreign_key == c }
+            cols = model.columns.map(&:name) - klass.exclude_params
+            cols.each_with_index do |c, _i|
+              reflection = model.reflections.detect { |_k, v| v.foreign_key == c }
               if reflection
                 column c do |o|
-                  klass.link_record(self,o.send(reflection.first))
+                  klass.link_record(self, o.send(reflection.first))
                 end
               else
                 column c
@@ -104,41 +115,46 @@ module IntrospectiveAdmin
           end
 
           show do
-            instance = self.send(model_name)
+            instance = send(model_name)
 
             attributes_table do
               model.columns.each do |c|
-                next if (c.name =~ /password/)
-                reflection = model.reflections.detect {|k,v| v.foreign_key == c.name }
+                next if c.name =~ /password/
+
+                reflection = model.reflections.detect { |_k, v| v.foreign_key == c.name }
                 if reflection
-                  row c.name do |o|
-                    klass.link_record(self,instance.send(reflection.first))
+                  row c.name do |_o|
+                    klass.link_record(self, instance.send(reflection.first))
                   end
                 else
                   row c.name
                 end
-
               end
 
-              nested_config.each do |assoc,options|
+              nested_config.each do |assoc, options|
                 panel assoc.capitalize do
                   table_for instance.send(assoc) do
                     options[:columns].each do |c|
                       if options[:class].reflections[c]
-                        column( c ) do |r|
-                          klass.link_record(self,r.send(c)) if r
+                        column(c) do |r|
+                          klass.link_record(self, r.send(c)) if r
                         end
                       else
                         column c
                       end
                     end
 
-                    admin_route = begin url_for(['admin', options[:class].name.underscore]) rescue false end
+                    admin_route = begin begin
+                      url_for(['admin', options[:class].name.underscore])
+                    rescue StandardError
+                      false
+                    end
+                    end
                     if admin_route
                       column 'actions' do |child|
-                        span link_to "View",   url_for(['admin', child])
-                        span link_to "Edit",   url_for(['edit','admin',child])
-                        span link_to "Delete", url_for(['admin',child]), method: :delete, confirm: "Are you sure you want to delete this?"
+                        span link_to 'View',   url_for(['admin', child])
+                        span link_to 'Edit',   url_for(['edit', 'admin', child])
+                        span link_to 'Delete', url_for(['admin', child]), method: :delete, confirm: 'Are you sure you want to delete this?'
                       end
                     end
                   end
@@ -147,18 +163,20 @@ module IntrospectiveAdmin
             end
           end
 
-          permit_params klass.params_list(model, klass.include_virtual_attributes) + [Hash[nested_config.map{|assoc,o|
-            ["#{assoc}_attributes", o[:params]+[(o[:allow_destroy] ? :_destroy : '')] ]
-          }]]
+          permitted_params = klass.params_list(model, klass.include_virtual_attributes) + [nested_config.to_h do |assoc, o|
+            ["#{assoc}_attributes", o[:params] + [(o[:allow_destroy] ? :_destroy : '')]]
+          end]
+          permit_params(*permitted_params)
 
           form do |f|
-            f.semantic_errors *f.object.errors.messages.keys
+            f.semantic_errors(*f.object.errors.messages.keys)
             f.actions
 
             klass.column_list(model, klass.include_virtual_attributes).each do |column|
-              if column == model.primary_key
-              elsif klass.polymorphic?(model,column)
-                f.input column+"_assign", collection: model.send("#{column}_assign_options")
+              next if column == model.primary_key
+
+              if klass.polymorphic?(model, column)
+                f.input "#{column}_assign", collection: model.send("#{column}_assign_options")
               elsif model.respond_to?("options_for_#{column}")
                 f.input column, collection: model.send("options_for_#{column}", f.object)
               else
@@ -168,22 +186,22 @@ module IntrospectiveAdmin
 
             div { '&nbsp'.html_safe }
 
-            nested_config.each do |assoc,options|
+            nested_config.each do |assoc, options|
               aclass  = options[:class]
-              columns = options[:columns]-[aclass.primary_key]
+              columns = options[:columns] - [aclass.primary_key]
               f.inputs do
                 f.has_many assoc, allow_destroy: options[:allow_destroy] do |r|
                   columns.each do |c|
                     if c == model_name || c == options[:polymorphic_reference]
                       # the join to the parent is implicit
-                    elsif klass.polymorphic?(aclass,c)
+                    elsif klass.polymorphic?(aclass, c)
                       r.input "#{c}_assign", collection: aclass.send("#{c}_assign_options")
                     elsif aclass.reflections[c] && aclass.respond_to?("options_for_#{c}")
                       # If the class has an options_for_<column> method defined use that
                       # rather than the default behavior, pass the instance for scoping,
                       # e.g. UserProjectJob.options_for_job is scoped by the Project's
                       # jobs:
-                      r.input c, collection: aclass.send("options_for_#{c}",f.object)
+                      r.input c, collection: aclass.send("options_for_#{c}", f.object)
                     else
                       r.input c
                     end
@@ -192,7 +210,6 @@ module IntrospectiveAdmin
               end
             end
           end
-
         end
       end
     end

data/lib/introspective_admin/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module IntrospectiveAdmin
-  VERSION = "0.9.0"
+  VERSION = '1.0.0'
 end

data/lib/introspective_admin.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'activeadmin'
 module IntrospectiveAdmin
   autoload :Base, 'introspective_admin/base'

data/lib/tasks/introspective_admin_tasks.rake

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # desc "Explaining what the task does"
 # task :introspective_admin do
 #   # Task goes here

data/spec/admin/company_admin_spec.rb

@@ -1,72 +1,73 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 
-RSpec.describe Admin::CompaniesController, :type => :controller do 
+RSpec.describe Admin::CompaniesController, type: :controller do
   render_views
 
-  before :each do 
+  before :each do
     user = double('user')
     allow(request.env['warden']).to receive(:authenticate!) { user }
     allow(controller).to receive(:current_user) { user }
   end
 
-  describe "GET index" do
-    it "finds all companies" do
+  describe 'GET index' do
+    it 'finds all companies' do
       c = Company.make!
       get :index
-      response.status.should == 200 
+      response.status.should
       assigns(:companies).include?(c).should == true
     end
   end
 
-  describe "SHOW record" do 
-    it "finds the record" do
+  describe 'SHOW record' do
+    it 'finds the record' do
       c = Company.make!
       get :show, params: { id: c.id }
-      response.status.should == 200 
+      response.status.should == 200
     end
   end
 
-  describe "NEW record" do 
-    it "renders the form for a new record" do
+  describe 'NEW record' do
+    it 'renders the form for a new record' do
       get :new
-      response.status.should == 200 
+      response.status.should == 200
     end
   end
 
-  describe "CREATE record" do 
-    it "creates the record" do
+  describe 'CREATE record' do
+    it 'creates the record' do
       c = Company.make
       post :create, params: { company: c.attributes }
       response.should redirect_to action: :show, id: Company.last.id
       Company.last.name.should == c.name
     end
 
-    it "creates a record with an admin" do
+    it 'creates a record with an admin' do
       u = User.make!
       c = Company.make
       post :create, params: { company: c.attributes.merge({
-        roles_attributes: {'0'=>{ user_id: u.id }}
+        roles_attributes: { '0'=>{ user_id: u.id } }
       }) }
       response.should redirect_to action: :show, id: Company.last.id
       Company.last.admins.include?(u).should be_truthy
     end
-
   end
 
-  describe "EDIT record" do 
-    it "renders the edit form for an existing record" do 
+  describe 'EDIT record' do
+    it 'renders the edit form for an existing record' do
       r = Company.make!
       get :edit, params: { id: r.id }
-      response.status.should == 200 
+      response.status.should == 200
     end
   end
 
-  describe "UPDATE record" do 
-    it "updates the record" do
+  describe 'UPDATE record' do
+    it 'updates the record' do
       c = Company.make!
-      put :update, params: { id: c.id, company: { name: "New Name" }  }
+      put :update, params: { id: c.id, company: { name: 'New Name' } }
       response.should redirect_to action: :show, id: c.id
-      Company.find(c.id).name.should == "New Name"
+      Company.find(c.id).name.should == 'New Name'
     end
   end
 end

data/spec/admin/job_admin_spec.rb

@@ -1,6 +1,8 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 
-RSpec.describe Admin::JobsController, :type => :controller do 
+RSpec.describe Admin::JobsController, type: :controller do
   render_views
 
   before :each do # Why can't I do this shit in a helper like I do for requests?
@@ -9,32 +11,32 @@ RSpec.describe Admin::JobsController, :type => :controller do
     allow(controller).to receive(:current_user) { user }
   end
 
-  describe "GET index" do
-    it "finds all Jobs" do
+  describe 'GET index' do
+    it 'finds all Jobs' do
       r = Job.make!
       get :index
-      response.status.should == 200 
+      response.status.should
       assigns(:jobs).include?(r).should == true
     end
   end
 
-  describe "SHOW record" do 
-    it "finds the record" do
+  describe 'SHOW record' do
+    it 'finds the record' do
       r = Job.make!
       get :show, params: { id: r.id }
-      response.status.should == 200 
+      response.status.should == 200
     end
   end
 
-  describe "NEW record" do 
-    it "renders the form for a new record" do
+  describe 'NEW record' do
+    it 'renders the form for a new record' do
       get :new
-      response.status.should == 200 
+      response.status.should == 200
     end
   end
 
-  describe "CREATE record" do 
-    it "creates the record" do
+  describe 'CREATE record' do
+    it 'creates the record' do
       r = Job.make
       post :create, params: { job: r.attributes }
       response.should redirect_to action: :show, id: Job.last.id
@@ -42,20 +44,20 @@ RSpec.describe Admin::JobsController, :type => :controller do
     end
   end
 
-  describe "EDIT record" do 
-    it "renders the edit form for an existing record" do 
+  describe 'EDIT record' do
+    it 'renders the edit form for an existing record' do
       r = Job.make!
       get :edit, params: { id: r.id }
-      response.status.should == 200 
+      response.status.should == 200
     end
   end
 
-  describe "UPDATE record" do 
-    it "updates the record" do
+  describe 'UPDATE record' do
+    it 'updates the record' do
       r = Job.make!
-      put :update, params: { id: r.id, job: { title: "New Name" }  }
+      put :update, params: { id: r.id, job: { title: 'New Name' } }
       response.should redirect_to action: :show, id: r.id
-      Job.find(r.id).title.should == "New Name"
+      Job.find(r.id).title.should == 'New Name'
     end
   end
 end

data/spec/admin/location_admin_spec.rb

@@ -1,6 +1,8 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 
-RSpec.describe Admin::LocationsController, :type => :controller do 
+RSpec.describe Admin::LocationsController, type: :controller do
   render_views
 
   before :each do # Why can't I do this shit in a helper like I do for requests?
@@ -9,58 +11,60 @@ RSpec.describe Admin::LocationsController, :type => :controller do
     allow(controller).to receive(:current_user) { user }
   end
 
-  describe "GET index" do
-    it "finds all locations" do
+  describe 'GET index' do
+    it 'finds all locations' do
       c = Location.make!
       get :index
-      response.status.should == 200 
+      response.status.should
       assigns(:locations).include?(c).should == true
     end
   end
 
-  describe "SHOW record" do 
-    it "finds the record" do
+  describe 'SHOW record' do
+    it 'finds the record' do
       c = Location.make!
       get :show, params: { id: c.id }
-      response.status.should == 200 
+      response.status.should == 200
     end
   end
-  
-  describe "NEW record" do 
+
+  describe 'NEW record' do
     # will fail until https://github.com/activeadmin/activeadmin/pull/4010 is merged
-    it "renders the form for a new record" do
+    it 'renders the form for a new record' do
       get :new
       response.body.should =~ /location\[unreflected_id\]/
-      response.status.should == 200 
+      response.status.should == 200
     end
   end
 
-  describe "CREATE record" do 
-    it "creates the record" do
+  describe 'CREATE record' do
+    it 'creates the record' do
       c = Location.make
       gps = LocationGps.make
-      post :create, params: { location: c.attributes.merge(gps_attributes: gps.attributes)  }
+      post :create, params: { location: c.attributes.merge(gps_attributes: gps.attributes) }
       response.should redirect_to action: :show, id: Location.last.id
-      Location.last.name.should == c.name
-      Location.last.gps.lat.round(10).should == gps.lat.round(10)
+      Location.last.name.should
+      c.name
+      Location.last.gps.lat.round(10).should
+      gps.lat.round(10)
       Location.last.gps.lng.round(10).should == gps.lng.round(10)
     end
   end
 
-  describe "EDIT record" do 
-    it "renders the edit form for an existing record" do 
+  describe 'EDIT record' do
+    it 'renders the edit form for an existing record' do
       r = Location.make!
       get :edit, params: { id: r.id }
-      response.status.should == 200 
+      response.status.should == 200
     end
   end
 
-  describe "UPDATE record" do 
-    it "updates the record" do
+  describe 'UPDATE record' do
+    it 'updates the record' do
       r = Location.make!
-      put :update, params: { id: r.id, location: { name: "New Name" }  }
+      put :update, params: { id: r.id, location: { name: 'New Name' } }
       response.should redirect_to action: :show, id: r.id
-      Location.find(r.id).name.should == "New Name"
+      Location.find(r.id).name.should == 'New Name'
     end
   end
 end