interrobang 1.1.0 → 1.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9712141ae193c892d33886ad593382b6be6074d6
-  data.tar.gz: 0f4f1cf059e7626d5ecbfc19ec8e65e0582d1a21
+  metadata.gz: 0ceec7459be5080517cd7fb86a34a82d298a4566
+  data.tar.gz: 786219e05a0eb05f8ce748145847dfd993a25831
 SHA512:
-  metadata.gz: 8592a7b828d2494581650bd18d475f907411c98530bbf359204c07a2f64637d4bb888dc7009bcbb716353725d437e4674fad7778b5b5e3a67f073aaec5d024ea
-  data.tar.gz: 89518dacacc502943491ea52a5a69b812f68ac87f7a6bcedb78f943b8b17075350f305a88805dcf6f75f62cbc00671d9be929b26a051c0c2ccc9b8c17be77b92
+  metadata.gz: f0a2e2f65b003c5e1d5af6ac61634d284d502f44c45708f92715babd30e258f2ffea92d192d557a1340eb22e41039a54e12350799bb75fb75f12a7c4fc9b4767
+  data.tar.gz: 47ed4dfbe582b2151a7666430c910b1bbd7e3fb9243d47d3f8f01275175a6a9f47d04749186126fecaea8cbdde632eae65b75c44b4c1272660e9217cd67329f3

data/README.md

@@ -69,8 +69,17 @@ Interrobang(Answer, :correct?, prefix: 'ensure_', suffix: '_on_saturday') do
     true
   end
 end # => :ensure_correct_on_saturday!
+```
 
+Beware! `Interrobang` will bangify undefined methods too that classes driven by `method_missing` can be converted too.
 
+```ruby
+class NaySayer
+  def method_missing(method, *args, &block)
+    false
+  end
+end
+Interrobang(NaySayer, :correct?) # => :correct!
 ```
 
 ### Filters
@@ -114,6 +123,8 @@ class Answer
 end
 ```
 
+### Details
+
 See `lib/interrobang.rb` for complete documentation and the tests for details.
 
 ## Installation
@@ -132,7 +143,6 @@ Or install it yourself as:
 
     $ gem install interrobang
 
-
 ## Example Use Case with Rails
 
 `Interrobang` works wonderfully with permission-related objects. Say we have a bangified `Protector` class that defines user permissions in our application:

data/lib/interrobang/version.rb

@@ -1,3 +1,3 @@
 module Interrobang
-  VERSION = '1.1.0'
+  VERSION = '1.1.1'
 end

data/lib/interrobang.rb

@@ -43,34 +43,23 @@ module Interrobang
   #   inlcude_super - The Boolean specifying whether to bangify parent methods
   #
   # Returns the Symbol Array of bangified method names.
-  def bangify_class(klass, matching: DEFAULT_PATTERN, only: [], except: [], prefix: '', suffix: '', include_super: false)
+  def bangify_class(klass, matching: DEFAULT_PATTERN, only: [], except: [], prefix: '', suffix: '', include_super: false, &block)
     method_keys = klass.instance_methods(include_super)
     only = [only] unless only.is_a?(Array)
     except = [except] unless except.is_a?(Array)
-    if only.empty?
-      method_keys.map do |method_key|
-        if method_key.to_s =~ matching && !except.include?(method_key)
-          if block_given?
-            bangify_method(klass, method_key, prefix: prefix, suffix: suffix, &Proc.new)
-          else
-            bangify_method(klass, method_key, prefix: prefix, suffix: suffix)
-          end
-        end
-      end.compact
-    else
-      method_keys.map do |method_key|
-        if only.include?(method_key)
-          if block_given?
-            bangify_method(klass, method_key, prefix: prefix, suffix: suffix, &Proc.new)
-          else
-            bangify_method(klass, method_key, prefix: prefix, suffix: suffix)
-          end
-        end
-      end.compact
+    methods_to_bangify =
+      if only.empty?
+        (method_keys - except).select { |method_key| method_key.to_s =~ matching }
+      else
+        method_keys & only
+      end
+    methods_to_bangify.map do |method_key|
+      bangify_method(klass, method_key, prefix: prefix, suffix: suffix, &block)
     end
   end
 
-  # Converts the specified predicate method to a bang method.
+  # Converts the specified predicate method to a bang method. Beware: bang
+  # methods will be created for undefined methods too.
   #
   # klass - The Class to target for bangification
   # predicate_method - The Symbol of the predicate method

data/test/lib/{predicate_bang_test.rb → interrobang_test.rb}

@@ -17,6 +17,11 @@ def test_class
 end
 
 describe Interrobang do
+
+  #
+  # Bangify Class
+  #
+
   bangify_class_signatures = {
     '#Interrobang' =>
       -> (*args, &block) { Interrobang(*args, &block) },
@@ -113,6 +118,10 @@ describe Interrobang do
     end
   end
 
+  #
+  # Bangify Method
+  #
+
   bangify_method_signatures = {
     '#Interrobang' =>
       -> (*args, &block) { Interrobang(*args, &block) },
@@ -129,6 +138,7 @@ describe Interrobang do
           method_block.call(klass, :true?)
           assert klass.new.true!
         end
+
         it "has no method missing shenanigans" do
           klass = test_class
           method_block.call(klass, :true?)
@@ -167,6 +177,12 @@ describe Interrobang do
         assert_equal klass.new.bang!, '!'
       end
 
+      it "converts undefined methods" do
+        klass = test_class
+        method_block.call(klass, :is_not_defined)
+        assert klass.new.respond_to?(:is_not_defined!)
+      end
+
       describe "options" do
         it "adds any provided prefix or suffix to the bang method" do
           klass = test_class
@@ -207,6 +223,10 @@ describe Interrobang do
     end
   end
 
+  #
+  # Everything Else
+  #
+
   it "is extendable" do
     class Answer
       extend Interrobang

data/test/test_helper.rb

@@ -1,5 +1,7 @@
-require 'codeclimate-test-reporter'
-CodeClimate::TestReporter.start
+if ENV['CODECLIMATE_REPO_TOKEN']
+  require 'codeclimate-test-reporter'
+  CodeClimate::TestReporter.start
+end
 
 require 'minitest/autorun'
 require 'minitest/pride'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: interrobang
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.1.1
 platform: ruby
 authors:
 - Faraz Yashar
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-03-29 00:00:00.000000000 Z
+date: 2015-04-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -71,7 +71,7 @@ files:
 - interrobang.gemspec
 - lib/interrobang.rb
 - lib/interrobang/version.rb
-- test/lib/predicate_bang_test.rb
+- test/lib/interrobang_test.rb
 - test/test_helper.rb
 homepage: https://github.com/fny/interrobang
 licenses:
@@ -98,6 +98,6 @@ signing_key:
 specification_version: 4
 summary: Convert your predicate_methods? into bang_methods! without abusing method_missing
 test_files:
-- test/lib/predicate_bang_test.rb
+- test/lib/interrobang_test.rb
 - test/test_helper.rb
 has_rdoc: