interpret 0.2.0 → 0.2.1

data/spec/integration/stale_translations_spec.rb

@@ -0,0 +1,28 @@
+# encoding: utf-8
+require "spec_helper"
+
+describe "Stale translations" do
+  before(:all) { User.create!  }
+  before { load_integration_data }
+
+  it "should show me nothing when I'm in english language" do
+    visit interpret_stale_translations_path(:en)
+    page.should have_content("There can't be stale translations for the main language")
+  end
+
+  it "should show me the recently modified translations in english", :js => true do
+    visit interpret_root_path(:en)
+    change_translation("table#results tbody tr:first", "New comments text")
+
+    visit interpret_stale_translations_path(:es)
+    page.all("table#stale_translations tbody tr").size.should == 1
+  end
+
+  it "should not show anything if I update a 'es' translation", :js => true do
+    visit interpret_root_path(:es)
+    change_translation("table#results tbody tr:first", "New comments text")
+
+    visit interpret_stale_translations_path(:es)
+    page.all("table#stale_translations tbody tr").size.should == 0
+  end
+end

data/spec/integration/tools_spec.rb

@@ -0,0 +1,86 @@
+# encoding: utf-8
+require "spec_helper"
+
+describe "Tools" do
+  before(:all) { User.create!  }
+  before { load_integration_data }
+
+  describe "Download" do
+    it "should be able to download a .yml file for the current language" do
+      visit interpret_tools_path(:en)
+      page.should have_button("Download")
+
+      page.click_button "Download"
+      page.response_headers["Content-Type"].should == "text/plain"
+    end
+
+    it "should get a yaml file for the current language" do
+      visit interpret_tools_path(:en)
+      page.should have_button("Download")
+
+      page.click_button "Download"
+      hash = YAML.load(page.source)
+      hash.first.first.should == "en"
+    end
+
+    it "should get a yaml file with all the correct translations" do
+      visit interpret_tools_path(:en)
+      page.should have_button("Download")
+
+      page.click_button "Download"
+      hash = YAML.load(page.source)
+      source_hash = YAML.load(en_yml)
+
+      hash.sort.should == source_hash.sort
+    end
+  end
+
+  describe "Import" do
+    it "should be able to import a file" do
+      visit interpret_tools_path(:en)
+      path = create_tmp_file("""
+                             en:
+                               someky: somevalue
+                             """)
+      page.attach_file("file", path)
+      page.click_button "Upload"
+      page.should have_content("Import successfully done.")
+    end
+
+    it "should not allow to be used with another language" do
+      path = create_tmp_file("""
+                             it:
+                               someky: somevalue
+                             """)
+      visit interpret_tools_path(:en)
+      page.attach_file("file", path)
+      page.click_button "Upload"
+      page.should have_content("the language doesn't match")
+    end
+
+    it "should update existing translations" do
+      path = create_tmp_file(import_en_yml)
+      visit interpret_tools_path(:en)
+
+      page.attach_file("file", path)
+      page.click_button "Upload"
+
+      visit interpret_root_path(:en)
+      within("table#results tbody tr:nth-child(4)") do
+        page.should have_content("A new printer phrase")
+      end
+    end
+
+    it "should create non existant translations" do
+      path = create_tmp_file(import_en_yml)
+      visit interpret_tools_path(:en)
+
+      page.attach_file("file", path)
+      page.click_button "Upload"
+
+      visit interpret_root_path(:en)
+      page.should have_content("new_stuff")
+      page.should have_content("Something brand new")
+    end
+  end
+end

data/spec/integration/translations_spec.rb

@@ -0,0 +1,26 @@
+# encoding: utf-8
+require "spec_helper"
+
+describe "Translations" do
+  before(:all) { User.create!  }
+  before { load_integration_data }
+
+  it "should let me edit a translation", :js => true do
+    visit interpret_root_path(:en)
+
+    # We need this to identify the translation we want to change
+    bip_id = ""
+    within("table#results tbody tr:first") do
+      bip_id = page.all("span.best_in_place").first[:id]
+    end
+    bip_id = bip_id.scan(/translation_\d+/).first
+
+    bip_area bip_id, :value, "New value"
+
+
+    visit interpret_root_path(:en)
+    within("table#results tbody tr:first") do
+      page.should have_content("New value")
+    end
+  end
+end

data/spec/models/translation_spec.rb

@@ -38,6 +38,16 @@ es:
     """
   }
 
+  let(:es_2_yml) {"""
+es:
+  p1: Hola mundo!
+    """}
+
+  let(:pt_2_yml) {"""
+pt:
+  p1: Olá mundo
+    """}
+
   let(:new_en_yml) {"""
 en:
   p1: Hello modified world! This new translation should not be copied into database
@@ -80,27 +90,6 @@ es:
   """
   }
 
-  # Convert a locale file into database translations
-  def file2db(string_file)
-    def parse_hash(dict, locale, prefix = "")
-      res = []
-      dict.keys.each do |x|
-        if dict[x].kind_of?(Hash)
-          res += parse_hash(dict[x], locale, "#{prefix}#{x}.")
-        else
-          res << Interpret::Translation.create!(:locale => locale, :key => "#{prefix}#{x}", :value => dict[x])
-        end
-      end
-      res
-    end
-
-    hash = YAML.load string_file
-    lang = hash.keys.first
-    Interpret::Translation.transaction do
-      parse_hash(hash.first[1], lang).map{|x| x.save!}
-    end
-  end
-
   before do
     Interpret::Translation.delete_all
     I18n.stub!(:default_locale).and_return('en')
@@ -235,16 +224,17 @@ es:
       trans.value.should == "Hello modified world! This new translation should not be copied into database"
     end
 
-    it "should not create new keys" do
+    it "should create new keys" do
       Interpret::Translation.delete_all
       file2db(en_yml)
-      howm_before = Interpret::Translation.locale('en').count
+      Interpret::Translation.locale('en').count
 
       @file.stub!(:content_type).and_return("text/plain")
       Interpret::Translation.import(@file)
 
-      howm_after = Interpret::Translation.locale('en').count
-      howm_before.should == howm_after
+      howm = Interpret::Translation.locale('en').count
+      # It should create 2 new translations, from 8 to 10
+      howm.should == 10
     end
 
     it "should not touch translations not present in the file" do
@@ -269,4 +259,47 @@ es:
       Interpret::Translation.export(es_trans).should == YAML.load(es_yml)
     end
   end
+
+  describe "set stale" do
+    it "should mark sibling translations as stale after editing the one of the app's default_language" do
+      Interpret::Translation.delete_all
+      file2db(en_yml)
+      file2db(es_2_yml)
+      file2db(pt_2_yml)
+
+      tr = Interpret::Translation.locale("en").find_by_key("p1")
+      tr.value = "New value"
+      tr.save!
+
+      Interpret::Translation.locale("es").find_by_key("p1").stale?.should be_true
+      Interpret::Translation.locale("pt").find_by_key("p1").stale?.should be_true
+    end
+
+    it "should not mark as stale the translation that you're editing when it's in the app's default_language" do
+      Interpret::Translation.delete_all
+      file2db(en_yml)
+      file2db(es_2_yml)
+
+      tr = Interpret::Translation.locale("en").find_by_key("p1")
+      tr.value = "New value"
+      tr.save!
+
+      tr.stale?.should be_false
+    end
+
+    it "should not mark sibling translations as stale after editing some that is not in the app's default_language" do
+      Interpret::Translation.delete_all
+      file2db(en_yml)
+      file2db(es_2_yml)
+      file2db(pt_2_yml)
+
+      tr = Interpret::Translation.locale("es").find_by_key("p1")
+      tr.value = "New value"
+      tr.save!
+
+      Interpret::Translation.locale("en").find_by_key("p1").stale?.should be_false
+      Interpret::Translation.locale("es").find_by_key("p1").stale?.should be_false
+      Interpret::Translation.locale("pt").find_by_key("p1").stale?.should be_false
+    end
+  end
 end

data/spec/observers/expiration_observer_spec.rb

@@ -10,8 +10,10 @@ describe Interpret::ExpirationObserver do
   it "should call run_expiration on observer" do
     backend = mock("A backend")
     backend.should_receive(:"reload!").once
+    old = Interpret.backend
     Interpret.backend = backend
     Interpret::Translation.create! :locale => "en", :key => "en.hello", :value => "Hello world"
+    Interpret.backend = old
   end
 end
 

data/spec/spec_helper.rb

@@ -2,21 +2,8 @@
 ENV["RAILS_ENV"] = "test"
 
 require File.expand_path('../../test_app/config/environment', __FILE__)
-require "rails/test_help"
 require "rspec/rails"
-require "database_helpers"
-
-ActionMailer::Base.delivery_method = :test
-ActionMailer::Base.perform_deliveries = true
-ActionMailer::Base.default_url_options[:host] = "test.com"
-
-Rails.backtrace_cleaner.remove_silencers!
-
-include DatabaseHelpers
-# Run any available migration
-puts 'Setting up database...'
-drop_all_tables
-migrate_database
+require 'yaml'
 
 # Load support files
 Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each{|f| require f}
@@ -27,7 +14,8 @@ RSpec.configure do |config|
   require 'rspec/expectations'
 
   config.include RSpec::Matchers
-  config.include DatabaseHelpers
+  config.include BestInPlace::TestHelpers
+  config.use_transactional_fixtures = true
 
   # == Mock Framework
   config.mock_with :rspec

data/spec/support/selenium_db_hack.rb

@@ -0,0 +1,19 @@
+# Avoids using the database_cleaner gem and allow us to have faster
+# integration specs with selenium. See https://github.com/jnicklas/capybara at
+# transactional fixtures section.
+
+
+class ActiveRecord::Base
+  mattr_accessor :shared_connection
+  @@shared_connection = nil
+
+  def self.connection
+    @@shared_connection || retrieve_connection
+  end
+end
+
+# Forces all threads to share the same connection. This works on
+# Capybara because it starts the web server in a thread.
+ActiveRecord::Base.shared_connection = ActiveRecord::Base.connection
+
+

data/spec/support/utils.rb

@@ -0,0 +1,89 @@
+# encoding: utf-8
+# Convert a locale file into database translations
+def file2db(string_file)
+  def parse_hash(dict, locale, prefix = "")
+    res = []
+    dict.keys.each do |x|
+      if dict[x].kind_of?(Hash)
+        res += parse_hash(dict[x], locale, "#{prefix}#{x}.")
+      else
+        res << Interpret::Translation.create!(:locale => locale, :key => "#{prefix}#{x}", :value => dict[x])
+      end
+    end
+    res
+  end
+
+  hash = YAML.load string_file
+  lang = hash.keys.first
+  parse_hash(hash.first[1], lang).map{|x| x.save!}
+end
+
+def en_yml
+"""
+en:
+  printer: Printer Friendly
+  comments: Comments
+  read_more: Read more
+  phrase: This is a rare phrase with non ascii chars
+
+  section1:
+    printer: Another printer
+
+  blacklist:
+    black_p1: A forbidden phrase
+
+  missings:
+    p1: Missing one
+    p2: Missing two
+    black: A one blacklisted
+  """
+end
+
+def import_en_yml
+"""
+en:
+  printer: A new printer phrase
+  new_stuff: Something brand new
+
+  section1:
+    printer: Other change
+  """
+end
+
+def load_integration_data
+  #en_yml =
+  es_yml = """
+es:
+  printer: Para imprimir
+  comments: Comentarios
+  read_more: Leer mas
+  phrase: Esta és una extraña frase con carácteres no ascii
+
+  section1:
+    printer: Otra impresora
+
+  blacklist:
+    black_p1: Una frase prohibida
+  """
+
+  file2db en_yml
+  file2db es_yml
+end
+
+def change_translation(scope, new_value)
+  bip_id = ""
+  within(scope) do
+    bip_id = page.all("span.best_in_place").first[:id]
+  end
+  bip_id = bip_id.scan(/translation_\d+/).first
+
+  bip_area bip_id, :value, new_value
+end
+
+def create_tmp_file(content)
+  file = Tempfile.new("interpret_test")
+  file.write(content)
+  path = file.path
+  file.close
+  path
+end

data/test_app/Gemfile

@@ -6,7 +6,7 @@ gem 'capistrano'
 
 group :development, :test do
   gem 'sqlite3-ruby', :require => 'sqlite3'
-  gem 'ruby-debug'
 end
 
 gem 'interpret', :path => ".."
+gem 'mysql2', "~> 0.2.7"

data/test_app/app/controllers/application_controller.rb

@@ -5,13 +5,11 @@ class ApplicationController < ActionController::Base
   before_filter :set_locale
 
   def current_user
-    session[:user_id] ? User.find(session[:user_id]) : User.where(:admin => true).first
+    session[:user_id] ? User.find(session[:user_id]) : User.first
   end
 
   def set_current_user
-    if params[:admin]
-      session[:user_id] = params[:admin] == "true" ? User.where(:admin => true).first : User.where(:admin => false).first
-    end
+    session[:user_id] = User.first
   end
 
   def toggle_edition_mode

data/test_app/app/models/interpret_ability.rb

@@ -0,0 +1,7 @@
+class InterpretAbility
+  include CanCan::Ability
+
+  def initialize(user)
+    can :manage, :all
+  end
+end