internetkassa 0.9.4

data/rails/init.rb

@@ -0,0 +1,4 @@
+require 'abn-amro/internetkassa'
+require 'abn-amro/internetkassa/helpers'
+
+ActionView::Base.send(:include, AbnAmro::Internetkassa::Helpers)

data/test/fixtures.rb

@@ -0,0 +1,74 @@
+RESPONSES = {
+  :succeeded => {
+    "CN"         => "Buyer name",
+    "BRAND"      => "iDEAL",
+    "orderID"    => "1235052040",
+    "PAYID"      => "3051611",
+    "ACCEPTANCE" => "0000000000",
+    "amount"     => "10",
+    "CARDNO"     => "11-XXXX-11",
+    "PM"         => "iDEAL",
+    "STATUS"     => "9",
+    "IP"         => "83.68.2.74",
+    "TRXDATE"    => "02/19/09",
+    "NCERROR"    => "0",
+    "ED"         => "",
+    "SHASIGN"    => "7537DD222E35EE9F9842921BD90C2CBFCFA59466",
+    "currency"   => "EUR"
+  },
+  
+  :failed => {
+    "CN"         => "",
+    "BRAND"      => "iDEAL",
+    "orderID"    => "1235052641",
+    "PAYID"      => "3051687",
+    "ACCEPTANCE" => "",
+    "amount"     => "10",
+    "CARDNO"     => "",
+    "PM"         => "iDEAL",
+    "STATUS"     => "2",
+    "IP"         => "83.68.2.74",
+    "TRXDATE"    => "02/19/09",
+    "NCERROR"    => "30001001",
+    "ED"         => "",
+    "SHASIGN"    => "BC9E821662DFD1EBC6E23BF044F6957796076B80",
+    "currency"   => "EUR"
+  },
+  
+  :cancelled => {
+    "CN" => "",
+    "BRAND" => "iDEAL",
+    "orderID" => "1235052559",
+    "PAYID" => "3051681",
+    "ACCEPTANCE" => "",
+    "amount" => "10",
+    "CARDNO" => "",
+    "PM" => "iDEAL",
+    "STATUS" => "2",
+    "IP" => "83.68.2.74",
+    "TRXDATE" => "02/19/09",
+    "NCERROR" => "30171001",
+    "ED" => "",
+    "SHASIGN" => "734AB5AD3033C46E1F69CBFB91EDD0AD34E7368D",
+    "currency" => "EUR"
+  },
+  
+  :exception => {
+    "CN"         => "",
+    "BRAND"      => "iDEAL",
+    "orderID"    => "1235052396",
+    "PAYID"      => "3051657",
+    "action"     => "index",
+    "ACCEPTANCE" => "",
+    "amount"     => "10",
+    "CARDNO"     => "",
+    "PM"         => "iDEAL",
+    "STATUS"     => "92",
+    "IP"         => "83.68.2.74",
+    "TRXDATE"    => "02/19/09",
+    "NCERROR"    => "20002001",
+    "ED"         => "",
+    "SHASIGN"    => "614F540CC51607DA44CB8D2403B8DF1781B9712C",
+    "currency"   => "EUR"
+  }
+}

data/test/helpers/fixtures_helper.rb

@@ -0,0 +1,7 @@
+module FixturesHelper
+  def fixture(name)
+    RESPONSES[name]
+  end
+end
+
+Test::Unit::TestCase.send(:include, FixturesHelper)

data/test/helpers/view_helper.rb

@@ -0,0 +1,19 @@
+require 'action_controller'
+require 'action_view'
+require 'action_view/test_case'
+
+class TestController
+  attr_accessor :output_buffer
+  
+  def initialize
+    @output_buffer = ''
+  end
+  
+  def url_for(options)
+    "http://www.example.com"
+  end
+  
+  def protect_against_forgery?
+    false
+  end
+end

data/test/helpers_test.rb

@@ -0,0 +1,45 @@
+require File.expand_path('../test_helper', __FILE__)
+
+describe "AbnAmro::Internetkassa::Helpers", ActionView::TestCase do
+  tests AbnAmro::Internetkassa::Helpers
+  
+  before do
+    @controller = TestController.new
+    
+    @instance = AbnAmro::Internetkassa.new(
+      :order_id => 123,
+      :amount => 1000,
+      :description => "HappyHardcore vol. 123 - the ballads",
+      :endpoint_url => "http://example.com/payments",
+      :TITLE => 'HappyHardcore vol. 123 - the ballads'
+    )
+    
+    # make sure we don't get bitten by sorting
+    ordered_data = @instance.data.to_a
+    @instance.stubs(:data).returns(ordered_data)
+  end
+  
+  it "should create a form tag with the AbnAmro::Internetkassa.service_url as its action" do
+    expected = %{<form action="#{AbnAmro::Internetkassa.service_url}" method="post">}
+    internetkassa_form_tag(@instance)[0..expected.length-1].should == expected
+  end
+  
+  it "should create a form with data from a AbnAmro::Internetkassa instance and yield" do
+    internetkassa_form_tag(@instance) { concat submit_tag('Betaal') }
+    
+    expected = [%{<form action="#{AbnAmro::Internetkassa.service_url}" method="post">}]
+    @instance.data.each do |name, value|
+      expected << %{<input name="#{name}" type="hidden" value="#{value}" />}
+    end
+    expected << %{<input name="commit" type="submit" value="Betaal" />}
+    expected << "</form>"
+    
+    assert_dom_equal expected.join("\n"), output_buffer
+  end
+  
+  private
+  
+  def method_missing(method, *args, &block)
+    @controller.send(method, *args, &block)
+  end
+end

data/test/internetkassa_remote_test.rb

@@ -0,0 +1,57 @@
+require File.expand_path('../test_helper', __FILE__)
+
+require 'rest'
+require 'hpricot'
+
+describe "AbnAmro::Internetkassa, when remote testing" do
+  before do
+    @instance = AbnAmro::Internetkassa.new(
+      :order_id => Time.now.to_i.to_s,
+      :amount => 1000,
+      :description => "HappyHardcore vol. 123 - the ballads",
+      :TITLE => 'HappyHardcore vol. 123 - the ballads'
+    )
+  end
+  
+  it "should have the right data to make a successful POST request" do
+    response = post(AbnAmro::Internetkassa.service_url, @instance.data)
+    response.should.be.success
+    
+    parse_response(response).should == {
+      :beneficiary => 'Fingertips BV',
+      :order_id =>    @instance.order_id,
+      :amount =>      '10.00 EUR',
+      :title =>       'HappyHardcore vol. 123 - the ballads'
+    }
+  end
+  
+  private
+  
+  def post(uri, values)
+    body = values.map { |k,v| "#{k}=#{v.to_s.gsub(' ', '%20')}" }.join('&')
+    REST.post(uri, body)
+  end
+  
+  def parse_response(response)
+    results = {}
+    
+    doc = Hpricot(response.body)
+    (doc / '#ncol_ref' / 'tr').each do |row|
+      cols = (row / 'td')
+      
+      key = case cols.first.inner_text
+      when /Ordernummer/
+        :order_id
+      when /Totaalbedrag/
+        :amount
+      when /Begunstigde/
+        :beneficiary
+      end
+      
+      results[key] = cols.last.inner_text.strip
+    end
+    
+    results[:title] = (doc / 'title').inner_text.strip
+    results
+  end
+end

data/test/internetkassa_test.rb

@@ -0,0 +1,151 @@
+require File.expand_path('../test_helper', __FILE__)
+
+describe "AbnAmro::Internetkassa, class methods" do
+  it "should return whether or not it's in test mode" do
+    assert AbnAmro::Internetkassa.test?
+  end
+  
+  it "should return the PSPID with #pspid or its aliased handsome cousin #merchant_id" do
+    AbnAmro::Internetkassa.pspid.should == 'fingertips'
+    AbnAmro::Internetkassa.merchant_id.should == 'fingertips'
+  end
+  
+  it "should return the passphrase used to sign the messages to the payment server" do
+    AbnAmro::Internetkassa.shasign.should == 'supersecret'
+    AbnAmro::Internetkassa.passphrase.should == 'supersecret'
+  end
+  
+  it "should have the correct service_urls" do
+    AbnAmro::Internetkassa::TEST_URL.should ==
+      "https://internetkassa.abnamro.nl/ncol/test/orderstandard.asp"
+    
+    AbnAmro::Internetkassa::PRODUCTION_URL.should ==
+      "https://internetkassa.abnamro.nl/ncol/prod/orderstandard.asp"
+  end
+  
+  it "should return the service_url for the current environment" do
+    begin
+      AbnAmro::Internetkassa.test = true
+      AbnAmro::Internetkassa.service_url.should ==
+        AbnAmro::Internetkassa::TEST_URL
+      
+      AbnAmro::Internetkassa.test = false
+      AbnAmro::Internetkassa.service_url.should ==
+        AbnAmro::Internetkassa::PRODUCTION_URL
+    ensure
+      AbnAmro::Internetkassa.test = true
+    end
+  end
+end
+
+describe "AbnAmro::Internetkassa, an instance" do
+  before do
+    @valid_attributes = {
+      :order_id => 123,
+      :amount => 1000,
+      :description => "HappyHardcore vol. 123 - the ballads",
+      :endpoint_url => "http://example.com/payments",
+      :url_variable => ":id",
+      :endpoint_params => [[:session_id, 'abcde12345'], [:message, '“Thanks for your purchase”']]
+    }
+    @instance = AbnAmro::Internetkassa.new(@valid_attributes)
+  end
+  
+  it "should have assigned the constructor arguments" do
+    @instance.order_id.should    == 123
+    @instance.amount.should      == 1000
+    @instance.description.should == "HappyHardcore vol. 123 - the ballads"
+  end
+  
+  it "should have used the endpoint_url shortcut to set all endpoint urls" do
+    @instance.accept_url.should    == "http://example.com/payments"
+    @instance.decline_url.should   == "http://example.com/payments"
+    @instance.exception_url.should == "http://example.com/payments"
+    @instance.cancel_url.should    == "http://example.com/payments"
+  end
+  
+  it "should have merged default values" do
+    @instance.currency.should == 'EUR'
+    @instance.language.should == 'nl_NL'
+  end
+  
+  it "should return the url_variable" do
+    @instance.url_variable.should == ":id"
+  end
+  
+  it "should return the extra params" do
+    @instance.endpoint_params.should == [[:session_id, 'abcde12345'], [:message, '“Thanks for your purchase”']]
+  end
+  
+  it "should have access to the pspid/merchant_id" do
+    @instance.send(:merchant_id).should == AbnAmro::Internetkassa.merchant_id
+  end
+  
+  it "should have access to the shasign/passphrase" do
+    @instance.send(:passphrase).should == AbnAmro::Internetkassa.passphrase
+  end
+  
+  it "should verify that the mandatory values are specified or raise an ArgumentError" do
+    %w{ merchant_id order_id amount currency language }.each do |key|
+      instance = AbnAmro::Internetkassa.new(@valid_attributes)
+      instance.stubs(key).returns(nil)
+      lambda { instance.send(:verify_values!) }.should.raise ArgumentError
+    end
+  end
+  
+  it "should create a SHA1 signature for the message" do
+    message = "#{@instance.order_id}#{@instance.amount}#{@instance.currency}#{AbnAmro::Internetkassa.merchant_id}#{AbnAmro::Internetkassa.passphrase}"
+    @instance.send(:signature).should == Digest::SHA1.hexdigest(message).upcase
+  end
+  
+  it "should return the key-value pairs that should be POSTed, according to the Internetkassa specs" do
+    @instance.data.should == {
+      :PSPID        => AbnAmro::Internetkassa.merchant_id,
+      :orderID      => @instance.order_id,
+      :amount       => @instance.amount,
+      :currency     => @instance.currency,
+      :language     => @instance.language,
+      :COM          => @instance.description,
+      :SHASign      => @instance.send(:signature),
+      :PARAMVAR     => @instance.url_variable,
+      :PARAMPLUS    => "session_id=abcde12345&message=%E2%80%9CThanks+for+your+purchase%E2%80%9D",
+      :accepturl    => @valid_attributes[:endpoint_url],
+      :declineurl   => @valid_attributes[:endpoint_url],
+      :exceptionurl => @valid_attributes[:endpoint_url],
+      :cancelurl    => @valid_attributes[:endpoint_url]
+    }
+  end
+  
+  it "should check if all mandatory values are specified before returning the `data'" do
+    @instance.expects(:verify_values!)
+    @instance.data
+  end
+  
+  it "should merge any optional arguments with the data" do
+    @valid_attributes[:TITLE] = 'My Transaction'
+    AbnAmro::Internetkassa.new(@valid_attributes).data.should == {
+      :PSPID        => AbnAmro::Internetkassa.merchant_id,
+      :orderID      => @instance.order_id,
+      :amount       => @instance.amount,
+      :currency     => @instance.currency,
+      :language     => @instance.language,
+      :COM          => @instance.description,
+      :SHASign      => @instance.send(:signature),
+      :PARAMVAR     => @instance.url_variable,
+      :PARAMPLUS    => "session_id=abcde12345&message=%E2%80%9CThanks+for+your+purchase%E2%80%9D",
+      :accepturl    => @valid_attributes[:endpoint_url],
+      :declineurl   => @valid_attributes[:endpoint_url],
+      :exceptionurl => @valid_attributes[:endpoint_url],
+      :cancelurl    => @valid_attributes[:endpoint_url],
+      :TITLE        => 'My Transaction'
+    }
+  end
+  
+  it "should not return blank values in the `data'" do
+    @instance.url_variable = nil
+    @instance.data.should.not.has_key :PARAMVAR
+    
+    @instance.url_variable = ''
+    @instance.data.should.not.has_key :PARAMVAR
+  end
+end

data/test/response_regression_test.rb

@@ -0,0 +1,32 @@
+require File.expand_path('../test_helper', __FILE__)
+
+describe "AbnAmro::Internetkassa::Response, regression tests" do
+  before do
+    AbnAmro::Internetkassa::Response.any_instance.stubs(:valid?).returns(true)
+    @response = AbnAmro::Internetkassa::Response.new({})
+  end
+  
+  it "should be retryable" do
+    retry_codes = AbnAmro::Internetkassa::Response::Codes::ERROR_CODES.select { |_,h| h[:retry] }
+    retry_codes.should.not.be.empty
+    
+    retry_all = retry_codes.all? do |code, _|
+      @response.stubs(:error_code).returns(code)
+      @response.retry?
+    end
+    
+    retry_all.should.be true
+  end
+  
+  it "should not be retryable" do
+    dont_retry_codes = AbnAmro::Internetkassa::Response::Codes::ERROR_CODES.select { |_,h| !h[:retry] }
+    dont_retry_codes.should.not.be.empty
+    
+    dont_retry_any = dont_retry_codes.all? do |code, _|
+      @response.stubs(:error_code).returns(code)
+      @response.retry? == false
+    end
+    
+    dont_retry_any.should.be true
+  end
+end

data/test/response_test.rb

@@ -0,0 +1,185 @@
+require File.expand_path('../test_helper', __FILE__)
+
+describe "AbnAmro::Internetkassa::Response, in general" do
+  before do
+    @response = AbnAmro::Internetkassa::Response.new(fixture(:succeeded))
+  end
+  
+  it "should return the raw params" do
+    @response.params.should == fixture(:succeeded)
+  end
+  
+  it "should return whether or not the transaction was authorized" do
+    @response.stubs(:status_code).returns('5')
+    @response.should.be.authorized
+    
+    @response.stubs(:status_code).returns('9')
+    @response.should.not.be.authorized
+  end
+  
+  it "should return whether or not the transaction was captured" do
+    @response.stubs(:status_code).returns('9')
+    @response.should.be.captured
+    
+    @response.stubs(:status_code).returns('5')
+    @response.should.not.be.captured
+  end
+  
+  it "should return the essential attributes" do
+    @response.order_id.should       == '1235052040'
+    @response.payment_id.should     == '3051611'
+    @response.payment_method.should == 'iDEAL'
+    @response.acceptance.should     == '0000000000'
+    @response.status_code.should    == '9'
+    @response.signature.should      == '7537DD222E35EE9F9842921BD90C2CBFCFA59466'
+    @response.currency.should       == 'EUR'
+  end
+  
+  it "should return the optional attributes" do
+    @response.customer_name.should        == 'Buyer name'
+    @response.card_number.should          == '11-XXXX-11'
+    @response.card_brand.should           == 'iDEAL'
+    @response.card_expiration_date.should == ''
+  end
+  
+  it "should return the amount in cents" do
+    @response.instance_variable_set(:@params, 'amount' => '10')
+    @response.amount.should == 1000
+  end
+  
+  it "should return the amount with decimals in cents" do
+    @response.instance_variable_set(:@params, 'amount' => '10.31')
+    @response.amount.should == 1031
+  end
+  
+  it "should return the transaction date as a Date instance" do
+    @response.transaction_date.should == Date.parse('02/19/2009')
+  end
+  
+  it "should create a SHA1 signature for the message" do
+    message =  @response.order_id
+    message += @response.currency
+    message += @response.params['amount']
+    message += @response.payment_method
+    message += @response.acceptance
+    message += @response.status_code
+    message += @response.card_number
+    message += @response.payment_id
+    message += @response.params['NCERROR']
+    message += @response.card_brand
+    
+    message += AbnAmro::Internetkassa.passphrase
+    
+    @response.send(:calculated_signature).should == Digest::SHA1.hexdigest(message).upcase
+  end
+  
+  it "should return that the signature matches the calculated_signature" do
+    @response.should.be.valid
+  end
+  
+  it "should return that the signature does NOT match the calculated_signature" do
+    @response.stubs(:signature).returns('NOT A VALID SHA1 SIGNATURE')
+    @response.should.not.be.valid
+  end
+  
+  it "should raise a SignatureInvalidError if initializing a response and the signature does not match the calculated_signature" do
+    params = fixture(:succeeded).dup
+    params['SHASIGN'] = 'NOT A VALID SHA1 SIGNATURE'
+    
+    lambda {
+      AbnAmro::Internetkassa::Response.new(params)
+    }.should.raise AbnAmro::Internetkassa::Response::SignatureInvalidError
+  end
+  
+  it "should return the message for the status code" do
+    @response.status_message.should == 'Payment requested'
+  end
+end
+
+describe "AbnAmro::Internetkassa::Response, with a successful payment" do
+  before do
+    @response = AbnAmro::Internetkassa::Response.new(fixture(:succeeded))
+  end
+  
+  it "should be successful" do
+    @response.should.be.success
+  end
+  
+  it "should not be retryable" do
+    @response.should.not.retry
+  end
+  
+  it "should return `nil' as the error code" do
+    @response.error_code.should.be nil
+  end
+  
+  it "should return `nil' as the error message" do
+    @response.error_message.should.be nil
+  end
+end
+
+describe "AbnAmro::Internetkassa::Response, with a failed payment" do
+  before do
+    @response = AbnAmro::Internetkassa::Response.new(fixture(:failed))
+  end
+  
+  it "should not be successful" do
+    @response.should.not.be.success
+  end
+  
+  it "should not be retryable" do
+    @response.should.not.retry
+  end
+  
+  it "should return the error code" do
+    @response.error_code.should == "30001001"
+  end
+  
+  it "should return the error message" do
+    @response.error_message.should == "Payment refused by the acquirer"
+  end
+end
+
+describe "AbnAmro::Internetkassa::Response, with a cancelled payment" do
+  before do
+    @response = AbnAmro::Internetkassa::Response.new(fixture(:cancelled))
+  end
+  
+  it "should not be successful" do
+    @response.should.not.be.success
+  end
+  
+  it "should not be retryable" do
+    @response.should.not.retry
+  end
+  
+  it "should return the error code" do
+    @response.error_code.should == "30171001"
+  end
+  
+  it "should return the error message" do
+    @response.error_message.should == "Payment method cancelled by the buyer"
+  end
+end
+
+describe "AbnAmro::Internetkassa::Response, when an exception occurred" do
+  before do
+    @response = AbnAmro::Internetkassa::Response.new(fixture(:exception))
+  end
+  
+  it "should not be successful" do
+    @response.should.not.be.success
+  end
+  
+  it "should not be retryable" do
+    @response.should.not.retry
+  end
+  
+  it "should return the error code" do
+    @response.error_code.should == "20002001"
+  end
+  
+  it "should return the error message" do
+    @response.error_message.should == "Origin for the response of the bank can not be checked"
+  end
+end