interferon 0.1.0 → 0.1.3

data/spec/lib/interferon_spec.rb

@@ -5,60 +5,73 @@ require 'interferon/destinations/datadog'
 include Interferon
 
 describe Interferon::Interferon do
+  let(:the_existing_alerts) { mock_existing_alerts }
+  let(:dest) { MockDest.new(the_existing_alerts) }
 
-  let(:the_existing_alerts) {mock_existing_alerts}
-  let(:dest) {MockDest.new(the_existing_alerts)}
-
-  context "when checking alerts have changed" do
-    it "detects a change if alert message is different" do
+  context 'when checking alerts have changed' do
+    it 'detects a change if alert message is different' do
       alert1 = create_test_alert('name1', 'testquery', 'message1')
       alert2 = mock_alert_json('name2', 'testquery', 'message2')
 
       expect(Interferon::Interferon.same_alerts(dest, [alert1, []], alert2)).to be false
     end
 
-    it "detects a change if datadog query is different" do
+    it 'detects a change if datadog query is different' do
       alert1 = create_test_alert('name1', 'testquery1', 'message1')
       alert2 = mock_alert_json('name2', 'testquery2', 'message2')
 
       expect(Interferon::Interferon.same_alerts(dest, [alert1, []], alert2)).to be false
     end
 
-    it "detects a change if alert notify_no_data is different" do
-      alert1 = create_test_alert('name1', 'testquery1', 'message1', { :notify_no_data => false })
+    it 'detects a change if alert notify_no_data is different' do
+      alert1 = create_test_alert('name1', 'testquery1', 'message1', notify_no_data: false)
+      alert2 = mock_alert_json('name2', 'testquery2', 'message2', nil, [1], notify_no_data: true)
+
+      expect(Interferon::Interferon.same_alerts(dest, [alert1, []], alert2)).to be false
+    end
+
+    it 'detects a change if alert silenced is different' do
+      alert1 = create_test_alert('name1', 'testquery1', 'message1', silenced: true)
+      alert2 = mock_alert_json('name2', 'testquery2', 'message2', nil, [1], silenced: {})
+
+      expect(Interferon::Interferon.same_alerts(dest, [alert1, []], alert2)).to be false
+    end
+
+    it 'detects a change if alert no_data_timeframe is different' do
+      alert1 = create_test_alert('name1', 'testquery1', 'message1', no_data_timeframe: nil)
+      alert2 = mock_alert_json('name2', 'testquery2', 'message2', nil, [1], no_data_timeframe: 60)
+
+      expect(Interferon::Interferon.same_alerts(dest, [alert1, []], alert2)).to be false
+    end
+
+    it 'detects a change if alert require_full_window is different' do
+      alert1 = create_test_alert('name1', 'testquery1', 'message1', require_full_window: false)
       alert2 = mock_alert_json(
-        'name2',
-        'testquery2',
-        'message2',
-        nil,
-        [1],
-        { :notify_no_data => true }
+        'name2', 'testquery2', 'message2', nil, [1], require_full_window: true
       )
 
       expect(Interferon::Interferon.same_alerts(dest, [alert1, []], alert2)).to be false
     end
 
-    it "detects a change if alert silenced is different" do
-      alert1 = create_test_alert('name1', 'testquery1', 'message1', { :silenced => true })
-      alert2 = mock_alert_json('name2', 'testquery2', 'message2', nil, [1], { :silenced => {} })
+    it 'detects a change if alert evaluation_delay is different' do
+      alert1 = create_test_alert('name1', 'testquery1', 'message1', evaluation_delay: nil)
+      alert2 = mock_alert_json('name2', 'testquery2', 'message2', nil, [1], evaluation_delay: 300)
 
       expect(Interferon::Interferon.same_alerts(dest, [alert1, []], alert2)).to be false
     end
 
-    it "does not detect a change when alert datadog query and message are the same" do
+    it 'does not detect a change when alert datadog query and message are the same' do
       alert1 = create_test_alert('name1', 'testquery1', 'message1')
       alert2 = mock_alert_json(
-        'name1',
-        'testquery1',
-        "message1\nThis alert was created via the alerts framework"
+        'name1', 'testquery1', "message1\nThis alert was created via the alerts framework"
       )
 
       expect(Interferon::Interferon.same_alerts(dest, [alert1, []], alert2)).to be true
     end
   end
 
-  context "dry_run_update_alerts_on_destination" do
-    let(:interferon) {Interferon::Interferon.new(nil,nil,nil,nil,true,0)}
+  context 'dry_run_update_alerts_on_destination' do
+    let(:interferon) { Interferon::Interferon.new(nil, nil, nil, nil, true, 0) }
 
     before do
       allow_any_instance_of(MockAlert).to receive(:evaluate)
@@ -73,10 +86,7 @@ describe Interferon::Interferon do
       expect(dest).not_to receive(:remove_alert_by_id)
 
       interferon.update_alerts_on_destination(
-        dest,
-        ['host'],
-        [alerts['name1'], alerts['name2']],
-        {}
+        dest, ['host'], [alerts['name1'], alerts['name2']], {}
       )
     end
 
@@ -87,10 +97,7 @@ describe Interferon::Interferon do
       expect(dest).to receive(:remove_alert_by_id).with('3').once
 
       interferon.update_alerts_on_destination(
-        dest,
-        ['host'],
-        [alerts['name1'], alerts['name2'], added],
-        {}
+        dest, ['host'], [alerts['name1'], alerts['name2'], added], {}
       )
     end
 
@@ -111,7 +118,7 @@ describe Interferon::Interferon do
     it 'deletes duplicate old alerts' do
       alert1 = mock_alert_json('name1', 'testquery1', '', nil, [1, 2, 3])
       alert2 = mock_alert_json('name2', 'testquery2', '')
-      existing_alerts = {'name1' => alert1, 'name2' => alert2}
+      existing_alerts = { 'name1' => alert1, 'name2' => alert2 }
       dest = MockDest.new(existing_alerts)
       allow(dest).to receive(:remove_alert)
       allow(dest).to receive(:remove_alert_by_id)
@@ -126,7 +133,7 @@ describe Interferon::Interferon do
     it 'deletes duplicate old alerts when creating new alert' do
       alert1 = mock_alert_json('name1', 'testquery1', '', nil, [1, 2, 3])
       alert2 = mock_alert_json('name2', 'testquery2', '')
-      existing_alerts = {'name1' => alert1, 'name2' => alert2}
+      existing_alerts = { 'name1' => alert1, 'name2' => alert2 }
       dest = MockDest.new(existing_alerts)
       allow(dest).to receive(:remove_alert)
       allow(dest).to receive(:remove_alert_by_id)
@@ -143,8 +150,8 @@ describe Interferon::Interferon do
     end
   end
 
-  context "update_alerts_on_destination" do
-    let(:interferon) {Interferon::Interferon.new(nil,nil,nil,nil,false,0)}
+  context 'update_alerts_on_destination' do
+    let(:interferon) { Interferon::Interferon.new(nil, nil, nil, nil, false, 0) }
 
     before do
       allow_any_instance_of(MockAlert).to receive(:evaluate)
@@ -158,7 +165,9 @@ describe Interferon::Interferon do
       expect(dest).not_to receive(:create_alert)
       expect(dest).not_to receive(:remove_alert_by_id)
 
-      interferon.update_alerts_on_destination(dest, ['host'], [alerts['name1'], alerts['name2']], {})
+      interferon.update_alerts_on_destination(
+        dest, ['host'], [alerts['name1'], alerts['name2']], {}
+      )
     end
 
     it 'runs added alerts' do
@@ -168,10 +177,7 @@ describe Interferon::Interferon do
       expect(dest).not_to receive(:remove_alert_by_id).with('3')
 
       interferon.update_alerts_on_destination(
-        dest,
-        ['host'],
-        [alerts['name1'], alerts['name2'], added],
-        {}
+        dest, ['host'], [alerts['name1'], alerts['name2'], added], {}
       )
     end
 
@@ -194,7 +200,7 @@ describe Interferon::Interferon do
     it 'deletes duplicate old alerts' do
       alert1 = mock_alert_json('name1', 'testquery1', '', nil, [1, 2, 3])
       alert2 = mock_alert_json('name2', 'testquery2', '')
-      existing_alerts = {'name1' => alert1, 'name2' => alert2}
+      existing_alerts = { 'name1' => alert1, 'name2' => alert2 }
       dest = MockDest.new(existing_alerts)
       allow(dest).to receive(:remove_alert)
       allow(dest).to receive(:remove_alert_by_id)
@@ -209,19 +215,15 @@ describe Interferon::Interferon do
     it 'deletes duplicate old alerts when creating new alert' do
       alert1 = mock_alert_json('name1', 'testquery1', '', nil, [1, 2, 3])
       alert2 = mock_alert_json('name2', 'testquery2', '')
-      existing_alerts = {'name1' => alert1, 'name2' => alert2}
+      existing_alerts = { 'name1' => alert1, 'name2' => alert2 }
       dest = MockDest.new(existing_alerts)
       allow(dest).to receive(:report_stats)
 
       added = create_test_alert('name1', 'testquery1', '')
 
-      expect(dest).to receive(:remove_alert).with(mock_alert_json(
-        'name1',
-        'testquery1',
-        '',
-        nil,
-        [2, 3]
-      ))
+      expect(dest).to receive(:remove_alert).with(
+        mock_alert_json('name1', 'testquery1', '', nil, [2, 3])
+      )
       expect(dest).to receive(:remove_alert).with(existing_alerts['name2'])
 
       interferon.update_alerts_on_destination(dest, ['host'], [added], {})
@@ -231,26 +233,25 @@ describe Interferon::Interferon do
   def mock_existing_alerts
     alert1 = mock_alert_json('name1', 'testquery1', '')
     alert2 = mock_alert_json('name2', 'testquery2', '')
-    {'name1' => alert1, 'name2' => alert2}
+    { 'name1' => alert1, 'name2' => alert2 }
   end
 
   class MockDest < Interferon::Destinations::Datadog
+    attr_reader :existing_alerts
+
     def initialize(the_existing_alerts)
       @existing_alerts = the_existing_alerts
     end
 
-    def create_alert(alert, people)
+    def create_alert(alert, _people)
       name = alert['name']
       id = [alert['name'][-1]]
       [name, id]
     end
-
-    def existing_alerts
-      @existing_alerts
-    end
   end
 
   DEFAULT_OPTIONS = {
+    'evaluation_delay' => nil,
     'notify_audit' => true,
     'notify_no_data' => false,
     'silenced' => {},
@@ -258,13 +259,13 @@ describe Interferon::Interferon do
     'no_data_timeframe' => nil,
     'require_full_window' => nil,
     'timeout' => nil,
-  }
+  }.freeze
 
-  def mock_alert_json(name, datadog_query, message, type="metric alert", id=nil, options={})
+  def mock_alert_json(name, datadog_query, message, type = 'metric alert', id = nil, options = {})
     options = DEFAULT_OPTIONS.merge(options)
 
     {
-      'name'=> name,
+      'name' => name,
       'query' => datadog_query,
       'type' => type,
       'message' => message,
@@ -273,7 +274,7 @@ describe Interferon::Interferon do
     }
   end
 
-  def create_test_alert(name, datadog_query, message, options={})
+  def create_test_alert(name, datadog_query, message, options = {})
     options = DEFAULT_OPTIONS.merge(options)
 
     alert_dsl = AlertDSL.new({})
@@ -292,6 +293,7 @@ describe Interferon::Interferon do
 
     alert_dsl.no_data_timeframe(options['no_data_timeframe'])
     alert_dsl.notify_no_data(options['notify_no_data'])
+    alert_dsl.evaluation_delay(options['evaluation_delay'])
     alert_dsl.require_full_window(options['require_full_window'])
     alert_dsl.thresholds(options['thresholds'])
     alert_dsl.timeout(options['timeout'])

data/spec/lib/work_hours_helper_spec.rb

@@ -1,39 +1,39 @@
-require "spec_helper"
-require "interferon/work_hours_helper"
+require 'spec_helper'
+require 'interferon/work_hours_helper'
 
 describe Interferon::WorkHoursHelper do
   subject { described_class }
 
-  describe ".now_is_work_hour?" do
-    context "when it is a work hour in a work day" do
-      it "return true" do
+  describe '.now_is_work_hour?' do
+    context 'when it is a work hour in a work day' do
+      it 'return true' do
         expect(subject.is_work_hour?(
-          Time.parse("Mon Nov 26 9:01:20 PST 2001").utc
+                 Time.parse('Mon Nov 26 9:01:20 PST 2001').utc
         )).to be_truthy
         expect(subject.is_work_hour?(
-          Time.parse("Fri Nov 30 16:35:20 PST 2001").utc
+                 Time.parse('Fri Nov 30 16:35:20 PST 2001').utc
         )).to be_truthy
       end
     end
 
-    context "when it is a work hour in a weekend" do
-      it "return false" do
+    context 'when it is a work hour in a weekend' do
+      it 'return false' do
         expect(subject.is_work_hour?(
-          Time.parse("Sat Nov 24 09:01:20 PST 2001").utc
+                 Time.parse('Sat Nov 24 09:01:20 PST 2001').utc
         )).to be_falsy
         expect(subject.is_work_hour?(
-          Time.parse("Sun Nov 25 09:01:20 PST 2001").utc
+                 Time.parse('Sun Nov 25 09:01:20 PST 2001').utc
         )).to be_falsy
       end
     end
 
-    context "when it is not a work hour" do
-      it "return false" do
+    context 'when it is not a work hour' do
+      it 'return false' do
         expect(subject.is_work_hour?(
-          Time.parse("Thu Nov 29 08:33:20 PST 2001").utc
+                 Time.parse('Thu Nov 29 08:33:20 PST 2001').utc
         )).to be_falsy
         expect(subject.is_work_hour?(
-          Time.parse("Fri Nov 30 17:33:20 PST 2001").utc
+                 Time.parse('Fri Nov 30 17:33:20 PST 2001').utc
         )).to be_falsy
       end
     end

data/spec/spec_helper.rb

@@ -7,7 +7,7 @@ require 'helpers/logging_helper.rb'
 # See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
 RSpec.configure do |config|
   config.expect_with :rspec do |expectations|
-      expectations.include_chain_clauses_in_custom_matcher_descriptions = true
+    expectations.include_chain_clauses_in_custom_matcher_descriptions = true
   end
 
   # rspec-mocks config goes here. You can use an alternate test double

metadata

@@ -1,8 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: interferon
 version: !ruby/object:Gem::Version
-  version: 0.1.0
-  prerelease: 
+  version: 0.1.3
 platform: ruby
 authors:
 - Igor Serebryany
@@ -10,189 +9,185 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-04-27 00:00:00.000000000 Z
+date: 2017-07-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dogapi
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.11'
-    - - ! '>='
+        version: '1.27'
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.11.1
+        version: 1.27.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.11'
-    - - ! '>='
+        version: '1.27'
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.11.1
+        version: 1.27.0
 - !ruby/object:Gem::Dependency
   name: aws-sdk
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.35'
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 1.35.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.35'
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 1.35.1
 - !ruby/object:Gem::Dependency
   name: dogstatsd-ruby
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.4'
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 1.4.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.4'
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 1.4.1
 - !ruby/object:Gem::Dependency
   name: diffy
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 3.1.0
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 3.1.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 3.1.0
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 3.1.0
 - !ruby/object:Gem::Dependency
   name: parallel
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.9'
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 1.9.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.9'
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 1.9.0
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - <
+    - - "<"
       - !ruby/object:Gem::Version
         version: 1.7.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - <
+    - - "<"
       - !ruby/object:Gem::Version
         version: 1.7.0
 - !ruby/object:Gem::Dependency
   name: tzinfo
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 1.2.2
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 1.2.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 1.2.2
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 1.2.2
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '3.2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '3.2'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0.10'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0.10'
-description: ': Store metrics alerts in code!'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 0.41.2
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 0.41.2
+description: ": Store metrics alerts in code!"
 email:
 - igor.serebryany@airbnb.com
 - jimmy.ngo@airbnb.com
@@ -201,8 +196,10 @@ executables:
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .travis.yml
+- ".gitignore"
+- ".rubocop.yml"
+- ".rubocop_todo.yml"
+- ".travis.yml"
 - Gemfile
 - LICENSE
 - README.md
@@ -246,28 +243,27 @@ files:
 homepage: https://www.github.com/airbnb/interferon
 licenses:
 - MIT
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.23.2
+rubygems_version: 2.5.2
 signing_key: 
-specification_version: 3
-summary: ': Store metrics alerts in code!'
+specification_version: 4
+summary: ": Store metrics alerts in code!"
 test_files:
 - spec/fixtures/loaders/host_sources/test_host_source.rb
 - spec/fixtures/loaders/test_sources/order_test_source.rb