interferon 0.0.2 → 0.0.3

data/lib/interferon/destinations/datadog.rb

@@ -103,41 +103,39 @@ module Interferon::Destinations
       end
 
       # log whenever we've encountered errors
-      if resp
-        code = resp[0].to_i
-
-        # client error
-        if code == 400
-          statsd.gauge('datadog.api.unknown_error', 0, :tags => ["alert:#{alert}"])
-          statsd.gauge('datadog.api.client_error', 1, :tags => ["alert:#{alert}"])
-          statsd.gauge('datadog.api.success', 0, :tags => ["alert:#{alert}"])
-
-          @stats[:api_client_errors] += 1
-          log.error("client error while #{action} alert '#{alert['name']}';" \
-              " query was '#{alert['metric']['datadog_query'].strip}'")
-
-        # unknown (prob. datadog) error:
-        elsif code >= 400 || code == -1
-          statsd.gauge('datadog.api.unknown_error', 1, :tags => ["alert:#{alert}"])
-          statsd.gauge('datadog.api.client_error', 0, :tags => ["alert:#{alert}"])
-          statsd.gauge('datadog.api.success', 0, :tags => ["alert:#{alert}"])
-
-          @stats[:api_unknown_errors] += 1
-          log.error("unknown error while #{action} alert '#{alert['name']}':" \
-              " query was '#{alert['metric']['datadog_query'].strip}'" \
-              " response was #{resp[0]}:'#{resp[1].inspect}'")
-
-        # assume this was a success
-        else
-          statsd.gauge('datadog.api.unknown_error', 0, :tags => ["alert:#{alert}"])
-          statsd.gauge('datadog.api.client_error', 0, :tags => ["alert:#{alert}"])
-          statsd.gauge('datadog.api.success', 1, :tags => ["alert:#{alert}"])
-
-          @stats[:api_successes] += 1
-          @stats[:alerts_created] += 1 if action == :creating
-          @stats[:alerts_updated] += 1 if action == :updating
-          @stats[:alerts_silenced] += 1 if alert_opts[:silenced]
-        end
+      code = @dry_run ? 200 : resp[0].to_i
+
+      # client error
+      if code == 400
+        statsd.gauge('datadog.api.unknown_error', 0, :tags => ["alert:#{alert}"])
+        statsd.gauge('datadog.api.client_error', 1, :tags => ["alert:#{alert}"])
+        statsd.gauge('datadog.api.success', 0, :tags => ["alert:#{alert}"])
+
+        @stats[:api_client_errors] += 1
+        log.error("client error while #{action} alert '#{alert['name']}';" \
+            " query was '#{alert['metric']['datadog_query'].strip}'")
+
+      # unknown (prob. datadog) error:
+      elsif code >= 400 || code == -1
+        statsd.gauge('datadog.api.unknown_error', 1, :tags => ["alert:#{alert}"])
+        statsd.gauge('datadog.api.client_error', 0, :tags => ["alert:#{alert}"])
+        statsd.gauge('datadog.api.success', 0, :tags => ["alert:#{alert}"])
+
+        @stats[:api_unknown_errors] += 1
+        log.error("unknown error while #{action} alert '#{alert['name']}':" \
+            " query was '#{alert['metric']['datadog_query'].strip}'" \
+            " response was #{resp[0]}:'#{resp[1].inspect}'")
+
+      # assume this was a success
+      else
+        statsd.gauge('datadog.api.unknown_error', 0, :tags => ["alert:#{alert}"])
+        statsd.gauge('datadog.api.client_error', 0, :tags => ["alert:#{alert}"])
+        statsd.gauge('datadog.api.success', 1, :tags => ["alert:#{alert}"])
+
+        @stats[:api_successes] += 1
+        @stats[:alerts_created] += 1 if action == :creating
+        @stats[:alerts_updated] += 1 if action == :updating
+        @stats[:alerts_silenced] += 1 if alert_opts[:silenced]
       end
 
       # lets key alerts by their name

data/lib/interferon/version.rb

@@ -1,3 +1,3 @@
 module Interferon
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: interferon
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-07 00:00:00.000000000 Z
+date: 2015-05-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dogapi