interferon 0.0.12 → 0.0.19

data/spec/lib/interferon_spec.rb

@@ -6,87 +6,232 @@ require 'interferon/destinations/datadog'
 include Interferon
 
 describe Interferon::Interferon do
-  it "would not be dry run if only alert message changed" do
-    alert1 = create_test_alert('name1', 'testquery', 'message1')
-    alert2 = mock_alert_json('name2', 'testquery', 'message2')
 
-    expect(Interferon::Interferon.same_alerts_for_dry_run_purpose(alert1, alert2)).to be true
-  end
+  let(:the_existing_alerts) {mock_existing_alerts}
+  let(:dest) {MockDest.new(the_existing_alerts)}
+
+  context "when checking alerts have changed" do
+    it "detects a change if alert message is different" do
+      alert1 = create_test_alert('name1', 'testquery', 'message1')
+      alert2 = mock_alert_json('name2', 'testquery', 'message2')
+
+      expect(Interferon::Interferon.same_alerts(dest, [alert1, []], alert2)).to be false
+    end
+
+    it "detects a change if datadog query is different" do
+      alert1 = create_test_alert('name1', 'testquery1', 'message1')
+      alert2 = mock_alert_json('name2', 'testquery2', 'message2')
 
-  it "would be dry run if alert datadog query changed" do
-    alert1 = create_test_alert('name1', 'testquery1', 'message1')
-    alert2 = mock_alert_json('name2', 'testquery2', 'message2')
+      expect(Interferon::Interferon.same_alerts(dest, [alert1, []], alert2)).to be false
+    end
 
-    expect(Interferon::Interferon.same_alerts_for_dry_run_purpose(alert1, alert2)).to be false
+    it "detects a change if alert notify_no_data is different" do
+      alert1 = create_test_alert('name1', 'testquery1', 'message1', false)
+      alert2 = mock_alert_json('name2', 'testquery2', 'message2', true)
+
+      expect(Interferon::Interferon.same_alerts(dest, [alert1, []], alert2)).to be false
+    end
+
+    it "detects a change if alert silenced is different" do
+      alert1 = create_test_alert('name1', 'testquery1', 'message1', false, true)
+      alert2 = mock_alert_json('name2', 'testquery2', 'message2', false, false)
+
+      expect(Interferon::Interferon.same_alerts(dest, [alert1, []], alert2)).to be false
+    end
+
+    it "does not detect a change when alert datadog query and message are the same" do
+      alert1 = create_test_alert('name1', 'testquery1', 'message1')
+      alert2 = mock_alert_json('name1', 'testquery1', "message1\nThis alert was created via the alerts framework")
+
+      expect(Interferon::Interferon.same_alerts(dest, [alert1, []], alert2)).to be true
+    end
   end
 
   context "dry_run_update_alerts_on_destination" do
-    let(:the_existing_alerts) {mock_existing_alerts}
-    let(:dest) {MockDest.new(the_existing_alerts)}
+    let(:interferon) {Interferon::Interferon.new(nil,nil,nil,nil,true,0)}
+
     before do
       allow_any_instance_of(MockAlert).to receive(:evaluate)
+      allow(dest).to receive(:remove_alert)
       allow(dest).to receive(:remove_alert_by_id)
       allow(dest).to receive(:report_stats)
     end
 
-    it 'dry run does not re-run existing alerts' do
+    it 'does not re-run existing alerts' do
       alerts = mock_existing_alerts
-      interferon = Interferon::Interferon.new(nil,nil,nil,nil)
       expect(dest).not_to receive(:create_alert)
       expect(dest).not_to receive(:remove_alert_by_id)
-      
-      interferon.update_alerts_on_destination(dest, ['host'], [alerts['name1'], alerts['name2']], {}, true)
+
+      interferon.update_alerts_on_destination(dest, ['host'], [alerts['name1'], alerts['name2']], {})
     end
 
-    it 'dry run runs added alerts' do
+    it 'runs added alerts' do
       alerts = mock_existing_alerts
-      interferon = Interferon::Interferon.new(nil,nil,nil,nil)
       added = create_test_alert('name3', 'testquery3', '')
       expect(dest).to receive(:create_alert).once.and_call_original
-      expect(dest).to receive(:remove_alert_by_id).with('[-dry-run-]name3').once
-      
-      interferon.update_alerts_on_destination(dest, ['host'], [alerts['name1'], alerts['name2'], added], {}, true)
+      expect(dest).to receive(:remove_alert_by_id).with('3').once
+
+      interferon.update_alerts_on_destination(dest, ['host'], [alerts['name1'], alerts['name2'], added], {})
+    end
+
+    it 'runs updated alerts' do
+      added = create_test_alert('name1', 'testquery3', '')
+      expect(dest).to receive(:create_alert).once.and_call_original
+      expect(dest).to receive(:remove_alert_by_id).with('1').once
+
+      interferon.update_alerts_on_destination(dest, ['host'], [added], {})
+    end
+
+    it 'deletes old alerts' do
+      expect(dest).to receive(:remove_alert).twice
+
+      interferon.update_alerts_on_destination(dest, ['host'], [], {})
+    end
+
+    it 'deletes duplicate old alerts' do
+      alert1 = mock_alert_json('name1', 'testquery1', '', false, false, [1, 2, 3])
+      alert2 = mock_alert_json('name2', 'testquery2', '')
+      existing_alerts = {'name1' => alert1, 'name2' => alert2}
+      dest = MockDest.new(existing_alerts)
+      allow(dest).to receive(:remove_alert)
+      allow(dest).to receive(:remove_alert_by_id)
+      allow(dest).to receive(:report_stats)
+
+      expect(dest).to receive(:remove_alert).with(existing_alerts['name1'])
+      expect(dest).to receive(:remove_alert).with(existing_alerts['name2'])
+
+      interferon.update_alerts_on_destination(dest, ['host'], [], {})
+    end
+
+    it 'deletes duplicate old alerts when creating new alert' do
+      alert1 = mock_alert_json('name1', 'testquery1', '', false, false, [1, 2, 3])
+      alert2 = mock_alert_json('name2', 'testquery2', '')
+      existing_alerts = {'name1' => alert1, 'name2' => alert2}
+      dest = MockDest.new(existing_alerts)
+      allow(dest).to receive(:remove_alert)
+      allow(dest).to receive(:remove_alert_by_id)
+      allow(dest).to receive(:report_stats)
+
+      added = create_test_alert('name1', 'testquery1', '')
+
+      # Since we change id to nil we will not be attempting to delete duplicate alerts
+      # during dry run
+      # expect(dest).to receive(:remove_alert).with(existing_alerts['name1'])
+      expect(dest).to receive(:remove_alert).with(existing_alerts['name2'])
+
+      interferon.update_alerts_on_destination(dest, ['host'], [added], {})
+    end
+  end
+
+  context "update_alerts_on_destination" do
+    let(:interferon) {Interferon::Interferon.new(nil,nil,nil,nil,false,0)}
+
+    before do
+      allow_any_instance_of(MockAlert).to receive(:evaluate)
+      allow(dest).to receive(:remove_alert)
+      allow(dest).to receive(:remove_alert_by_id)
+      allow(dest).to receive(:report_stats)
     end
 
-    it 'dry run runs updated alerts' do
+    it 'does not re-run existing alerts' do
       alerts = mock_existing_alerts
-      interferon = Interferon::Interferon.new(nil,nil,nil,nil)
+      expect(dest).not_to receive(:create_alert)
+      expect(dest).not_to receive(:remove_alert_by_id)
+
+      interferon.update_alerts_on_destination(dest, ['host'], [alerts['name1'], alerts['name2']], {})
+    end
+
+    it 'runs added alerts' do
+      alerts = mock_existing_alerts
+      added = create_test_alert('name3', 'testquery3', '')
+      expect(dest).to receive(:create_alert).once.and_call_original
+      expect(dest).not_to receive(:remove_alert_by_id).with('3')
+
+      interferon.update_alerts_on_destination(dest, ['host'], [alerts['name1'], alerts['name2'], added], {})
+    end
+
+    it 'runs updated alerts' do
       added = create_test_alert('name1', 'testquery3', '')
       expect(dest).to receive(:create_alert).once.and_call_original
-      expect(dest).to receive(:remove_alert_by_id).with('[-dry-run-]name1').once
-      
-      interferon.update_alerts_on_destination(dest, ['host'], [added], {}, true)
+      expect(dest).not_to receive(:remove_alert_by_id).with('1')
+
+      interferon.update_alerts_on_destination(dest, ['host'], [added], {})
     end
 
-    def mock_existing_alerts
-      alert1 = mock_alert_json('name1', 'testquery1', '')
+    it 'deletes old alerts' do
+      alerts = mock_existing_alerts
+      expect(dest).to receive(:remove_alert).with(alerts['name1'])
+      expect(dest).to receive(:remove_alert).with(alerts['name2'])
+
+      interferon.update_alerts_on_destination(dest, ['host'], [], {})
+    end
+
+    it 'deletes duplicate old alerts' do
+      alert1 = mock_alert_json('name1', 'testquery1', '', false, false, [1, 2, 3])
       alert2 = mock_alert_json('name2', 'testquery2', '')
-      {'name1'=>alert1, 'name2'=>alert2}
+      existing_alerts = {'name1' => alert1, 'name2' => alert2}
+      dest = MockDest.new(existing_alerts)
+      allow(dest).to receive(:remove_alert)
+      allow(dest).to receive(:remove_alert_by_id)
+      allow(dest).to receive(:report_stats)
+
+      expect(dest).to receive(:remove_alert).with(existing_alerts['name1'])
+      expect(dest).to receive(:remove_alert).with(existing_alerts['name2'])
+
+      interferon.update_alerts_on_destination(dest, ['host'], [], {})
     end
 
-    class MockDest < Interferon::Destinations::Datadog
-      @existing_alerts
+    it 'deletes duplicate old alerts when creating new alert' do
+      alert1 = mock_alert_json('name1', 'testquery1', '', false, false, [1, 2, 3])
+      alert2 = mock_alert_json('name2', 'testquery2', '')
+      existing_alerts = {'name1' => alert1, 'name2' => alert2}
+      dest = MockDest.new(existing_alerts)
+      allow(dest).to receive(:report_stats)
+
+      added = create_test_alert('name1', 'testquery1', '')
 
-      def initialize(the_existing_alerts)
-        @existing_alerts = the_existing_alerts
-      end
+      expect(dest).to receive(:remove_alert).with(mock_alert_json('name1', 'testquery1', '', false, false, [2, 3]))
+      expect(dest).to receive(:remove_alert).with(existing_alerts['name2'])
 
-      def create_alert(alert, people)
-        name = alert['name']
-        [name, name]
-      end
+      interferon.update_alerts_on_destination(dest, ['host'], [added], {})
+    end
+  end
+
+  def mock_existing_alerts
+    alert1 = mock_alert_json('name1', 'testquery1', '')
+    alert2 = mock_alert_json('name2', 'testquery2', '')
+    {'name1' => alert1, 'name2' => alert2}
+  end
+
+  class MockDest < Interferon::Destinations::Datadog
+    @existing_alerts
 
-      def existing_alerts
-        @existing_alerts
-      end
+    def initialize(the_existing_alerts)
+      @existing_alerts = the_existing_alerts
+    end
+
+    def create_alert(alert, people)
+      name = alert['name']
+      id = [alert['name'][-1]]
+      [name, id]
+    end
+
+    def existing_alerts
+      @existing_alerts
     end
   end
 
-  def mock_alert_json(name, datadog_query, message)
-    {'name'=> name,'query'=> datadog_query,'message'=> message}
+  def mock_alert_json(name, datadog_query, message, notify_no_data=false, silenced=false, id=nil)
+    { 'name'=> name,
+      'query'=> datadog_query,
+      'message'=> message,
+      'notify_no_data' => notify_no_data,
+      'silenced' => silenced,
+      'id' => id.nil? ? [name[-1]] : id
+    }
   end
 
-  def create_test_alert(name, datadog_query, message)
+  def create_test_alert(name, datadog_query, message, notify_no_data=false, silenced=false)
     alert_dsl = MockAlertDSL.new
     metric_dsl = MockMetricDSL.new
     metric_dsl.datadog_query(datadog_query)
@@ -94,6 +239,8 @@ describe Interferon::Interferon do
     alert_dsl.name(name)
     alert_dsl.applies(true)
     alert_dsl.message(message)
+    alert_dsl.silenced(silenced)
+    alert_dsl.notify_no_data(notify_no_data)
     notify_dsl = MockNotifyDSL.new
     notify_dsl.groups(['a'])
     alert_dsl.notify(notify_dsl)

data/spec/lib/work_hours_helper_spec.rb

@@ -0,0 +1,41 @@
+require "spec_helper"
+require "interferon/work_hours_helper"
+
+describe Interferon::WorkHoursHelper do
+  subject { described_class }
+
+  describe ".now_is_work_hour?" do
+    context "when it is a work hour in a work day" do
+      it "return true" do
+        expect(subject.is_work_hour?(
+          Time.parse("Mon Nov 26 9:01:20 PST 2001").utc
+        )).to be_truthy
+        expect(subject.is_work_hour?(
+          Time.parse("Fri Nov 30 16:35:20 PST 2001").utc
+        )).to be_truthy
+      end
+    end
+
+    context "when it is a work hour in a weekend" do
+      it "return false" do
+        expect(subject.is_work_hour?(
+          Time.parse("Sat Nov 24 09:01:20 PST 2001").utc
+        )).to be_falsy
+        expect(subject.is_work_hour?(
+          Time.parse("Sun Nov 25 09:01:20 PST 2001").utc
+        )).to be_falsy
+      end
+    end
+
+    context "when it is not a work hour" do
+      it "return false" do
+        expect(subject.is_work_hour?(
+          Time.parse("Thu Nov 29 08:33:20 PST 2001").utc
+        )).to be_falsy
+        expect(subject.is_work_hour?(
+          Time.parse("Fri Nov 30 17:33:20 PST 2001").utc
+        )).to be_falsy
+      end
+    end
+  end
+end

metadata

@@ -1,113 +1,189 @@
 --- !ruby/object:Gem::Specification
 name: interferon
 version: !ruby/object:Gem::Version
-  version: 0.0.12
+  version: 0.0.19
 platform: ruby
 authors:
 - Igor Serebryany
+- Jimmy Ngo
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-05-24 00:00:00.000000000 Z
+date: 2017-01-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dogapi
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.11'
-    - - ">="
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: 1.11.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.11'
-    - - ">="
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: 1.11.1
 - !ruby/object:Gem::Dependency
   name: aws-sdk
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.35'
-    - - ">="
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: 1.35.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.35'
-    - - ">="
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: 1.35.1
 - !ruby/object:Gem::Dependency
   name: dogstatsd-ruby
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.4'
-    - - ">="
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: 1.4.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.4'
-    - - ">="
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: 1.4.1
+- !ruby/object:Gem::Dependency
+  name: diffy
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 3.1.0
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: 3.1.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 3.1.0
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: 3.1.0
+- !ruby/object:Gem::Dependency
+  name: parallel
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '1.9'
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: 1.9.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '1.9'
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: 1.9.0
+- !ruby/object:Gem::Dependency
+  name: nokogiri
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - <
+      - !ruby/object:Gem::Version
+        version: 1.7.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - <
+      - !ruby/object:Gem::Version
+        version: 1.7.0
+- !ruby/object:Gem::Dependency
+  name: tzinfo
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 1.2.2
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: 1.2.2
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 1.2.2
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: 1.2.2
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '3.2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '3.2'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '0.10'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '0.10'
-description: ": Store metrics alerts in code!"
+description: ': Store metrics alerts in code!'
 email:
 - igor.serebryany@airbnb.com
+- jimmy.ngo@airbnb.com
 executables:
 - interferon
 extensions: []
 extra_rdoc_files: []
 files:
-- ".gitignore"
-- ".travis.yml"
+- .gitignore
+- .travis.yml
 - Gemfile
 - LICENSE
 - README.md
@@ -128,6 +204,7 @@ files:
 - lib/interferon/loaders.rb
 - lib/interferon/logging.rb
 - lib/interferon/version.rb
+- lib/interferon/work_hours_helper.rb
 - script/pre-commit
 - spec/fixtures/loaders/host_sources/test_host_source.rb
 - spec/fixtures/loaders/test_sources/order_test_source.rb
@@ -140,10 +217,12 @@ files:
 - spec/helpers/logging_helper.rb
 - spec/helpers/mock_alert.rb
 - spec/helpers/optica_helper.rb
+- spec/lib/interferon/group_sources/filesystem_spec.rb
 - spec/lib/interferon/host_sources/optica_services_spec.rb
 - spec/lib/interferon/host_sources/optica_spec.rb
 - spec/lib/interferon/loaders_spec.rb
 - spec/lib/interferon_spec.rb
+- spec/lib/work_hours_helper_spec.rb
 - spec/spec_helper.rb
 homepage: https://www.github.com/airbnb/interferon
 licenses:
@@ -155,20 +234,20 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5.1
+rubygems_version: 2.6.6
 signing_key: 
 specification_version: 4
-summary: ": Store metrics alerts in code!"
+summary: ': Store metrics alerts in code!'
 test_files:
 - spec/fixtures/loaders/host_sources/test_host_source.rb
 - spec/fixtures/loaders/test_sources/order_test_source.rb
@@ -181,8 +260,10 @@ test_files:
 - spec/helpers/logging_helper.rb
 - spec/helpers/mock_alert.rb
 - spec/helpers/optica_helper.rb
+- spec/lib/interferon/group_sources/filesystem_spec.rb
 - spec/lib/interferon/host_sources/optica_services_spec.rb
 - spec/lib/interferon/host_sources/optica_spec.rb
 - spec/lib/interferon/loaders_spec.rb
 - spec/lib/interferon_spec.rb
+- spec/lib/work_hours_helper_spec.rb
 - spec/spec_helper.rb