interface-dsl 0.1.4 → 0.1.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a08f65100277da590913ecc15c42d7c5428a8d42
-  data.tar.gz: 17227276991c60ae9f4e9dee377492666c0a085d
+  metadata.gz: 6e8e9d4a6a3e4193121aa9810bb856eaa9b4b55f
+  data.tar.gz: b57a5f53fb5f71e1f429d1e2fb29ece754fb93aa
 SHA512:
-  metadata.gz: 7b430dfe570938c708800edb0af3acab804552a4ca390167f560cd00b2ad679e75b1f20f9fc704eb9bd57339565c015c82fcf66cf3fc5e20610c01a404921001
-  data.tar.gz: 8208b4c19043b6328d0d924ecc084685828d1759d98c4c1c9ef1b477095b8c86c752ec9d2bcb7c5bcbbb0d1dd70a78c5f4dfc7e2503a9e11dfd9307df1eccf3e
+  metadata.gz: c531aa1457a25afca68e02a7c79ca0abeec3d2d0e3a4fe29d2dcf2932e9934c0bec2197771afd42b4e5a2d23ddc51d48432fa7885bcfdd9a68d3efbefe3ce38f
+  data.tar.gz: 0e140c323d173e97f18fb2df08ef9b8ffcdc678d25986e665183ada64deb3f87a2205011b6690d2e6a60de951bd63fffc26db067d8571550a979f9ceab62ce9f

data/lib/interface/{adapter.rb → default_adapter.rb}

@@ -1,31 +1,33 @@
 module Interface
-  class Adapter
+  class DefaultAdapter
     CallingError   = Class.new(StandardError)
     InterfaceError = Class.new(StandardError)
 
     extend FactoryMethods
 
-    def_factory :call
+    deffactory :call
 
     def initialize(callable)
       @callable = callable
     end
 
-    def call
+    def call(*args, &block)
       unless callable.respond_to?(:call)
         fail(InterfaceError("#{callable.class} is not callable!"))
       end
 
-      _call
+      _call(*args, &block)
     end
 
     private
 
-    def _call
-      result = callable.call
+    attr_reader :callable
+
+    def _call(*args, &block)
+      result = callable.call(*args, &block)
       if result.is_a?(Array)
         status, _result = result
-        status == :ok || fail(ServiceError("Error while calling #{callable.class}: #{_result}"))
+        status == :ok || fail(CallingError("Error while calling #{callable.class}: #{_result}"))
         _result
       else
         result

data/lib/interface/default_settings.rb

@@ -0,0 +1,8 @@
+module Interface
+  class DefaultSettings
+    extend ::Dry::Configurable
+
+    setting(:allow_top_level_api_endpoints?, false)
+    setting(:response_adapter, ::Interface::DefaultAdapter)
+  end
+end

data/lib/interface/dsl/version.rb

@@ -1,5 +1,5 @@
 module Interface
   module Dsl
-    VERSION = "0.1.4"
+    VERSION = "0.1.5"
   end
 end

data/lib/interface/dsl.rb

@@ -1,17 +1,18 @@
 require "interface"
-require "interface/dsl/version"
 
 module Interface
   module DSL
-    OrphanPort         = Class.new(StandardError)
-    ImmutableInterface = Class.new(StandardError)
+    def defsettings(configuration_class)
+      if !configuration_class.is_a?(Class) || !configuration_class.is_a?(Module)
+        fail(::Interface::Errors::UnexpectedInstanceError.new('Only classes and modules are supported'))
+      end
 
-    require "interface/port_group"
-    require "interface/port_entity"
+      @settings ||= configuration_class
+    end
 
     def interface(name, &block)
       if interfaces.key?(name)
-        fail(ImmutableInterface.new("Interface can't be redefined or reopened! Use .extend_api method"))
+        fail(::Interface::Errors::ImmutableInterfaceError.new("Interface can't be redefined or reopened! Use .extend_api method"))
       end
 
       interfaces.merge!(name => ::Interface::PortGroup.new(name, self).tap do |group|
@@ -60,12 +61,16 @@ module Interface
       @points ||= Hashie::Mash.new
     end
 
+    def _settings
+      @settings || ::Interface::DefaultSettings
+    end
+
     private
 
     def check_top_level_enpoint_policy
-      return if Interface.config.allow_top_level_api_endpoints? || !top_level?
+      return if _settings.config.allow_top_level_api_endpoints? || !top_level?
 
-      fail(OrphanPort.new("Can not be defined as a top level Interface"))
+      fail(::Interface::Errors::OrphanPortError.new("Can not be defined as a top level Interface"))
     end
 
     def top_level?
@@ -89,7 +94,7 @@ module Interface
     end
 
     def define_entity(name, &block)
-      ::Interface::PortEntity.new(name).tap { |port| port.instance_eval(&block) }
+      ::Interface::PortEntity.new(name, _settings.config.response_adapter).tap { |port| port.instance_eval(&block) }
     end
   end
 end

data/lib/interface/errors.rb

@@ -0,0 +1,11 @@
+module Interface
+  module Errors
+    BaseError               = Class.new(StandardError)
+
+    OrphanPortError         = Class.new(BaseError)
+    ImmutableInterfaceError = Class.new(BaseError)
+    InvalidInputError       = Class.new(BaseError)
+    HandlerMissingError     = Class.new(BaseError)
+    UnexpectedInstanceError = Class.new(BaseError)
+  end
+end

data/lib/interface/port_entity.rb

@@ -1,10 +1,5 @@
 module Interface
-  # TODO
-  # => define Schemas with dry-validation
-  class PortEntity < Struct.new(:name)
-    WTFError          = Class.new(StandardError)
-    InvalidInputError = Class.new(StandardError)
-
+  class PortEntity < Struct.new(:name, :default_adapter)
     N_A = 'N/A'.freeze
     LIM = ('-' * 48).freeze
 
@@ -14,17 +9,26 @@ module Interface
 
     def call(*args, &block)
       if @handler.nil?
-        fail(WTFError.new("WAT A HECK U DOIN'! THERE'S NO HANDLER TO CALL!"))
+        fail(::Interface::Errors::HandlerMissingError.new("Handler is undefined"))
       end
 
       if !@contract.nil?
-        fail(InvalidInputError.new("Empty argument list doesn not comply with the Contract")) if args.empty?
+        fail(::Interface::Errors::InvalidInputError.new("Empty argument list doesn not comply with the Contract")) if args.empty?
 
         errors = @contract.call(*args).errors
-        fail(InvalidInputError.new(errors)) if errors.any?
+        fail(::Interface::Errors::InvalidInputError.new(errors)) if errors.any?
       end
 
-      @handler.call(*args, &block)
+      # this is a decent source of bugs.
+      caller =  if !@adapter.nil?
+                  @adapter.new(@handler)
+                elsif !default_adapter.nil?
+                  default_adapter.new(@handler)
+                else
+                  @handler
+                end
+
+      caller.call(*args, &block)
     end
 
     def handler(klass)
@@ -35,11 +39,15 @@ module Interface
       @contract = validation_schema
     end
 
-    def returns(hash)
-      { success: [:ok,    Object],
-        failure: [:error, String] }
+    def returns(klass)
+      @adapter = klass
     end
 
+    # def returns(hash)
+    #   { success: [:ok,    Object],
+    #     failure: [:error, String] }
+    # end
+
     #TODO
     def before_call; end
     def after_call; end

data/lib/interface.rb

@@ -1,9 +1,14 @@
 require 'dry-configurable'
 require 'dry-validation'
 require 'factorymethods'
+require 'interface/dsl/version'
+require 'hashie'
 
 module Interface
-  extend ::Dry::Configurable
+  autoload :PortGroup,       'interface/port_group'
+  autoload :PortEntity,      'interface/port_entity'
+  autoload :Errors,          'interface/errors'
 
-  setting(:allow_top_level_api_endpoints?, false)
+  autoload :DefaultSettings, 'interface/default_settings'
+  autoload :DefaultAdapter,  'interface/default_adapter'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: interface-dsl
 version: !ruby/object:Gem::Version
-  version: 0.1.4
+  version: 0.1.5
 platform: ruby
 authors:
 - Oleksiy Kurnenkov
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-01-06 00:00:00.000000000 Z
+date: 2017-01-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dry-validation
@@ -140,9 +140,11 @@ files:
 - bin/setup
 - interface-dsl.gemspec
 - lib/interface.rb
-- lib/interface/adapter.rb
+- lib/interface/default_adapter.rb
+- lib/interface/default_settings.rb
 - lib/interface/dsl.rb
 - lib/interface/dsl/version.rb
+- lib/interface/errors.rb
 - lib/interface/port_entity.rb
 - lib/interface/port_group.rb
 homepage: https://github.com/o-kurnenkov/interface-dsl