interest_days 0.5.2 → 0.5.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2883c05efa288b06891b2aac71fca5331c723d1df471b18267f60879a9faad7f
-  data.tar.gz: 74379f2e234f43b03c711a26c0ad7fa3cc5ca32fce5bcfacb3ceb329a4f44448
+  metadata.gz: 10512ef2d8b56d0c8110707011f3b9588a2fdd11bea9c5ba2efbf28f4f898da5
+  data.tar.gz: 5d5eceafc7ef04cb73e07828d28cd9345f6b6bc065682d8da8d770f6ab64ed9c
 SHA512:
-  metadata.gz: 72b9afc11e72d1f9b015d8c457187c1f9c3a4d99cf5606a4ae6279eff57df24d8b3ea6d7b659b64920edce0898c8ba5194a532b7c1797c2eef73539b7a7d11b5
-  data.tar.gz: b12ea6908e66b813a5d4a8567a5da45a63f612b23b66c2752377dd614e035bb5e260bb4e1595f8e2eef80d37de194ba06b7c90868fc328da8aa996edf945454b
+  metadata.gz: 6ecb400209fb903908d8e3c1bf9be08f81ca2b8dd58543b87a301b167b1f875faf6831f52d31da9862cb071a2852ef797dd00b2478918771cdb99aab3d803daa
+  data.tar.gz: 381edf8b7bf4ee0dce7ed7c0ef288ebbf2ddf617da4cfc5980254b46826a48035267bc901734e1c78eceebe7e7ae46ae0247df1cb5165a4c18ea858136927ce5

data/CHANGELOG.md

@@ -1,4 +1,8 @@
 
+## [0.5.3] / 2022-11-14
+==================
+  * Fix ICMA act/act strategy for interest periods relates to small periods within a leap year.
+
 ## [0.5.2] / 2022-11-11
 ==================
   * Fix ICMA act/act strategy for interest periods longer than one year.

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    interest_days (0.5.2)
+    interest_days (0.5.3)
 
 GEM
   remote: https://rubygems.org/

data/interest_days.gemspec

@@ -14,7 +14,6 @@ Gem::Specification.new do |spec|
   spec.license       = "MIT"
   spec.required_ruby_version = ">= 2.7.0"
 
-
   spec.metadata["homepage_uri"] = spec.homepage
   spec.metadata["source_code_uri"] = "https://github.com/eugenmueller/interest_days"
   spec.metadata["changelog_uri"] = "https://github.com/eugenmueller/interest_days/blob/v0.2.0/CHANGELOG.md"

data/lib/interest_days/calculation/icma_act_act.rb

@@ -8,17 +8,14 @@ module InterestDays
       DAYS_IN_LEAP_YEAR = 366
 
       def day_count_factor
-        return days.fdiv(start_date_days_in_year) if start_date_and_end_date_in_same_year?
-
-        if years_in_between_factor.positive?
-          return start_date_period_factor + years_in_between_factor + end_date_period_factor
-        end
+        return multiple_years_day_count_factor if years_in_between_factor.positive?
 
         days.fdiv(year_days_in_period)
       end
 
       private
 
+      # calculate for periods smaller than a year
       def year_days_in_period
         period_contains_leap_day? ? DAYS_IN_LEAP_YEAR : DAYS_IN_YEAR
       end
@@ -35,6 +32,11 @@ module InterestDays
                       end
       end
 
+      # claculate for period span more than a year
+      def multiple_years_day_count_factor
+        start_date_period_factor + years_in_between_factor + end_date_period_factor
+      end
+
       def start_date_period_factor
         (start_date_days_in_year - start_date.yday).fdiv(start_date_days_in_year)
       end
@@ -48,11 +50,11 @@ module InterestDays
       end
 
       def start_date_period_with_leap_date?
-        start_date.leap? && start_date.month < 3
+        start_date.leap? && Date.new(start_date.year, 2, 29)&.between?(start_date, Date.new(start_date.year, 12, 31))
       end
 
       def end_date_period_with_leap_date?
-        end_date.leap? && end_date >= Date.new(end_date.year, 2, 29)
+        end_date.leap? && Date.new(end_date.year, 2, 29)&.between?(Date.new(end_date.year, 1, 1), end_date)
       end
 
       def start_date_and_end_date_in_same_year?

data/lib/interest_days/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module InterestDays
-  VERSION = "0.5.2"
+  VERSION = "0.5.3"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: interest_days
 version: !ruby/object:Gem::Version
-  version: 0.5.2
+  version: 0.5.3
 platform: ruby
 authors:
 - Eugen Mueller