intercom 4.2.0 → 4.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d0e11ca3b41ab460f24a33608fb6a4113227bf791cefa9aa9dc9cc31e418faf5
-  data.tar.gz: d0379934e0ab635bb042db6ea4840e930f4c5ad56951554193f7d9ec1e7f190d
+  metadata.gz: 8a680039a8ef799d52b227657866f60afa19bf4b292f9d70646c8f962eca11a0
+  data.tar.gz: 40317d4521715f294bec48805ed9edf6f83406260b5c74bde5e9cf96cdf9cb8c
 SHA512:
-  metadata.gz: 7f77ceb73f95a43cfde87e2e274939c76f3dc023d8836683166bdc22f04de9ea14c58cedca3aecffd116023c3f92897c31f5a07d53d0811db1c958109ba5315a
-  data.tar.gz: 6c36c19e9d95c3218b3c4ac5034c252185a1618d62694920ec4fa5576f5152fb5f8eb4634c1cbb3802870195c6f592848269f830eb2060681380e2ba5e68d91c
+  metadata.gz: df28a00dc009f9e7bd94fa497021312d4cbe005905eea6095d1efe1172f567d8f806a47750843e129cfae5af80db038aea355ba2f1a2b5122142893574d9d977
+  data.tar.gz: d57709458d73737890f1933264f10b23c486a08840bd3a561c8971dbfef3d2ad88b4ddb2d393154b4127cd78196a39a56c93c0f08c747c74bd303c729d01fc5f

data/lib/intercom/base_collection_proxy.rb

@@ -68,10 +68,7 @@ module Intercom
     end
 
     def payload
-      payload = {}
-      payload[:per_page] = @params[:per_page] if @params[:per_page]
-      payload[:starting_after] = @params[:starting_after] if @params[:starting_after]
-      payload
+      @params.keep_if { |k, v| !v.nil? }.to_h
     end
   end
 end

data/lib/intercom/version.rb

@@ -1,3 +1,3 @@
 module Intercom #:nodoc:
-  VERSION = "4.2.0"
+  VERSION = "4.2.1"
 end

data/spec/unit/intercom/base_collection_proxy_spec.rb

@@ -44,4 +44,9 @@ describe Intercom::BaseCollectionProxy do
     contacts.each { |contact| emails_iter2 << contact.email }
     _(emails_iter1).must_equal emails_iter2
   end
+
+  it "supports query params" do
+    client.expects(:get).with("/conversations", {:intercom_user_id => 'abcdef0000'}).returns(test_conversation_list)
+    _(client.conversations.find_all(:intercom_user_id => 'abcdef0000').map(&:id)).must_equal %w[147]
+  end
 end

data/spec/unit/intercom/company_spec.rb

@@ -9,7 +9,7 @@ describe Intercom::Company do
       _(proc { client.companies.find(:company_id => "4")}).must_raise Intercom::HttpError
     end
 
-    it "on find_all" do
+    it "on all" do
       client.expects(:get).with("/companies", {}).returns(nil)
       _(proc { client.companies.all.each {|company| }}).must_raise Intercom::HttpError
     end

data/spec/unit/intercom/conversation_spec.rb

@@ -13,6 +13,11 @@ describe "Intercom::Conversation" do
     client.conversations.all.each { |c| }
   end
 
+  it "can filter conversations based on params" do
+    client.expects(:get).with("/conversations", {type: 'user', intercom_user_id: '123456789'}).returns(test_conversation_list)
+    client.conversations.find_all(type: 'user', intercom_user_id: '123456789').each { |c| }
+  end
+
   it 'marks a conversation as read' do
     client.expects(:put).with('/conversations/147', { read: true })
     client.conversations.mark_read('147')

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: intercom
 version: !ruby/object:Gem::Version
-  version: 4.2.0
+  version: 4.2.1
 platform: ruby
 authors:
 - Ben McRedmond
@@ -12,10 +12,10 @@ authors:
 - Declan McGrath
 - Jamie Osler
 - Bob Long
-autorequire:
+autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-12-08 00:00:00.000000000 Z
+date: 2022-12-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest
@@ -264,7 +264,7 @@ homepage: https://www.intercom.io
 licenses:
 - MIT
 metadata: {}
-post_install_message:
+post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -279,8 +279,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.7
-signing_key:
+rubygems_version: 3.2.16
+signing_key: 
 specification_version: 4
 summary: Ruby bindings for the Intercom API
 test_files: