intercom 0.1.9 → 0.1.10

data/changes.txt

@@ -1,3 +1,6 @@
+0.1.10
+ - fix broken tag updating :(
+
 0.1.9
  - better response object for tags
 

data/lib/intercom/hashable_object.rb

@@ -1,9 +1,7 @@
 module Intercom
   module HashableObject
     def from_hash(hash)
-      hash.each do |key,value|
-        instance_variable_set("@#{key}".to_sym, value)
-      end
+      hash.each {|attribute, value| instance_variable_set("@#{attribute}".to_sym, value) }
     end
 
     def to_hash
@@ -14,7 +12,11 @@ module Intercom
     end
 
     def displayable_attributes
-      to_hash.delete_if {|k, v| !self.respond_to?(k) }
+      to_hash.select {|attribute, value| self.respond_to?(attribute) }
+    end
+
+    def to_wire
+      to_hash.select {|attribute, value| self.respond_to?("#{attribute.to_s}=") }
     end
   end
 end

data/lib/intercom/tag.rb

@@ -32,7 +32,9 @@ module Intercom
     extend RequiresParameters
     include HashableObject
 
-    attr_reader :name, :color, :segment, :tagged_user_count, :id
+    attr_accessor :name, :color
+    attr_reader :segment, :tagged_user_count, :id
+    attr_writer :user_ids, :emails, :tag_or_untag
 
     def initialize(attributes={})
       from_hash(attributes)
@@ -68,7 +70,7 @@ module Intercom
     ##
     # Saves a Tag on your application
     def save
-      response = Intercom.post("/v1/tags", to_hash)
+      response = Intercom.post("/v1/tags", to_wire)
       self.from_hash(response)
       displayable_self
     end

data/lib/intercom/version.rb

@@ -1,3 +1,3 @@
 module Intercom #:nodoc:
-  VERSION = "0.1.9"
+  VERSION = "0.1.10"
 end

data/spec/spec_helper.rb

@@ -98,6 +98,16 @@ def test_tag
   }
 end
 
+def updated_test_tag
+  {
+    "id" => "4f73428b5e4dfc000b000112",
+    "name" => "Test Tag",
+    "color" => "green",
+    "segment" => false,
+    "tagged_user_count" => 2
+  }
+end
+
 def error_on_modify_frozen
   RUBY_VERSION =~ /1.8/ ? TypeError : RuntimeError
 end

data/spec/unit/intercom/tag_spec.rb

@@ -30,4 +30,13 @@ describe "Intercom::Tag" do
     tag.tagged_user_count.must_equal 2
   end
 
+  it "updates tags" do
+    Intercom.expects(:get).with("/v1/tags", {:name => "Test Tag"}).returns(test_tag)
+    tag = Intercom::Tag.find_by_name "Test Tag"
+    tag.color.must_equal "red"
+    tag.color = "green"
+    Intercom.expects(:post).with("/v1/tags", {:name => "Test Tag", :color => "green"}).returns(updated_test_tag)
+    tag.save
+  end
+
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: intercom
 version: !ruby/object:Gem::Version
-  version: 0.1.9
+  version: 0.1.10
   prerelease: 
 platform: ruby
 authors: