interaktor 0.4.0 → 0.5.0

data/spec/interaktor/organizer_spec.rb

@@ -11,8 +11,8 @@ RSpec.describe Interaktor::Organizer do
       expect {
         organizer.organize(interaktor2, interaktor3)
       }.to change(organizer, :organized)
-             .from([])
-             .to([interaktor2, interaktor3])
+        .from([])
+        .to([interaktor2, interaktor3])
     end
 
     it "sets interaktors given an array of classes" do
@@ -21,8 +21,8 @@ RSpec.describe Interaktor::Organizer do
       expect {
         organizer.organize([interaktor2, interaktor3])
       }.to change(organizer, :organized)
-             .from([])
-             .to([interaktor2, interaktor3])
+        .from([])
+        .to([interaktor2, interaktor3])
     end
 
     it "allows multiple organize calls" do
@@ -33,8 +33,8 @@ RSpec.describe Interaktor::Organizer do
         organizer.organize(interaktor2, interaktor3)
         organizer.organize(interaktor4)
       }.to change(organizer, :organized)
-             .from([])
-             .to([interaktor2, interaktor3, interaktor4])
+        .from([])
+        .to([interaktor2, interaktor3, interaktor4])
     end
   end
 
@@ -50,51 +50,41 @@ RSpec.describe Interaktor::Organizer do
     it "calls each interaktor in order" do
       organizer = FakeInteraktor.build_interaktor(type: described_class) do
         input { required(:foo) }
-        success { required(:foo) }
+        success { required(:baz) }
       end
 
       interaktor1 = FakeInteraktor.build_interaktor("Interaktor1") do
         input { required(:foo) }
-        success { required(:foo) }
+        success { required(:bar) }
 
         def call
-          success!(foo: "bar")
+          success!(bar: "whatever")
         end
       end
 
       interaktor2 = FakeInteraktor.build_interaktor("Interaktor2") do
-        input { required(:foo) }
-        success { required(:foo) }
-
-        def call
-          success!(foo: "baz")
-        end
-      end
-
-      interaktor3 = FakeInteraktor.build_interaktor("Interaktor3") do
-        input { required(:foo) }
-        success { required(:foo) }
+        input { required(:bar) }
+        success { required(:baz) }
 
         def call
-          success!(foo: "wadus")
+          success!(baz: "whatever")
         end
       end
 
-      allow(organizer).to receive(:organized) {
-        [interaktor1, interaktor2, interaktor3]
-      }
+      allow(organizer).to receive(:organized).and_return([interaktor1, interaktor2])
 
       expect(interaktor1).to receive(:call!).once.ordered.and_call_original
       expect(interaktor2).to receive(:call!).once.ordered.and_call_original
-      expect(interaktor3).to receive(:call!).once.ordered.and_call_original
 
       result = organizer.call(foo: "asdf")
 
-      expect(result.foo).to eq "wadus"
+      expect(result.baz).to eq "whatever"
     end
 
-    it "calls each interaktor in order and passes success attributes" do
-      organizer = FakeInteraktor.build_interaktor(type: described_class) { input { required(:foo) } }
+    it "allows an interaktor to accept input attributes from an organizer" do
+      organizer = FakeInteraktor.build_interaktor(type: described_class) do
+        input { required(:foo) }
+      end
 
       interaktor1 = FakeInteraktor.build_interaktor("Interaktor1") do
         input { required(:foo) }
@@ -105,119 +95,97 @@ RSpec.describe Interaktor::Organizer do
         end
       end
 
-      interaktor2 = FakeInteraktor.build_interaktor("Interaktor1") do
+      interaktor2 = FakeInteraktor.build_interaktor("Interaktor2") do
         input { required(:bar) }
 
         def call
-          self.bar = "wadus"
         end
       end
 
-      allow(organizer).to receive(:organized) {
-        [interaktor1, interaktor2]
-      }
+      allow(organizer).to receive(:organized).and_return([interaktor1, interaktor2])
 
       expect(interaktor1).to receive(:call!).once.ordered.and_call_original
       expect(interaktor2).to receive(:call!).once.ordered.and_call_original
 
-      result = organizer.call(foo: "asdf")
-
-      expect(result.bar).to eq "wadus"
+      organizer.call(foo: "whatever")
     end
 
-    it "allows an interaktor to accept required attributes from previous success attributes" do
-      organizer = FakeInteraktor.build_interaktor(type: described_class)
-      interaktor1 = FakeInteraktor.build_interaktor("Interaktor1") do
-        success { required(:foo) }
-
-        def call
-          success!(foo: "whatever")
-        end
-      end
+    it "allows an interaktor to accept input attributes from the previous organized interaktor's input attributes" do
+      organizer = FakeInteraktor.build_interaktor(type: described_class) { input { required(:foo) } }
+      interaktor1 = FakeInteraktor.build_interaktor("Interaktor1") { input { required(:foo) } }
       interaktor2 = FakeInteraktor.build_interaktor("Interaktor2") do
+        input { required(:foo) }
         success { required(:bar) }
 
         def call
-          success!(bar: "whatever")
-        end
-      end
-      interaktor3 = FakeInteraktor.build_interaktor("Interaktor3") do
-        input do
-          required(:foo)
-          required(:bar)
-        end
-      end
-
-      allow(organizer).to receive(:organized).and_return([interaktor1, interaktor2, interaktor3])
-
-      expect(interaktor1).to receive(:call!).once.ordered.and_call_original
-      expect(interaktor2).to receive(:call!).once.ordered.and_call_original
-      expect(interaktor3).to receive(:call!).once.ordered.and_call_original
-
-      organizer.call
-    end
-
-    it "allows an interaktor to accept required attributes from the original organizer" do
-      organizer = FakeInteraktor.build_interaktor(type: described_class) do
-        input do
-          required(:foo)
-          required(:bar)
+          success!(bar: foo)
         end
       end
-      interaktor1 = FakeInteraktor.build_interaktor("Interaktor1")
-      interaktor2 = FakeInteraktor.build_interaktor("Interaktor2") { input { required(:foo) } }
-      interaktor3 = FakeInteraktor.build_interaktor("Interaktor3") { input { required(:bar) } }
 
-      allow(organizer).to receive(:organized).and_return([interaktor1, interaktor2, interaktor3])
+      allow(organizer).to receive(:organized).and_return([interaktor1, interaktor2])
 
       expect(interaktor1).to receive(:call!).once.ordered.and_call_original
       expect(interaktor2).to receive(:call!).once.ordered.and_call_original
-      expect(interaktor3).to receive(:call!).once.ordered.and_call_original
 
-      organizer.call(foo: "whatever", bar: "baz")
+      organizer.call(foo: "whatever")
     end
 
-    it "allows an interaktor to accept required attributes from the original organizer AND previous success attributes" do
+    it "allows an interaktor to accept input attributes from the previous organized interaktor's success attributes" do
       organizer = FakeInteraktor.build_interaktor(type: described_class) { input { required(:foo) } }
+
       interaktor1 = FakeInteraktor.build_interaktor("Interaktor1") do
+        input { required(:foo) }
         success { required(:bar) }
 
         def call
-          success!(bar: "whatever")
+          success!(bar: foo)
         end
       end
+
       interaktor2 = FakeInteraktor.build_interaktor("Interaktor2") do
+        input { required(:bar) }
         success { required(:baz) }
 
         def call
-          success!(baz: "whatever")
-        end
-      end
-      interaktor3 = FakeInteraktor.build_interaktor("Interaktor3") do
-        input do
-          required(:foo)
-          required(:bar)
-          required(:baz)
+          success!(baz: bar)
         end
       end
 
-      allow(organizer).to receive(:organized).and_return([interaktor1, interaktor2, interaktor3])
+      allow(organizer).to receive(:organized).and_return([interaktor1, interaktor2])
 
       expect(interaktor1).to receive(:call!).once.ordered.and_call_original
       expect(interaktor2).to receive(:call!).once.ordered.and_call_original
-      expect(interaktor3).to receive(:call!).once.ordered.and_call_original
 
       organizer.call(foo: "whatever")
     end
 
-    it "raises an exception if an interaktor requires an input attribute not provided by any previous interaktor" do
+    it "raises an exception if an interaktor requires an input attribute not provided by the organizer" do
+      organizer = FakeInteraktor.build_interaktor(type: described_class)
+      interaktor1 = FakeInteraktor.build_interaktor("Interaktor1") { input { required(:foo) } }
+
+      allow(organizer).to receive(:organized).and_return([interaktor1])
+
+      expect(interaktor1).not_to receive(:call!)
+
+      expect {
+        organizer.call
+      }.to raise_error(
+        an_instance_of(Interaktor::Error::OrganizerMissingPassedAttributeError)
+          .and(having_attributes(
+            attribute: :foo,
+            interaktor: interaktor1
+          ))
+      )
+    end
+
+    it "raises an exception if an interaktor requires an input attribute not provided by the previous interaktor" do
       organizer = FakeInteraktor.build_interaktor(type: described_class)
       interaktor1 = FakeInteraktor.build_interaktor("Interaktor1")
       interaktor2 = FakeInteraktor.build_interaktor("Interaktor2") { input { required(:foo) } }
 
       allow(organizer).to receive(:organized).and_return([interaktor1, interaktor2])
 
-      expect(interaktor1).not_to receive(:call!)
+      expect(interaktor2).not_to receive(:call!)
 
       expect {
         organizer.call
@@ -225,7 +193,7 @@ RSpec.describe Interaktor::Organizer do
         an_instance_of(Interaktor::Error::OrganizerMissingPassedAttributeError)
           .and(having_attributes(
             attribute: :foo,
-            interaktor: interaktor2,
+            interaktor: interaktor2
           ))
       )
     end

data/spec/support/helpers.rb

@@ -3,12 +3,10 @@ class FakeInteraktor
   def self.build_interaktor(name = nil, type: Interaktor, &block)
     name ||= "MyTest#{type}"
 
-    result = Class.new.include(type)
-
-    result.class_eval(&block) if block
-    result.define_singleton_method(:inspect) { name.to_s }
-    result.define_singleton_method(:to_s) { inspect }
-
-    result
+    Class.new.include(type).tap do |klass|
+      klass.class_eval(&block) if block
+      klass.define_singleton_method(:inspect) { name.to_s }
+      klass.define_singleton_method(:to_s) { inspect }
+    end
   end
 end

data/spec/support/lint.rb

@@ -9,12 +9,12 @@ RSpec.shared_examples "lint" do |interaktor_class|
       expect(result.success?).to be true
     end
 
-    it "removes unknown provided attributes" do
+    it "raises an exception for unknown provided attributes" do
       interaktor = FakeInteraktor.build_interaktor(type: interaktor_class)
 
-      result = interaktor.call(baz: "wadus")
-
-      expect(result.baz).to be nil
+      expect {
+        interaktor.call(baz: "wadus")
+      }.to raise_error(Interaktor::Error::UnknownAttributeError)
     end
 
     it "fails when a non-hash or non-context argument is passed" do
@@ -36,12 +36,12 @@ RSpec.shared_examples "lint" do |interaktor_class|
       expect(result.success?).to be true
     end
 
-    it "removes unknown provided attributes" do
+    it "raises an exception for unknown provided attributes" do
       interaktor = FakeInteraktor.build_interaktor(type: interaktor_class)
 
-      result = interaktor.call!(baz: "wadus")
-
-      expect(result.baz).to be nil
+      expect {
+        interaktor.call!(baz: "wadus")
+      }.to raise_error(Interaktor::Error::UnknownAttributeError)
     end
 
     it "fails when a non-hash or non-context argument is passed" do
@@ -302,16 +302,12 @@ RSpec.shared_examples "lint" do |interaktor_class|
       end
 
       expect(interaktor.input_schema).to be_a Dry::Schema::Params
-      expect(interaktor.input_schema.info).to eq(
-        keys: { bar: { required: true, type: "string" } },
-      )
-
       expect(interaktor.required_input_attributes).to contain_exactly(:bar)
 
       result = interaktor.call(bar: "baz")
 
       expect(result.success?).to be true
-      expect(result.bar).to eq "baz"
+      expect { result.bar }.to raise_error(NoMethodError)
     end
 
     it "accepts a schema definition block" do
@@ -320,16 +316,12 @@ RSpec.shared_examples "lint" do |interaktor_class|
       end
 
       expect(interaktor.input_schema).to be_a Dry::Schema::Params
-      expect(interaktor.input_schema.info).to eq(
-        keys: { bar: { required: true, type: "string" } },
-      )
-
       expect(interaktor.required_input_attributes).to contain_exactly(:bar)
 
       result = interaktor.call(bar: "baz")
 
       expect(result.success?).to be true
-      expect(result.bar).to eq "baz"
+      expect { result.bar }.to raise_error(NoMethodError)
     end
 
     it "raises an exception when the attribute is required and not provided" do
@@ -343,20 +335,20 @@ RSpec.shared_examples "lint" do |interaktor_class|
         an_instance_of(Interaktor::Error::AttributeSchemaValidationError).and(
           having_attributes(
             interaktor: interaktor,
-            validation_errors: { bar: ["is missing"] },
+            validation_errors: {bar: ["is missing"]}
           )
         )
       )
     end
 
-    it "removes unknown provided attributes" do
+    it "raises an exception for unknown provided attributes" do
       interaktor = FakeInteraktor.build_interaktor(type: interaktor_class) do
         input { required(:bar).filled(:string) }
       end
 
-      result = interaktor.call!(bar: "baz", foo: "unexpected")
-
-      expect(result.foo).to be nil
+      expect {
+        interaktor.call!(bar: "baz", foo: "unexpected")
+      }.to raise_error Interaktor::Error::UnknownAttributeError
     end
 
     it "allows provided optional attributes" do
@@ -369,7 +361,7 @@ RSpec.shared_examples "lint" do |interaktor_class|
       result = interaktor.call(bar: "baz")
 
       expect(result.success?).to be true
-      expect(result.bar).to eq "baz"
+      expect { result.bar }.to raise_error(NoMethodError)
     end
 
     it "allows missing optional attributes" do
@@ -382,10 +374,10 @@ RSpec.shared_examples "lint" do |interaktor_class|
       result = interaktor.call
 
       expect(result.success?).to be true
-      expect(result.bar).to be_nil
+      expect { result.bar }.to raise_error(NoMethodError)
     end
 
-    it "creates attribute getters and setters" do
+    it "creates attribute getters" do
       interaktor = FakeInteraktor.build_interaktor(type: interaktor_class) do
         input do
           required(:foo).filled(:string)
@@ -395,17 +387,14 @@ RSpec.shared_examples "lint" do |interaktor_class|
         def call
           foo
           bar
-
-          self.foo = "one"
-          self.bar = "two"
         end
       end
 
       result = interaktor.call(foo: "bar", bar: "baz")
 
       expect(result.success?).to be true
-      expect(result.foo).to eq "one"
-      expect(result.bar).to eq "two"
+      expect { result.foo }.to raise_error(NoMethodError)
+      expect { result.bar }.to raise_error(NoMethodError)
     end
   end
 
@@ -420,10 +409,6 @@ RSpec.shared_examples "lint" do |interaktor_class|
       end
 
       expect(interaktor.success_schema).to be_a Dry::Schema::Params
-      expect(interaktor.success_schema.info).to eq(
-        keys: { bar: { required: true, type: "string" } },
-      )
-
       expect(interaktor.required_success_attributes).to contain_exactly(:bar)
 
       result = interaktor.call
@@ -442,10 +427,6 @@ RSpec.shared_examples "lint" do |interaktor_class|
       end
 
       expect(interaktor.success_schema).to be_a Dry::Schema::Params
-      expect(interaktor.success_schema.info).to eq(
-        keys: { bar: { required: true, type: "string" } },
-      )
-
       expect(interaktor.required_success_attributes).to contain_exactly(:bar)
 
       result = interaktor.call
@@ -464,18 +445,18 @@ RSpec.shared_examples "lint" do |interaktor_class|
       end
 
       expect {
-        result = interaktor.call
+        interaktor.call
       }.to raise_error(
         an_instance_of(Interaktor::Error::AttributeSchemaValidationError).and(
           having_attributes(
             interaktor: interaktor,
-            validation_errors: { bar: ["is missing"] },
+            validation_errors: {bar: ["is missing"]}
           )
         )
       )
     end
 
-    it "removes unknown provided attributes" do
+    it "raises an exception for unknown provided attributes" do
       interaktor = FakeInteraktor.build_interaktor(type: interaktor_class) do
         success { required(:bar).filled(:string) }
 
@@ -484,9 +465,9 @@ RSpec.shared_examples "lint" do |interaktor_class|
         end
       end
 
-      result = interaktor.call
-
-      expect(result.foo).to be nil
+      expect {
+        interaktor.call
+      }.to raise_error Interaktor::Error::UnknownAttributeError
     end
 
     it "allows missing optional attributes" do
@@ -517,7 +498,7 @@ RSpec.shared_examples "lint" do |interaktor_class|
 
       expect { interaktor.call }.to(
         raise_error(
-          an_instance_of(Interaktor::Error::MissingExplicitSuccessError).and having_attributes(attributes: [:bar])
+          an_instance_of(Interaktor::Error::MissingExplicitSuccessError).and(having_attributes(attributes: [:bar]))
         )
       )
     end
@@ -534,10 +515,6 @@ RSpec.shared_examples "lint" do |interaktor_class|
       end
 
       expect(interaktor.failure_schema).to be_a Dry::Schema::Params
-      expect(interaktor.failure_schema.info).to eq(
-        keys: { bar: { required: true, type: "string" } },
-      )
-
       expect(interaktor.required_failure_attributes).to contain_exactly(:bar)
 
       result = interaktor.call
@@ -556,10 +533,6 @@ RSpec.shared_examples "lint" do |interaktor_class|
       end
 
       expect(interaktor.failure_schema).to be_a Dry::Schema::Params
-      expect(interaktor.failure_schema.info).to eq(
-        keys: { bar: { required: true, type: "string" } },
-      )
-
       expect(interaktor.required_failure_attributes).to contain_exactly(:bar)
 
       result = interaktor.call
@@ -578,18 +551,18 @@ RSpec.shared_examples "lint" do |interaktor_class|
       end
 
       expect {
-        result = interaktor.call
+        interaktor.call
       }.to raise_error(
         an_instance_of(Interaktor::Error::AttributeSchemaValidationError).and(
           having_attributes(
             interaktor: interaktor,
-            validation_errors: { bar: ["is missing"] },
+            validation_errors: {bar: ["is missing"]}
           )
         )
       )
     end
 
-    it "removes unknown provided attributes" do
+    it "raises an exception for unknown provided attributes" do
       interaktor = FakeInteraktor.build_interaktor(type: interaktor_class) do
         failure { required(:bar).filled(:string) }
 
@@ -598,9 +571,9 @@ RSpec.shared_examples "lint" do |interaktor_class|
         end
       end
 
-      result = interaktor.call
-
-      expect(result.foo).to be nil
+      expect {
+        interaktor.call
+      }.to raise_error Interaktor::Error::UnknownAttributeError
     end
 
     it "allows missing optional attributes" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: interaktor
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.5.0
 platform: ruby
 authors:
 - Taylor Thurlow
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-02-18 00:00:00.000000000 Z
+date: 2025-11-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dry-schema
@@ -28,16 +28,16 @@ dependencies:
   name: zeitwerk
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '2'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -62,25 +62,31 @@ files:
 - ".github/workflows/tests.yml"
 - ".gitignore"
 - ".rspec"
-- ".rubocop.yml"
 - ".ruby-version"
+- ".standard.yml"
 - Gemfile
 - Gemfile.ci
 - Guardfile
 - README.md
 - Rakefile
+- bin/_guard-core
+- bin/guard
+- bin/rspec
+- bin/standardrb
 - interaktor.gemspec
 - lib/interaktor.rb
 - lib/interaktor/callable.rb
-- lib/interaktor/context.rb
 - lib/interaktor/error/attribute_error.rb
 - lib/interaktor/error/attribute_schema_validation_error.rb
 - lib/interaktor/error/base.rb
+- lib/interaktor/error/invalid_method_for_state_error.rb
 - lib/interaktor/error/missing_explicit_success_error.rb
 - lib/interaktor/error/organizer_missing_passed_attribute_error.rb
 - lib/interaktor/error/organizer_success_attribute_missing_error.rb
+- lib/interaktor/error/unknown_attribute_error.rb
 - lib/interaktor/failure.rb
 - lib/interaktor/hooks.rb
+- lib/interaktor/interaction.rb
 - lib/interaktor/organizer.rb
 - spec/integration_spec.rb
 - spec/interaktor/context_spec.rb
@@ -94,7 +100,7 @@ homepage: https://github.com/taylorthurlow/interaktor
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -102,23 +108,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.5'
+      version: '3.0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.6
-signing_key: 
+rubygems_version: 3.4.19
+signing_key:
 specification_version: 4
 summary: Simple service object implementation
-test_files:
-- spec/integration_spec.rb
-- spec/interaktor/context_spec.rb
-- spec/interaktor/hooks_spec.rb
-- spec/interaktor/organizer_spec.rb
-- spec/interaktor_spec.rb
-- spec/spec_helper.rb
-- spec/support/helpers.rb
-- spec/support/lint.rb
+test_files: []