interaktor 0.1.3 → 0.1.4

data/spec/interactor/context_spec.rb

@@ -2,36 +2,36 @@ module Interaktor
   describe Context do
     describe ".build" do
       it "converts the given hash to a context" do
-        context = Context.build(foo: "bar")
+        context = described_class.build(foo: "bar")
 
-        expect(context).to be_a(Context)
+        expect(context).to be_a(described_class)
         expect(context.foo).to eq("bar")
       end
 
       it "builds an empty context if no hash is given" do
-        context = Context.build
+        context = described_class.build
 
-        expect(context).to be_a(Context)
+        expect(context).to be_a(described_class)
         expect(context.send(:table)).to eq({})
       end
 
       it "doesn't affect the original hash" do
         hash = { foo: "bar" }
-        context = Context.build(hash)
+        context = described_class.build(hash)
 
-        expect(context).to be_a(Context)
+        expect(context).to be_a(described_class)
         expect {
           context.foo = "baz"
-        }.not_to change {
+        }.not_to(change {
           hash[:foo]
-        }
+        })
       end
 
       it "preserves an already built context" do
-        context1 = Context.build(foo: "bar")
-        context2 = Context.build(context1)
+        context1 = described_class.build(foo: "bar")
+        context2 = described_class.build(context1)
 
-        expect(context2).to be_a(Context)
+        expect(context2).to be_a(described_class)
         expect {
           context2.foo = "baz"
         }.to change {
@@ -41,7 +41,7 @@ module Interaktor
     end
 
     describe "#success?" do
-      let(:context) { Context.build }
+      let(:context) { described_class.build }
 
       it "is true by default" do
         expect(context.success?).to eq(true)
@@ -49,7 +49,7 @@ module Interaktor
     end
 
     describe "#failure?" do
-      let(:context) { Context.build }
+      let(:context) { described_class.build }
 
       it "is false by default" do
         expect(context.failure?).to eq(false)
@@ -57,7 +57,7 @@ module Interaktor
     end
 
     describe "#fail!" do
-      let(:context) { Context.build(foo: "bar") }
+      let(:context) { described_class.build(foo: "bar") }
 
       it "sets success to false" do
         expect {
@@ -139,9 +139,9 @@ module Interaktor
     end
 
     describe "#called!" do
-      let(:context) { Context.build }
-      let(:instance1) { double(:instance1) }
-      let(:instance2) { double(:instance2) }
+      let(:context) { described_class.build }
+      let(:instance1) { instance_double(Interaktor) }
+      let(:instance2) { instance_double(Interaktor) }
 
       it "appends to the internal list of called instances" do
         expect {
@@ -152,9 +152,9 @@ module Interaktor
     end
 
     describe "#rollback!" do
-      let(:context) { Context.build }
-      let(:instance1) { double(:instance1) }
-      let(:instance2) { double(:instance2) }
+      let(:context) { described_class.build }
+      let(:instance1) { instance_double(Interaktor) }
+      let(:instance2) { instance_double(Interaktor) }
 
       before do
         allow(context).to receive(:_called) { [instance1, instance2] }
@@ -177,7 +177,7 @@ module Interaktor
     end
 
     describe "#_called" do
-      let(:context) { Context.build }
+      let(:context) { described_class.build }
 
       it "is empty by default" do
         expect(context._called).to eq([])

data/spec/interactor/hooks_spec.rb

@@ -1,3 +1,5 @@
+# rubocop:disable RSpec/ScatteredSetup
+
 module Interaktor
   describe Hooks do
     describe "#with_hooks" do
@@ -356,3 +358,5 @@ module Interaktor
     end
   end
 end
+
+# rubocop:enable RSpec/ScatteredSetup

data/spec/interactor/organizer_spec.rb

@@ -1,12 +1,12 @@
 module Interaktor
   describe Organizer do
-    let(:organizer) { Class.new.send(:include, Organizer) }
+    let(:organizer) { Class.new.include(described_class) }
 
     include_examples "lint"
 
     describe ".organize" do
-      let(:interaktor2) { double(:interaktor2) }
-      let(:interaktor3) { double(:interaktor3) }
+      let(:interaktor2) { instance_double(Interaktor) }
+      let(:interaktor3) { instance_double(Interaktor) }
 
       it "sets interaktors given class arguments" do
         expect {
@@ -21,7 +21,7 @@ module Interaktor
       end
 
       it "allows multiple organize calls" do
-        interaktor4 = double(:interaktor4)
+        interaktor4 = instance_double(Interaktor)
         expect {
           organizer.organize(interaktor2, interaktor3)
           organizer.organize(interaktor4)
@@ -36,20 +36,19 @@ module Interaktor
     end
 
     describe "#call" do
-      let(:instance) { organizer.new }
-      let(:context) { double(:context) }
-      let(:interaktor2) { double(:interaktor2) }
-      let(:interaktor3) { double(:interaktor3) }
-      let(:interaktor4) { double(:interaktor4) }
-
-      before do
-        allow(instance).to receive(:context) { context }
+      it "calls each interaktor in order with the context" do
+        instance = organizer.new
+        context = instance_double(Interaktor::Context)
+        interaktor2 = class_double(Class.new.include(Interaktor))
+        interaktor3 = class_double(Class.new.include(Interaktor))
+        interaktor4 = class_double(Class.new.include(Interaktor))
+
+        allow(instance).to receive(:context).and_return(context)
+        instance.instance_variable_set(:@context, context)
         allow(organizer).to receive(:organized) {
           [interaktor2, interaktor3, interaktor4]
         }
-      end
 
-      it "calls each interaktor in order with the context" do
         expect(interaktor2).to receive(:call!).once.with(context).ordered
         expect(interaktor3).to receive(:call!).once.with(context).ordered
         expect(interaktor4).to receive(:call!).once.with(context).ordered

data/spec/support/lint.rb

@@ -1,64 +1,75 @@
 shared_examples "lint" do
-  let(:interaktor) { Class.new.send(:include, described_class) }
+  let(:interaktor) { Class.new.include(described_class) }
 
   describe ".call" do
-    let(:context) { double(:context) }
-    let(:instance) { double(:instance, context: context) }
+    let(:context) { instance_double(Interaktor::Context) }
+    let(:instance) { instance_double(interaktor) }
 
     it "calls an instance with the given context" do
-      expect(interaktor).to receive(:new).once.with(foo: "bar") { instance }
+      instance.instance_variable_set(:@context, context)
+      expect(interaktor).to receive(:new).once.with(foo: "bar").and_return(instance)
       expect(instance).to receive(:run).once.with(no_args)
 
-      expect(interaktor.call(foo: "bar")).to eq(context)
+      resulting_context = interaktor.call(foo: "bar")
+
+      expect(resulting_context).to eq(context)
     end
 
     it "provides a blank context if none is given" do
-      expect(interaktor).to receive(:new).once.with({}) { instance }
+      instance.instance_variable_set(:@context, context)
+      expect(interaktor).to receive(:new).once.with({}).and_return(instance)
       expect(instance).to receive(:run).once.with(no_args)
 
-      expect(interaktor.call).to eq(context)
+      resulting_context = interaktor.call({})
+
+      expect(resulting_context).to eq(context)
     end
   end
 
   describe ".call!" do
-    let(:context) { double(:context) }
-    let(:instance) { double(:instance, context: context) }
+    let(:context) { instance_double(Interaktor::Context) }
+    let(:instance) { instance_double(interaktor) }
 
     it "calls an instance with the given context" do
-      expect(interaktor).to receive(:new).once.with(foo: "bar") { instance }
+      instance.instance_variable_set(:@context, context)
+      expect(interaktor).to receive(:new).once.with(foo: "bar").and_return(instance)
       expect(instance).to receive(:run!).once.with(no_args)
 
-      expect(interaktor.call!(foo: "bar")).to eq(context)
+      resulting_context = interaktor.call!(foo: "bar")
+
+      expect(resulting_context).to eq(context)
     end
 
     it "provides a blank context if none is given" do
-      expect(interaktor).to receive(:new).once.with({}) { instance }
+      instance.instance_variable_set(:@context, context)
+      expect(interaktor).to receive(:new).once.with({}).and_return(instance)
       expect(instance).to receive(:run!).once.with(no_args)
 
-      expect(interaktor.call!).to eq(context)
+      resulting_context = interaktor.call!({})
+
+      expect(resulting_context).to eq(context)
     end
   end
 
   describe ".new" do
-    let(:context) { double(:context) }
+    let(:context) { instance_double(Interaktor::Context) }
 
     it "initializes a context" do
-      expect(Interaktor::Context).to receive(:build)
-                                       .once.with(foo: "bar") { context }
+      expect(Interaktor::Context).to receive(:build).once.with(foo: "bar").and_return(context)
 
       instance = interaktor.new(foo: "bar")
 
-      expect(instance).to be_a(interaktor)
-      expect(instance.context).to eq(context)
+      expect(instance).to be_an(interaktor)
+      expect(instance.instance_variable_get(:@context)).to eq(context)
     end
 
     it "initializes a blank context if none is given" do
-      expect(Interaktor::Context).to receive(:build).once.with({}) { context }
+      expect(Interaktor::Context).to receive(:build).once.with({}).and_return(context)
 
       instance = interaktor.new
 
       expect(instance).to be_a(interaktor)
-      expect(instance.context).to eq(context)
+      expect(instance.instance_variable_get(:@context)).to eq(context)
     end
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: interaktor
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.1.4
 platform: ruby
 authors:
 - Taylor Thurlow
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-07-13 00:00:00.000000000 Z
+date: 2020-09-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: zeitwerk
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.3.1
+        version: '2.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.3.1
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -61,14 +61,14 @@ files:
 - spec/interactor/context_spec.rb
 - spec/interactor/hooks_spec.rb
 - spec/interactor/organizer_spec.rb
-- spec/interactor_spec.rb
+- spec/interaktor_spec.rb
 - spec/spec_helper.rb
 - spec/support/lint.rb
 homepage: https://github.com/taylorthurlow/interaktor
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -84,7 +84,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubygems_version: 3.1.2
-signing_key: 
+signing_key:
 specification_version: 4
 summary: Simple service object implementation
 test_files:
@@ -92,6 +92,6 @@ test_files:
 - spec/interactor/context_spec.rb
 - spec/interactor/hooks_spec.rb
 - spec/interactor/organizer_spec.rb
-- spec/interactor_spec.rb
+- spec/interaktor_spec.rb
 - spec/spec_helper.rb
 - spec/support/lint.rb