interactor-validation 0.4.0 → 0.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 34fec19e843f97e1e192485a44c70b70f52533dafe4431f7bd4e0fe9ccd22dce
-  data.tar.gz: be4ffec4a5ec8d3b9f65d9f5be3303a5bb9e3b1bb7f13bff790575152d1d3a81
+  metadata.gz: a84c031fc1b57751f8632449ffdc9014c2dfa7caff24bafd5bf418882adf1550
+  data.tar.gz: a3315d47373378b4152095b7e358305330c4aa67af41f3f97e943092b0f5ed23
 SHA512:
-  metadata.gz: 107fc2505862ab2c62be405fd38f8a115c9b775a32d15052bd27a3c47eede633d36a3cf1fa2b0c383057d9bbc9b960900670e254dab41cdaa0abf42dceaf7a19
-  data.tar.gz: 2b60b8af76fa09de78733ecd26a57bf112a94d5e5d0e7605edf3a4234f366e9b85aafd0720130b39a8acdc195e6c865fb08c181da53dd4e65285964b217fa73b
+  metadata.gz: 39c3fc71fc57f9b56c342417fba7b362f095516e9e624a810f6474b6f4006173de76c6336be8dbaaf067b6d30bfac916c5628312b8f74bbbe5536e01837c4b28
+  data.tar.gz: 68e581fd48735e33046850215381a91687d040b6d792d03e4d0972772023fa099978441908b6f460367cc909d5175bb60992753c635cc001199072a5468cb8a3

data/README.md

@@ -7,7 +7,7 @@ Structured, lightweight parameter validation designed specifically for [Interact
 - **Built for Interactor** - Seamless integration with service objects
 - **Comprehensive validators** - Presence, format, length, inclusion, numericality, boolean
 - **Nested validation** - Validate complex hashes and arrays
-- **Custom validations** - Override `validate!` for business logic
+- **Custom validations** - `validate!` for other business logic
 - **Flexible error formats** - Human-readable messages or machine-readable codes
 - **Zero dependencies** - Just Interactor and Ruby stdlib
 - **Configurable** - Control validation behavior and error handling
@@ -30,6 +30,9 @@ Structured, lightweight parameter validation designed specifically for [Interact
 - [Parameter Delegation](#parameter-delegation)
 - [Requirements](#requirements)
 - [Design Philosophy](#design-philosophy)
+- [Development](#development)
+- [Contributing](#contributing)
+- [License](#license)
 
 ## Installation
 
@@ -239,7 +242,7 @@ result.errors
 
 ## Custom Validations
 
-Override `validate!` for custom business logic:
+Override `validate!` for custom business logic that requires external dependencies (database queries, API calls, etc.):
 
 ```ruby
 class CreateOrder
@@ -253,7 +256,8 @@ class CreateOrder
   validates :user_id, presence: true
 
   def validate!
-    super  # Run parameter validations first
+    # Parameter validations have already run at this point
+    # No need to call super - there is no parent validate! method
 
     product = Product.find_by(id: product_id)
     if product.nil?
@@ -269,9 +273,41 @@ class CreateOrder
 end
 ```
 
+**Important:** Parameter validations (defined via `validates`) run automatically before `validate!`. You should never call `super` in your `validate!` method as there is no parent implementation.
+
 ## Configuration
 
-Configure global validation behavior in an initializer or before your interactors are loaded:
+Configuration can be set at three levels (in order of precedence):
+
+### 1. Per-Interactor Configuration
+
+Configure individual interactors using either a `configure` block or dedicated methods:
+
+```ruby
+class CreateUser
+  include Interactor
+  include Interactor::Validation
+
+  # Option 1: Using configure block
+  configure do |config|
+    config.halt = true
+    config.mode = :code
+  end
+
+  # Option 2: Using dedicated methods
+  validation_halt true
+  validation_mode :code
+  validation_skip_validate false
+
+  # ... validations and call method
+end
+```
+
+Configuration is inherited from parent classes and can be overridden in child classes.
+
+### 2. Global Configuration
+
+Configure global defaults in an initializer or before your interactors are loaded:
 
 ```ruby
 Interactor::Validation.configure do |config|
@@ -427,10 +463,46 @@ While ActiveModel::Validations is powerful, it's designed for ActiveRecord model
 
 ## Development
 
+### Setup
+
 ```bash
 bundle install
-bundle exec rspec       # Run tests
-bundle exec rubocop     # Lint code
+```
+
+### Running Tests
+
+```bash
+bundle exec rspec                                      # Run all tests
+bundle exec rspec spec/interactor/validation_spec.rb  # Run specific test file
+bundle exec rspec spec/interactor/validation_spec.rb:42  # Run specific test at line 42
+```
+
+### Linting
+
+```bash
+bundle exec rubocop     # Check code style
+bundle exec rubocop -a  # Auto-fix safe issues
+bundle exec rubocop -A  # Auto-fix all issues (use with caution)
+```
+
+### Combined (Default Rake Task)
+
+```bash
+bundle exec rake  # Runs both rspec and rubocop
+```
+
+### Interactive Console
+
+```bash
+bundle exec irb -r ./lib/interactor/validation  # Load gem in IRB
+```
+
+### Gem Management
+
+```bash
+bundle exec rake build     # Build gem file
+bundle exec rake install   # Install gem locally
+bundle exec rake release   # Release gem (requires permissions)
 ```
 
 ## Contributing

data/lib/interactor/validation/validates.rb

@@ -11,6 +11,9 @@ require_relative "validators/array"
 
 module Interactor
   module Validation
+    # Exception raised when validation should halt on first error
+    class HaltValidation < StandardError; end
+
     module Validates
       def self.included(base)
         base.extend(ClassMethods)
@@ -21,18 +24,73 @@ module Interactor
         base.prepend(InstanceMethods)
       end
 
+      class ConfigurationProxy
+        def initialize(config_hash)
+          @config = config_hash
+        end
+
+        def mode=(value)
+          @config[:mode] = value
+        end
+
+        def halt=(value)
+          @config[:halt] = value
+        end
+
+        def skip_validate=(value)
+          @config[:skip_validate] = value
+        end
+      end
+
       module ClassMethods
+        def inherited(subclass)
+          super
+          # Ensure child class gets its own copy of config, merging with parent's config
+          subclass._validation_config = _validation_config.dup
+          # Ensure child class gets its own copy of validations
+          subclass._validations = _validations.dup
+        end
+
         def validates(param_name, **rules, &)
+          # Ensure we have our own copy of validations when first modifying
+          begin
+            self._validations = _validations.dup if _validations.equal?(superclass._validations)
+          rescue StandardError
+            false
+          end
           _validations[param_name] ||= {}
           _validations[param_name].merge!(rules)
           _validations[param_name][:_nested] = build_nested_rules(&) if block_given?
         end
 
+        def configure
+          # Ensure we have our own copy of config before modifying
+          begin
+            self._validation_config = _validation_config.dup if _validation_config.equal?(superclass._validation_config)
+          rescue StandardError
+            false
+          end
+          config = ConfigurationProxy.new(_validation_config)
+          yield(config)
+        end
+
         def validation_halt(value)
+          # Ensure we have our own copy of config before modifying
+          begin
+            self._validation_config = _validation_config.dup if _validation_config.equal?(superclass._validation_config)
+          rescue StandardError
+            false
+          end
           _validation_config[:halt] = value
         end
 
         def validation_mode(value)
+          # Ensure we have our own copy of config before modifying
+          begin
+            self._validation_config = _validation_config.dup if _validation_config.equal?(superclass._validation_config)
+          rescue StandardError
+            false
+          end
           _validation_config[:mode] = value
         end
 
@@ -57,19 +115,8 @@ module Interactor
         end
       end
 
-      # Base module with default validate! that does nothing
-      module BaseValidation
-        def validate!
-          # Default implementation - does nothing
-          # Subclasses can override and call super
-        end
-      end
-
       module InstanceMethods
         def self.prepended(base)
-          # Include BaseValidation so super works in user's validate!
-          base.include(BaseValidation) unless base.ancestors.include?(BaseValidation)
-
           # Include all validator modules
           base.include(Validators::Presence)
           base.include(Validators::Numeric)
@@ -82,31 +129,28 @@ module Interactor
         end
 
         def errors
-          @errors ||= Errors.new
+          @errors ||= Errors.new(halt_checker: -> { validation_config(:halt) })
         end
 
-        def validate!
-          errors.clear
+        def run_validations!
           param_errors = false
 
-          # Run parameter validations
-          if self.class._validations
-            self.class._validations.each do |param, rules|
-              value = context.respond_to?(param) ? context.public_send(param) : nil
-              validate_param(param, value, rules)
-
-              # Halt on first error if configured
-              if validation_config(:halt) && errors.any?
-                context.fail!(errors: format_errors)
-                break
+          begin
+            # Run parameter validations
+            if self.class._validations
+              self.class._validations.each do |param, rules|
+                value = context.respond_to?(param) ? context.public_send(param) : nil
+                validate_param(param, value, rules)
               end
+              param_errors = errors.any?
             end
-            param_errors = errors.any?
-          end
 
-          # Call super to allow user-defined validate! to run
-          # Skip if param validations failed and skip_validate is true
-          super unless param_errors && validation_config(:skip_validate)
+            # Run custom validations if defined
+            # Skip if param validations failed and skip_validate is true
+            validate! if respond_to?(:validate!, true) && !(param_errors && validation_config(:skip_validate))
+          rescue HaltValidation
+            # Validation halted on first error - fall through to fail context
+          end
 
           # Fail context if any errors exist
           context.fail!(errors: format_errors) if errors.any?

data/lib/interactor/validation/version.rb

@@ -2,6 +2,6 @@
 
 module Interactor
   module Validation
-    VERSION = "0.4.0"
+    VERSION = "0.4.1"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: interactor-validation
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.4.1
 platform: ruby
 authors:
 - Wilson Anciro