interactor-validation 0.3.8 → 0.3.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 337f8200b44c78cb5a2eeefa3d9dcd5c5c1ec864ef7f0e18d710309365b21e9f
-  data.tar.gz: 4c0b74a6a2cc0fbc9bd391665da07a454054c7ec29fef12d84dccd6945296ba3
+  metadata.gz: f9c7888fc968eb40b00dbb2225455cd34f60444dfa710eb2d2e3ca991178a572
+  data.tar.gz: 2ff3d6b998b0bc1ec4112c888c7169842335f4829fd215b40e08b98e7e6a38a6
 SHA512:
-  metadata.gz: b3fc4532523214b0723c009ed73b2d75ad5213480ae920261da7263adf2b3929ecef608b1d6b8924461f0fc873cf11777a2f80ea32528a9c8228320025086440
-  data.tar.gz: f58f08c52ef1e58be7d8ddb566d14b8aff8b24c408f1976128decada786ce29570ac38d6df7a862e50f5681e64e3ed9eb73b65fb6909da80504f3b113f28c06b
+  metadata.gz: 622c1af2f52477ccef49d4fea329a2d27d34b4a9cf30387a5c213ad58c7ae0ee8f645a942cde0dc12e2605128c607a204a1d44d7c54004c4205f27a6a3745107
+  data.tar.gz: 57adf88f0a34b152a3af76afdcce71b183dc0e5ef4d79b4bf2ccde88c4dc5cbc15173a2c1e5a257674487b0367ce29261cd721e483a333ac255ca31e5604db59

data/README.md

@@ -365,6 +365,9 @@ Interactor::Validation.configure do |config|
   # Stop at first error for better performance
   config.halt = false  # Set to true to stop on first validation error
 
+  # Skip custom validate! hook when parameter validation fails
+  config.skip_validate = true  # Set to false to always run validate! hook
+
   # Security settings
   config.regex_timeout = 0.1        # Regex timeout in seconds (ReDoS protection)
   config.max_array_size = 1000      # Max array size for nested validation
@@ -476,6 +479,75 @@ end
 - Improve API response times by failing fast
 - Provide cleaner error messages (only the most relevant error)
 
+### Skip Custom Validations on Parameter Errors
+
+Control whether custom `validate!` hooks run when parameter validation fails:
+
+```ruby
+# Default behavior (skip_validate = true)
+class CreateUser
+  include Interactor
+  include Interactor::Validation
+
+  configure_validation do |config|
+    config.skip_validate = true  # Default
+  end
+
+  params :username, :email
+
+  validates :username, presence: true
+  validates :email, presence: true
+
+  def validate!
+    # This will NOT run if username or email validation fails
+    # Improves performance by skipping expensive checks
+    user_exists = User.exists?(username: username)
+    errors.add(:username, "already taken") if user_exists
+  end
+
+  def call
+    User.create!(username: username, email: email)
+  end
+end
+
+# With skip_validate = false, always run validate!
+class CreateUserAlwaysValidate
+  include Interactor
+  include Interactor::Validation
+
+  configure_validation do |config|
+    config.skip_validate = false  # Run validate! even with param errors
+  end
+
+  params :username, :email
+
+  validates :username, presence: true
+  validates :email, presence: true
+
+  def validate!
+    # This WILL run even if username or email is missing
+    # Useful when you need to collect all possible errors
+    user_exists = User.exists?(username: username) if username.present?
+    errors.add(:username, "already taken") if user_exists
+  end
+
+  def call
+    User.create!(username: username, email: email)
+  end
+end
+```
+
+**When to use skip_validate = true (default):**
+- Skip expensive database lookups when basic params are invalid
+- Avoid unnecessary API calls when required fields are missing
+- Improve performance in high-traffic endpoints
+- Fail fast with only parameter validation errors
+
+**When to use skip_validate = false:**
+- Collect all possible validation errors in a single request
+- Always run business logic validations regardless of param state
+- Provide comprehensive error feedback to users
+
 ### ActiveModel Integration
 
 Use ActiveModel's custom validation callbacks:

data/lib/interactor/validation/configuration.rb

@@ -5,7 +5,8 @@ module Interactor
     # Configuration class for interactor validation behavior
     class Configuration
       attr_accessor :halt, :regex_timeout, :max_array_size,
-                    :enable_instrumentation, :cache_regex_patterns
+                    :enable_instrumentation, :cache_regex_patterns,
+                    :skip_validate
       attr_reader :error_mode
 
       # Backward compatibility alias for halt_on_first_error
@@ -22,6 +23,7 @@ module Interactor
         @max_array_size = 1000 # Maximum array size for nested validation (memory protection)
         @enable_instrumentation = false # ActiveSupport::Notifications instrumentation
         @cache_regex_patterns = true # Cache compiled regex patterns for performance
+        @skip_validate = true # Skip validate! hook if validate_params! has errors
       end
 
       def error_mode=(mode)

data/lib/interactor/validation/validates.rb

@@ -146,8 +146,11 @@ module Interactor
             { attribute: error.attribute, type: :invalid, options: {} }
           end
 
-          # Skip custom validations if halt was requested
-          unless @halt_validation
+          # Skip custom validations if configured to skip when param errors exist
+          skip_custom_validation = current_config.skip_validate && existing_error_details.any?
+
+          # Skip custom validations if halt was requested or if configured to skip on param errors
+          unless @halt_validation || skip_custom_validation
             # Call super to allow class's validate! to run and add custom errors
             # Rescue exceptions that might be raised
             begin
@@ -245,7 +248,14 @@ module Interactor
       # Get the current configuration (instance config overrides global config)
       # @return [Configuration] the active configuration
       def current_config
-        @current_config || self.class.validation_config || Interactor::Validation.configuration
+        return @current_config if @current_config
+
+        # Try to get class-level config if available
+        if self.class.respond_to?(:validation_config)
+          self.class.validation_config || Interactor::Validation.configuration
+        else
+          Interactor::Validation.configuration
+        end
       end
 
       # Instrument a block of code if instrumentation is enabled

data/lib/interactor/validation/version.rb

@@ -2,6 +2,6 @@
 
 module Interactor
   module Validation
-    VERSION = "0.3.8"
+    VERSION = "0.3.9"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: interactor-validation
 version: !ruby/object:Gem::Version
-  version: 0.3.8
+  version: 0.3.9
 platform: ruby
 authors:
 - Wilson Anciro