interactor-initializer 0.3.1 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e3ea58c9b012de5b156139019d173263e679ce434a7acd02ff519ddb9a870ff6
-  data.tar.gz: 819740461e55ae27e97c59babe2ef3030feccb3bf28b0c022ffa627e8b994764
+  metadata.gz: 48ae4cdc95136e2d4634abb54b9af7ab13816df90cb147c39bc59d7948f470cf
+  data.tar.gz: 4361edbf7cfc0d182c3a4efa2f0a98f7ed76cbc5283976e4cf7ff1019cc67021
 SHA512:
-  metadata.gz: 0c2e0049fa3c92b586fa67c8c0bc6c6199c92207b2b2eb312af4708866e078b86fe0b3ae804be70754f1b726423b21a8f250c273ab04c2f5c93b4513b6163996
-  data.tar.gz: 711c376811a586fc39f01bcd65cb6c0fde86890585d205dd4e01b9835f01085ad53ffacf3c44c314966ee75e1563e5b443315471b75ea9893d317cbb176284ef
+  metadata.gz: 1782e56969744186ba4edd1f0f14dcbc182897c4a4e087866c01110e643e33fc4d9f16cfc2e080420584fce1da0426032ddd415a140921f0cbc4301817d68ef9
+  data.tar.gz: d462d0249546d8eb8b4da751bd35b223db77b38e10194a3f40912ec8464de2e979863e09450ac022cf8ea732a6e156bf6dacb5be2ec94311169bb54e467f146e

data/.gitignore

@@ -1,6 +1,5 @@
 /.bundle/
 /.yardoc
-/Gemfile.lock
 /_yardoc/
 /coverage/
 /doc/

data/.ruby-version

@@ -0,0 +1 @@
+3.0.3

data/Gemfile.lock

@@ -0,0 +1,35 @@
+PATH
+  remote: .
+  specs:
+    interactor-initializer (1.0.1)
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    diff-lcs (1.5.0)
+    rake (10.5.0)
+    rspec (3.11.0)
+      rspec-core (~> 3.11.0)
+      rspec-expectations (~> 3.11.0)
+      rspec-mocks (~> 3.11.0)
+    rspec-core (3.11.0)
+      rspec-support (~> 3.11.0)
+    rspec-expectations (3.11.0)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.11.0)
+    rspec-mocks (3.11.0)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.11.0)
+    rspec-support (3.11.0)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  bundler
+  interactor-initializer!
+  rake (~> 10.0)
+  rspec (~> 3.0)
+
+BUNDLED WITH
+   2.2.32

data/lib/interactor/initializer/helper.rb

@@ -0,0 +1,62 @@
+# frozen_string_literal: true
+
+class Interactor::Initializer::Helper
+  def self.modify_class(target_class, signature, attributes, class_methods)
+    assignments = attr_assignments(attributes)
+
+    target_class.class_eval <<-RUBY, __FILE__, __LINE__ + 1
+      def initialize(#{signature})
+        #{assignments}
+      end
+
+      #{class_methods}
+    RUBY
+
+    attr_readers(target_class, attributes)
+  end
+
+  def self.attr_readers(target_class, attributes)
+    target_class.class_eval do
+      attributes.each do |attr|
+        attr_reader(attr)
+        protected(attr)
+      end
+    end
+  end
+
+  def self.methods_with_params
+    <<-RUBY
+      def self.for(*args)
+        new(*args).run
+      end
+
+      def self.run(*args)
+        new(*args).run
+      end
+
+      def self.with(*args)
+        new(*args).run
+      end
+    RUBY
+  end
+
+  def self.methods_with_keywords
+    <<-RUBY
+      def self.for(args)
+        new(**args).run
+      end
+
+      def self.run(args)
+        new(**args).run
+      end
+
+      def self.with(args)
+        new(**args).run
+      end
+    RUBY
+  end
+
+  def self.attr_assignments(attributes)
+    attributes.map { |attr| "@#{attr} = #{attr}" }.join(';')
+  end
+end

data/lib/interactor/initializer/version.rb

@@ -1,5 +1,5 @@
 module Interactor
   module Initializer
-    VERSION = '0.3.1'.freeze
+    VERSION = '1.0.1'.freeze
   end
 end

data/lib/interactor/initializer.rb

@@ -1,26 +1,29 @@
+# frozen_string_literal: true
+
 require 'interactor/initializer/version'
-require 'interactor/initializer/attr_readers'
-require 'interactor/initializer/call_methods'
-require 'interactor/initializer/initialize'
+require 'interactor/initializer/helper'
 
 module Interactor
   module Initializer
     def self.included(target_class)
       target_class.extend ClassMethods
-      Interactor::Initializer::CallMethods.for(target_class)
     end
 
     module ClassMethods
       module_function
 
       def initialize_with(*attributes)
-        Interactor::Initializer::Initialize.for(self, attributes)
-        Interactor::Initializer::AttrReaders.for(self, attributes)
+        signature = attributes.join(', ')
+        class_methods = Interactor::Initializer::Helper.methods_with_params
+
+        Interactor::Initializer::Helper.modify_class(self, signature, attributes, class_methods)
       end
 
       def initialize_with_keyword_params(*attributes)
-        Interactor::Initializer::Initialize.for(self, attributes, keyword_params: true)
-        Interactor::Initializer::AttrReaders.for(self, attributes)
+        signature = attributes.map { |attr| "#{attr}:" }.join(', ')
+        class_methods = Interactor::Initializer::Helper.methods_with_keywords
+
+        Interactor::Initializer::Helper.modify_class(self, signature, attributes, class_methods)
       end
     end
   end

data/spec/{initializer/attr_readers_spec.rb → interactor/initializer/helper_spec.rb}

@@ -1,8 +1,11 @@
-describe Interactor::Initializer::AttrReaders do
-  describe '.for' do
-    subject { described_class.for(dummy_class, attributes) }
+# frozen_string_literal: true
+
+describe Interactor::Initializer::Helper do
+  describe '.attr_readers' do
+    subject { described_class.attr_readers(dummy_class, attributes) }
+
     let(:dummy_class) { Class.new }
-    let(:attributes) { [:test1, :test2] }
+    let(:attributes) { %i[test1 test2] }
 
     it 'adds protected attr_reader' do
       subject

data/spec/interactor/initializer_spec.rb

@@ -0,0 +1,109 @@
+# frozen_string_literal: true
+
+describe Interactor::Initializer do
+  let(:interactor) do
+    Class.new do
+      include Interactor::Initializer
+
+      initialize_with :arg1, :arg2
+
+      def run
+        :result
+      end
+    end
+  end
+  let(:params) { %w[value1 value2] }
+
+  describe '.for' do
+    subject { interactor.for(*params) }
+
+    it { is_expected.to eq(:result) }
+  end
+
+  describe '.with' do
+    subject { interactor.with(*params) }
+
+    it { is_expected.to eq(:result) }
+  end
+
+  describe '.run' do
+    subject { interactor.run(*params) }
+
+    it { is_expected.to eq(:result) }
+  end
+
+  describe '.new' do
+    subject { interactor.new(*params) }
+
+    it 'adds instance variables' do
+      expect(subject.instance_variable_get(:@arg1)).to eq 'value1'
+      expect(subject.instance_variable_get(:@arg2)).to eq 'value2'
+    end
+  end
+
+  context 'when incorrect number of params' do
+    subject { interactor.for(*params) }
+
+    let(:params) { %w[value1] }
+
+    it 'raises an error' do
+      expect { subject }.to raise_error(/wrong number of arguments/)
+    end
+  end
+
+  context 'when initialization with keywords' do
+    let(:interactor) do
+      Class.new do
+        include Interactor::Initializer
+
+        initialize_with_keyword_params :arg1, :arg2
+
+        def run
+          :result
+        end
+      end
+    end
+    let(:params) do
+      { arg1: 'value1', arg2: 'value2' }
+    end
+
+    describe '.for' do
+      subject { interactor.for(params) }
+
+      it { is_expected.to eq(:result) }
+    end
+
+    describe '.with' do
+      subject { interactor.with(params) }
+
+      it { is_expected.to eq(:result) }
+    end
+
+    describe '.run' do
+      subject { interactor.run(params) }
+
+      it { is_expected.to eq(:result) }
+    end
+
+    describe '.new' do
+      subject { interactor.new(**params) }
+
+      it 'adds instance variables' do
+        expect(subject.instance_variable_get(:@arg1)).to eq 'value1'
+        expect(subject.instance_variable_get(:@arg2)).to eq 'value2'
+      end
+    end
+
+    context 'when incorrect keywords' do
+      subject { interactor.for(params) }
+
+      let(:params) do
+        { arg1: 'value2', arg4: 'value2' }
+      end
+
+      it 'raises an error' do
+        expect { subject }.to raise_error(/missing keyword: :arg2/)
+      end
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: interactor-initializer
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 1.0.1
 platform: ruby
 authors:
 - Šarūnas Kūjalis
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-04-09 00:00:00.000000000 Z
+date: 2022-03-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -63,19 +63,18 @@ files:
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
+- ".ruby-version"
 - Gemfile
+- Gemfile.lock
 - LICENSE
 - README.md
 - Rakefile
 - interactor-initializer.gemspec
 - lib/interactor/initializer.rb
-- lib/interactor/initializer/attr_readers.rb
-- lib/interactor/initializer/call_methods.rb
-- lib/interactor/initializer/initialize.rb
+- lib/interactor/initializer/helper.rb
 - lib/interactor/initializer/version.rb
-- spec/initializer/attr_readers_spec.rb
-- spec/initializer/call_methods_spec.rb
-- spec/initializer/initialize_spec.rb
+- spec/interactor/initializer/helper_spec.rb
+- spec/interactor/initializer_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/vinted/interactor-initializer
 licenses:

data/lib/interactor/initializer/attr_readers.rb

@@ -1,10 +0,0 @@
-class Interactor::Initializer::AttrReaders
-  def self.for(target_class, attributes)
-    target_class.class_eval do
-      attributes.each do |attribute|
-        attr_reader(attribute)
-        protected(attribute)
-      end
-    end
-  end
-end

data/lib/interactor/initializer/call_methods.rb

@@ -1,9 +0,0 @@
-class Interactor::Initializer::CallMethods
-  METHOD_NAMES = %i(for with run).freeze
-
-  def self.for(target_class)
-    METHOD_NAMES.each do |method_name|
-      target_class.define_singleton_method(method_name) { |*args| new(*args).run }
-    end
-  end
-end

data/lib/interactor/initializer/initialize.rb

@@ -1,35 +0,0 @@
-class Interactor::Initializer::Initialize
-  def self.for(*args, **kwargs)
-    new(*args, **kwargs).run
-  end
-
-  attr_reader :target_class, :attributes, :keyword_params
-
-  def initialize(target_class, attributes, keyword_params: false)
-    @target_class = target_class
-    @attributes = attributes
-    @keyword_params = keyword_params
-  end
-
-  def run
-    target_class.class_eval <<-RUBY
-      def initialize(#{initializer_signature(attributes)})
-        #{attr_assignments(attributes)}
-      end
-    RUBY
-  end
-
-  private
-
-  def initializer_signature(attributes)
-    return attributes.join(', ') unless keyword_params
-
-    attributes.map { |attribute| "#{attribute}:" }.join(', ')
-  end
-
-  def attr_assignments(attributes)
-    attributes.inject('') do |assignments, attribute|
-      "#{assignments}@#{attribute} = #{attribute};"
-    end
-  end
-end

data/spec/initializer/call_methods_spec.rb

@@ -1,13 +0,0 @@
-describe Interactor::Initializer::CallMethods do
-  describe '.for' do
-    subject { described_class.for(dummy_class) }
-    let(:dummy_class) { Class.new }
-
-    it 'adds .for .with and .run class methods' do
-      subject
-      expect(dummy_class).to respond_to :for
-      expect(dummy_class).to respond_to :with
-      expect(dummy_class).to respond_to :run
-    end
-  end
-end

data/spec/initializer/initialize_spec.rb

@@ -1,28 +0,0 @@
-describe Interactor::Initializer::Initialize do
-  describe '.for' do
-    subject { described_class.for(dummy_class, attributes, keyword_params: keyword_params) }
-    let(:dummy_class) { Class.new }
-    let(:attributes) { [:test1, :test2] }
-    let(:keyword_params) { false }
-
-    shared_examples 'object initializer' do
-      it 'adds object initializer' do
-        subject
-        expect(dummy_instance.instance_variable_get(:@test1)).to eq 1
-        expect(dummy_instance.instance_variable_get(:@test2)).to eq 2
-      end
-    end
-
-    it_behaves_like 'object initializer' do
-      let(:dummy_instance) { dummy_class.new(1, 2) }
-    end
-
-    context 'when keyword params' do
-      let(:keyword_params) { true }
-
-      it_behaves_like 'object initializer' do
-        let(:dummy_instance) { dummy_class.new(test1: 1, test2: 2) }
-      end
-    end
-  end
-end