integrity 0.1.9.2 → 0.1.9.3

data/test/helpers/acceptance.rb

@@ -1,4 +1,8 @@
 require File.dirname(__FILE__) + "/../helpers"
+
+gem "foca-storyteller"
+require "storyteller"
+
 require "helpers/acceptance/git_helper"
 
 module AcceptanceHelper

data/test/helpers/acceptance/notifier_helper.rb

@@ -0,0 +1,47 @@
+module NotifierHelper
+  def fill_in_email_notifier
+    fill_in "notifiers[Email][to]",     :with => "quentin@example.com"
+    fill_in "notifiers[Email][from]",   :with => "ci@example.com"
+    fill_in "notifiers[Email][user]",   :with => "inspector"
+    fill_in "notifiers[Email][pass]",   :with => "gadget"
+    fill_in "notifiers[Email][auth]",   :with => "simple"
+    fill_in "notifiers[Email][domain]", :with => "example.com"
+  end
+
+  def fill_in_project_info(name, repo)
+    fill_in "Name",            :with => name
+    fill_in "Git repository",  :with => repo
+    fill_in "Branch to track", :with => "master"
+    fill_in "Build script",    :with => "rake"
+    check   "Public project"
+
+    fill_in_email_notifier
+  end
+
+  def assert_have_email_notifier
+    assert_have_tag "input#email_notifier_to[@value='quentin@example.com']"
+    assert_have_tag "input#email_notifier_from[@value='ci@example.com']"
+    assert_have_tag "input#email_notifier_user[@value='inspector']"
+    assert_have_tag "input#email_notifier_pass[@value='gadget']"
+    assert_have_tag "input#email_notifier_auth[@value='simple']"
+    assert_have_tag "input#email_notifier_domain[@value='example.com']"
+  end
+
+  def add_project(name, repo)
+    visit "/new"
+    fill_in_project_info(name, repo)
+    click_button "Create Project"
+
+    assert_have_tag("h1", :content => name)
+    click_link 'Edit Project'
+    assert_have_email_notifier
+  end
+
+  def edit_project(name)
+    visit "/#{name}"
+    click_link "Edit Project"
+    assert_have_email_notifier
+    fill_in :branch, :with => "testing"
+    click_button "Update Project"
+  end
+end

data/test/unit/build_test.rb

@@ -36,16 +36,6 @@ class BuildTest < Test::Unit::TestCase
       @build.successful = false
       @build.status.should be(:failed)
     end
-
-    test "deprecated properties" do
-      @build.short_commit_identifier.should == @build.commit.short_identifier
-      @build.commit_identifier.should == @build.commit.identifier
-      @build.commit_author.should     == @build.commit.author
-      @build.commit_message.should    == @build.commit.message
-      @build.commited_at.should       == @build.commit.committed_at
-      @build.project_id.should        == @build.commit.project_id
-      @build.should respond_to(:commit_metadata)
-    end
   end
 
   describe "Pending builds" do
@@ -58,4 +48,25 @@ class BuildTest < Test::Unit::TestCase
       Build.should have(3).pending
     end
   end
+
+  describe "Queueing a build" do
+    before(:each) do
+      @commit = Commit.gen
+      stub.instance_of(ProjectBuilder).build(@commit)
+    end
+
+    it "creates an empty Build" do
+      @commit.build.should be_nil
+      Build.queue(@commit)
+      @commit.build.should_not be_nil
+    end
+
+    it "ensures the build is saved" do
+      @commit.build.should be_nil
+      Build.queue(@commit)
+
+      commit = Commit.first(:identifier => @commit.identifier)
+      commit.build.should_not be_nil
+    end
+  end
 end

data/test/unit/commit_test.rb

@@ -32,6 +32,8 @@ class CommitTest < Test::Unit::TestCase
       commit.author.name.should == "Nicolás Sanguinetti"
       commit.author.email.should == "contacto@nicolassanguinetti.info"
       commit.author.full.should == "Nicolás Sanguinetti <contacto@nicolassanguinetti.info>"
+
+      Commit.gen(:author => nil).author.to_s.should =~ /not loaded/
     end
 
     it "raises ArgumentError with invalid author" do
@@ -41,6 +43,8 @@ class CommitTest < Test::Unit::TestCase
     it "has a commit message" do
       commit = Commit.gen(:message => "This commit rocks")
       commit.message.should == "This commit rocks"
+
+      Commit.gen(:message => nil).message.should =~ /not loaded/
     end
 
     it "has a commit date" do
@@ -59,25 +63,4 @@ class CommitTest < Test::Unit::TestCase
       commit.human_readable_status.should be("658ba96 hasn't been built yet")
     end
   end
-
-  describe "Queueing a build" do
-    before(:each) do
-      @commit = Commit.gen
-      stub.instance_of(ProjectBuilder).build(@commit)
-    end
-
-    it "creates an empty Build" do
-      @commit.build.should be_nil
-      @commit.queue_build
-      @commit.build.should_not be_nil
-    end
-
-    it "ensures the build is saved" do
-      @commit.build.should be_nil
-      @commit.queue_build
-
-      commit = Commit.first(:identifier => @commit.identifier)
-      commit.build.should_not be_nil
-    end
-  end
 end

data/test/unit/helpers_test.rb

@@ -53,15 +53,19 @@ class BrowsePublicProjectsTest < Test::Unit::TestCase
     end
 
     test "commit" do
-      assert_equal "/ci/foo-bar/commits/#{@commit.identifier}",
-        @h.commit_path(@build.commit)
-      assert_equal "http://example.org/ci/foo-bar/commits/#{@commit.identifier}",
-        @h.commit_url(@build.commit).to_s
+      silence_warnings {
+        assert_equal "/ci/foo-bar/commits/#{@commit.identifier}",
+          @h.commit_path(@build.commit)
+        assert_equal "http://example.org/ci/foo-bar/commits/#{@commit.identifier}",
+          @h.commit_url(@build.commit).to_s
+      }
     end
 
     test "compat" do
-      assert_equal @h.build_path(@build), @h.commit_path(@build.commit)
-      assert_equal @h.build_url(@build),  @h.commit_url(@build.commit)
+      silence_warnings {
+        assert_equal @h.build_path(@build), @h.commit_path(@build.commit)
+        assert_equal @h.build_url(@build),  @h.commit_url(@build.commit)
+      }
     end
   end
 

data/test/unit/migrations_test.rb

@@ -24,13 +24,14 @@ class MigrationsTest < Test::Unit::TestCase
 
   before(:each) do
     [Project, Build, Commit, Notifier].each(&:auto_migrate_down!)
+    database_adapter.execute("DROP TABLE migration_info")
     assert !table_exists?("migration_info") # just to be sure
   end
 
   test "upgrading a pre migration database" do
-    util_capture { Integrity.migrate_db }
+    capture_stdout { Integrity.migrate_db }
 
-    current_migrations.should == ["initial", "add_commits"]
+    current_migrations.should == ["initial", "add_commits", "add_enabled_column"]
     assert table_exists?("integrity_projects")
     assert table_exists?("integrity_builds")
     assert table_exists?("integrity_notifiers")
@@ -40,8 +41,8 @@ class MigrationsTest < Test::Unit::TestCase
   test "migrating data from initial to add_commits migration" do
     load_initial_migration_fixture
 
-    util_capture { Integrity.migrate_db }
-    current_migrations.should == ["initial", "add_commits"]
+    capture_stdout { Integrity.migrate_db }
+    current_migrations.should == ["initial", "add_commits", "add_enabled_column"]
 
     sinatra = Project.first(:name => "Sinatra")
     sinatra.should have(1).commits

data/test/unit/notifier/base_test.rb

@@ -0,0 +1,43 @@
+require File.dirname(__FILE__) + "/../../helpers"
+
+class BaseNotifierTest < Test::Unit::TestCase
+  before(:each) do
+    @commit = Commit.gen(:successful)
+    @base = Notifier::Base.new(@commit, {})
+  end
+
+  it "requires to implement .to_haml" do
+    assert_raise(NotImplementedError) { Notifier::Base.to_haml }
+  end
+
+  it "requires to implement #deliver!" do
+    assert_raise(NotImplementedError) { @base.deliver! }
+  end
+
+  it "provides a short message" do
+    assert_equal "Built #{@commit.short_identifier} successfully", @base.short_message
+  end
+
+  it "provides a full message" do
+    assert @base.full_message.include?("Commit Message: #{@commit.message}")
+    assert @base.full_message.include?("Commit Date: #{@commit.committed_at}")
+    assert @base.full_message.include?("Commit Author: #{@commit.author.name}")
+    assert @base.full_message.include?("Link: #{@base.commit_url}")
+    assert @base.full_message.include?("Build Output")
+    assert @base.full_message.include?(@commit.build.output)
+  end
+
+  it "provides a commit url" do
+    assert_equal "http://localhost:8910/#{@commit.project.name}" +
+      "/commits/#{@commit.identifier}", @base.commit_url
+  end
+
+  test "deprecated methods" do
+    silence_warnings {
+      assert_equal @base.commit, @base.build
+      assert_equal @base.commit_url, @base.build_url
+      assert_equal @base.send(:stripped_commit_output),
+        @base.send(:stripped_build_output)
+    }
+  end
+end

data/test/unit/notifier_test.rb

@@ -1,11 +1,6 @@
 require File.dirname(__FILE__) + "/../helpers"
 
 class NotifierTest < Test::Unit::TestCase
-  test "deprecated methods" do
-    Notifier::Base.new(Build.gen, {}).should respond_to(:build)
-    Notifier::Base.new(Build.gen, {}).should respond_to(:build_url)
-  end
-
   specify "IRC fixture is valid and can be saved" do
     lambda do
       Notifier.generate(:irc).tap do |project|
@@ -71,58 +66,32 @@ class NotifierTest < Test::Unit::TestCase
     end
   end
 
-  it "knows which notifiers are available" do
-    Notifier.gen(:irc)
-    Notifier.gen(:twitter)
-    Notifier.should have(2).available
-    Notifier.available.should include(Integrity::Notifier::IRC)
-    Notifier.available.should include(Integrity::Notifier::Twitter)
-  end
+  describe "Registering a notifier" do
+    it "registers given notifier class" do
+      load "helpers/acceptance/textfile_notifier.rb"
 
-  it "knows how to notify the world of a build" do
-    irc   = Notifier.generate(:irc)
-    build = Integrity::Build.generate
-    Notifier::IRC.expects(:notify_of_build).with(build, irc.config)
-    irc.notify_of_build(build)
-  end
+      Notifier.register(Integrity::Notifier::Textfile)
 
-  describe "Enabling a list of notifiers for a project" do
-    it "creates new notifiers for the project" do
-      project = Project.generate
-      lambda do
-        project.enable_notifiers(["IRC", "Twitter"],
-          {"IRC" => {"uri" => "irc://irc.freenode.net/integrity"},
-           "Twitter" => {"username" => "john"}})
-      end.should change(project.notifiers, :count).from(0).to(2)
+      assert_equal Integrity::Notifier::Textfile,
+        Notifier.available["Textfile"]
     end
 
-    it "deletes all of previous notifiers" do
-      project = Project.generate(:notifiers => [Notifier.gen(:irc), Notifier.gen(:twitter)])
-      lambda do
-        project.enable_notifiers("IRC", {"IRC" => {:foo => "bar"}})
-        project.reload
-      end.should change(project.notifiers, :count).from(2).to(1)
-    end
+    it "raises ArgumentError if given class is not a valid notifier" do
+      assert_raise(ArgumentError) {
+        Notifier.register(Class.new)
+      }
 
-    it "does nothing if given nil as the list of notifiers to enable" do
-      lambda { Project.gen.enable_notifiers(nil, {}) }.should_not change(Notifier, :count)
+      assert Notifier.available.empty?
     end
+  end
 
-    it "doesn't destroy any of the other notifiers that exist for other projects" do
-      irc = Notifier.generate(:irc)
-
-      project = Project.gen
-      project.enable_notifiers("IRC", {"IRC" => irc.config})
+  it "knows how to notify the world of a build" do
+    irc   = Notifier.gen(:irc)
+    Notifier.register(Integrity::Notifier::IRC)
+    build = Build.gen
 
-      lambda do
-        Project.gen.enable_notifiers("IRC", {"IRC" => irc.config})
-      end.should_not change(project.notifiers, :count)
-    end
-  end
+    mock(Notifier::IRC).notify_of_build(build, irc.config) { nil }
 
-  it "requires notifier classes to implement Notifier.to_haml and Notifier#deliver!" do
-    class Blah < Notifier::Base; end
-    lambda { Blah.to_haml }.should raise_error(NoMethodError)
-    lambda { Blah.new(Build.gen, {}).deliver! }.should raise_error(NoMethodError)
+    irc.notify_of_build(build)
   end
 end

data/test/unit/project_builder_test.rb

@@ -52,7 +52,6 @@ class ProjectBuilderTest < Test::Unit::TestCase
       }.should raise_error
     end
 
-
     it "sets the build status to failure when the build command exits with a non-zero status" do
       @project.update_attributes(:command => "exit 1")
       SCM::Git.any_instance.expects(:with_revision).with(@commit.identifier).yields
@@ -94,6 +93,14 @@ class ProjectBuilderTest < Test::Unit::TestCase
       @project.update_attributes(:uri => "scm://example.org")
       lambda { ProjectBuilder.new(@project) }.should raise_error(SCM::SCMUnknownError)
     end
+
+    it "doesn't fail if the commit identifier can't be retrieved" do
+      SCM::Git.any_instance.expects(:with_revision).with(@commit.identifier).yields
+      SCM::Git.any_instance.expects(:info).returns(false)
+      lambda {
+        ProjectBuilder.new(@project).build(@commit)
+      }.should_not raise_error
+    end
   end
 
   describe "When deleting the code from disk" do

data/test/unit/project_test.rb

@@ -110,11 +110,6 @@ class ProjectTest < Test::Unit::TestCase
       project = Project.gen(:commits => commits)
       project.last_commit.should == commits.sort_by {|c| c.committed_at }.last
     end
-
-    test "deprecated properties" do
-      @project.last_build.should      == @project.last_commit
-      @project.previous_builds.should == @project.previous_commits
-    end
   end
 
   describe "Validation" do
@@ -218,31 +213,113 @@ class ProjectTest < Test::Unit::TestCase
     end
   end
 
+  describe "When updating its notifiers" do
+    setup do
+      twitter = Notifier.gen(:twitter, :enabled => true)
+      irc     = Notifier.gen(:irc,     :enabled => false)
+
+      @project = Project.gen(:notifiers => [twitter, irc])
+    end
+
+    it "creates and enable the given notifiers" do
+      Notifier.all.destroy!
+
+      project = Project.gen
+      project.update_notifiers(["IRC", "Twitter"],
+          {"IRC"     => {"uri" => "irc://irc.freenode.net/integrity"},
+           "Twitter" => {"username" => "john"}})
+
+      assert_equal 2,         Notifier.count
+      assert_equal 2,         project.enabled_notifiers.count
+      assert_equal "IRC",     project.notifiers.first.name
+      assert_equal "Twitter", project.notifiers.last.name
+
+      project.update_notifiers(["Twitter"],
+          {"IRC"     => {"uri" => "irc://irc.freenode.net/integrity"},
+           "Twitter" => {"username" => "john"}})
+
+      assert_equal 2, Notifier.count
+      assert ! project.notifies?("IRC")
+      assert   project.notifies?("Twitter")
+    end
+
+    it "creates notifiers present in config even when they're disabled" do
+      @project.update_notifiers(["IRC"],
+        {"IRC"     => {"uri" => "irc://irc.freenode.net/integrity"},
+         "Twitter" => {"username" => "john"}})
+
+      assert_equal 2, @project.notifiers.count
+    end
+
+    it "disables notifiers that are not included in the list" do
+      @project.update_notifiers(["IRC"],
+          {"IRC"     => {"uri" => "irc://irc.freenode.net/integrity"},
+           "Twitter" => {"username" => "john"}})
+
+      @project.update_notifiers(["IRC"],
+        {"IRC"     => {"uri" => "irc://irc.freenode.net/integrity"}})
+
+      assert ! @project.notifiers.first(:name => "Twitter").enabled?
+      assert   @project.notifiers.first(:name => "IRC").enabled?
+    end
+
+    it "preserves config of notifiers that are being disabled" do
+      @project.update_notifiers(["IRC"],
+        {"IRC"     => {"uri" => "irc://irc.freenode.net/integrity"},
+          "Twitter" => {"username" => "john"}})
+
+      assert_equal "john",
+        @project.notifiers.first(:name => "Twitter").config["username"]
+    end
+
+    it "does nothing if given nil as the list of notifiers to enable" do
+      lambda { Project.gen.update_notifiers(nil, {}) }.should_not change(Notifier, :count)
+    end
+
+    it "doesn't destroy any of the other notifiers that exist for other projects" do
+      irc = Notifier.generate(:irc)
+
+      project = Project.gen
+      project.update_notifiers("IRC", {"IRC" => irc.config})
+
+      lambda {
+        Project.gen.update_notifiers("IRC", {"IRC" => irc.config})
+      }.should_not change(project.notifiers, :count)
+    end
+  end
+
   describe "When retrieving state about its notifier" do
     before(:each) do
-      @project = Project.generate
+      @project = Project.gen
       @irc     = Notifier.generate(:irc)
     end
 
+    it "knows which notifiers are enabled" do
+      notifiers = [Notifier.gen(:irc, :enabled => false),
+        Notifier.gen(:twitter, :enabled => true)]
+      project = Project.gen(:notifiers => notifiers)
+
+      assert_equal 1, project.enabled_notifiers.size
+    end
+
     specify "#config_for returns given notifier's configuration" do
       @project.update_attributes(:notifiers => [@irc])
       @project.config_for("IRC").should == {:uri => "irc://irc.freenode.net/integrity"}
     end
 
-    specify "#config_for returns an empty hash if no such notifier" do
+    specify "#config_for returns an empty hash for unknown notifier" do
       @project.config_for("IRC").should == {}
     end
 
-    specify "#notifies? is true if it uses the given notifier" do
-      @project.update_attributes(:notifiers => [@irc])
-      @project.notifies?("IRC").should == true
-    end
+    specify "#notifies? is true if the notifier exists and is enabled" do
+      assert ! @project.notifies?("UndefinedNotifier")
 
-    specify "#notifies? is false if it doesnt use the given notifier" do
-      @project.update_attributes(:notifiers => [])
+      @project.update_attributes(:notifiers =>
+        [ Notifier.gen(:irc, :enabled     => true),
+          Notifier.gen(:twitter, :enabled => false) ])
 
-      @project.notifies?("IRC").should == false
-      @project.notifies?("UndefinedNotifier").should == false
+      assert @project.notifies?("IRC")
+      assert ! @project.notifies?("Twitter")
     end
   end
 
@@ -275,13 +352,12 @@ class ProjectTest < Test::Unit::TestCase
       }.should change(Commit, :count).by(1)
 
       build = Build.all.last
-      build.commit.should be(@project.last_commit)
+      build.commit.should == @project.last_commit
 
       @project.last_commit.should be_pending
-      @project.last_commit.identifier.should be("FOOBAR")
-
+      @project.last_commit.identifier.should  == "FOOBAR"
       @project.last_commit.author.name.should == "<Commit author not loaded>"
-      @project.last_commit.message.should == "<Commit message not loaded>"
+      @project.last_commit.message.should     == "<Commit message not loaded>"
     end
   end
 end