instrument_all_the_things 1.0.3 → 1.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ac64a9b7acfa4de004260992b1c4f664587345e692a6f08f9798442b0568619d
-  data.tar.gz: 6bd26e6ea3186c4ca0883a4a2971dc2980f0c71409f6654a5da1ab183539b372
+  metadata.gz: 8233c84f173a53f91f896e019fa3ad70cbf0834cc43b3291c341c633099cc13b
+  data.tar.gz: 71cb7736c90caa59f66e7666eb20d8b3c0a71510c0e0dd2b740ee6f3397174d0
 SHA512:
-  metadata.gz: 97d28f7d5a86fbaf0cc1a9792ad26d39cc2a34ddc9bbbba9c82d413f19b785136af1319dc27f1a44c72f494b701fcf11003743edae6276c30a0ec100da054de8
-  data.tar.gz: d78092b9f1ad421ba8674ad830821558399dd471117f4fe1efda3905ef0dc472e421c4105288790582d76f15d60f8881a3da6554050ff69f50ae1a071e46fc19
+  metadata.gz: 6614358e22371b877b9b79f63807906dcc08560a8585dcaeb985599ef889ef900c60a911ef15a1554749da0d84f0bcc92c4cffa4bd38b7b8ef5c3d0e8dbd3704
+  data.tar.gz: 8a19bb27f82820e1bb8695355e6e8761c02e3237e0a33c441831a57969d21a7192c96e1ccf92c35fc008d03f075227d1306583ccdbaea352ea9e2dd6a365a063

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    instrument_all_the_things (1.0.3)
+    instrument_all_the_things (1.0.4)
       ddtrace
       dogstatsd-ruby
 
@@ -11,7 +11,7 @@ GEM
     ast (2.4.0)
     benchmark-ips (2.7.2)
     coderay (1.1.2)
-    ddtrace (0.33.1)
+    ddtrace (0.34.0)
       msgpack
     diff-lcs (1.3)
     docile (1.3.2)
@@ -71,4 +71,4 @@ DEPENDENCIES
   simplecov
 
 BUNDLED WITH
-   2.0.2
+   2.1.4

data/README.md

@@ -93,6 +93,32 @@ also be passed to the DataDog tracer, and their [options](https://github.com/Dat
 | span_type | See DD Docs.                                                  | `nil`
 | tags      | Set of tags to be added to the span, expected to be a hash    | {}
 
+#### Dynamic Tags
+
+If a trace's tags need to reference either an instance variable or a parameter to the method being traced, you must pass in a proc for the tag value.
+
+For instance variables, this will look like this:
+```ruby
+instrument trace: { tags: [-> { "some_stat:#{some_instance_var}" }]}
+def my_instance_method
+...
+end
+```
+
+For parameter references, your proc will need to to have a parameter of `args` or `kwargs` (or both), depending on if the parameter you need to reference is a normal parameter or a keyword parameter. Examples:
+
+```ruby
+instrument trace: { tags: [->(args) { "log_args:#{args[0]}" }]}
+def my_instance_method(my_var)
+...
+end
+
+instrument trace: { tags: [->(kwargs) { "log_args:#{kwargs[:my_arg]}" }]}
+def my_instance_method(my_arg:)
+...
+end
+```
+
 ## Testing Support
 
 You can setup your test environment by running the following setup:

data/lib/instrument_all_the_things/method_proxy.rb

@@ -40,21 +40,24 @@ module InstrumentAllTheThings
         @_iatt_built_for = val
       end
 
-      def set_context_tags(klass, settings, *args, **kwargs) # rubocop:disable Lint/UnusedMethodArgument
+      def set_context_tags(klass, settings, args, kwargs)
         return unless settings.is_a?(Hash) && settings[:trace].is_a?(Hash) && settings[:trace][:tags]
 
         settings[:context][:tags] = settings[:trace][:tags].map do |tag|
           if tag.is_a?(Proc)
-            if tag.arity == 1
-              tag.call(eval(tag.parameters[0][1].to_s))
+            case tag.arity
+            when 2
+              tag.call(args, kwargs)
+            when 1
+              tag.parameters[0][1].to_s == 'args' ? tag.call(args) : tag.call(kwargs)
             else
               klass.instance_exec(&tag)
             end
           else
             tag
           end
-        rescue StandardError
-          nil
+          rescue StandardError
+            nil
         end.compact
       end
 

data/lib/instrument_all_the_things/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module InstrumentAllTheThings
-  VERSION = '1.0.3'
+  VERSION = '1.0.4'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: instrument_all_the_things
 version: !ruby/object:Gem::Version
-  version: 1.0.3
+  version: 1.0.4
 platform: ruby
 authors:
 - Brian Malinconico
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-04-01 00:00:00.000000000 Z
+date: 2020-04-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ddtrace
@@ -176,7 +176,7 @@ files:
 - vendor/cache/ast-2.4.0.gem
 - vendor/cache/benchmark-ips-2.7.2.gem
 - vendor/cache/coderay-1.1.2.gem
-- vendor/cache/ddtrace-0.33.1.gem
+- vendor/cache/ddtrace-0.34.0.gem
 - vendor/cache/diff-lcs-1.3.gem
 - vendor/cache/docile-1.3.2.gem
 - vendor/cache/dogstatsd-ruby-4.7.0.gem