instant_quote 1.7.19 → 1.7.21

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2b94c442934e40507587cd652e9ec9683419ce66c75d2166e7ac8c5aef42fc52
-  data.tar.gz: 3f58db1c317c52cf60ab2b8ab18b7f70964621698eb867484c5cc9bca9270c63
+  metadata.gz: 502f0004b8814d403960af4d7224d6f3e14dddc643b5cded504f2ae4d936e639
+  data.tar.gz: f5de71cb828ecc9c2b7c1ce4675717bd21554ee3746e822555c9720a4a0aa91b
 SHA512:
-  metadata.gz: 5e8d155b93561766d13ff661689591bdd6e76da37b3843e7e46bc800e7adfe6c662c6bd2cbe268b62d917e0bb8e150df9fede107d6252060bce2a860553a1fb5
-  data.tar.gz: 1d703f56473a6c3b3b851725ca36494c0e5c6fb1185d2460fcbd4f45f07403eb894c6807a97d9b474d553499d7b864f68726c7241859985a33b2504e1c9878bf
+  metadata.gz: 3ca9d74af469fd1895aa53657f67281a8fe53784b6e3ee831e4cd7f16c0d0d7689ec70daf19745c8620f8fdc1a26179babdbea8ebec8c82489304a8531b2c853
+  data.tar.gz: 5e374c6ad1ad7262986829cb503e4871723ebfd90a6de7a6749fc7c98752f3c506b4e67133cbadbee45058797b297fd3f288339b8c4373f6144399e01b7599fb

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    instant_quote (1.7.19)
+    instant_quote (1.7.21)
       activesupport
       capital_on_tap (~> 1.0.1)
       iwoca (~> 1.1.0)

data/bin/console

@@ -32,5 +32,53 @@ end
 
 send(:include, InstantQuote)
 
+# Configuration needed for the Money gem
+Money.default_currency = :gbp
+I18n.available_locales = [:en]
+I18n.locale = :en
+Money.locale_backend = :i18n
+Money.rounding_mode = BigDecimal::ROUND_HALF_EVEN
+
+def declined_v1_json
+  json = '{
+    "data": {
+      "state_key": "[FILTERED]",
+      "approval_requirements": [
+        { "type": "cc", "status": "required" },
+        { "type": "enhanced_security_check", "status": "pending" }
+      ],
+      "approval_status": { "status": "declined" },
+      "latest_approval_request": { "status": "decision_made" }
+    }
+  }'
+
+  JSON.parse(json)
+end
+
+def approved_v1_json
+  json = '{
+    "data": {
+      "state_key": "[FILTERED]",
+      "approval_status": {
+        "approved": {
+          "duration": 24,
+          "interval": "1m",
+          "max_credit": 21000.0,
+          "min_credit": 1.0,
+          "rate_structures": [
+            { "effective_on_day": 0, "rates": [{ "max_principal": 21000.0, "rate": 0.0515 }] }
+          ],
+          "time_out": "2023-09-24T00:00:00Z",
+          "top_up_allowed": false
+        },
+        "status": "approved"
+      },
+      "latest_approval_request": { "status": "decision_made" }
+    }
+  }'
+
+  JSON.parse(json)
+end
+
 require 'pry'
 Pry.start

data/lib/instant_quote/connection_translators/iwoca.rb

@@ -8,13 +8,13 @@ module InstantQuote
           data: {
             company: company_information,
             people: [person_information],
-            requests: [
-              amount: (application.amount_pennies / 100),
-              duration: { amount: 12, unit: 'months' },
-              purpose: application&.proceeds_purpose&.name,
-              product_type: product_name,
-              urgency: 'asap'
-            ]
+            # requests: [
+            #   amount: (application.amount_pennies / 100),
+            #   duration: { amount: 12, unit: 'months' },
+            #   purpose: application&.proceeds_purpose&.name,
+            #   product_type: product_name,
+            #   urgency: 'asap'
+            # ]
           }
         }
       end

data/lib/instant_quote/decision_parsers/iwoca.rb

@@ -98,6 +98,16 @@ module InstantQuote
       # offers - the response of the available offers
       def initialize(data = {})
         @data = super
+
+        # Just in case (v1 has a lot of key 'data' nesting)
+        @data = @data.dig(:data) if @data.key?(:data)
+
+        # It's a v1 JSON response, so we need to translate it to v2 first!
+        if @data.key?(:state_key)
+          puts "Translating v1 JSON to v2..."
+          @data = DecisionParsers::IwocaV2Translator.translate(@data)
+        end
+
         @status = @data[:status] if @data.key?(:status)
         @offers = @data[:offers] if @data.key?(:offers)
       end
@@ -153,7 +163,7 @@ module InstantQuote
       end
 
       def monthly_interest_rate
-        first_offer&.interest_rate
+        first_offer[:interest_rate]
       end
 
       def status

data/lib/instant_quote/decision_parsers/{iwoca_webhook.rb → iwoca_v1.rb}

@@ -2,28 +2,52 @@
 
 module InstantQuote
   module DecisionParsers
-    # Example response:
+    # Example responses:
     #
-    # { data:
-    #   {
-    #     balance: {
-    #       principal: 0.0, interest: 0.0, product_fees: 0.0, other_fees: 0.0, total: 0.0
-    #     },
-    #     latest_approval_request: { status: "no_decision_possible" },
-    #     approval_requirements: [
-    #       { type: "cc", status: "required" },
-    #       { type: "bus_cc", status: "required" },
-    #       { type: "dir_guarantor", status: "required" },
-    #       { type: "enhanced_security_check", status: "pending" }
+    # {
+    #   "data": {
+    #     "state_key": "[FILTERED]",
+    #     "approval_requirements": [
+    #       { "type": "enhanced_security_check", "status": "pending" }
+    #     ],
+    #     "approval_status": { "status": "declined" },
+    #     "latest_approval_request": { "status": "decision_made" }
+    #   }
+    # }
+    #
+    # {
+    #   "data": {
+    #     "state_key": "[FILTERED]",
+    #     "approval_requirements": [
+    #       { "type": "cc", "status": "required" },
+    #       { "type": "enhanced_security_check", "status": "pending" }
     #     ],
-    #     funding_requirements: [
-    #       { status: "required", type: "fraud" },
-    #       { type: "docs", status: "required" },
-    #       { type: "enhanced_security_check", status: "pending" }
-    #     ]
+    #     "approval_status": { "status": "declined" },
+    #     "latest_approval_request": { "status": "decision_made" }
     #   }
     # }
-    class IwocaWebhook < DecisionParser
+    #
+    # {
+    #   "data": {
+    #     "state_key": "[FILTERED]",
+    #     "approval_status": {
+    #       "approved": {
+    #         "duration": 24,
+    #         "interval": "1m",
+    #         "max_credit": 21000.0,
+    #         "min_credit": 1.0,
+    #         "rate_structures": [
+    #           { "effective_on_day": 0, "rates": [{ "max_principal": 21000.0, "rate": 0.0515 }] }
+    #         ],
+    #         "time_out": "2023-09-24T00:00:00Z",
+    #         "top_up_allowed": false
+    #       },
+    #       "status": "approved"
+    #     },
+    #     "latest_approval_request": { "status": "decision_made" }
+    #   }
+    # }
+    class IwocaV1 < DecisionParser
       STATUSES = {
         pending: 'pending',
         approved: 'approved',
@@ -78,6 +102,11 @@ module InstantQuote
         Money.new(amount_approved * 100).format
       end
 
+      # Only used by the new iwoca2 translator
+      def amount_unformatted
+        status_hash.dig(:approved, :max_credit) || 0
+      end
+
       def credit_duration
         status_hash.dig(:approved, :duration)
       end

data/lib/instant_quote/decision_parsers/iwoca_v2_translator.rb

@@ -0,0 +1,69 @@
+# frozen_string_literal: true
+
+require 'instant_quote/decision_parsers/iwoca'
+
+# This class is used to translate iwoca's v1 decision format to v2. In the app we might have some
+# decisions stored with the v1 format that need translation but the webhook at the moment is also
+# using the old format (with state_key instead of customer_id).
+module InstantQuote
+  module DecisionParsers
+    class IwocaV2Translator
+      def initialize(v1_json)
+        @decision = InstantQuote::DecisionParsers::IwocaV1.new(v1_json)
+      end
+
+      def self.translate(decision)
+        new(decision).translate
+      end
+
+      # Translates the v1 JSON into v2 format.
+      def translate
+        {
+          status: {
+            status: translate_status(@decision.status),
+            requests: [
+              {
+                suggested_product: {
+                  amount: @decision.amount_unformatted,
+                  duration: {
+                    unit: translate_interval(@decision.credit_interval),
+                    amount: @decision.credit_duration
+                  },
+                }
+              }
+            ]
+          },
+          offers: [
+            {
+              interest_rate: @decision.monthly_interest_rate
+            }
+          ],
+        }
+      end
+
+      private
+
+      def translate_status(v1_status)
+        case v1_status
+        when 'approved'
+          'funded'
+        else
+          v1_status
+        end
+      end
+
+      def translate_interval(v1_interval)
+        case v1_interval
+        when '1m'
+          'months'
+        when '1w'
+          'weeks'
+        when '1d'
+          'days'
+        else
+          'months'
+        end
+      end
+    end
+  end
+end

data/lib/instant_quote/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module InstantQuote
-  VERSION = '1.7.19'
+  VERSION = '1.7.21'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: instant_quote
 version: !ruby/object:Gem::Version
-  version: 1.7.19
+  version: 1.7.21
 platform: ruby
 authors:
 - rikas
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2023-08-30 00:00:00.000000000 Z
+date: 2023-08-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -158,7 +158,8 @@ files:
 - lib/instant_quote/decision_parsers/iwoca_flexi24.rb
 - lib/instant_quote/decision_parsers/iwoca_recovery_loans.rb
 - lib/instant_quote/decision_parsers/iwoca_revenue_based_loans.rb
-- lib/instant_quote/decision_parsers/iwoca_webhook.rb
+- lib/instant_quote/decision_parsers/iwoca_v1.rb
+- lib/instant_quote/decision_parsers/iwoca_v2_translator.rb
 - lib/instant_quote/decision_parsers/optimum.rb
 - lib/instant_quote/decision_parsers/youlend.rb
 - lib/instant_quote/version.rb