instant_quote 1.6.3 → 1.7.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: abc48d75b550699ee2f7ac657e783b7dfdf135cdeba67174fa555e2c8219eb67
-  data.tar.gz: 16445d466e8628ad37c2f74efbb04669413164936e5c35602fd73a0bbce2d28a
+  metadata.gz: 15d07ba008846c863937a179a6d330833031b4291a595f30bf0701980a3c1bc0
+  data.tar.gz: 102ede083d49fc37c21ab29277e8eed0433fe4961dca1bffb9576c641b002894
 SHA512:
-  metadata.gz: 0ed04a2b5e3502847768a7e1669e85e50fe332da5afa4191d76ed481b6cbf9e35d5954f294ec34933490d028357bf28bbac08386e71cbc628523df07e2e1c6a6
-  data.tar.gz: fd6c81808739183be1d69f526014812b64c2fb8c15044c11b8b3fdd17ae6f1ede25a1365a27e64948b0a7e3c61ce0c884ebcc17c20fa4b98e0820bf1346fec27
+  metadata.gz: 00b3e2c8bb67d19a2e2be46bd261404bf0763a2876d1a32fbdd1bcbe8f584759485c3566d7c049a511958ae0a02c8cd4c7a6987647d822e1715e62196b8af315
+  data.tar.gz: 4c85a4d8f1d65aae349b62c2defb1d01e5342444ed2a345da25b3f7e27d0e77a37a08d947e9c2a743f4d80e9c511c2e77797385bad1bb2442cb8c8a08ccc71ea

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    instant_quote (1.6.3)
+    instant_quote (1.7.4)
       activesupport
       capital_on_tap
       iwoca
@@ -13,7 +13,7 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (6.1.1)
+    activesupport (6.1.3)
       concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (>= 1.6, < 2)
       minitest (>= 5.1)
@@ -44,7 +44,7 @@ GEM
     faraday_middleware (1.0.0)
       faraday (~> 1.0)
     hashdiff (1.0.1)
-    i18n (1.8.8)
+    i18n (1.8.9)
       concurrent-ruby (~> 1.0)
     iwoca (1.0.0)
       addressable

data/lib/instant_quote/adapter.rb

@@ -23,42 +23,42 @@ module InstantQuote
       new.get_link(connection)
     end
 
-    def self.get_quote(params, connection = nil)
+    def self.get_quote(params, connection)
       new.get_quote(params, connection)
     end
 
-    def self.get_status(application_id, connection = nil)
+    def self.get_status(application_id, connection)
       new.get_status(application_id, connection)
     end
 
-    def self.get_preapproval(params, connection = nil)
+    def self.get_preapproval(params, connection)
       new.get_preapproval(params, connection)
     end
 
-    def self.get_approval(application_id, connection = nil)
+    def self.get_approval(application_id, connection)
       new.get_approval(application_id, connection)
     end
 
-    def get_link(_application_id, _connection = nil)
+    def get_link(_connection)
       raise NotImplementedError, "You must implement '#{self.class.name}#get_link'"
     end
 
-    def get_quote(_params, _connection = nil)
+    def get_quote(_params, _connection)
       raise NotImplementedError, "You must implement '#{self.class.name}#get_quote'"
     end
 
-    def get_status(_application_id, _connection = nil)
+    def get_status(_application_id, _connection)
       raise NotImplementedError, "You must implement '#{self.class.name}#get_status'"
     end
 
-    # Default for pre approval will be true, override it in the adapter class if needed.
-    def get_preapproval(_params, _connection = nil)
-      true
+    # Default for pre approval will be success, override it in the adapter class if needed.
+    def get_preapproval(_params, _connection)
+      OpenStruct.new(success?: true)
     end
 
-    # Default for approval will be true, override it in the adapter class if needed.
-    def get_approval(_application_id, _connection = nil)
-      true
+    # Default for approval will be success, override it in the adapter class if needed.
+    def get_approval(_application_id, _connection)
+      OpenStruct.new(success?: true)
     end
   end
 end

data/lib/instant_quote/adapter_finder.rb

@@ -56,7 +56,7 @@ module InstantQuote
     end
 
     def get_approval
-      adapter.get_approval(connection.external_id)
+      adapter.get_approval(connection.external_id, connection)
     end
 
     def additional_fields

data/lib/instant_quote/adapters/capital_on_tap.rb

@@ -70,7 +70,7 @@ module InstantQuote
       # rubocop:enable Layout/LineLength
 
       # Creates the quote with the information from instant connection
-      def get_quote(params)
+      def get_quote(params, _connection)
         response = ::CapitalOnTap::Application.create(params)
 
         # CoT responses can be 200 OK but still have an error!
@@ -94,7 +94,7 @@ module InstantQuote
       #  :links=>{:self=>'/api/v1/Applications/B247T62', :parent=>nil},
       #  :metaData=>{}
       # }
-      def get_status(application_id)
+      def get_status(application_id, _connection)
         response = ::CapitalOnTap::Application.status(application_id)
 
         raise_error(response) unless response.success?

data/lib/instant_quote/adapters/iwoca.rb

@@ -58,7 +58,7 @@ module InstantQuote
       ]
 
       # Creates the iwoca customer and returns the state key from the response.
-      def get_quote(params)
+      def get_quote(params, _connection)
         response = ::Iwoca::Quote.create_customer(params)
 
         return response.data[:state_key] if response.success?
@@ -67,7 +67,7 @@ module InstantQuote
       end
 
       # Get the current status for the created customer.
-      def get_status(state_key)
+      def get_status(state_key, _connection)
         response = ::Iwoca::Quote.credit_facility_status(state_key)
 
         raise_error(response) unless response.success?
@@ -86,7 +86,7 @@ module InstantQuote
         raise_error(response)
       end
 
-      def get_approval(state_key)
+      def get_approval(state_key, _connection)
         response = ::Iwoca::Quote.approval(state_key)
         response.success?
       end

data/lib/instant_quote/adapters/optimum.rb

@@ -96,7 +96,7 @@ module InstantQuote
         }
       ]
 
-      def get_quote(params)
+      def get_quote(params, _connection)
         response = ::Optimum::Decision.create(params)
 
         return response.data[:opportunityId] if response.success?
@@ -104,7 +104,7 @@ module InstantQuote
         raise_error(response)
       end
 
-      def get_status(application_id)
+      def get_status(application_id, _connection)
         response = ::Optimum::Decision.update(application_id)
 
         raise_error(response) unless response.success?

data/lib/instant_quote/adapters/youlend.rb

@@ -9,7 +9,7 @@ module InstantQuote
       additional_fields [
         {
           name: 'monthly_card_revenue',
-          label: 'Avg. monthly revenue from card payments',
+          label: 'Avg. monthly card revenue',
           required: true,
           type: 'money'
         },
@@ -21,7 +21,7 @@ module InstantQuote
         },
         {
           name: 'applicant_consent',
-          label: 'Yes, I give my consent for my data to be shared',
+          label: 'Yes, I give my consent for my data to be shared with YouLend',
           required: true,
           type: 'checkbox'
         }

data/lib/instant_quote/decision_parsers/youlend.rb

@@ -18,18 +18,24 @@ module InstantQuote
     # }
     class Youlend < DecisionParser
       def approved?
-        status_hash[:loanOptions].any?
+        status_hash[:loanOptions].any? && first_option
       end
 
       def declined?
-        status_hash[:loanOptions].empty?
+        !approved?
       end
 
       def sweep
         first_option[:sweep]
       end
 
+      def status
+        approved? ? 'approved' : 'declined'
+      end
+
       def fee
+        return 0.0 unless first_option
+
         fee = first_option[:fee].to_f
 
         Money.new(fee * 100).format
@@ -47,6 +53,8 @@ module InstantQuote
         Money.new(amount * 100).format
       end
 
+      alias amount funded_amount
+
       private
 
       def first_option
@@ -54,7 +62,11 @@ module InstantQuote
       end
 
       def status_hash
-        data.presence || { loanOptions: [] }
+        default = { loanOptions: [] }
+
+        return default unless data && !data.empty?
+
+        data
       end
     end
   end

data/lib/instant_quote/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module InstantQuote
-  VERSION = '1.6.3'
+  VERSION = '1.7.4'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: instant_quote
 version: !ruby/object:Gem::Version
-  version: 1.6.3
+  version: 1.7.4
 platform: ruby
 authors:
 - rikas
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-02-08 00:00:00.000000000 Z
+date: 2021-02-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler