instant_quote 1.1.2 → 1.1.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5ef7de39482768419b0f8fcceef1a519f9a6f59d806663f87855b112255fb901
-  data.tar.gz: 365472c89d076772550acd39988412d8fc6a7501b0684d6a694a88e151802010
+  metadata.gz: 358724fb16cc0c89f578d0b59b1dc3b7f962af917986c46d8c77406cab783abf
+  data.tar.gz: 3cdff1f454bfdb1ac5637912ac0bf421671fcbadf33c98bc0d3533c4f981c054
 SHA512:
-  metadata.gz: 7ba1a1214b4eb23a89b69f90f60195bf7f50d2d45f17b1727571f506dbc033513ec127c56ba18a5061fd93abb6df30b5952cf57bcf0ada33bdda091962fd43b8
-  data.tar.gz: 655bec0c02d728f1e2f39ffa32decbad0754359ede1b60dcfa866b65509316cddc1d0e5ea3ded3b279b1e850b89f2b6d0508d26af472d18f1eececf730bf0a2d
+  metadata.gz: f3bb568804077b6526a0c39debbb36c39da156bbb158dd6e5f4ca32d59797aad9ab140aba3ee37955021196a833754e35281db9d26bf757ac080da991a077526
+  data.tar.gz: 8301b9bd8ce4c50f502e86b0a62faca488a35150a7ad247af3b3148004552c04e70c3c6febf31895bdba94e0c96316e70cf4214be0dd4b68113c26d47b4ab463

data/.rubocop.yml

@@ -15,3 +15,12 @@ Metrics/BlockLength:
 
 Naming/AccessorMethodName:
   Enabled: false
+
+Style/HashEachMethods:
+  Enabled: true
+
+Style/HashTransformKeys:
+  Enabled: true
+
+Style/HashTransformValues:
+  Enabled: true

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    instant_quote (1.1.2)
+    instant_quote (1.1.7)
       activesupport
       capital_on_tap
       iwoca
@@ -11,7 +11,7 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (6.0.2.1)
+    activesupport (6.0.2.2)
       concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (>= 0.7, < 2)
       minitest (~> 5.1)
@@ -29,13 +29,16 @@ GEM
       rainbow
     coderay (1.1.2)
     concurrent-ruby (1.1.6)
+    crack (0.4.3)
+      safe_yaml (~> 1.0.0)
     diff-lcs (1.3)
     docile (1.3.2)
     dotenv (2.7.5)
-    faraday (0.17.3)
+    faraday (1.0.1)
       multipart-post (>= 1.2, < 3)
-    faraday_middleware (0.14.0)
-      faraday (>= 0.7.4, < 1.0)
+    faraday_middleware (1.0.0)
+      faraday (~> 1.0)
+    hashdiff (1.0.1)
     i18n (1.8.2)
       concurrent-ruby (~> 1.0)
     iwoca (1.0.0)
@@ -45,54 +48,61 @@ GEM
       multi_json
       rainbow
     jaro_winkler (1.5.4)
-    method_source (0.9.2)
+    method_source (1.0.0)
     minitest (5.14.0)
     money (6.13.7)
       i18n (>= 0.6.4, <= 2)
     multi_json (1.14.1)
     multipart-post (2.1.1)
     parallel (1.19.1)
-    parser (2.7.0.2)
+    parser (2.7.0.5)
       ast (~> 2.4.0)
     phonelib (0.6.42)
-    pry (0.12.2)
-      coderay (~> 1.1.0)
-      method_source (~> 0.9.0)
-    pry-byebug (3.8.0)
+    pry (0.13.0)
+      coderay (~> 1.1)
+      method_source (~> 1.0)
+    pry-byebug (3.9.0)
       byebug (~> 11.0)
-      pry (~> 0.10)
+      pry (~> 0.13.0)
     public_suffix (4.0.3)
     rainbow (3.0.0)
     rake (10.5.0)
+    rexml (3.2.4)
     rspec (3.9.0)
       rspec-core (~> 3.9.0)
       rspec-expectations (~> 3.9.0)
       rspec-mocks (~> 3.9.0)
     rspec-core (3.9.1)
       rspec-support (~> 3.9.1)
-    rspec-expectations (3.9.0)
+    rspec-expectations (3.9.1)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.9.0)
     rspec-mocks (3.9.1)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.9.0)
     rspec-support (3.9.2)
-    rubocop (0.79.0)
+    rubocop (0.80.1)
       jaro_winkler (~> 1.5.1)
       parallel (~> 1.10)
       parser (>= 2.7.0.1)
       rainbow (>= 2.2.2, < 4.0)
+      rexml
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 1.4.0, < 1.7)
     ruby-progressbar (1.10.1)
-    simplecov (0.18.1)
+    safe_yaml (1.0.5)
+    simplecov (0.18.5)
       docile (~> 1.1)
-      simplecov-html (~> 0.11.0)
-    simplecov-html (0.11.0)
+      simplecov-html (~> 0.11)
+    simplecov-html (0.12.2)
     thread_safe (0.3.6)
-    tzinfo (1.2.6)
+    tzinfo (1.2.7)
       thread_safe (~> 0.1)
     unicode-display_width (1.6.1)
+    webmock (3.8.3)
+      addressable (>= 2.3.6)
+      crack (>= 0.3.2)
+      hashdiff (>= 0.4.0, < 2.0.0)
     zeitwerk (2.3.0)
 
 PLATFORMS
@@ -107,6 +117,7 @@ DEPENDENCIES
   rspec (~> 3.0)
   rubocop
   simplecov
+  webmock
 
 BUNDLED WITH
    2.0.2

data/instant_quote.gemspec

@@ -33,6 +33,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rspec', '~> 3.0'
   spec.add_development_dependency 'rubocop'
   spec.add_development_dependency 'simplecov'
+  spec.add_development_dependency 'webmock'
 
   spec.add_dependency 'activesupport'
   spec.add_dependency 'capital_on_tap'

data/lib/instant_quote/adapters/capital_on_tap.rb

@@ -50,9 +50,7 @@ module InstantQuote
         response = ::CapitalOnTap::Application.create(params)
 
         # CoT responses can be 200 OK but still have an error!
-        unless response.success? && !response.error
-          raise ApiError.new(data: response.body, error: response.error || 'Unknown API error')
-        end
+        raise_error(response) unless response.success? && !response.error
 
         response.body.dig(:result)
       end
@@ -75,7 +73,7 @@ module InstantQuote
       def get_status(application_id)
         response = ::CapitalOnTap::Application.status(application_id)
 
-        raise ApiError.new(data: response.body, error: response.error) unless response.success?
+        raise_error(response) unless response.success?
 
         DecisionParsers::CapitalOnTap.new(response.body[:applicationStatus])
       end
@@ -89,6 +87,16 @@ module InstantQuote
       def get_approval(_application_id)
         true
       end
+
+      private
+
+      def raise_error(response)
+        raise ApiError.new(
+          adapter: 'capital_on_tap',
+          data: response.body,
+          error: response.error || 'Unknown API error'
+        )
+      end
     end
   end
 end

data/lib/instant_quote/adapters/iwoca.rb

@@ -75,9 +75,9 @@ module InstantQuote
       def get_status(state_key)
         response = ::Iwoca::Quote.credit_facility_status(state_key)
 
-        return response.data if response.success?
+        raise_error(response) unless response.success?
 
-        raise_error(response)
+        DecisionParsers::Iwoca.new(response.body)
       end
 
       # Gets the URL for the given state key.
@@ -97,7 +97,12 @@ module InstantQuote
       private
 
       def raise_error(response)
-        raise ApiError.new(data: response.data, error: response.errors.first[:detail])
+        raise ApiError.new(
+          adapter: 'iwoca',
+          data: response.data,
+          code: response.errors.first[:code],
+          error: response.errors.first[:detail]
+        )
       end
     end
   end

data/lib/instant_quote/api_error.rb

@@ -2,14 +2,16 @@
 
 module InstantQuote
   class ApiError < StandardError
-    attr_accessor :error, :data
+    attr_accessor :error, :data, :code, :adapter
 
     alias message error
     alias to_s error
 
     def initialize(params = {})
+      @adapter = params[:adapter]
       @error = params[:error]
       @data = params[:data] || {}
+      @code = params[:code]
 
       # Delete the metaData key, because it's irrelevant and has long strings
       @data.delete(:metaData) if @data.key?(:metaData)

data/lib/instant_quote/connection_translators/capital_on_tap.rb

@@ -61,7 +61,7 @@ module InstantQuote
 
         return '' unless addr && addr != ''
 
-        street_parts = [addr.line_1, addr.line_2, addr.line_3, addr.line_4]
+        street_parts = [addr.line_1, addr.line_2]
 
         {
           CountryCode: 'UK',

data/lib/instant_quote/decision_parsers/capital_on_tap.rb

@@ -30,7 +30,7 @@ module InstantQuote
       end
 
       def amount
-        Money.new(credit_decision[:approvalAmount].to_f * 1000).format
+        Money.new(credit_decision[:approvalAmount].to_f * 100).format
       end
 
       def monthly_interest_rate

data/lib/instant_quote/decision_parsers/iwoca.rb

@@ -45,7 +45,7 @@ module InstantQuote
       # because  it's silly :)
       def initialize(data = {})
         @data = super
-        @data = @data[:data] || {}
+        @data = @data[:data] if @data.key?(:data)
       end
 
       def pending?

data/lib/instant_quote/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module InstantQuote
-  VERSION = '1.1.2'
+  VERSION = '1.1.7'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: instant_quote
 version: !ruby/object:Gem::Version
-  version: 1.1.2
+  version: 1.1.7
 platform: ruby
 authors:
 - rikas
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-03-16 00:00:00.000000000 Z
+date: 2020-07-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -108,6 +108,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: webmock
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement