instagram_connect 0.3.13 → 0.3.14

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: acad3028e8aecad50414e6bd980d896ca1b5c8245b28d517889b1cbfd5cca8ce
-  data.tar.gz: d7be5c7d2b2da1ba842cf1558a38de3d820557f4b982892c047c10d76b5b0744
+  metadata.gz: d434793fea3922a883a5c471a9b8ac915fd9495e1d33249c0e8eaaa3a0ad5a57
+  data.tar.gz: ce5ba440af874f60ffd385c0f1bb9ec9163e133ad9ae82fee572f9a4a31fdd34
 SHA512:
-  metadata.gz: 00e7e104a3ac1cc0cfcca780868f4c046ff4d593ce37606862f6d81b20971dfc66edcbd070018a1775e60ae2143393f9ce42b00ecffb835504cd093579e04964
-  data.tar.gz: 95e0f2ee5b9462277e0f87156288a31314a7b73888a0a38aa411340f25f98a4c646e04d45989c638dc6f0664982bf9f11d85aed3e3ebaefbb151a3e4f143ed8e
+  metadata.gz: a891502b9568dabd9836bc7b33e37823b6552b390b89ded7391d80af5a1c5799ac8486ff8424096f4bedc4497d0f1f5027845f46a7ee169224d19291bb87b00f
+  data.tar.gz: decbeeebb16e42c4e08213276bc910c3f1930ada5dffcf369a4e93f689afe8a94efed8a0964e9d79a5173616b3664ae60751c33bb997669de06d8165c22bfbc2

data/CHANGELOG.md

@@ -6,10 +6,41 @@ All notable changes to this project are documented here. The format follows
 
 ## [Unreleased]
 
+## [0.3.14] - 2026-07-28
+
+### Added
+
+- **Outbound attachments.** `UploadAttachmentJob` uploads a message's file to Meta and records the
+  reusable `attachment_upload_id`; `SendMessageJob` then sends the attachment BEFORE the words
+  about it, so the customer sees the photo and then the caption in the order the operator wrote
+  them. Two steps rather than one because a file Meta rejects (too large, wrong type) must fail
+  the message with THAT reason rather than the send's. Size ceilings are checked before an upload
+  is spent, and `attachment_delivered_at` is the resume cursor so a worker killed between the two
+  halves never shows the customer the photo twice. `upload_attachment`/`send_attachment` had
+  existed with zero callers since 0.1.
+
+### Fixed
+
+- An attachment-only message no longer posts an empty text alongside it: splitting `""` yields one
+  empty part, which was sent as a message.
+
+### Migration
+
+- `add_column :instagram_connect_messages, :attachment_delivered_at, :datetime` (`if_not_exists`).
+
+
 ## [0.3.13] - 2026-07-28
 
 ### Fixed
 
+- **An echo of a message this system sent no longer collides with it.** Every outbound send stores
+  Meta's mid; the echo of that same message then arrived and the handler called `create!` on the
+  same mid, so the event was banked `failed` and every replay failed again — forever
+  (`PG::UniqueViolation` on `index_instagram_connect_messages_on_account_and_mid`, hourly, in
+  production). The echo now ENRICHES the row it is echoing — filling only what the original write
+  could not know — and never rewrites direction, status, source or body, so a CMS-sent message
+  cannot be turned into one that looks sent from the phone.
+
 - **The readiness pass was the one path still shipping an unreadable token to Meta.** It builds its
   own `Authorization` header rather than going through `Account#client`, so 0.3.12's guard never
   covered it: Meta answered "Cannot parse access token" and the failure was recorded as if the

data/app/jobs/instagram_connect/send_message_job.rb

@@ -41,7 +41,26 @@ module InstagramConnect
 
     def deliver(message, conversation, tag)
       client = conversation.account.client
-      parts = TextSplitter.split(message.body.to_s)
+
+      # The attachment goes first, so the customer sees the photo and then the
+      # words about it — the order the operator wrote them in. Sent by
+      # reference: attachment_upload_id is Meta's reusable id, so the same file
+      # is uploaded once however many threads it is sent to.
+      if message.attachment_upload_id.present? && !message.attachment_delivered?
+        result = client.send_attachment(recipient_id: conversation.igsid,
+                                        attachment_id: message.attachment_upload_id, tag: tag)
+        unless result.success?
+          return fail_message(message, result.error_code&.to_s, result.error_message)
+        end
+
+        message.update!(attachment_delivered_at: Time.current,
+                        ig_message_id: message.ig_message_id.presence || result.id)
+      end
+
+      # reject(&:blank?): an attachment-only message has no text, and splitting
+      # "" yields one empty part — which would post an empty message Meta has
+      # no reason to accept.
+      parts = TextSplitter.split(message.body.to_s).reject(&:blank?)
 
       # Resume rather than restart. A worker killed mid-fan-out has already
       # delivered the earlier parts, and re-sending them repeats text the

data/app/jobs/instagram_connect/upload_attachment_job.rb

@@ -0,0 +1,66 @@
+module InstagramConnect
+  # Uploads a message's file to Meta and records the reusable attachment id,
+  # then hands the message to the sender.
+  #
+  # Two steps rather than one because Meta's upload is a separate call with its
+  # own failure mode: a file it rejects (too large, wrong type) must fail the
+  # message with THAT reason, not with whatever the send would have said
+  # afterwards. The id is reusable, so the same file sent to a second thread
+  # costs no upload at all.
+  #
+  # The host attaches the file however it likes (Active Storage, a Tempfile);
+  # this job only needs something that responds to #open or #path.
+  class UploadAttachmentJob < ApplicationJob
+    queue_as :default
+
+    # Meta's own ceilings, stated here so a file that cannot possibly work is
+    # refused before it costs an upload.
+    SIZE_LIMITS = { "image" => 8.megabytes, "video" => 25.megabytes,
+                    "audio" => 25.megabytes, "file" => 25.megabytes }.freeze
+
+    def perform(message_id, file_path, type: "image")
+      message = Message.find_by(id: message_id)
+      return if message.nil? || message.attachment_upload_id.present?
+
+      unless File.exist?(file_path)
+        return fail_message(message, "attachment_missing",
+                            "The file to send could not be read.")
+      end
+
+      limit = SIZE_LIMITS.fetch(type, SIZE_LIMITS["file"])
+      if File.size(file_path) > limit
+        return fail_message(message, "attachment_too_large",
+                            "Instagram refuses #{type}s over #{limit / 1.megabyte}MB.")
+      end
+
+      upload(message, file_path, type)
+    end
+
+    private
+
+    def upload(message, file_path, type)
+      result = File.open(file_path) do |file|
+        message.conversation.account.client.upload_attachment(file: file, type: type)
+      end
+
+      unless result.success?
+        return fail_message(message, result.error_code&.to_s, result.error_message)
+      end
+
+      attachment_id = result.data["attachment_id"].presence || result.id
+      if attachment_id.blank?
+        return fail_message(message, "attachment_upload_empty",
+                            "Instagram accepted the upload but returned no attachment id.")
+      end
+
+      message.update!(attachment_upload_id: attachment_id, media_kind: type)
+      SendMessageJob.perform_later(message.id)
+    end
+
+    def fail_message(message, reason, error)
+      message.update!(status: "failed", failure_reason: reason, error_message: error)
+      message.broadcast_refresh
+      nil
+    end
+  end
+end

data/app/models/instagram_connect/message.rb

@@ -42,6 +42,12 @@ module InstagramConnect
       sent_at || created_at
     end
 
+    # The attachment half of this send is done. Mirrors delivered_parts_count
+    # for the text half, so a resumed job never re-sends the photo.
+    def attachment_delivered?
+      attachment_delivered_at.present?
+    end
+
     def deleted?
       deleted_at.present?
     end

data/db/migrate/20260728020000_add_attachment_delivered_at_to_messages.rb

@@ -0,0 +1,9 @@
+class AddAttachmentDeliveredAtToMessages < ActiveRecord::Migration[8.0]
+  # The resume cursor for the attachment half of a send, mirroring
+  # delivered_parts_count for the text half: a worker killed between the
+  # attachment and the text must not send the photo twice.
+  def change
+    add_column :instagram_connect_messages, :attachment_delivered_at, :datetime,
+               if_not_exists: true
+  end
+end

data/lib/instagram_connect/ingest/handlers/messages.rb

@@ -15,6 +15,17 @@ module InstagramConnect
         end
 
         def call
+          # An echo of a message this system already sent is a CONFIRMATION,
+          # not a new message: the send stored the mid first, so create! hits
+          # the unique index on [account_id, ig_message_id] and the event is
+          # banked failed — then every replay fails again, forever. Enrich the
+          # row Meta is echoing rather than duplicating it, and do not
+          # re-register it on the conversation (it was registered when sent).
+          if (existing = existing_message)
+            enrich(existing)
+            return existing
+          end
+
           message = InstagramConnect::Message.create!(
             conversation: conversation,
             direction: echo? ? "outbound" : "inbound",
@@ -49,6 +60,28 @@ module InstagramConnect
 
         private
 
+        def existing_message
+          return if mid.blank?
+
+          InstagramConnect::Message.find_by(account_id: conversation.account_id,
+                                            ig_message_id: mid)
+        end
+
+        # Fill only what the original write could not know — Meta's clock, the
+        # media it processed, the story it was a reply to. Direction, status,
+        # source and body stay as first written: an echo must not rewrite a
+        # CMS-sent message into one that looks sent from the phone.
+        def enrich(message)
+          message.sent_at ||= envelope.occurred_at
+          message.media_status ||= media_status
+          message.media_kind ||= attachments.first&.dig("type")
+          message.story_id ||= story&.dig("id")
+          message.story_url ||= story&.dig("url")
+          message.save! if message.changed?
+          store_attachments(message) if message.attachments.none?
+          message
+        end
+
         def payload
           event["message"] || {}
         end

data/lib/instagram_connect/version.rb

@@ -1,3 +1,3 @@
 module InstagramConnect
-  VERSION = "0.3.13"
+  VERSION = "0.3.14"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: instagram_connect
 version: !ruby/object:Gem::Version
-  version: 0.3.13
+  version: 0.3.14
 platform: ruby
 authors:
 - Kshitiz Sinha
@@ -104,6 +104,7 @@ files:
 - app/jobs/instagram_connect/sync_conversations_job.rb
 - app/jobs/instagram_connect/sync_media_job.rb
 - app/jobs/instagram_connect/sync_stories_job.rb
+- app/jobs/instagram_connect/upload_attachment_job.rb
 - app/models/instagram_connect/account.rb
 - app/models/instagram_connect/api_budget.rb
 - app/models/instagram_connect/application_record.rb
@@ -148,6 +149,7 @@ files:
 - db/migrate/20260725205417_add_conversation_profile_fields.rb
 - db/migrate/20260727074500_add_removed_flag_to_instagram_connect_media.rb
 - db/migrate/20260727110000_add_children_to_instagram_connect_media.rb
+- db/migrate/20260728020000_add_attachment_delivered_at_to_messages.rb
 - docs/CONFIGURATION.md
 - docs/app_review_guide.md
 - docs/auth_paths.md