inst_statsd 3.2.0 → 3.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 705acd8e1a6b843e6f4e54ec0e1525f1165022547c22649d4b0c60c2c1fc83fa
-  data.tar.gz: 1d0daad7330f761a6ea4642bd52c85a0a4bf5a6856e7bd967750670a7f08832e
+  metadata.gz: 70725525a856b43a9d37075d6bdf74fdeac3a7c3a306545bca25e41e3011ca9a
+  data.tar.gz: e7fcf1593bf7186c877be71fbd38f86c285fa852294ee08e00d90049076cb0b6
 SHA512:
-  metadata.gz: 1a23712f36838b2fd9afd2fe15430c9239e14b212aa6a05ed3358c81ff9799a2d11345dc1170915de903d6a73eed0a0dce05c183c75661693296ab5511b2cdb8
-  data.tar.gz: d5a2406ba15f33196527a9d24cb7d52d6eb5d0aea387f7a80d9382e389777e0c375473d50282af0841f9832adc8f27d8c89b3f07c249764de3170aa8b033303e
+  metadata.gz: '02963b466ff709d44a2e7ed69f8a060263d0a66b87cf856d1bf9a8f75814441dda10692fb7184096c36e7365865e94d2d322cc2a04863fe66183a21e97085e0e'
+  data.tar.gz: f24f390b747d2a86e81a45bde5e9160e86375dd565798da7e9bd037977b6be4cc71c4c29621fe3c87bade029c2884ee74b02382f2a100770563811edd3171ac8

data/lib/inst_statsd/distribution.rb

@@ -29,6 +29,9 @@ module InstStatsd
     # @example Increment the error count:
     #  InstStatsd::Statsd.distributed_increment('client.request.failed', tags: { status: '500' })
     def distributed_increment(metric, tags: {})
+      # Non-Datadog clients don't support distribution metrics, so we use fall back to increment
+      return increment(metric, tags: tags) if instance && !data_dog?
+
       distribution(metric, 1, tags: tags)
     end
   end

data/lib/inst_statsd/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module InstStatsd
-  VERSION = "3.2.0"
+  VERSION = "3.3.0"
 end

data/spec/inst_statsd/distribution_spec.rb

@@ -4,19 +4,19 @@ require "spec_helper"
 require "datadog/statsd"
 
 RSpec.describe InstStatsd::Distribution do
+  let(:instance) { instance_double(Datadog::Statsd) }
+
+  before do
+    allow(InstStatsd::Statsd).to receive_messages(data_dog?: is_datadog, dog_tags: dog_tags, instance: instance)
+  end
+
   describe ".distribution" do
     subject { InstStatsd::Statsd.distribution(metric, value, tags: tags) }
 
-    let(:instance) { instance_double(Datadog::Statsd) }
-
     let(:metric) { "client.request.failed" }
     let(:value) { 23 }
     let(:tags) { { status: "500" } }
 
-    before do
-      allow(InstStatsd::Statsd).to receive_messages(data_dog?: is_datadog, dog_tags: dog_tags, instance: instance)
-    end
-
     context "when instance and data_dog? are configured" do
       let(:dog_tags) { { environment: "production" } }
       let(:is_datadog) { true }
@@ -49,6 +49,8 @@ RSpec.describe InstStatsd::Distribution do
 
     let(:metric) { "client.request.failed" }
     let(:tags) { { status: "500" } }
+    let(:dog_tags) { { status: "401" } }
+    let(:is_datadog) { true }
 
     before do
       allow(InstStatsd::Statsd).to receive_messages(distribution: nil)
@@ -59,5 +61,16 @@ RSpec.describe InstStatsd::Distribution do
 
       subject
     end
+
+    context "when the configured instance is not a DataDog instance" do
+      let(:dog_tags) { {} }
+      let(:is_datadog) { false }
+
+      it 'invokes "increment" on InstStatsd::Statsd with metric and tags' do
+        expect(InstStatsd::Statsd).to receive(:increment).with(metric, tags: tags)
+
+        subject
+      end
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: inst_statsd
 version: !ruby/object:Gem::Version
-  version: 3.2.0
+  version: 3.3.0
 platform: ruby
 authors:
 - Nick Cloward