inst-jobs 3.0.0 → 3.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8a9b37f7e43ec441a00056cbacce6f749e93de4496f4cbdff2c765015056ac71
-  data.tar.gz: ccbb0ed96932e436e109db2ae5c3076ce64245bc98a04424f5f9858f045d7a81
+  metadata.gz: c9d86b7b6161b9397c885a82d687f85d84e7a17db5261bfc5ef1bb7e9f25e2ac
+  data.tar.gz: 4a75f8ac73b5f0a0b19d8073bcbfe87f654bbbdb90e147ddf02066916653d4e0
 SHA512:
-  metadata.gz: 560e60386a4ea4e2851b3c6304ab38982134be7141c6d84671259f744c1d1fbb2dbb7af099ecbe2606fe35364b0d20dd54a6a6dccc6cea95ed02dc56c840d8d7
-  data.tar.gz: 9aceb6dc65083dc71a7f360d6a7e3fafbb8992f17b9a080e53e190d5a7772b417ef7caecd05f3c6f9fe8462e7ea9f67f788e9423d45dd251979547e3329924a0
+  metadata.gz: cd3f9df169146f34f7366e02830575bf27e2fd33e97d190bed34dd8be44e34431261111eef133368cd342668cabeb529af6e16c8985fcf15c99807ea7a07fbab
+  data.tar.gz: 3924f7b2f6f4eee37c4d92bfedfd683304dfd0c035a65f47ea9dae607c0e81b03c35860420f39a7dadf890d203c85fe24de68c90c80a48839f23b6193311b3e3

data/lib/delayed/backend/base.rb

@@ -176,7 +176,9 @@ module Delayed
           ignores = []
           loop do
             batch_scope = ignores.empty? ? jobs : jobs.where.not(id: ignores)
-            batch = batch_scope.to_a
+            # if we don't reload this it's possible to keep getting the
+            # same array each loop even after the jobs have been deleted.
+            batch = batch_scope.reload.to_a
             break if batch.empty?
 
             batch.each do |job|

data/lib/delayed/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Delayed
-  VERSION = "3.0.0"
+  VERSION = "3.0.1"
 end

data/spec/shared/shared_backend.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require "timeout"
+
 module InDelayedJobTest
   def self.check_in_job
     Delayed::Job.in_delayed_job?.should == true
@@ -960,6 +962,21 @@ shared_examples_for "a backend" do
     end
   end
 
+  it "removes an un-reschedulable job" do
+    change_setting(Delayed::Settings, :max_attempts, -1) do
+      job = Delayed::Job.new(tag: "tag")
+      `echo ''`
+      child_pid = $?.pid
+      job.create_and_lock!("Jobworker:#{child_pid}")
+      Timeout.timeout(1) do
+        # if this takes longer than a second it's hung
+        # in an infinite loop, which would be bad.
+        expect(Delayed::Job.unlock_orphaned_jobs(nil, "Jobworker")).to eq(1)
+      end
+      expect { Delayed::Job.find(job.id) }.to raise_error(ActiveRecord::RecordNotFound)
+    end
+  end
+
   it "unlocks orphaned jobs given a pid" do
     change_setting(Delayed::Settings, :max_attempts, 2) do
       job1 = Delayed::Job.new(tag: "tag")

metadata

@@ -1,15 +1,16 @@
 --- !ruby/object:Gem::Specification
 name: inst-jobs
 version: !ruby/object:Gem::Version
-  version: 3.0.0
+  version: 3.0.1
 platform: ruby
 authors:
-- Tobias Luetke
-- Brian Palmer
-autorequire:
+- Cody Cutrer
+- Ethan Vizitei
+- Jacob Burroughs
+autorequire: 
 bindir: exe
 cert_chain: []
-date: 2021-09-30 00:00:00.000000000 Z
+date: 2021-10-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -409,9 +410,11 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 1.4.0
-description:
+description: 
 email:
-- brianp@instructure.com
+- cody@instructure.com
+- evizitei@instructure.com
+- jburroughs@instructure.com
 executables:
 - inst_jobs
 extensions: []
@@ -513,7 +516,7 @@ files:
 homepage: https://github.com/instructure/inst-jobs
 licenses: []
 metadata: {}
-post_install_message:
+post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -528,8 +531,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.24
-signing_key:
+rubygems_version: 3.0.3
+signing_key: 
 specification_version: 4
 summary: Instructure-maintained fork of delayed_job
 test_files: