inst-jobs 2.1.3 → 2.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4c31ed6d846425c9bf022bb8c744681019cbf0f0192d4e0ee7f0a5d7dc44a65c
-  data.tar.gz: 4a5b940ba8bd6770209d93e20ccc217d4ab5915bcd1a5791de70b076e7cecf97
+  metadata.gz: 35a651c7d168b0e569ebc47f13ed3500bd10d813308993ecdbfbc176e74943a5
+  data.tar.gz: eba8a2e50f5414684045bde99d5ccc1dc144d00f6b84d3bb82ec5c6becc34003
 SHA512:
-  metadata.gz: 07377763c26979774add4b3445aa72ebc2cbff6aabe595e1157c883a90dea48407bc8ecb87f5532265178a96b27548caaf5ce13a0789c469272980bc864a2882
-  data.tar.gz: 7ddd291e18be337ae1d858d016af92cc255c111e5141eafca8cee598fcdae9563a74983ba6b98daeb50c1fe599490dd9c962e1c722d5dcea5083bf16a619641d
+  metadata.gz: bc667a0ce1380f8acfe092bdf938d06e8d2dfff1018f53679930f88c8ffa45bf088e758fd362f99c5835600527f5a3d2cf189e7560dd6ecce57850d64682f178
+  data.tar.gz: 83d984683717018254316d891a972809bf7c3597628d94de149a4af0dab2efe5cf77473a6580408ec461c0d8dddc206b03e8747cbe6f22ba2f169194be876210

data/lib/delayed/backend/active_record.rb

@@ -13,9 +13,13 @@ end
 module Delayed
   module Backend
     module ActiveRecord
+      class AbstractJob < ::ActiveRecord::Base
+        self.abstract_class = true
+      end
+
       # A job object that is persisted to the database.
       # Contains the work object as a YAML field.
-      class Job < ::ActiveRecord::Base
+      class Job < AbstractJob
         include Delayed::Backend::Base
         self.table_name = :delayed_jobs
 
@@ -27,7 +31,7 @@ module Delayed
 
         class << self
           def create(attributes, &block)
-            return super if connection.prepared_statements || Rails.version < '5.2'
+            return super if connection.prepared_statements
 
             # modified from ActiveRecord::Persistence.create and ActiveRecord::Persistence#_insert_record
             job = new(attributes, &block)
@@ -37,7 +41,7 @@ module Delayed
 
         def single_step_create
           connection = self.class.connection
-          return save if connection.prepared_statements || Rails.version < '5.2'
+          return save if connection.prepared_statements
 
           # a before_save callback that we're skipping
           initialize_defaults
@@ -66,7 +70,8 @@ module Delayed
           # > Multiple queries sent in a single PQexec call are processed in a single transaction,
           # unless there are explicit BEGIN/COMMIT commands included in the query string to divide
           # it into multiple transactions.
-          sql = "SELECT pg_advisory_xact_lock(#{connection.quote_table_name('half_md5_as_bigint')}(#{connection.quote(values['strand'])})); #{sql}" if values["strand"]
+          # but we don't need to lock when inserting into Delayed::Failed
+          sql = "SELECT pg_advisory_xact_lock(#{connection.quote_table_name('half_md5_as_bigint')}(#{connection.quote(values['strand'])})); #{sql}" if values["strand"] && self.class == Job
           result = connection.execute(sql, "#{self} Create")
           self.id = result.values.first.first
           result.clear
@@ -98,7 +103,7 @@ module Delayed
         # to raise the lock level
         before_create :lock_strand_on_create
         def lock_strand_on_create
-          if strand.present?
+          if strand.present? && self.class == Job
             self.class.connection.execute("SELECT pg_advisory_xact_lock(#{self.class.connection.quote_table_name('half_md5_as_bigint')}(#{self.class.connection.quote(strand)}))")
           end
         end
@@ -513,17 +518,6 @@ module Delayed
         class Failed < Job
           include Delayed::Backend::Base
           self.table_name = :failed_jobs
-          # Rails hasn't completely loaded yet, and setting the table name will cache some stuff
-          # so reset that cache so that it will load correctly after Rails is all loaded
-          # It's fixed in Rails 5 to not cache anything when you set the table_name
-          if Rails.version < '5' && Rails.version >= '4.2'
-            @arel_engine = nil
-            @arel_table = nil
-          end
-        end
-        if Rails.version < '5' && Rails.version >= '4.2'
-          @arel_engine = nil
-          @arel_table = nil
         end
       end
 

data/lib/delayed/backend/base.rb

@@ -56,6 +56,12 @@ module Delayed
           kwargs[:expires_at] = expires_at
           kwargs[:queue] = queue
 
+          strand_args = 0
+          strand_args += 1 if strand
+          strand_args += 1 if n_strand
+          strand_args += 1 if singleton
+          raise ArgumentError, "Only one of strand, n_strand, or singleton can be used" if strand_args > 1
+
           # If two parameters are given to n_strand, the first param is used
           # as the strand name for looking up the Setting, while the second
           # param is appended to make a unique set of strands.

data/lib/delayed/backend/redis/job.rb

@@ -395,13 +395,6 @@ class Job
     result
   end
 
-  if Rails.version < "4.1"
-    def changes_applied
-      @previously_changed = changes
-      @changed_attributes.clear
-    end
-  end
-
   def save!(*a)
     save(*a) || raise(RecordNotSaved)
   end

data/lib/delayed/periodic.rb

@@ -53,18 +53,12 @@ class Periodic
   end
 
   def enqueue_args
-    # yes, checking for whether it is actually the boolean literal false,
-    # which means the consuming code really does not want this job to be
-    # a singleton at all.
-    non_singleton_periodic_job = @job_args[:singleton] == false
     inferred_args = {
       max_attempts: 1,
       run_at: @cron.next_time(Delayed::Periodic.now).utc.to_time,
-      singleton: (non_singleton_periodic_job ? nil : tag)
+      singleton: tag,
+      on_conflict: :patient
     }
-    unless non_singleton_periodic_job
-      inferred_args[:on_conflict] = :patient
-    end
     @job_args.merge(inferred_args)
   end
 

data/lib/delayed/pool.rb

@@ -39,6 +39,7 @@ class Pool
     Process.wait unlock_pid
 
     spawn_periodic_auditor
+    spawn_abandoned_job_cleanup
     spawn_all_workers
     say "Workers spawned"
     join
@@ -105,12 +106,41 @@ class Pool
   # db connections with the parent
   def fork_with_reconnects
     fork do
+      @self_pipe.each(&:close) # sub-processes don't need to wake us up; keep their FDs clean
       Pool.on_fork.()
       Delayed::Job.reconnect!
       yield
     end
   end
 
+  def spawn_abandoned_job_cleanup
+    return if Settings.disable_abandoned_job_cleanup
+    cleanup_interval_in_minutes = 60
+    @abandoned_cleanup_thread = Thread.new do
+      # every hour (staggered by process)
+      # check for dead jobs and cull them.
+      # Will actually be more often based on the
+      # number of worker nodes in the pool.  This will actually
+      # be a max of N times per hour where N is the number of workers,
+      # but they won't overrun each other because the health check
+      # takes an advisory lock internally
+      sleep(rand(cleanup_interval_in_minutes * 60))
+      loop do
+        schedule_abandoned_job_cleanup
+        sleep(cleanup_interval_in_minutes * 60)
+      end
+    end
+  end
+
+  def schedule_abandoned_job_cleanup
+    pid = fork_with_reconnects do
+      # we want to avoid db connections in the main pool process
+      $0 = "delayed_abandoned_job_cleanup"
+      Delayed::Worker::HealthCheck.reschedule_abandoned_jobs
+    end
+    workers[pid] = :abandoned_job_cleanup
+  end
+
   def spawn_periodic_auditor
     return if Settings.disable_periodic_jobs
 
@@ -217,6 +247,8 @@ class Pool
       case worker
       when :periodic_audit
         say "ran auditor: #{worker}"
+      when :abandoned_job_cleanup
+        say "ran cleanup: #{worker}"
       when :work_queue
         say "work queue exited, restarting", :info
         spawn_work_queue

data/lib/delayed/settings.rb

@@ -8,6 +8,7 @@ module Delayed
   module Settings
     SETTINGS = [
       :default_job_options,
+      :disable_abandoned_job_cleanup,
       :disable_periodic_jobs,
       :disable_automatic_orphan_unlocking,
       :fetch_batch_size,
@@ -83,7 +84,7 @@ module Delayed
     def self.worker_config(config_filename = nil)
       config_filename ||= default_worker_config_name
       config = YAML.load(ERB.new(File.read(config_filename)).result)
-      env = defined?(RAILS_ENV) ? RAILS_ENV : ENV['RAILS_ENV'] || 'development'
+      env = Rails.env || 'development'
       config = config[env] || config['default']
       # Backwards compatibility from when the config was just an array of queues
       config = { :workers => config } if config.is_a?(Array)

data/lib/delayed/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Delayed
-  VERSION = "2.1.3"
+  VERSION = "2.3.2"
 end

data/lib/delayed/work_queue/in_process.rb

@@ -16,6 +16,7 @@ class InProcess
   end
 
   # intentional nops for compatibility w/ parent process
+  def init; end
   def close; end
   def wake_up; end
 end

data/lib/delayed/work_queue/parent_process/client.rb

@@ -11,7 +11,10 @@ class ParentProcess
     def initialize(addrinfo, config: Settings.parent_process)
       @addrinfo = addrinfo
       @connect_timeout = config['client_connect_timeout'] || 2
-      @self_pipe = IO.pipe
+    end
+
+    def init
+      @self_pipe ||= IO.pipe
     end
 
     def close

data/lib/delayed/worker.rb

@@ -69,7 +69,6 @@ class Worker
     @config = options
     @job_count = 0
 
-    @self_pipe = IO.pipe
     @signal_queue = []
 
     app = Rails.application
@@ -120,6 +119,8 @@ class Worker
   def start
     logger.info "Starting worker"
     set_process_name("start:#{Settings.worker_procname_prefix}#{@queue_name}:#{min_priority || 0}:#{max_priority || 'max'}")
+    @self_pipe = IO.pipe
+    work_queue.init
 
     work_thread = Thread.current
     SIGNALS.each do |sig|
@@ -162,6 +163,9 @@ class Worker
       signal_processor.kill
       signal_processor.join
     end
+
+    @self_pipe&.each(&:close)
+    @self_pipe = nil
   end
 
   def cleanup!

data/lib/delayed/worker/consul_health_check.rb

@@ -9,52 +9,49 @@ module Delayed
     class ConsulHealthCheck < HealthCheck
       self.type_name = :consul
 
-      CONSUL_CONFIG_KEYS = %w{url host port ssl token connect_timeout receive_timeout send_timeout}.map(&:freeze).freeze
+      CONSUL_CONFIG_KEYS = %w{url acl_token}.map(&:freeze).freeze
       DEFAULT_SERVICE_NAME = 'inst-jobs_worker'.freeze
-      attr_reader :agent_client, :catalog_client
+      attr_reader :service_client, :health_client
 
       def initialize(*, **)
         super
         # Because we don't want the consul client to be a hard dependency we're
         # only requiring it once it's absolutely needed
-        require 'imperium'
+        require 'diplomat'
 
         if config.keys.any? { |k| CONSUL_CONFIG_KEYS.include?(k) }
-          consul_config = Imperium::Configuration.new.tap do |conf|
+          consul_config = Diplomat::Configuration.new.tap do |conf|
             CONSUL_CONFIG_KEYS.each do |key|
               conf.send("#{key}=", config[key]) if config[key]
             end
           end
-          @agent_client = Imperium::Agent.new(consul_config)
-          @catalog_client = Imperium::Catalog.new(consul_config)
+          @service_client = Diplomat::Service.new(configuration: consul_config)
+          @health_client = Diplomat::Health.new(configuration: consul_config)
         else
-          @agent_client = Imperium::Agent.default_client
-          @catalog_client = Imperium::Catalog.default_client
+          @service_client = Diplomat::Service.new
+          @health_client = Diplomat::Health.new
         end
       end
 
       def start
-        service = Imperium::Service.new({
+        @service_client.register({
           id: worker_name,
           name: service_name,
+          check: check_attributes
         })
-        service.add_check(check_attributes)
-        response = @agent_client.register_service(service)
-        response.ok?
       end
 
       def stop
-        response = @agent_client.deregister_service(worker_name)
-        response.ok? || response.not_found?
+        @service_client.deregister(worker_name)
       end
 
       def live_workers
-        live_nodes = @catalog_client.list_nodes_for_service(service_name)
-        if live_nodes.ok?
-          live_nodes.map(&:service_id)
-        else
-          raise "Unable to read from Consul catalog: #{live_nodes.content}"
-        end
+        # Filter out critical workers (probably nodes failing their serf health check)
+        live_nodes = @health_client.service(service_name, {
+          filter: 'not Checks.Status == critical'
+        })
+
+        live_nodes.map { |n| n.Service['ID']}
       end
 
       private

data/lib/delayed/worker/health_check.rb

@@ -23,12 +23,13 @@ module Delayed
         def reschedule_abandoned_jobs
           return if Settings.worker_health_check_type == :none
           Delayed::Job.transaction do
-            # this job is a special case, and is not a singleton
+            # this action is a special case, and SHOULD NOT be a periodic job
             # because if it gets wiped out suddenly during execution
             # it can't go clean up it's abandoned self.  Therefore,
-            # we try to get an advisory lock when it runs.  If we succeed,
-            # no other job is trying to do this right now (and if we abandon the
-            # job, the transaction will end, releasing the advisory lock).
+            # we expect it to get run from it's own process forked from the job pool
+            # and we try to get an advisory lock when it runs.  If we succeed,
+            # no other worker is trying to do this right now (and if we abandon the
+            # operation, the transaction will end, releasing the advisory lock).
             result = attempt_advisory_lock
             return unless result
             checker = Worker::HealthCheck.build(

data/lib/delayed_job.rb

@@ -18,6 +18,7 @@ require 'rails'
 require 'active_support/core_ext/module/attribute_accessors'
 require 'active_record'
 require 'after_transaction_commit'
+require 'debug_inspector'
 
 require 'delayed/core_ext/kernel'
 

data/spec/active_record_job_spec.rb

@@ -262,8 +262,6 @@ describe 'Delayed::Backed::ActiveRecord::Job' do
 
   context "non-transactional", non_transactional: true do
     it "creates a stranded job in a single statement" do
-      skip "Requires Rails 5.2 or greater" unless Rails.version >= '5.2'
-
       allow(Delayed::Job.connection).to receive(:prepared_statements).and_return(false)
       allow(Delayed::Job.connection).to receive(:execute).with(be_include("pg_advisory_xact_lock"), anything).and_call_original.once
       allow(Delayed::Job.connection).to receive(:insert).never
@@ -273,8 +271,6 @@ describe 'Delayed::Backed::ActiveRecord::Job' do
     end
 
     it "creates a non-stranded job in a single statement" do
-      skip "Requires Rails 5.2 or greater" unless Rails.version >= '5.2'
-
       allow(Delayed::Job.connection).to receive(:prepared_statements).and_return(false)
       call_count = 0
       allow(Delayed::Job.connection).to receive(:execute).and_wrap_original do |m, (arg1, arg2)|
@@ -286,5 +282,20 @@ describe 'Delayed::Backed::ActiveRecord::Job' do
       expect(call_count).to eq 1
       expect(Delayed::Job.find(j.id)).to eq j
     end
+
+    it "does not lock a stranded failed job creation" do
+      j = create_job(strand: "test1")
+      # query for metadata to ensure it's loaded before we start mucking with the connection
+      Delayed::Backend::ActiveRecord::Job::Failed.new
+
+      allow(Delayed::Job.connection).to receive(:prepared_statements).and_return(false)
+      allow(Delayed::Job.connection).to receive(:execute).and_wrap_original do |original, *args|
+        expect(args.first).not_to include("pg_advisory_xact_lock")
+        original.call(*args)
+      end
+      allow(Delayed::Job.connection).to receive(:insert).never
+      j.fail!
+      allow(Delayed::Job.connection).to receive(:execute).and_call_original
+    end
   end
 end

data/spec/delayed/periodic_spec.rb

@@ -27,15 +27,5 @@ RSpec.describe Delayed::Periodic do
       expect(instance).to_not be_nil
       expect(instance.enqueue_args[:singleton]).to eq("periodic: just a test")
     end
-
-    it "uses no singleton if told to skip" do
-      Delayed::Periodic.cron job_name, '*/10 * * * *', {singleton: false} do
-        # no-op
-      end
-      instance = Delayed::Periodic.scheduled[job_name]
-      expect(instance).to_not be_nil
-      expect(instance.enqueue_args[:singleton]).to be_nil
-      Delayed::Periodic.perform_audit!
-    end
   end
 end

data/spec/delayed/work_queue/parent_process/client_spec.rb

@@ -3,7 +3,7 @@
 require 'spec_helper'
 
 RSpec.describe Delayed::WorkQueue::ParentProcess::Client do
-  let(:subject) { described_class.new(addrinfo) }
+  let(:subject) { described_class.new(addrinfo).tap(&:init) }
   let(:addrinfo) { double('Addrinfo') }
   let(:connection) { double('Socket') }
   let(:job) { Delayed::Job.new(locked_by: "worker_name") }

data/spec/delayed/worker/consul_health_check_spec.rb

@@ -1,76 +1,63 @@
 # frozen_string_literal: true
 
 require 'spec_helper'
-require 'imperium'
 
 RSpec.describe Delayed::Worker::ConsulHealthCheck do
   let(:health_check) { Delayed::Worker::ConsulHealthCheck.new(worker_name: 'foobar') }
 
-  # can't use a verifying double for the response because the methods we're
-  # tryig to stub are actually on HTTP::Message
-  let(:response) { double('Imperium::Response') }
-  let(:agent_client) { instance_double(Imperium::Agent) }
-
-  before do
-    allow(Imperium::Agent).to receive(:default_client).and_return(agent_client)
-  end
-
   describe '#initialize' do
-    it 'must use the default agent client when the config is mostly empty' do
+    it 'must use a default service client when the config is mostly empty' do
       check = Delayed::Worker::ConsulHealthCheck.new(worker_name: 'foobar')
-      expect(check.agent_client).to eq Imperium::Agent.default_client
+      expect(check.service_client.configuration.url.to_s).to eq 'http://localhost:8500'
     end
 
-    it 'must create a new agent API client when the config has relevant keys set' do
+    it 'must create a new service API client when the config has relevant keys set' do
       check = Delayed::Worker::ConsulHealthCheck.new(worker_name: 'foobar', config: {url: 'http://consul.example.com:8500'})
-      agent_client = check.agent_client
-      expect(agent_client).to_not eq Imperium::Agent.default_client
-      expect(agent_client.config.url.to_s).to eq 'http://consul.example.com:8500'
+      service_client = check.service_client
+      expect(service_client.configuration.url.to_s).to eq 'http://consul.example.com:8500'
     end
   end
 
   describe '#start' do
     it 'must register this process as a service with consul' do
-      expect(response).to receive(:ok?).and_return(true)
-      expect(agent_client).to receive(:register_service)
-        .with(an_instance_of(Imperium::Service))
-        .and_return(response)
+      stub = stub_request(:put, "localhost:8500/v1/agent/service/register")
+        .with(body: hash_including({id: 'foobar' }))
+
       health_check.start
+
+      expect(stub).to have_been_requested
     end
 
 
     it 'must supply a args style check' do
-      allow(response).to receive(:ok?).and_return(true)
-      allow(agent_client).to receive(:register_service) { |service|
-        check = service.checks.first
-        expect(check.args).to_not be_nil
-        response
-      }
+      stub = stub_request(:put, "localhost:8500/v1/agent/service/register")
+        .with(body: hash_including({check:  WebMock::API.hash_including({args: anything})}))
+
       health_check.start
+
+      expect(stub).to have_been_requested
     end
 
     it 'must include the docker container id when the docker option is set to true' do
+      stub = stub_request(:put, "localhost:8500/v1/agent/service/register")
+        .with(body: hash_including({check:  WebMock::API.hash_including({docker_container_id: anything})}))
+
       local_health_check = Delayed::Worker::ConsulHealthCheck.new(
         worker_name: 'foobar',
         config: {docker: true}
       )
-      allow(response).to receive(:ok?).and_return(true)
-      allow(agent_client).to receive(:register_service) { |service|
-        check = service.checks.first
-        expect(check.docker_container_id).to_not be_nil
-        response
-      }
       local_health_check.start
+
+      expect(stub).to have_been_requested
     end
   end
 
   describe '#stop' do
     it 'must deregister the service from consul' do
-      allow(response).to receive(:ok?).and_return(true)
-      expect(agent_client).to receive(:deregister_service)
-        .with(health_check.worker_name)
-        .and_return(response)
+      stub = stub_request(:put, "localhost:8500/v1/agent/service/deregister/foobar")
+
       health_check.stop
+      expect(stub).to have_been_requested
     end
   end
 end

data/spec/gemfiles/52.gemfile

@@ -1,7 +1,7 @@
 source "https://rubygems.org"
 
-gemspec :path=>"../../"
+gemspec :path => "../../"
 
 gem "rails", "~> 5.2.0"
-gem 'sinatra', "2.0.0.beta2"
-gem 'sinatra-contrib', "2.0.0.beta2"
+gem 'sinatra', "~> 2.0"
+gem 'sinatra-contrib', "~> 2.0"

data/spec/gemfiles/60.gemfile

@@ -1,7 +1,7 @@
 source "https://rubygems.org"
 
-gemspec :path=>"../../"
+gemspec :path => "../../"
 
 gem "rails", "~> 6.0.0"
-gem 'sinatra', "2.0.0.beta2"
-gem 'sinatra-contrib', "2.0.0.beta2"
+gem 'sinatra', "~> 2.0"
+gem 'sinatra-contrib', "~> 2.0"

data/spec/gemfiles/60.gemfile.lock

@@ -0,0 +1,246 @@
+PATH
+  remote: ../..
+  specs:
+    inst-jobs (2.3.1)
+      activerecord (>= 5.2)
+      activesupport (>= 5.2)
+      after_transaction_commit (>= 1.0, < 3)
+      debug_inspector (~> 1.0)
+      fugit (~> 1.3)
+      railties (>= 5.2)
+      redis (> 3.0)
+      redis-scripting (~> 1.0.1)
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    actioncable (6.0.3.7)
+      actionpack (= 6.0.3.7)
+      nio4r (~> 2.0)
+      websocket-driver (>= 0.6.1)
+    actionmailbox (6.0.3.7)
+      actionpack (= 6.0.3.7)
+      activejob (= 6.0.3.7)
+      activerecord (= 6.0.3.7)
+      activestorage (= 6.0.3.7)
+      activesupport (= 6.0.3.7)
+      mail (>= 2.7.1)
+    actionmailer (6.0.3.7)
+      actionpack (= 6.0.3.7)
+      actionview (= 6.0.3.7)
+      activejob (= 6.0.3.7)
+      mail (~> 2.5, >= 2.5.4)
+      rails-dom-testing (~> 2.0)
+    actionpack (6.0.3.7)
+      actionview (= 6.0.3.7)
+      activesupport (= 6.0.3.7)
+      rack (~> 2.0, >= 2.0.8)
+      rack-test (>= 0.6.3)
+      rails-dom-testing (~> 2.0)
+      rails-html-sanitizer (~> 1.0, >= 1.2.0)
+    actiontext (6.0.3.7)
+      actionpack (= 6.0.3.7)
+      activerecord (= 6.0.3.7)
+      activestorage (= 6.0.3.7)
+      activesupport (= 6.0.3.7)
+      nokogiri (>= 1.8.5)
+    actionview (6.0.3.7)
+      activesupport (= 6.0.3.7)
+      builder (~> 3.1)
+      erubi (~> 1.4)
+      rails-dom-testing (~> 2.0)
+      rails-html-sanitizer (~> 1.1, >= 1.2.0)
+    activejob (6.0.3.7)
+      activesupport (= 6.0.3.7)
+      globalid (>= 0.3.6)
+    activemodel (6.0.3.7)
+      activesupport (= 6.0.3.7)
+    activerecord (6.0.3.7)
+      activemodel (= 6.0.3.7)
+      activesupport (= 6.0.3.7)
+    activestorage (6.0.3.7)
+      actionpack (= 6.0.3.7)
+      activejob (= 6.0.3.7)
+      activerecord (= 6.0.3.7)
+      marcel (~> 1.0.0)
+    activesupport (6.0.3.7)
+      concurrent-ruby (~> 1.0, >= 1.0.2)
+      i18n (>= 0.7, < 2)
+      minitest (~> 5.1)
+      tzinfo (~> 1.1)
+      zeitwerk (~> 2.2, >= 2.2.2)
+    addressable (2.7.0)
+      public_suffix (>= 2.0.2, < 5.0)
+    after_transaction_commit (2.2.2)
+      activerecord (>= 5.2)
+    builder (3.2.4)
+    bump (0.10.0)
+    byebug (11.1.3)
+    coderay (1.1.3)
+    concurrent-ruby (1.1.9)
+    crack (0.4.5)
+      rexml
+    crass (1.0.6)
+    database_cleaner (2.0.1)
+      database_cleaner-active_record (~> 2.0.0)
+    database_cleaner-active_record (2.0.0)
+      activerecord (>= 5.a)
+      database_cleaner-core (~> 2.0.0)
+    database_cleaner-core (2.0.1)
+    debug_inspector (1.1.0)
+    deep_merge (1.2.1)
+    diff-lcs (1.4.4)
+    diplomat (2.5.1)
+      deep_merge (~> 1.2)
+      faraday (>= 0.9)
+    erubi (1.10.0)
+    et-orbi (1.2.4)
+      tzinfo
+    faraday (1.4.1)
+      faraday-excon (~> 1.1)
+      faraday-net_http (~> 1.0)
+      faraday-net_http_persistent (~> 1.1)
+      multipart-post (>= 1.2, < 3)
+      ruby2_keywords (>= 0.0.4)
+    faraday-excon (1.1.0)
+    faraday-net_http (1.0.1)
+    faraday-net_http_persistent (1.1.0)
+    fugit (1.4.5)
+      et-orbi (~> 1.1, >= 1.1.8)
+      raabro (~> 1.4)
+    globalid (0.4.2)
+      activesupport (>= 4.2.0)
+    hashdiff (1.0.1)
+    i18n (1.8.10)
+      concurrent-ruby (~> 1.0)
+    loofah (2.10.0)
+      crass (~> 1.0.2)
+      nokogiri (>= 1.5.9)
+    mail (2.7.1)
+      mini_mime (>= 0.1.1)
+    marcel (1.0.1)
+    method_source (1.0.0)
+    mini_mime (1.1.0)
+    minitest (5.14.4)
+    multi_json (1.15.0)
+    multipart-post (2.1.1)
+    mustermann (1.1.1)
+      ruby2_keywords (~> 0.0.1)
+    nio4r (2.5.7)
+    nokogiri (1.11.7-x86_64-darwin)
+      racc (~> 1.4)
+    pg (1.2.3)
+    pry (0.14.1)
+      coderay (~> 1.1)
+      method_source (~> 1.0)
+    public_suffix (4.0.6)
+    raabro (1.4.0)
+    racc (1.5.2)
+    rack (2.2.3)
+    rack-protection (2.1.0)
+      rack
+    rack-test (1.1.0)
+      rack (>= 1.0, < 3)
+    rails (6.0.3.7)
+      actioncable (= 6.0.3.7)
+      actionmailbox (= 6.0.3.7)
+      actionmailer (= 6.0.3.7)
+      actionpack (= 6.0.3.7)
+      actiontext (= 6.0.3.7)
+      actionview (= 6.0.3.7)
+      activejob (= 6.0.3.7)
+      activemodel (= 6.0.3.7)
+      activerecord (= 6.0.3.7)
+      activestorage (= 6.0.3.7)
+      activesupport (= 6.0.3.7)
+      bundler (>= 1.3.0)
+      railties (= 6.0.3.7)
+      sprockets-rails (>= 2.0.0)
+    rails-dom-testing (2.0.3)
+      activesupport (>= 4.2.0)
+      nokogiri (>= 1.6)
+    rails-html-sanitizer (1.3.0)
+      loofah (~> 2.3)
+    railties (6.0.3.7)
+      actionpack (= 6.0.3.7)
+      activesupport (= 6.0.3.7)
+      method_source
+      rake (>= 0.8.7)
+      thor (>= 0.20.3, < 2.0)
+    rake (13.0.3)
+    redis (4.2.5)
+    redis-scripting (1.0.1)
+      redis (>= 3.0)
+    rexml (3.2.5)
+    rspec (3.10.0)
+      rspec-core (~> 3.10.0)
+      rspec-expectations (~> 3.10.0)
+      rspec-mocks (~> 3.10.0)
+    rspec-core (3.10.1)
+      rspec-support (~> 3.10.0)
+    rspec-expectations (3.10.1)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.10.0)
+    rspec-mocks (3.10.2)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.10.0)
+    rspec-support (3.10.2)
+    ruby2_keywords (0.0.4)
+    sinatra (2.1.0)
+      mustermann (~> 1.0)
+      rack (~> 2.2)
+      rack-protection (= 2.1.0)
+      tilt (~> 2.0)
+    sinatra-contrib (2.1.0)
+      multi_json
+      mustermann (~> 1.0)
+      rack-protection (= 2.1.0)
+      sinatra (= 2.1.0)
+      tilt (~> 2.0)
+    sprockets (4.0.2)
+      concurrent-ruby (~> 1.0)
+      rack (> 1, < 3)
+    sprockets-rails (3.2.2)
+      actionpack (>= 4.0)
+      activesupport (>= 4.0)
+      sprockets (>= 3.0.0)
+    thor (1.1.0)
+    thread_safe (0.3.6)
+    tilt (2.0.10)
+    timecop (0.9.4)
+    tzinfo (1.2.9)
+      thread_safe (~> 0.1)
+    webmock (3.13.0)
+      addressable (>= 2.3.6)
+      crack (>= 0.3.2)
+      hashdiff (>= 0.4.0, < 2.0.0)
+    websocket-driver (0.7.5)
+      websocket-extensions (>= 0.1.0)
+    websocket-extensions (0.1.5)
+    wwtd (1.4.1)
+    zeitwerk (2.4.2)
+
+PLATFORMS
+  x86_64-darwin-20
+
+DEPENDENCIES
+  bump
+  byebug
+  database_cleaner (~> 2.0)
+  database_cleaner-active_record (~> 2.0)
+  diplomat (~> 2.5.1)
+  inst-jobs!
+  pg
+  pry
+  rack-test
+  rails (~> 6.0.0)
+  rake
+  rspec (~> 3.10)
+  sinatra (~> 2.0)
+  sinatra-contrib (~> 2.0)
+  timecop (= 0.9.4)
+  webmock
+  wwtd (~> 1.4.0)
+
+BUNDLED WITH
+   2.2.17

data/spec/gemfiles/61.gemfile

@@ -0,0 +1,7 @@
+source "https://rubygems.org"
+
+gemspec :path => "../../"
+
+gem "rails", "~> 6.1.0"
+gem 'sinatra', "~> 2.0"
+gem 'sinatra-contrib', "~> 2.0"

data/spec/shared/shared_backend.rb

@@ -313,6 +313,13 @@ shared_examples_for 'a backend' do
       expect(second).to eq nil
     end
 
+    it "complains if you pass more than one strand-based option" do
+      expect { create_job(strand: 'a', n_strand: 'b') }.to raise_error(ArgumentError)
+      expect { create_job(strand: 'a', singleton: 'b') }.to raise_error(ArgumentError)
+      expect { create_job(n_strand: 'a', singleton: 'b') }.to raise_error(ArgumentError)
+      expect { create_job(strand: 'a', n_strand: 'b', singleton: 'c') }.to raise_error(ArgumentError)
+    end
+
     context 'singleton' do
       it "should create if there's no jobs on the strand" do
         @job = create_job(:singleton => 'myjobs')

data/spec/shared/worker.rb

@@ -21,7 +21,7 @@ shared_examples_for 'Delayed::Worker' do
 
   describe "running a job" do
     it "should not fail when running a job with a % in the name" do
-      @job = "Some % Name here".delay(ignore_transaction: true).starts_with?("Some % Name")
+      @job = "Some % Name here".delay(ignore_transaction: true).start_with?("Some % Name")
       @worker.perform(@job)
     end
   end

data/spec/spec_helper.rb

@@ -5,8 +5,9 @@ require 'delayed/testing'
 
 require 'database_cleaner'
 require 'rack/test'
-require 'test_after_commit' if ::Rails.version < '5'
 require 'timecop'
+require 'webmock/rspec'
+
 require 'pry'
 require 'byebug'
 
@@ -19,6 +20,7 @@ RSpec.configure do |config|
   config.before(:suite) do
     DatabaseCleaner.strategy = :transaction
     DatabaseCleaner.clean_with(:truncation)
+    WebMock.disable_net_connect!
   end
 
   config.before(:each) do |example|
@@ -60,18 +62,8 @@ connection_config = {
   database: ENV['TEST_DB_DATABASE'],
 }
 
-if ::Rails.version < '5'
-  class ActiveRecord::Migration
-    class << self
-      def [](_version); self; end
-    end
-  end
-end
-
 def migrate(file)
-  if ::Rails.version < '5.2'
-    ActiveRecord::Migrator.migrate(file)
-  elsif ::Rails.version >= '6'
+  if ::Rails.version >= '6'
     ActiveRecord::MigrationContext.new(file, ActiveRecord::SchemaMigration).migrate
   else
     ActiveRecord::MigrationContext.new(file).migrate

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: inst-jobs
 version: !ruby/object:Gem::Version
-  version: 2.1.3
+  version: 2.3.2
 platform: ruby
 authors:
 - Tobias Luetke
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-12-22 00:00:00.000000000 Z
+date: 2021-07-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -17,28 +17,28 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '4.2'
+        version: '5.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '4.2'
+        version: '5.2'
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '4.2'
+        version: '5.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '4.2'
+        version: '5.2'
 - !ruby/object:Gem::Dependency
   name: after_transaction_commit
   requirement: !ruby/object:Gem::Requirement
@@ -65,14 +65,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '4.2'
+        version: '5.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '4.2'
+        version: '5.2'
 - !ruby/object:Gem::Dependency
   name: redis
   requirement: !ruby/object:Gem::Requirement
@@ -121,14 +121,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.0.3
+        version: '1.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.0.3
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: bump
   requirement: !ruby/object:Gem::Requirement
@@ -161,44 +161,58 @@ dependencies:
   name: database_cleaner
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.6.1
+        version: '2.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.6.1
+        version: '2.0'
 - !ruby/object:Gem::Dependency
-  name: imperium
+  name: database_cleaner-active_record
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.5.2
+        version: '2.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.0'
+- !ruby/object:Gem::Dependency
+  name: diplomat
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 2.5.1
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.5.2
+        version: 2.5.1
 - !ruby/object:Gem::Dependency
   name: pg
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "<"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "<"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
@@ -261,14 +275,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.8.0
+        version: '3.10'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.8.0
+        version: '3.10'
 - !ruby/object:Gem::Dependency
   name: sinatra
   requirement: !ruby/object:Gem::Requirement
@@ -303,14 +317,28 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.7.1
+        version: 0.9.4
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.7.1
+        version: 0.9.4
+- !ruby/object:Gem::Dependency
+  name: webmock
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: wwtd
   requirement: !ruby/object:Gem::Requirement
@@ -422,11 +450,10 @@ files:
 - spec/delayed/worker/consul_health_check_spec.rb
 - spec/delayed/worker/health_check_spec.rb
 - spec/delayed/worker_spec.rb
-- spec/gemfiles/42.gemfile
-- spec/gemfiles/50.gemfile
-- spec/gemfiles/51.gemfile
 - spec/gemfiles/52.gemfile
 - spec/gemfiles/60.gemfile
+- spec/gemfiles/60.gemfile.lock
+- spec/gemfiles/61.gemfile
 - spec/migrate/20140924140513_add_story_table.rb
 - spec/redis_job_spec.rb
 - spec/sample_jobs.rb
@@ -464,11 +491,10 @@ test_files:
 - spec/sample_jobs.rb
 - spec/spec_helper.rb
 - spec/redis_job_spec.rb
+- spec/gemfiles/60.gemfile.lock
+- spec/gemfiles/61.gemfile
 - spec/gemfiles/60.gemfile
-- spec/gemfiles/42.gemfile
 - spec/gemfiles/52.gemfile
-- spec/gemfiles/50.gemfile
-- spec/gemfiles/51.gemfile
 - spec/shared_jobs_specs.rb
 - spec/shared/performable_method.rb
 - spec/shared/testing.rb

data/spec/gemfiles/42.gemfile

@@ -1,7 +0,0 @@
-source "https://rubygems.org"
-
-gemspec :path=>"../../"
-
-gem "rails", "~> 4.2.5"
-gem "after_transaction_commit", "<2"
-gem 'test_after_commit', '0.4.1'

data/spec/gemfiles/50.gemfile

@@ -1,7 +0,0 @@
-source "https://rubygems.org"
-
-gemspec :path=>"../../"
-
-gem "rails", "~> 5.0.0"
-gem 'sinatra', "2.0.0.beta2"
-gem 'sinatra-contrib', "2.0.0.beta2"

data/spec/gemfiles/51.gemfile

@@ -1,7 +0,0 @@
-source "https://rubygems.org"
-
-gemspec :path=>"../../"
-
-gem "rails", "~> 5.1.0"
-gem 'sinatra', "2.0.0.beta2"
-gem 'sinatra-contrib', "2.0.0.beta2"