inspec 4.7.24 → 4.10.4

data/lib/plugins/inspec-plugin-manager-cli/test/functional/inspec-plugin_test.rb

@@ -19,10 +19,6 @@ module PluginManagerHelpers
     end
   end
 
-  def setup
-    skip_windows!
-  end
-
   def copy_in_project_config_dir(fixture_name, dest = nil)
     src = Dir.glob(File.join(project_config_dirs_path, fixture_name, "*"))
     dest ||= File.join(project_config_dirs_path, "empty")
@@ -54,19 +50,17 @@ end
 class PluginManagerCliHelp < Minitest::Test
   include CorePluginFunctionalHelper
 
-  def setup
-    skip_windows!
-  end
-
   # Main inspec help subcommand listing
   def test_inspec_help_includes_plugin
     result = run_inspec_process_with_this_plugin("help")
+    skip_windows!
     assert_includes result.stdout, "inspec plugin"
   end
 
   # inspec plugin help subcommand listing
   def test_inspec_plugin_help_includes_plugin
     result = run_inspec_process_with_this_plugin("plugin help")
+    skip_windows!
     assert_includes result.stdout, "inspec plugin list"
     assert_includes result.stdout, "inspec plugin search"
     assert_includes result.stdout, "inspec plugin install"
@@ -84,20 +78,29 @@ class PluginManagerCliList < Minitest::Test
 
   def test_list_when_no_user_plugins_installed
     result = run_inspec_process_with_this_plugin("plugin list")
-    assert_equal 0, result.exit_status, "exist status must be 0"
+
+    skip_windows!
     assert_includes result.stdout, "0 plugin(s) total", "Empty list should include zero count"
+
+    assert_exit_code 0, result
   end
 
   def test_list_all_when_no_user_plugins_installed
     result = run_inspec_process_with_this_plugin("plugin list --all")
-    assert_equal 0, result.exit_status, "exist status must be 0"
+
+    skip_windows!
     assert_includes result.stdout, "6 plugin(s) total", "--all list should find six"
     assert_includes result.stdout, "inspec-plugin-manager-cli", "--all list should find inspec-plugin-manager-cli"
     assert_includes result.stdout, "habitat", "--all list should find habitat"
 
+    assert_exit_code 0, result
+
+    # TODO: split
     result = run_inspec_process_with_this_plugin("plugin list -a")
-    assert_equal 0, result.exit_status, "exist status must be 0"
+
     assert_includes result.stdout, "6 plugin(s) total", "-a list should find six"
+
+    assert_exit_code 0, result
   end
 
   def test_list_when_gem_and_path_plugins_installed
@@ -107,7 +110,8 @@ class PluginManagerCliList < Minitest::Test
     end
 
     result = run_inspec_process_with_this_plugin("plugin list", pre_run: pre_block)
-    assert_equal 0, result.exit_status, "exist status must be 0"
+
+    skip_windows!
     assert_includes result.stdout, "2 plugin(s) total", "gem+path should show two plugins"
 
     # Plugin Name                   Version   Via     ApiVer
@@ -120,6 +124,8 @@ class PluginManagerCliList < Minitest::Test
     assert_match(/\s*inspec-\S+\s+\d+\.\d+\.\d+\s+gem\s+2/, gem_line)
     path_line = result.stdout.split("\n").grep(/path/).first
     assert_match(/\s*inspec-\S+\s+src\s+path\s+2/, path_line)
+
+    assert_exit_code 0, result
   end
 
   def test_list_when_a_train_plugin_is_installed
@@ -129,7 +135,8 @@ class PluginManagerCliList < Minitest::Test
     end
 
     result = run_inspec_process_with_this_plugin("plugin list", pre_run: pre_block)
-    assert_equal 0, result.exit_status, "exist status must be 0"
+
+    skip_windows!
     assert_includes result.stdout, "1 plugin(s) total", "list train should show one plugins"
 
     # Plugin Name                   Version   Via     ApiVer
@@ -142,6 +149,8 @@ class PluginManagerCliList < Minitest::Test
     assert_includes(train_line, "0.1.0")
     assert_includes(train_line, "gem")
     assert_includes(train_line, "train-1")
+
+    assert_exit_code 0, result
   end
 end
 
@@ -160,79 +169,98 @@ class PluginManagerCliSearch < Minitest::Test
 
   def test_search_for_a_real_gem_with_full_name_no_options
     result = run_inspec_process("plugin search --include-test-fixture inspec-test-fixture")
-    assert_equal 0, result.exit_status, "Search should exit 0 on a hit"
+
     assert_includes result.stdout, "inspec-test-fixture", "Search result should contain the gem name"
     assert_includes result.stdout, "1 plugin(s) found", "Search result should find 1 plugin"
     line = result.stdout.split("\n").grep(/inspec-test-fixture/).first
     assert_match(/\s*inspec-test-fixture\s+\((\d+\.\d+\.\d+){1}\)/, line, "Plugin line should include name and exactly one version")
+
+    assert_exit_code 0, result
   end
 
   def test_search_for_a_real_gem_with_stub_name_no_options
     result = run_inspec_process("plugin search --include-test-fixture inspec-test-")
-    assert_equal 0, result.exit_status, "Search should exit 0 on a hit"
+
     assert_includes result.stdout, "inspec-test-fixture", "Search result should contain the gem name"
     assert_includes result.stdout, "1 plugin(s) found", "Search result should find 1 plugin"
 
     line = result.stdout.split("\n").grep(/inspec-test-fixture/).first
     assert_match(/\s*inspec-test-fixture\s+\((\d+\.\d+\.\d+){1}\)/, line, "Plugin line should include name and exactly one version")
+
+    assert_exit_code 0, result
   end
 
   def test_search_for_a_real_gem_with_full_name_and_exact_option
     result = run_inspec_process("plugin search --exact --include-test-fixture inspec-test-fixture")
-    assert_equal 0, result.exit_status, "Search should exit 0 on a hit"
+
     assert_includes result.stdout, "inspec-test-fixture", "Search result should contain the gem name"
     assert_includes result.stdout, "1 plugin(s) found", "Search result should find 1 plugin"
 
+    assert_exit_code 0, result
+
+    # TODO: split
     result = run_inspec_process("plugin search -e --include-test-fixture inspec-test-fixture")
-    assert_equal 0, result.exit_status, "Search should exit 0 on a hit"
+
+    assert_exit_code 0, result
   end
 
   def test_search_for_a_real_gem_with_stub_name_and_exact_option
     result = run_inspec_process("plugin search --exact --include-test-fixture inspec-test-")
-    assert_equal 2, result.exit_status, "Search should exit 2 on a miss"
+
     assert_includes result.stdout, "0 plugin(s) found", "Search result should find 0 plugins"
 
+    assert_exit_code 2, result
+
+    # TODO: split
     result = run_inspec_process("plugin search -e --include-test-fixture inspec-test-")
-    assert_equal 2, result.exit_status, "Search should exit 2 on a miss"
+
+    assert_exit_code 2, result
   end
 
   def test_search_for_a_real_gem_with_full_name_and_all_option
     result = run_inspec_process("plugin search --all --include-test-fixture inspec-test-fixture")
-    assert_equal 0, result.exit_status, "Search should exit 0 on a hit"
     assert_includes result.stdout, "inspec-test-fixture", "Search result should contain the gem name"
     assert_includes result.stdout, "1 plugin(s) found", "Search result should find 1 plugin"
 
     line = result.stdout.split("\n").grep(/inspec-test-fixture/).first
     assert_match(/\s*inspec-test-fixture\s+\((\d+\.\d+\.\d+(,\s)?){2,}\)/, line, "Plugin line should include name and at least two versions")
 
+    assert_exit_code 0, result
+
+    # TODO: split
     result = run_inspec_process("plugin search -a --include-test-fixture inspec-test-fixture")
-    assert_equal 0, result.exit_status, "Search should exit 0 on a hit"
+
+    assert_exit_code 0, result
   end
 
   def test_search_for_a_gem_with_missing_prefix
     result = run_inspec_process("plugin search --include-test-fixture test-fixture")
-    assert_equal 1, result.exit_status, "Search should exit 1 on user error"
+    assert_exit_code 1, result
     assert_includes result.stdout, "All inspec plugins must begin with either 'inspec-' or 'train-'"
   end
 
   def test_search_for_a_gem_that_does_not_exist
     result = run_inspec_process("plugin search --include-test-fixture inspec-test-fixture-nonesuch")
-    assert_equal 2, result.exit_status, "Search should exit 2 on a miss"
+
     assert_includes result.stdout, "0 plugin(s) found", "Search result should find 0 plugins"
+
+    assert_exit_code 2, result
   end
 
   def test_search_for_a_real_gem_with_full_name_no_options_and_train_name
     result = run_inspec_process("plugin search --include-test-fixture train-test-fixture")
-    assert_equal 0, result.exit_status, "Search should exit 0 on a hit"
+
     assert_includes result.stdout, "train-test-fixture", "Search result should contain the gem name"
     assert_includes result.stdout, "1 plugin(s) found", "Search result should find 1 plugin"
     line = result.stdout.split("\n").grep(/train-test-fixture/).first
     assert_match(/\s*train-test-fixture\s+\((\d+\.\d+\.\d+){1}\)/, line, "Plugin line should include name and exactly one version")
+
+    assert_exit_code 0, result
   end
 
   def test_search_omit_excluded_inspec_plugins
     result = run_inspec_process("plugin search --include-test-fixture inspec-")
-    assert_equal 0, result.exit_status, "Search should exit 0"
+
     assert_includes result.stdout, "inspec-test-fixture", "Search result should contain the test gem"
     %w{
       inspec-core
@@ -240,6 +268,8 @@ class PluginManagerCliSearch < Minitest::Test
     }.each do |plugin_name|
       refute_includes result.stdout, plugin_name, "Search result should not contain excluded gems"
     end
+
+    assert_exit_code 0, result
   end
 
   def test_search_for_a_real_gem_with_full_name_no_options_filter_fixtures
@@ -300,11 +330,9 @@ class PluginManagerCliInstall < Minitest::Test
 
       install_result = run_inspec_process_with_this_plugin("plugin install #{fixture_info[:given]}", post_run: list_after_run)
 
-      assert_empty install_result.stderr
-      assert_equal 0, install_result.exit_status, "Exit status should be 0"
-
       # Check UX messaging
       success_message = install_result.stdout.split("\n").grep(/installed/).last
+      skip_windows!
       refute_nil success_message, "Should find a success message at the end"
       assert_includes success_message, fixture_info[:plugin_name]
       assert_includes success_message, "plugin installed via source path reference"
@@ -319,6 +347,10 @@ class PluginManagerCliInstall < Minitest::Test
       plugin_data = install_result.payload.plugin_data
       entry = plugin_data["plugins"].detect { |e| e["name"] == fixture_info[:plugin_name] }
       assert_equal fixture_info[:resolved_path], entry["installation_path"], "Regardless of input, the entry point should be correct."
+
+      assert_empty install_result.stderr
+
+      assert_exit_code 0, install_result
     end
   end
 
@@ -326,42 +358,48 @@ class PluginManagerCliInstall < Minitest::Test
     bad_path = File.join(project_fixtures_path, "none", "such", "inspec-test-fixture-nonesuch.rb")
     install_result = run_inspec_process_with_this_plugin("plugin install #{bad_path}")
 
-    assert_empty install_result.stderr
-    assert_equal 1, install_result.exit_status, "Exit status should be 1"
-
     error_message = install_result.stdout.split("\n").last
+    skip_windows!
     assert_includes error_message, "No such source code path"
     assert_includes error_message, "inspec-test-fixture-nonesuch.rb"
     assert_includes error_message, "installation failed"
+
+    assert_empty install_result.stderr
+
+    assert_exit_code 1, install_result
   end
 
   def test_fail_install_from_path_with_wrong_name
     bad_path = File.join(project_fixtures_path, "plugins", "wrong-name", "lib", "wrong-name.rb")
     install_result = run_inspec_process_with_this_plugin("plugin install #{bad_path}")
 
-    assert_empty install_result.stderr
-    assert_equal 1, install_result.exit_status, "Exit status should be 1"
-
     error_message = install_result.stdout.split("\n").last
+    skip_windows!
     assert_includes error_message, "Invalid plugin name"
     assert_includes error_message, "wrong-name"
     assert_includes error_message, "All inspec plugins must begin with either 'inspec-' or 'train-'"
     assert_includes error_message, "installation failed"
+
+    assert_empty install_result.stderr
+
+    assert_exit_code 1, install_result
   end
 
   def test_fail_install_from_path_when_it_is_not_a_plugin
     bad_path = File.join(project_fixtures_path, "plugins", "inspec-egg-white-omelette", "lib", "inspec-egg-white-omelette.rb")
     install_result = run_inspec_process_with_this_plugin("plugin install #{bad_path}")
 
-    assert_empty install_result.stderr
-    assert_equal 1, install_result.exit_status, "Exit status should be 1"
-
     error_message = install_result.stdout.split("\n").last
+    skip_windows!
     assert_includes error_message, "Does not appear to be a plugin"
     assert_includes error_message, "inspec-egg-white-omelette"
     assert_includes error_message, "After probe-loading the supposed plugin, it did not register"
     assert_includes error_message, "Ensure something inherits from 'Inspec.plugin(2)'"
     assert_includes error_message, "installation failed"
+
+    assert_empty install_result.stderr
+
+    assert_exit_code 1, install_result
   end
 
   def test_fail_install_from_path_when_it_is_already_installed
@@ -375,38 +413,41 @@ class PluginManagerCliInstall < Minitest::Test
     end
 
     install_result = run_inspec_process_with_this_plugin("plugin install #{plugin_path}", pre_run: pre_block)
-    assert_empty install_result.stderr
-    assert_equal 2, install_result.exit_status, "Exit status on second install should be 2"
 
     error_message = install_result.stdout.split("\n").last
+    skip_windows!
     assert_includes error_message, "Plugin already installed"
     assert_includes error_message, "inspec-test-fixture"
     assert_includes error_message, "Use 'inspec plugin list' to see previously installed plugin"
     assert_includes error_message, "installation failed"
+
+    assert_empty install_result.stderr
+
+    assert_exit_code 2, install_result
   end
 
   def test_fail_install_from_path_when_the_dir_structure_is_wrong
     bad_path = File.join(project_fixtures_path, "plugins", "inspec-wrong-structure")
     install_result = run_inspec_process_with_this_plugin("plugin install #{bad_path}")
 
-    assert_empty install_result.stderr
-    assert_equal 1, install_result.exit_status, "Exit status should be 1"
-
     error_message = install_result.stdout.split("\n").last
+    skip_windows!
     assert_includes error_message, "Unrecognizable plugin structure"
     assert_includes error_message, "inspec-wrong-structure"
     assert_includes error_message, " When installing from a path, please provide the path of the entry point file"
     assert_includes error_message, "installation failed"
+
+    assert_empty install_result.stderr
+
+    assert_exit_code 1, install_result
   end
 
   def test_install_from_gemfile
     fixture_gemfile_path = File.join(core_fixture_plugins_path, "inspec-test-fixture", "pkg", "inspec-test-fixture-0.1.0.gem")
     install_result = run_inspec_process_with_this_plugin("plugin install #{fixture_gemfile_path}", post_run: list_after_run)
 
-    assert_empty install_result.stderr
-    assert_equal 0, install_result.exit_status, "Exit status should be 0"
-
     success_message = install_result.stdout.split("\n").grep(/installed/).last
+    skip_windows!
     refute_nil success_message, "Should find a success message at the end"
     assert_includes success_message, "inspec-test-fixture"
     assert_includes success_message, "0.1.0"
@@ -416,24 +457,29 @@ class PluginManagerCliInstall < Minitest::Test
     itf_line = list_result.stdout.split("\n").grep(/inspec-test-fixture/).first
     refute_nil itf_line, "inspec-test-fixture should now appear in the output of inspec list"
     assert_match(/\s*inspec-test-fixture\s+0.1.0\s+gem\s+/, itf_line, "list output should show that it is a gem installation with version")
+
+    assert_empty install_result.stderr
+
+    assert_exit_code 0, install_result
   end
 
   def test_fail_install_from_nonexistant_gemfile
     bad_path = File.join(project_fixtures_path, "none", "such", "inspec-test-fixture-nonesuch-0.3.0.gem")
     install_result = run_inspec_process_with_this_plugin("plugin install #{bad_path}")
 
-    assert_empty install_result.stderr
-    assert_equal 1, install_result.exit_status, "Exit status should be 1"
+    skip_windows!
     assert_match(/No such plugin gem file .+ - installation failed./, install_result.stdout)
+
+    assert_empty install_result.stderr
+
+    assert_exit_code 1, install_result
   end
 
   def test_install_from_rubygems_latest
     install_result = run_inspec_process_with_this_plugin("plugin install inspec-test-fixture", post_run: list_after_run)
 
-    assert_empty install_result.stderr
-    assert_equal 0, install_result.exit_status, "Exit status should be 0"
-
     success_message = install_result.stdout.split("\n").grep(/installed/).last
+    skip_windows!
     refute_nil success_message, "Should find a success message at the end"
     assert_includes success_message, "inspec-test-fixture"
     assert_includes success_message, "0.2.0"
@@ -443,23 +489,28 @@ class PluginManagerCliInstall < Minitest::Test
     itf_line = list_result.stdout.split("\n").grep(/inspec-test-fixture/).first
     refute_nil itf_line, "inspec-test-fixture should now appear in the output of inspec list"
     assert_match(/\s*inspec-test-fixture\s+0.2.0\s+gem\s+/, itf_line, "list output should show that it is a gem installation with version")
+
+    assert_empty install_result.stderr
+
+    assert_exit_code 0, install_result
   end
 
   def test_fail_install_from_nonexistant_remote_rubygem
     install_result = run_inspec_process_with_this_plugin("plugin install inspec-test-fixture-nonesuch")
 
-    assert_empty install_result.stderr
-    assert_equal 1, install_result.exit_status, "Exit status should be 1"
+    skip_windows!
     assert_match(/No such plugin gem .+ could be found on rubygems.org - installation failed./, install_result.stdout)
+
+    assert_empty install_result.stderr
+
+    assert_exit_code 1, install_result
   end
 
   def test_install_from_rubygems_with_pinned_version
     install_result = run_inspec_process_with_this_plugin("plugin install inspec-test-fixture -v 0.1.0", post_run: list_after_run)
 
-    assert_empty install_result.stderr
-    assert_equal 0, install_result.exit_status, "Exit status should be 0"
-
     success_message = install_result.stdout.split("\n").grep(/installed/).last
+    skip_windows!
     refute_nil success_message, "Should find a success message at the end"
     assert_includes success_message, "inspec-test-fixture"
     assert_includes success_message, "0.1.0"
@@ -469,32 +520,40 @@ class PluginManagerCliInstall < Minitest::Test
     itf_line = list_result.stdout.split("\n").grep(/inspec-test-fixture/).first
     refute_nil itf_line, "inspec-test-fixture should now appear in the output of inspec list"
     assert_match(/\s*inspec-test-fixture\s+0.1.0\s+gem\s+/, itf_line, "list output should show that it is a gem installation with version")
+
+    assert_empty install_result.stderr
+
+    assert_exit_code 0, install_result
   end
 
   def test_fail_install_from_nonexistant_rubygem_version
     install_result = run_inspec_process_with_this_plugin("plugin install inspec-test-fixture -v 99.99.99")
 
-    assert_empty install_result.stderr
-    assert_equal 1, install_result.exit_status, "Exit status should be 1"
-
     fail_message = install_result.stdout.split("\n").grep(/failed/).last
+    skip_windows!
     refute_nil fail_message, "Should find a failure message at the end"
     assert_includes fail_message, "inspec-test-fixture"
     assert_includes fail_message, "99.99.99"
     assert_includes fail_message, "no such version"
     assert_includes fail_message, "on rubygems.org"
+
+    assert_empty install_result.stderr
+
+    assert_exit_code 1, install_result
   end
 
   def test_refuse_install_when_missing_prefix
     install_result = run_inspec_process_with_this_plugin("plugin install test-fixture")
 
-    assert_empty install_result.stderr
-    assert_equal 1, install_result.exit_status, "Exit status should be 1"
-
     fail_message = install_result.stdout.split("\n").grep(/failed/).last
+    skip_windows!
     refute_nil fail_message, "Should find a failure message at the end"
     assert_includes fail_message, "test-fixture"
     assert_includes fail_message, "All inspec plugins must begin with either 'inspec-' or 'train-'"
+
+    assert_empty install_result.stderr
+
+    assert_exit_code 1, install_result
   end
 
   def test_refuse_install_when_already_installed_same_version
@@ -504,14 +563,17 @@ class PluginManagerCliInstall < Minitest::Test
     end
 
     install_result = run_inspec_process_with_this_plugin("plugin install inspec-test-fixture", pre_run: pre_block)
-    assert_empty install_result.stderr
-    assert_equal 2, install_result.exit_status, "Exit status should be 2"
 
     refusal_message = install_result.stdout.split("\n").grep(/refusing/).last
+    skip_windows!
     refute_nil refusal_message, "Should find a failure message at the end"
     assert_includes refusal_message, "inspec-test-fixture"
     assert_includes refusal_message, "0.2.0"
     assert_includes refusal_message, "Plugin already installed at latest version"
+
+    assert_empty install_result.stderr
+
+    assert_exit_code 2, install_result
   end
 
   def test_refuse_install_when_already_installed_can_update
@@ -521,25 +583,26 @@ class PluginManagerCliInstall < Minitest::Test
     end
 
     install_result = run_inspec_process_with_this_plugin("plugin install inspec-test-fixture", pre_run: pre_block)
-    assert_empty install_result.stderr
-    assert_equal 2, install_result.exit_status, "Exit status should be 2"
 
     refusal_message = install_result.stdout.split("\n").grep(/refusing/).last
+    skip_windows!
     refute_nil refusal_message, "Should find a failure message at the end"
     assert_includes refusal_message, "inspec-test-fixture"
     assert_includes refusal_message, "0.1.0"
     assert_includes refusal_message, "0.2.0"
     assert_includes refusal_message, "Update required"
     assert_includes refusal_message, "inspec plugin update"
+
+    assert_empty install_result.stderr
+
+    assert_exit_code 2, install_result
   end
 
   def test_install_from_rubygems_latest_with_train_plugin
     install_result = run_inspec_process_with_this_plugin("plugin install train-test-fixture", post_run: list_after_run)
 
-    assert_empty install_result.stderr
-    assert_equal 0, install_result.exit_status, "Exit status should be 0"
-
     success_message = install_result.stdout.split("\n").grep(/installed/).last
+    skip_windows!
     refute_nil success_message, "Should find a success message at the end"
     assert_includes success_message, "train-test-fixture"
     assert_includes success_message, "0.1.0"
@@ -549,6 +612,10 @@ class PluginManagerCliInstall < Minitest::Test
     itf_line = list_result.stdout.split("\n").grep(/train-test-fixture/).first
     refute_nil itf_line, "train-test-fixture should now appear in the output of inspec list"
     assert_match(/\s*train-test-fixture\s+0.1.0\s+gem\s+/, itf_line, "list output should show that it is a gem installation with version")
+
+    assert_empty install_result.stderr
+
+    assert_exit_code 0, install_result
   end
 
   def test_refuse_install_when_plugin_on_exclusion_list
@@ -562,17 +629,19 @@ class PluginManagerCliInstall < Minitest::Test
       train-tax-calculator
     }.each do |plugin_name|
       install_result = run_inspec_process_with_this_plugin("plugin install #{plugin_name}")
-      assert_empty install_result.stderr
-      assert_equal 2, install_result.exit_status, "Exit status should be 2"
-
       refusal_message = install_result.stdout
       refute_nil refusal_message, "Should find a failure message at the end"
+      skip_windows!
       assert_includes refusal_message, plugin_name
       assert_includes refusal_message, "Plugin on Exclusion List"
       assert_includes refusal_message, "refusing to install"
       assert_includes refusal_message, "Rationale:"
       assert_includes refusal_message, "etc/plugin_filters.json"
       assert_includes refusal_message, "github.com/inspec/inspec/issues/new"
+
+      assert_empty install_result.stderr
+
+      assert_exit_code 2, install_result
     end
   end
 
@@ -581,9 +650,12 @@ class PluginManagerCliInstall < Minitest::Test
 
     install_result = run_inspec_process_with_this_plugin("plugin install inspec-test-fixture -v 0.1.1 --log-level debug")
 
-    assert_equal 1, install_result.exit_status, "Exit status should be 1"
+    skip_windows!
     assert_includes install_result.stdout, "DEBUG"
+
     assert_includes install_result.stderr, "can't activate rake"
+
+    assert_exit_code 1, install_result
   end
 end
 
@@ -603,10 +675,9 @@ class PluginManagerCliUpdate < Minitest::Test
     end
 
     update_result = run_inspec_process_with_this_plugin("plugin update inspec-test-fixture", pre_run: pre_block, post_run: list_after_run)
-    assert_empty update_result.stderr
-    assert_equal 0, update_result.exit_status, "Exit status should be 0"
 
     success_message = update_result.stdout.split("\n").grep(/updated/).last
+    skip_windows!
     refute_nil success_message, "Should find a success message at the end"
     assert_includes success_message, "inspec-test-fixture"
     assert_includes success_message, "0.1.0"
@@ -617,6 +688,10 @@ class PluginManagerCliUpdate < Minitest::Test
     itf_line = list_result.stdout.split("\n").grep(/inspec-test-fixture/).first
     refute_nil itf_line, "inspec-test-fixture should appear in the output of inspec list"
     assert_match(/\s*inspec-test-fixture\s+0.2.0\s+gem\s+/, itf_line, "list output should show that it is a gem installation with version 0.2.0")
+
+    assert_empty update_result.stderr
+
+    assert_exit_code 0, update_result
   end
 
   def test_refuse_update_when_already_current
@@ -626,22 +701,28 @@ class PluginManagerCliUpdate < Minitest::Test
     end
 
     update_result = run_inspec_process_with_this_plugin("plugin update inspec-test-fixture", pre_run: pre_block)
-    assert_empty update_result.stderr
-    assert_equal 2, update_result.exit_status, "Exit status should be 2"
 
     refusal_message = update_result.stdout.split("\n").grep(/refusing/).last
+    skip_windows!
     refute_nil refusal_message, "Should find a failure message at the end"
     assert_includes refusal_message, "inspec-test-fixture"
     assert_includes refusal_message, "0.2.0"
     assert_includes refusal_message, "Already installed at latest version"
+
+    assert_empty update_result.stderr
+
+    assert_exit_code 2, update_result
   end
 
   def test_fail_update_from_nonexistant_gem
     update_result = run_inspec_process_with_this_plugin("plugin update inspec-test-fixture-nonesuch")
 
+    skip_windows!
+    assert_match(/No such plugin installed:.+ - update failed/, update_result.stdout)
+
     assert_empty update_result.stderr
-    assert_equal 1, update_result.exit_status, "Exit status should be 1"
-    assert_match(/No such plugin installed: .+ - update failed/, update_result.stdout)
+
+    assert_exit_code 1, update_result
   end
 
   def test_fail_update_path
@@ -651,14 +732,17 @@ class PluginManagerCliUpdate < Minitest::Test
     end
 
     update_result = run_inspec_process_with_this_plugin("plugin update inspec-meaning-of-life", pre_run: pre_block)
-    assert_empty update_result.stderr
-    assert_equal 2, update_result.exit_status, "Exit status should be 2"
 
     refusal_message = update_result.stdout.split("\n").grep(/refusing/).last
+    skip_windows!
     refute_nil refusal_message, "Should find a failure message at the end"
     assert_includes refusal_message, "inspec-meaning-of-life"
     assert_includes refusal_message, "inspec plugin uninstall"
     assert_includes refusal_message, "Cannot update path-based install"
+
+    assert_empty update_result.stderr
+
+    assert_exit_code 2, update_result
   end
 end
 
@@ -677,10 +761,9 @@ class PluginManagerCliUninstall < Minitest::Test
 
     # Attempt uninstall
     uninstall_result = run_inspec_process_with_this_plugin("plugin uninstall inspec-test-fixture", pre_run: pre_block, post_run: list_after_run)
-    assert_empty uninstall_result.stderr
-    assert_equal 0, uninstall_result.exit_status, "Exit status should be 0"
 
     success_message = uninstall_result.stdout.split("\n").grep(/uninstalled/).last
+    skip_windows!
     refute_nil success_message, "Should find a success message at the end"
     assert_includes success_message, "inspec-test-fixture"
     assert_includes success_message, "0.1.0"
@@ -689,6 +772,10 @@ class PluginManagerCliUninstall < Minitest::Test
     list_result = uninstall_result.payload.list_result
     itf_line = list_result.stdout.split("\n").grep(/inspec-test-fixture/).first
     assert_nil itf_line, "inspec-test-fixture should not appear in the output of inspec list"
+
+    assert_empty uninstall_result.stderr
+
+    assert_exit_code 0, uninstall_result
   end
 
   def test_when_a_path_plugin_can_be_uninstalled
@@ -699,10 +786,9 @@ class PluginManagerCliUninstall < Minitest::Test
     end
 
     uninstall_result = run_inspec_process_with_this_plugin("plugin uninstall inspec-meaning-of-life", pre_run: pre_block, post_run: list_after_run)
-    assert_empty uninstall_result.stderr
-    assert_equal 0, uninstall_result.exit_status, "Exit status should be 0"
 
     success_message = uninstall_result.stdout.split("\n").grep(/uninstalled/).last
+    skip_windows!
     refute_nil success_message, "Should find a success message at the end"
     assert_includes success_message, "inspec-meaning-of-life"
     assert_includes success_message, "path-based plugin install"
@@ -711,14 +797,21 @@ class PluginManagerCliUninstall < Minitest::Test
     list_result = uninstall_result.payload.list_result
     itf_line = list_result.stdout.split("\n").grep(/inspec-meaning-of-life/).first
     assert_nil itf_line, "inspec-meaning-of-life should not appear in the output of inspec list"
+
+    assert_empty uninstall_result.stderr
+
+    assert_exit_code 0, uninstall_result
   end
 
   def test_fail_uninstall_from_plugin_that_is_not_installed
     uninstall_result = run_inspec_process_with_this_plugin("plugin uninstall inspec-test-fixture-nonesuch")
 
-    assert_empty uninstall_result.stderr
-    assert_equal 1, uninstall_result.exit_status, "Exit status should be 1"
+    skip_windows!
     refute_includes "Inspec::Plugin::V2::UnInstallError", uninstall_result.stdout # Stacktrace marker
-    assert_match(/No such plugin installed: .+ - uninstall failed/, uninstall_result.stdout)
+    assert_match(/No such plugin installed:.+ - uninstall failed/, uninstall_result.stdout)
+
+    assert_empty uninstall_result.stderr
+
+    assert_exit_code 1, uninstall_result
   end
 end