inspec-core 4.18.51 → 4.18.85

data/lib/inspec/resources/port.rb

@@ -703,7 +703,7 @@ module Inspec::Resources
   end
 
   class SolarisPorts < FreeBsdPorts
-    include SolarisNetstatParser
+    include Inspec::Utils::SolarisNetstatParser
 
     def info
       # extract all port info

data/lib/inspec/resources/postfix_conf.rb

@@ -4,7 +4,7 @@ require "inspec/utils/simpleconfig"
 module Inspec::Resources
   class PostfixConf < IniConfig
     name "postfix_conf"
-    supports platform: "linux"
+    supports platform: "unix"
     desc "Use the postfix_conf Inspec audit resource to test the configuration of the Postfix Mail Transfer Agent"
 
     # Allow user to specify a custom configuration path, use default Postfix configuration path if no custom path is provided

data/lib/inspec/resources/service.rb

@@ -112,21 +112,23 @@ module Inspec::Resources
       # Ubuntu < 15.04 : Upstart
       # Upstart runs with PID 1 as /sbin/init.
       # Systemd runs with PID 1 as /lib/systemd/systemd.
-      if %w{ubuntu}.include?(platform)
+
+      case platform
+      when "ubuntu"
         version = os[:release].to_f
         if version < 15.04
           Upstart.new(inspec, service_ctl)
         else
           Systemd.new(inspec, service_ctl)
         end
-      elsif %w{linuxmint}.include?(platform)
+      when "linuxmint"
         version = os[:release].to_f
         if version < 18
           Upstart.new(inspec, service_ctl)
         else
           Systemd.new(inspec, service_ctl)
         end
-      elsif %w{debian}.include?(platform)
+      when "debian"
         if os[:release] == "buster/sid"
           version = 10
         else
@@ -137,41 +139,47 @@ module Inspec::Resources
         elsif version > 0
           SysV.new(inspec, service_ctl || "/usr/sbin/service")
         end
-      elsif %w{redhat fedora centos oracle cloudlinux}.include?(platform)
+      when "redhat", "fedora", "centos", "oracle", "cloudlinux"
         version = os[:release].to_i
-        if (%w{redhat centos oracle cloudlinux}.include?(platform) && version >= 7) || (platform == "fedora" && version >= 15)
+
+        systemd = ((platform != "fedora" && version >= 7) ||
+                   (platform == "fedora" && version >= 15))
+
+        if systemd
           Systemd.new(inspec, service_ctl)
         else
           SysV.new(inspec, service_ctl || "/sbin/service")
         end
-      elsif %w{wrlinux}.include?(platform)
+      when "wrlinux"
         SysV.new(inspec, service_ctl)
-      elsif %w{mac_os_x}.include?(platform)
+      when "mac_os_x"
         LaunchCtl.new(inspec, service_ctl)
-      elsif os.windows?
+      when "windows"
         WindowsSrv.new(inspec)
-      elsif %w{freebsd}.include?(platform)
+      when "freebsd"
         BSDInit.new(inspec, service_ctl)
-      elsif %w{arch}.include?(platform)
+      when "arch"
         Systemd.new(inspec, service_ctl)
-      elsif %w{coreos}.include?(platform)
+      when "coreos"
         Systemd.new(inspec, service_ctl)
-      elsif %w{suse opensuse}.include?(platform)
+      when "suse", "opensuse"
         if os[:release].to_i >= 12
           Systemd.new(inspec, service_ctl)
         else
           SysV.new(inspec, service_ctl || "/sbin/service")
         end
-      elsif %w{aix}.include?(platform)
+      when "aix"
         SrcMstr.new(inspec)
-      elsif %w{amazon}.include?(platform)
+      when "amazon"
         if os[:release] =~ /^20\d\d/
           Upstart.new(inspec, service_ctl)
         else
           Systemd.new(inspec, service_ctl)
         end
-      elsif os.solaris?
+      when "solaris", "smartos", "omnios", "openindiana", "opensolaris", "nexentacore"
         Svcs.new(inspec)
+      when "yocto"
+        Systemd.new(inspec, service_ctl)
       end
     end
 

data/lib/inspec/resources/users.rb

@@ -442,8 +442,8 @@ module Inspec::Resources
   end
 
   class LinuxUser < UnixUser
-    include PasswdParser
-    include CommentParser
+    include Inspec::Utils::PasswdParser
+    include Inspec::Utils::CommentParser
 
     def meta_info(username)
       cmd = inspec.command("getent passwd #{username}")
@@ -589,7 +589,7 @@ module Inspec::Resources
   # - chpass(1)  A flexible tool for changing user database information.
   # - passwd(1)  The command-line tool to change user passwords.
   class FreeBSDUser < UnixUser
-    include PasswdParser
+    include Inspec::Utils::PasswdParser
 
     def meta_info(username)
       cmd = inspec.command("pw usershow #{username} -7")

data/lib/inspec/resources/virtualization.rb

@@ -3,8 +3,8 @@ require "hashie/mash"
 module Inspec::Resources
   class Virtualization < Inspec.resource(1)
     name "virtualization"
-    supports platform: "linux"
-    desc "Use the virtualization InSpec audit resource to test the virtualization platform on which the system is running"
+    supports platform: "unix"
+    desc "Use the virtualization InSpec audit resource to test various virtualization platforms."
     example <<~EXAMPLE
       describe virtualization do
         its('system') { should eq 'docker' }
@@ -23,19 +23,21 @@ module Inspec::Resources
     EXAMPLE
 
     def initialize
+      # TODO: no need for hashie here... in fact, no reason for a hash at all
       @virtualization_data = Hashie::Mash.new
       collect_data_linux
     end
 
     # add helper methods for easy access of properties
     # allows users to use virtualization.role, virtualization.system
-    %w{role system}.each do |property|
-      define_method(property.to_sym) do
-        @virtualization_data[property.to_sym]
+    %i{role system}.each do |property|
+      define_method(property) do
+        @virtualization_data[property]
       end
     end
 
     def params
+      # TODO: this is broken. cannot return anything but nil
       collect_data_linux
     end
 
@@ -215,6 +217,7 @@ module Inspec::Resources
 
       @virtualization_data[:system] = "docker"
       @virtualization_data[:role] = "guest"
+      # TODO: needs to support host
       true
     end
 
@@ -233,23 +236,24 @@ module Inspec::Resources
       true
     end
 
-    def collect_data_linux # rubocop:disable Metrics/PerceivedComplexity, Metrics/CyclomaticComplexity
+    def collect_data_linux
       # This avoids doing multiple detections in a single test
       return unless @virtualization_data.empty?
 
       # each detect method will return true if it matched and was successfully
       # able to populate @virtualization_data with stuff.
       return if detect_xen
+      return if detect_docker
       return if detect_virtualbox
-      return if detect_openstack
+      return if detect_lxd
+      return if detect_lxc_docker
+      return if detect_linux_vserver
       return if detect_kvm_from_cpuinfo
       return if detect_kvm_from_sys
       return if detect_openvz
+      return if detect_openstack
       return if detect_parallels
-      return if detect_linux_vserver
-      return if detect_lxc_docker
-      return if detect_docker
-      return if detect_lxd
+      # TODO: where is vmware?
     end
   end
 end

data/lib/inspec/resources/x509_certificate.rb

@@ -34,13 +34,15 @@ module Inspec::Resources
     include FileReader
 
     # @see https://tools.ietf.org/html/rfc5280#page-23
-    def initialize(filename)
-      @certpath = filename
+    def initialize(opts)
+      @opts = options(opts)
       @issuer = nil
       @parsed_subject = nil
       @parsed_issuer = nil
       @extensions = nil
-      @cert = OpenSSL::X509::Certificate.new read_file_content(@certpath)
+      @content = @opts[:content]
+      @content ||= read_file_content(@opts[:filepath])
+      @cert = OpenSSL::X509::Certificate.new @content
     end
 
     # Forward these methods directly to OpenSSL::X509::Certificate instance
@@ -137,7 +139,19 @@ module Inspec::Resources
     end
 
     def to_s
-      "x509_certificate #{@certpath}"
+      cert = @opts[:filepath]
+      cert ||= subject.CN
+      "x509_certificate #{cert}"
+    end
+
+    private
+
+    def options(opts)
+      if opts.is_a?(String)
+        { filepath: opts }
+      else
+        opts
+      end
     end
   end
 end

data/lib/inspec/resources/xinetd_conf.rb

@@ -17,7 +17,7 @@ module Inspec::Resources
       end
     EXAMPLE
 
-    include XinetdParser
+    include Inspec::Utils::XinetdParser
     include FileReader
 
     def initialize(conf_path = "/etc/xinetd.conf")

data/lib/inspec/resources/xml.rb

@@ -3,8 +3,7 @@ require "inspec/resources/json"
 module Inspec::Resources
   class XmlConfig < JsonConfig
     name "xml"
-    supports platform: "unix"
-    supports platform: "windows"
+    supports platform: "os"
     desc "Use the xml InSpec resource to test configuration data in an XML file"
     example <<~EXAMPLE
       describe xml('default.xml') do

data/lib/inspec/rspec_extensions.rb

@@ -114,3 +114,15 @@ class RSpec::Core::ExampleGroup
   # So, we use prepend.
   prepend Inspec::TestDslLazyLoader
 end
+
+class ResourceInspector < RSpec::Support::ObjectFormatter::BaseInspector
+  def self.can_inspect?(object)
+    Inspec::Resource === object
+  end
+
+  def inspect # do NOT use default inspect in rspec w/ resources
+    object.to_s
+  end
+end
+
+RSpec::Support::ObjectFormatter::INSPECTOR_CLASSES.unshift ResourceInspector

data/lib/inspec/rule.rb

@@ -13,32 +13,20 @@ module Inspec
   class Rule
     include ::RSpec::Matchers
 
-    #
-    # Include any resources from the given resource DSL.  The passed
-    # resource_dsl will also be included in any Inspec::Expect objects
-    # we make.
-    #
-    # @params resource_dsl [Module]
-    # @returns [TrueClass]
-    #
-    def self.with_resource_dsl(resource_dsl)
-      include resource_dsl
-      @resource_dsl = resource_dsl
-      true
-    end
-
-    def self.resource_dsl # rubocop:disable Style/TrivialAccessors
-      @resource_dsl
-    end
-
     attr_reader :__waiver_data
-    def initialize(id, profile_id, opts, &block)
+    attr_accessor :resource_dsl
+    attr_reader :__profile_id
+
+    def initialize(id, profile_id, resource_dsl, opts, &block)
       @impact = nil
       @title = nil
       @descriptions = {}
       @refs = []
       @tags = {}
 
+      @resource_dsl = resource_dsl
+      extend resource_dsl # TODO: remove! do it via method_missing
+
       # not changeable by the user:
       @__code = nil
       @__block = block
@@ -168,7 +156,7 @@ module Inspec
     # @return [nil|DescribeBase] if called without arguments, returns DescribeBase
     def describe(*values, &block)
       if values.empty? && !block_given?
-        dsl = self.class.ancestors[1]
+        dsl = resource_dsl
         Class.new(DescribeBase) do
           include dsl
         end.new(method(:__add_check))
@@ -183,6 +171,59 @@ module Inspec
       target
     end
 
+    # allow attributes to be accessed within control blocks
+    def input(input_name, options = {})
+      if options.empty?
+        # Simply an access, no event here
+        Inspec::InputRegistry.find_or_register_input(input_name, __profile_id).value
+      else
+        options[:priority] ||= 20
+        options[:provider] = :inline_control_code
+        evt = Inspec::Input.infer_event(options)
+        Inspec::InputRegistry.find_or_register_input(input_name, __profile_id, event: evt).value
+      end
+    end
+
+    # Find the Input object, but don't collapse to a value.
+    # Will return nil on a miss.
+    def input_object(input_name)
+      Inspec::InputRegistry.find_or_register_input(input_name, __profile_id)
+    end
+
+    def attribute(name, options = {})
+      Inspec.deprecate(:attrs_dsl, "Input name: #{name}, Profile: #{__profile_id}")
+      input(name, options)
+    end
+
+    # Support for Control DSL plugins.
+    # This is called when an unknown method is encountered
+    # within a control block.
+    def method_missing(method_name, *arguments, &block)
+      # Check to see if there is a control_dsl plugin activator hook with the method name
+      registry = Inspec::Plugin::V2::Registry.instance
+      hook = registry.find_activators(plugin_type: :control_dsl, activator_name: method_name).first
+      if hook
+        # OK, load the hook if it hasn't been already.  We'll then know a module,
+        # which we can then inject into the context
+        hook.activate
+
+        # Inject the module's methods into the context.
+        # implementation_class is the field name, but this is actually a module.
+        self.class.include(hook.implementation_class)
+        # Now that the module is loaded, it defined one or more methods
+        # (presumably the one we were looking for.)
+        # We still haven't called it, so do so now.
+        send(method_name, *arguments, &block)
+      else
+        begin
+          Inspec::DSL.method_missing_resource(inspec, method_name, *arguments)
+        rescue LoadError
+          super
+        end
+      end
+    end
+
+    # TODO: figure out why these violations exist and nuke them.
     def self.rule_id(rule)
       rule.instance_variable_get(:@__rule_id)
     end
@@ -290,7 +331,7 @@ module Inspec
     def __apply_waivers
       input_name = @__rule_id # TODO: control ID slugging
       registry = Inspec::InputRegistry.instance
-      input = registry.inputs_by_profile.dig(@__profile_id, input_name)
+      input = registry.inputs_by_profile.dig(__profile_id, input_name)
       return unless input
 
       # An InSpec Input is a datastructure that tracks a profile parameter
@@ -347,7 +388,7 @@ module Inspec
     def with_dsl(block)
       return nil if block.nil?
 
-      dsl = self.class.resource_dsl
+      dsl = resource_dsl
 
       return block unless dsl
 

data/lib/inspec/utils/filter.rb

@@ -1,3 +1,5 @@
+require "inspec/exceptions"
+
 module FilterTable
   # This is used as a sentinel value in custom property filtering
   module NoCriteriaProvided; end

data/lib/inspec/utils/parser.rb

@@ -1,277 +1,281 @@
 require "inspec/resources/command"
 
-module PasswdParser
-  # Parse /etc/passwd files.
-  #
-  # @param [String] content the raw content of /etc/passwd
-  # @return [Array] Collection of passwd entries
-  def parse_passwd(content)
-    content.to_s.split("\n").map do |line|
-      next if line[0] == "#"
-
-      parse_passwd_line(line)
-    end.compact
-  end
-
-  # Parse a line of /etc/passwd
-  #
-  # @param [String] line a line of /etc/passwd
-  # @return [Hash] Map of entries in this line
-  def parse_passwd_line(line)
-    x = line.split(":")
-    {
-      # rubocop:disable Layout/AlignHash
-      "user"     => x[0],
-      "password" => x[1],
-      "uid"      => x[2],
-      "gid"      => x[3],
-      "desc"     => x[4],
-      "home"     => x[5],
-      "shell"    => x[6],
-    }
-  end
-end
+module Inspec
+  module Utils
+    module PasswdParser
+      # Parse /etc/passwd files.
+      #
+      # @param [String] content the raw content of /etc/passwd
+      # @return [Array] Collection of passwd entries
+      def parse_passwd(content)
+        content.to_s.split("\n").map do |line|
+          next if line[0] == "#"
+
+          parse_passwd_line(line)
+        end.compact
+      end
 
-module CommentParser
-  # Parse a line with a command. For example: `a = b   # comment`.
-  # Retrieves the actual content.
-  #
-  # @param [String] raw the content lines you want to be parsed
-  # @param [Hash] opts optional configuration
-  # @return [Array] contains the actual line and the position of the line end
-  def parse_comment_line(raw, opts)
-    idx_nl = raw.index("\n")
-    idx_comment = raw.index(opts[:comment_char])
-    idx_nl = raw.length if idx_nl.nil?
-    idx_comment = idx_nl + 1 if idx_comment.nil?
-    line = ""
-
-    # is a comment inside this line
-    if idx_comment < idx_nl && idx_comment != 0
-      line = raw[0..(idx_comment - 1)]
-      # in case we don't allow comments at the end
-      # of an assignment/statement, ignore it and fall
-      # back to treating this as a regular line
-      if opts[:standalone_comments] && !is_empty_line(line)
-        line = raw[0..(idx_nl - 1)]
+      # Parse a line of /etc/passwd
+      #
+      # @param [String] line a line of /etc/passwd
+      # @return [Hash] Map of entries in this line
+      def parse_passwd_line(line)
+        x = line.split(":")
+        {
+          # rubocop:disable Layout/AlignHash
+          "user"     => x[0],
+          "password" => x[1],
+          "uid"      => x[2],
+          "gid"      => x[3],
+          "desc"     => x[4],
+          "home"     => x[5],
+          "shell"    => x[6],
+        }
       end
-    # if there is no comment in this line
-    elsif idx_comment > idx_nl && idx_nl != 0
-      line = raw[0..(idx_nl - 1)]
     end
-    [line, idx_nl]
-  end
-end
 
-module LinuxMountParser
-  # this parses the output of mount command (only tested on linux)
-  # this method expects only one line of the mount output
-  def parse_mount_options(mount_line, compatibility = false)
-    if includes_whitespaces?(mount_line)
-      # Device-/Sharenames and Mountpoints including whitespaces require special treatment:
-      # We use the keyword ' type ' to split up and rebuild the desired array of fields
-      type_split = mount_line.split(" type ")
-      fs_path = type_split[0]
-      other_opts = type_split[1]
-      fs, path = fs_path.match(%r{^(.+?)\son\s(/.+?)$}).captures
-      mount = [fs, "on", path, "type"]
-      mount.concat(other_opts.scan(/\S+/))
-    else
-      # ... otherwise we just split the fields by whitespaces
-      mount = mount_line.scan(/\S+/)
+    module CommentParser
+      # Parse a line with a command. For example: `a = b   # comment`.
+      # Retrieves the actual content.
+      #
+      # @param [String] raw the content lines you want to be parsed
+      # @param [Hash] opts optional configuration
+      # @return [Array] contains the actual line and the position of the line end
+      def parse_comment_line(raw, opts)
+        idx_nl = raw.index("\n")
+        idx_comment = raw.index(opts[:comment_char])
+        idx_nl = raw.length if idx_nl.nil?
+        idx_comment = idx_nl + 1 if idx_comment.nil?
+        line = ""
+
+        # is a comment inside this line
+        if idx_comment < idx_nl && idx_comment != 0
+          line = raw[0..(idx_comment - 1)]
+          # in case we don't allow comments at the end
+          # of an assignment/statement, ignore it and fall
+          # back to treating this as a regular line
+          if opts[:standalone_comments] && !is_empty_line(line)
+            line = raw[0..(idx_nl - 1)]
+          end
+        # if there is no comment in this line
+        elsif idx_comment > idx_nl && idx_nl != 0
+          line = raw[0..(idx_nl - 1)]
+        end
+        [line, idx_nl]
+      end
     end
 
-    # parse device and type
-    mount_options    = { device: mount[0], type: mount[4] }
-
-    if compatibility == false
-      # parse options as array
-      mount_options[:options] = mount[5].gsub(/\(|\)/, "").split(",")
-    else
-      Inspec.deprecate(:mount_parser_serverspec_compat, "Parsing mount options in this fashion is deprecated")
-      mount_options[:options] = {}
-      mount[5].gsub(/\(|\)/, "").split(",").each do |option|
-        name, val = option.split("=")
-        if val.nil?
-          val = true
-        elsif val =~ /^\d+$/
-          # parse numbers
-          val = val.to_i
+    module LinuxMountParser
+      # this parses the output of mount command (only tested on linux)
+      # this method expects only one line of the mount output
+      def parse_mount_options(mount_line, compatibility = false)
+        if includes_whitespaces?(mount_line)
+          # Device-/Sharenames and Mountpoints including whitespaces require special treatment:
+          # We use the keyword ' type ' to split up and rebuild the desired array of fields
+          type_split = mount_line.split(" type ")
+          fs_path = type_split[0]
+          other_opts = type_split[1]
+          fs, path = fs_path.match(%r{^(.+?)\son\s(/.+?)$}).captures
+          mount = [fs, "on", path, "type"]
+          mount.concat(other_opts.scan(/\S+/))
+        else
+          # ... otherwise we just split the fields by whitespaces
+          mount = mount_line.scan(/\S+/)
         end
-        mount_options[:options][name.to_sym] = val
+
+        # parse device and type
+        mount_options    = { device: mount[0], type: mount[4] }
+
+        if compatibility == false
+          # parse options as array
+          mount_options[:options] = mount[5].gsub(/\(|\)/, "").split(",")
+        else
+          Inspec.deprecate(:mount_parser_serverspec_compat, "Parsing mount options in this fashion is deprecated")
+          mount_options[:options] = {}
+          mount[5].gsub(/\(|\)/, "").split(",").each do |option|
+            name, val = option.split("=")
+            if val.nil?
+              val = true
+            elsif val =~ /^\d+$/
+              # parse numbers
+              val = val.to_i
+            end
+            mount_options[:options][name.to_sym] = val
+          end
+        end
+
+        mount_options
       end
-    end
 
-    mount_options
-  end
+      # Device-/Sharename or Mountpoint includes whitespaces?
+      def includes_whitespaces?(mount_line)
+        ws = mount_line.match(/^(.+)\son\s(.+)\stype\s.*$/)
+        ws.captures[0].include?(" ") || ws.captures[1].include?(" ")
+      end
+    end
 
-  # Device-/Sharename or Mountpoint includes whitespaces?
-  def includes_whitespaces?(mount_line)
-    ws = mount_line.match(/^(.+)\son\s(.+)\stype\s.*$/)
-    ws.captures[0].include?(" ") || ws.captures[1].include?(" ")
-  end
-end
+    module BsdMountParser
+      # this parses the output of mount command (only tested on freebsd)
+      # this method expects only one line of the mount output
+      def parse_mount_options(mount_line, _compatibility = false)
+        return {} if mount_line.nil? || mount_line.empty?
 
-module BsdMountParser
-  # this parses the output of mount command (only tested on freebsd)
-  # this method expects only one line of the mount output
-  def parse_mount_options(mount_line, _compatibility = false)
-    return {} if mount_line.nil? || mount_line.empty?
+        mount = mount_line.chomp.split(" ", 4)
+        options = mount[3].tr("()", "").split(", ")
 
-    mount = mount_line.chomp.split(" ", 4)
-    options = mount[3].tr("()", "").split(", ")
+        # parse device and type
+        { device: mount[0], type: options.shift, options: options }
+      end
+    end
 
-    # parse device and type
-    { device: mount[0], type: options.shift, options: options }
-  end
-end
+    module SolarisNetstatParser
+      # takes this as a input and parses the values
+      # UDP: IPv4
+      #    Local Address        Remote Address      State
+      # -------------------- -------------------- ----------
+      #       *.*                                 Unbound
+      def parse_netstat(content) # rubocop:disable Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity, Metrics/AbcSize
+        return [] if content.nil? || content.empty?
 
-module SolarisNetstatParser
-  # takes this as a input and parses the values
-  # UDP: IPv4
-  #    Local Address        Remote Address      State
-  # -------------------- -------------------- ----------
-  #       *.*                                 Unbound
-  def parse_netstat(content) # rubocop:disable Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity, Metrics/AbcSize
-    return [] if content.nil? || content.empty?
-
-    protocol = nil
-    column_widths = nil
-    ports = []
-    cache_name_line = nil
-
-    content.each_line do |line|
-      # find header, its delimiter
-      if line =~ /TCP:|UDP:|SCTP:/
-        # get protocol
-        protocol = line.split(":")[0].chomp.strip.downcase
-
-        # determine version tcp, tcp6, udp, udp6
-        proto_version = line.split(":")[1].chomp.strip
-        protocol += "6" if proto_version == "IPv6"
-
-        # reset names cache
+        protocol = nil
         column_widths = nil
+        ports = []
         cache_name_line = nil
-        names = nil
-      # calulate width of a column based on the horizontal line
-      elsif line =~ /^[- ]+$/
-        column_widths = columns(line)
-      # parse header values from line
-      elsif column_widths.nil? && !line.nil?
-        # we do not know the width at this point of time, therefore we need to cache
-        cache_name_line = line
-      # content line
-      elsif !column_widths.nil? && !line.nil? && !line.chomp.empty?
-        # default row
-        port = split_columns(column_widths, line).to_a.map { |v| v.chomp.strip }
-
-        # parse the header names
-        # TODO: names should be optional
-        names = split_columns(column_widths, cache_name_line).to_a.map { |v| v.chomp.strip.downcase.tr(" ", "-").gsub(/[^\w-]/, "_") }
-        info = {
-          "protocol" => protocol.downcase,
-        }
 
-        # generate hash for each line and use the names as keys
-        names.each_index do |i|
-          info[names[i]] = port[i] if i != 0
+        content.each_line do |line|
+          # find header, its delimiter
+          if line =~ /TCP:|UDP:|SCTP:/
+            # get protocol
+            protocol = line.split(":")[0].chomp.strip.downcase
+
+            # determine version tcp, tcp6, udp, udp6
+            proto_version = line.split(":")[1].chomp.strip
+            protocol += "6" if proto_version == "IPv6"
+
+            # reset names cache
+            column_widths = nil
+            cache_name_line = nil
+            names = nil
+          # calulate width of a column based on the horizontal line
+          elsif line =~ /^[- ]+$/
+            column_widths = columns(line)
+          # parse header values from line
+          elsif column_widths.nil? && !line.nil?
+            # we do not know the width at this point of time, therefore we need to cache
+            cache_name_line = line
+          # content line
+          elsif !column_widths.nil? && !line.nil? && !line.chomp.empty?
+            # default row
+            port = split_columns(column_widths, line).to_a.map { |v| v.chomp.strip }
+
+            # parse the header names
+            # TODO: names should be optional
+            names = split_columns(column_widths, cache_name_line).to_a.map { |v| v.chomp.strip.downcase.tr(" ", "-").gsub(/[^\w-]/, "_") }
+            info = {
+              "protocol" => protocol.downcase,
+            }
+
+            # generate hash for each line and use the names as keys
+            names.each_index do |i|
+              info[names[i]] = port[i] if i != 0
+            end
+
+            ports.push(info)
+          end
         end
-
-        ports.push(info)
+        ports
       end
-    end
-    ports
-  end
 
-  private
+      private
 
-  # takes a line like "-------------------- -------------------- ----------"
-  # as input and calculates the length of each column
-  def columns(line)
-    # find all columns
-    m = line.scan(/-+/)
-    # calculate the length each column
-    m.map { |x| x.length } # rubocop:disable Style/SymbolProc
-  end
+      # takes a line like "-------------------- -------------------- ----------"
+      # as input and calculates the length of each column
+      def columns(line)
+        # find all columns
+        m = line.scan(/-+/)
+        # calculate the length each column
+        m.map { |x| x.length } # rubocop:disable Style/SymbolProc
+      end
 
-  # takes a line and the width of the columns to extract the values
-  def split_columns(columns, line)
-    # generate regex based on columns
-    sep = '\\s'
-    length = columns.length
-    arr = columns.map.with_index do |x, i|
-      reg = "(.{#{x}})#{sep}" # add seperator between columns
-      reg = "(.{,#{x}})#{sep}" if i == length - 2 # make the pre-last one optional
-      reg = "(.{,#{x}})" if i == length - 1 # use , to say max value
-      reg
+      # takes a line and the width of the columns to extract the values
+      def split_columns(columns, line)
+        # generate regex based on columns
+        sep = '\\s'
+        length = columns.length
+        arr = columns.map.with_index do |x, i|
+          reg = "(.{#{x}})#{sep}" # add seperator between columns
+          reg = "(.{,#{x}})#{sep}" if i == length - 2 # make the pre-last one optional
+          reg = "(.{,#{x}})" if i == length - 1 # use , to say max value
+          reg
+        end
+        # extracts the columns
+        line.match(Regexp.new(arr.join))
+      end
     end
-    # extracts the columns
-    line.match(Regexp.new(arr.join))
-  end
-end
 
-# This parser for xinetd (extended Internet daemon) configuration files
-module XinetdParser
-  def xinetd_include_dir(dir)
-    return [] if dir.nil?
+    # This parser for xinetd (extended Internet daemon) configuration files
+    module XinetdParser
+      def xinetd_include_dir(dir)
+        return [] if dir.nil?
 
-    unless inspec.file(dir).directory?
-      raise Inspec::Exceptions::ResourceSkipped, "Can't find folder: #{dir}"
-    end
+        unless inspec.file(dir).directory?
+          raise Inspec::Exceptions::ResourceSkipped, "Can't find folder: #{dir}"
+        end
 
-    files = inspec.command("find #{dir} -type f").stdout.split("\n")
-    files.map { |file| parse_xinetd(read_content(file)) }
-  end
+        files = inspec.command("find #{dir} -type f").stdout.split("\n")
+        files.map { |file| parse_xinetd(read_content(file)) }
+      end
 
-  def parse_xinetd(raw) # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
-    return {} if raw.nil?
-
-    require "inspec/utils/simpleconfig"
-
-    res = {}
-    cur_group = nil
-    simple_conf = []
-    rest = raw + "\n"
-    until rest.empty?
-      # extract content line
-      nl = rest.index("\n") || (rest.length - 1)
-      comment = rest.index("#") || (rest.length - 1)
-      dst_idx = comment < nl ? comment : nl
-      inner_line = dst_idx == 0 ? "" : rest[0..dst_idx - 1].strip
-      # update unparsed content
-      rest = rest[nl + 1..-1]
-      next if inner_line.empty?
-
-      if inner_line == "}"
-        if cur_group == "defaults"
-          res[cur_group] = SimpleConfig.new(simple_conf.join("\n"))
-        else
-          res[cur_group] ||= []
-          res[cur_group].push(SimpleConfig.new(simple_conf.join("\n")))
-        end
+      def parse_xinetd(raw) # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
+        return {} if raw.nil?
+
+        require "inspec/utils/simpleconfig"
+
+        res = {}
         cur_group = nil
-      elsif rest.lstrip[0] == "{"
-        cur_group = inner_line
         simple_conf = []
-        rest = rest[rest.index("\n") + 1..-1]
-      elsif cur_group.nil?
-        # parse all included files
-        others = xinetd_include_dir(inner_line[/includedir (.+)/, 1])
-
-        # complex merging of included configurations, as multiple services
-        # may be defined with the same name but different configuration
-        others.each do |ores|
-          ores.each do |k, v|
-            res[k] ||= []
-            res[k].concat(v)
+        rest = raw + "\n"
+        until rest.empty?
+          # extract content line
+          nl = rest.index("\n") || (rest.length - 1)
+          comment = rest.index("#") || (rest.length - 1)
+          dst_idx = comment < nl ? comment : nl
+          inner_line = dst_idx == 0 ? "" : rest[0..dst_idx - 1].strip
+          # update unparsed content
+          rest = rest[nl + 1..-1]
+          next if inner_line.empty?
+
+          if inner_line == "}"
+            if cur_group == "defaults"
+              res[cur_group] = SimpleConfig.new(simple_conf.join("\n"))
+            else
+              res[cur_group] ||= []
+              res[cur_group].push(SimpleConfig.new(simple_conf.join("\n")))
+            end
+            cur_group = nil
+          elsif rest.lstrip[0] == "{"
+            cur_group = inner_line
+            simple_conf = []
+            rest = rest[rest.index("\n") + 1..-1]
+          elsif cur_group.nil?
+            # parse all included files
+            others = xinetd_include_dir(inner_line[/includedir (.+)/, 1])
+
+            # complex merging of included configurations, as multiple services
+            # may be defined with the same name but different configuration
+            others.each do |ores|
+              ores.each do |k, v|
+                res[k] ||= []
+                res[k].concat(v)
+              end
+            end
+          else
+            simple_conf.push(inner_line)
           end
         end
-      else
-        simple_conf.push(inner_line)
+
+        res
       end
     end
-
-    res
   end
 end