inspec-core 2.3.10 → 2.3.23

data/lib/plugins/inspec-plugin-manager-cli/test/unit/cli_args_test.rb

@@ -26,7 +26,7 @@ class PluginManagerCliOptions < MiniTest::Test
 
   def test_search_args
     arg_config = cli_class.all_commands['search'].options
-    assert_equal 2, arg_config.count, 'The search command should have 2 options'
+    assert_equal 3, arg_config.count, 'The search command should have 3 options'
 
     assert_includes arg_config.keys, :all, 'The search command should have an --all option'
     assert_equal :boolean, arg_config[:all].type, 'The --all option should be boolean'
@@ -40,6 +40,10 @@ class PluginManagerCliOptions < MiniTest::Test
     refute_nil arg_config[:exact].description, 'The --exact option should have a description'
     refute arg_config[:exact].required, 'The --exact option should not be required'
 
+    assert_includes arg_config.keys, :'include-test-fixture', 'The search command should have an --include-test-fixture option'
+    assert_equal :boolean, arg_config[:'include-test-fixture'].type, 'The --include-test-fixture option should be boolean'
+    refute arg_config[:'include-test-fixture'].required, 'The --include-test-fixture option should not be required'
+
     assert_equal 1, cli_class.instance_method(:search).arity, 'The search command should take one argument'
   end
 

data/lib/resources/package.rb

@@ -258,7 +258,7 @@ module Inspec::Resources
       cmd = inspec.command("apk info -vv --no-network | grep #{package_name}")
       return {} if cmd.exit_status.to_i != 0
 
-      pkg_info = cmd.stdout.split("\n").reject! { |e| e =~ /^WARNING/i }
+      pkg_info = cmd.stdout.split("\n").delete_if { |e| e =~ /^WARNING/i }
       pkg = pkg_info[0].split(' - ')[0]
 
       {

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: inspec-core
 version: !ruby/object:Gem::Version
-  version: 2.3.10
+  version: 2.3.23
 platform: ruby
 authors:
 - Dominik Richter
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-10-04 00:00:00.000000000 Z
+date: 2018-10-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: train-core
@@ -297,201 +297,7 @@ files:
 - MAINTAINERS.toml
 - README.md
 - bin/inspec
-- docs/.gitignore
-- docs/README.md
-- docs/dev/control-eval.md
-- docs/dev/filtertable-internals.md
-- docs/dev/filtertable-usage.md
-- docs/dev/integration-testing.md
-- docs/dev/plugins.md
-- docs/dsl_inspec.md
-- docs/dsl_resource.md
-- docs/glossary.md
-- docs/habitat.md
-- docs/inspec_and_friends.md
-- docs/matchers.md
-- docs/migration.md
-- docs/platforms.md
-- docs/plugin_kitchen_inspec.md
-- docs/plugins.md
-- docs/profiles.md
-- docs/reporters.md
-- docs/resources/aide_conf.md.erb
-- docs/resources/apache.md.erb
-- docs/resources/apache_conf.md.erb
-- docs/resources/apt.md.erb
-- docs/resources/audit_policy.md.erb
-- docs/resources/auditd.md.erb
-- docs/resources/auditd_conf.md.erb
-- docs/resources/bash.md.erb
-- docs/resources/bond.md.erb
-- docs/resources/bridge.md.erb
-- docs/resources/bsd_service.md.erb
-- docs/resources/chocolatey_package.md.erb
-- docs/resources/command.md.erb
-- docs/resources/cpan.md.erb
-- docs/resources/cran.md.erb
-- docs/resources/crontab.md.erb
-- docs/resources/csv.md.erb
-- docs/resources/dh_params.md.erb
-- docs/resources/directory.md.erb
-- docs/resources/docker.md.erb
-- docs/resources/docker_container.md.erb
-- docs/resources/docker_image.md.erb
-- docs/resources/docker_plugin.md.erb
-- docs/resources/docker_service.md.erb
-- docs/resources/elasticsearch.md.erb
-- docs/resources/etc_fstab.md.erb
-- docs/resources/etc_group.md.erb
-- docs/resources/etc_hosts.md.erb
-- docs/resources/etc_hosts_allow.md.erb
-- docs/resources/etc_hosts_deny.md.erb
-- docs/resources/file.md.erb
-- docs/resources/filesystem.md.erb
-- docs/resources/firewalld.md.erb
-- docs/resources/gem.md.erb
-- docs/resources/group.md.erb
-- docs/resources/grub_conf.md.erb
-- docs/resources/host.md.erb
-- docs/resources/http.md.erb
-- docs/resources/iis_app.md.erb
-- docs/resources/iis_site.md.erb
-- docs/resources/inetd_conf.md.erb
-- docs/resources/ini.md.erb
-- docs/resources/interface.md.erb
-- docs/resources/iptables.md.erb
-- docs/resources/json.md.erb
-- docs/resources/kernel_module.md.erb
-- docs/resources/kernel_parameter.md.erb
-- docs/resources/key_rsa.md.erb
-- docs/resources/launchd_service.md.erb
-- docs/resources/limits_conf.md.erb
-- docs/resources/login_defs.md.erb
-- docs/resources/mount.md.erb
-- docs/resources/mssql_session.md.erb
-- docs/resources/mysql_conf.md.erb
-- docs/resources/mysql_session.md.erb
-- docs/resources/nginx.md.erb
-- docs/resources/nginx_conf.md.erb
-- docs/resources/npm.md.erb
-- docs/resources/ntp_conf.md.erb
-- docs/resources/oneget.md.erb
-- docs/resources/oracledb_session.md.erb
-- docs/resources/os.md.erb
-- docs/resources/os_env.md.erb
-- docs/resources/package.md.erb
-- docs/resources/packages.md.erb
-- docs/resources/parse_config.md.erb
-- docs/resources/parse_config_file.md.erb
-- docs/resources/passwd.md.erb
-- docs/resources/pip.md.erb
-- docs/resources/port.md.erb
-- docs/resources/postgres_conf.md.erb
-- docs/resources/postgres_hba_conf.md.erb
-- docs/resources/postgres_ident_conf.md.erb
-- docs/resources/postgres_session.md.erb
-- docs/resources/powershell.md.erb
-- docs/resources/processes.md.erb
-- docs/resources/rabbitmq_config.md.erb
-- docs/resources/registry_key.md.erb
-- docs/resources/runit_service.md.erb
-- docs/resources/security_policy.md.erb
-- docs/resources/service.md.erb
-- docs/resources/shadow.md.erb
-- docs/resources/ssh_config.md.erb
-- docs/resources/sshd_config.md.erb
-- docs/resources/ssl.md.erb
-- docs/resources/sys_info.md.erb
-- docs/resources/systemd_service.md.erb
-- docs/resources/sysv_service.md.erb
-- docs/resources/upstart_service.md.erb
-- docs/resources/user.md.erb
-- docs/resources/users.md.erb
-- docs/resources/vbscript.md.erb
-- docs/resources/virtualization.md.erb
-- docs/resources/windows_feature.md.erb
-- docs/resources/windows_hotfix.md.erb
-- docs/resources/windows_task.md.erb
-- docs/resources/wmi.md.erb
-- docs/resources/x509_certificate.md.erb
-- docs/resources/xinetd_conf.md.erb
-- docs/resources/xml.md.erb
-- docs/resources/yaml.md.erb
-- docs/resources/yum.md.erb
-- docs/resources/zfs_dataset.md.erb
-- docs/resources/zfs_pool.md.erb
-- docs/shared/matcher_be.md.erb
-- docs/shared/matcher_cmp.md.erb
-- docs/shared/matcher_eq.md.erb
-- docs/shared/matcher_include.md.erb
-- docs/shared/matcher_match.md.erb
-- docs/shell.md
-- docs/style.md
-- examples/README.md
-- examples/custom-resource/README.md
-- examples/custom-resource/controls/example.rb
-- examples/custom-resource/inspec.yml
-- examples/custom-resource/libraries/batsignal.rb
-- examples/custom-resource/libraries/gordon.rb
-- examples/inheritance/README.md
-- examples/inheritance/controls/example.rb
-- examples/inheritance/inspec.yml
-- examples/kitchen-ansible/.kitchen.yml
-- examples/kitchen-ansible/Gemfile
-- examples/kitchen-ansible/README.md
-- examples/kitchen-ansible/files/nginx.repo
-- examples/kitchen-ansible/tasks/main.yml
-- examples/kitchen-ansible/test/integration/default/default.yml
-- examples/kitchen-ansible/test/integration/default/web_spec.rb
-- examples/kitchen-chef/.kitchen.yml
-- examples/kitchen-chef/Berksfile
-- examples/kitchen-chef/Gemfile
-- examples/kitchen-chef/README.md
-- examples/kitchen-chef/metadata.rb
-- examples/kitchen-chef/recipes/default.rb
-- examples/kitchen-chef/recipes/nginx.rb
-- examples/kitchen-chef/test/integration/default/web_spec.rb
-- examples/kitchen-puppet/.kitchen.yml
-- examples/kitchen-puppet/Gemfile
-- examples/kitchen-puppet/Puppetfile
-- examples/kitchen-puppet/README.md
-- examples/kitchen-puppet/manifests/site.pp
-- examples/kitchen-puppet/metadata.json
-- examples/kitchen-puppet/modules/.gitkeep
-- examples/kitchen-puppet/test/integration/default/web_spec.rb
-- examples/meta-profile/README.md
-- examples/meta-profile/controls/example.rb
-- examples/meta-profile/inspec.yml
-- examples/plugins/inspec-resource-lister/Gemfile
-- examples/plugins/inspec-resource-lister/LICENSE
-- examples/plugins/inspec-resource-lister/README.md
-- examples/plugins/inspec-resource-lister/Rakefile
-- examples/plugins/inspec-resource-lister/inspec-resource-lister.gemspec
-- examples/plugins/inspec-resource-lister/lib/inspec-resource-lister.rb
-- examples/plugins/inspec-resource-lister/lib/inspec-resource-lister/cli_command.rb
-- examples/plugins/inspec-resource-lister/lib/inspec-resource-lister/plugin.rb
-- examples/plugins/inspec-resource-lister/lib/inspec-resource-lister/version.rb
-- examples/plugins/inspec-resource-lister/test/fixtures/README.md
-- examples/plugins/inspec-resource-lister/test/functional/README.md
-- examples/plugins/inspec-resource-lister/test/functional/inspec_resource_lister_test.rb
-- examples/plugins/inspec-resource-lister/test/helper.rb
-- examples/plugins/inspec-resource-lister/test/unit/README.md
-- examples/plugins/inspec-resource-lister/test/unit/cli_args_test.rb
-- examples/plugins/inspec-resource-lister/test/unit/plugin_def_test.rb
-- examples/profile-attribute.yml
-- examples/profile-attribute/README.md
-- examples/profile-attribute/controls/example.rb
-- examples/profile-attribute/inspec.yml
-- examples/profile-sensitive/README.md
-- examples/profile-sensitive/controls/sensitive-failures.rb
-- examples/profile-sensitive/controls/sensitive.rb
-- examples/profile-sensitive/inspec.yml
-- examples/profile/README.md
-- examples/profile/controls/example.rb
-- examples/profile/controls/gordon.rb
-- examples/profile/controls/meta.rb
-- examples/profile/inspec.yml
-- examples/profile/libraries/gordon_config.rb
+- etc/plugin_filters.json
 - inspec-core.gemspec
 - lib/bundles/README.md
 - lib/bundles/inspec-compliance/api.rb
@@ -565,6 +371,7 @@ files:
 - lib/inspec/plugin/v1/registry.rb
 - lib/inspec/plugin/v2.rb
 - lib/inspec/plugin/v2/activator.rb
+- lib/inspec/plugin/v2/filter.rb
 - lib/inspec/plugin/v2/installer.rb
 - lib/inspec/plugin/v2/loader.rb
 - lib/inspec/plugin/v2/plugin_base.rb

data/docs/.gitignore

@@ -1,2 +0,0 @@
-resources.md
-cli.md

data/docs/README.md

@@ -1,41 +0,0 @@
-# InSpec documentation
-
-This is the home of the InSpec documentation. This documentation provides an introduction to this mechanism and shows how to write custom tests.
-
-The goal of this folder is for any community member to clone these docs, make the changes, check if they are valid, and contribute to the project.
-
-## How to build docs
-
-We build docs by:
-
-1. Auto-generating docs from code
-2. Transforming markdown+snippets in this folder into pure markdown in `www/source/docs`
-3. Rendering them to the website via instructions in `www/`
-
-For development, you **only need step 1**!
-
-**1 Generate docs**
-
-To generate all docs run:
-
-```
-bundle exec rake docs
-```
-
-You can run tasks individually. For a list of tasks run:
-
-```
-bundle exec rake --tasks docs
-```
-
-## Stability Index
-
-Every available InSpec resource will indicate its stability. As InSpec matures, certain parts are more reliable than others. Brand new features are likely to be redesigned and marked as such.
-
-The stability indices are as follows:
-
-* `Stability: Deprecated` - This features will be removed in future versions, because its known for being problematic. Do not rely on it.
-* `Stability: Experimental` - New features may change or are removed in future versions
-* `Stability: Stable` - API is well established and proofed. Maintaining compatibility is a high priority
-* `Stability: Locked` - Only security and performance fixes are allowed
-

data/docs/dev/control-eval.md

@@ -1,62 +0,0 @@
-# What happens when a profile file is loaded
-
-## Consult with Harry Tuttle
-
-[He's not from Central Services or anything.](https://youtu.be/VRfoIyx8KfU?t=2m41s)
-
-## Tips
-
-* In the early days of InSpec / ServerSpec, controls were called "rules".  Throughout various places in the code, the word "rule" is used to mean "control".  Make the mental subsitution.
-* InSpec supports reading profiles from tarballs, local files, git repos, etc.  So, don't count on local file reading; instead it uses a special source reader to obtain the contents of the files.
-
-## The basics of the stack
-
-    #5  Inspec::Profile.collect_tests(include_list#Array) at lib/inspec/profile.rb:167
-    #4  Hash.each at lib/inspec/profile.rb:167
-    #3  block in Inspec::Profile.block in collect_tests(include_list#Array) at lib/inspec/profile.rb:170
-    #2  Inspec::ProfileContext.load_control_file(*args#Array) at lib/inspec/profile_context.rb:141
-    #1  Inspec::ProfileContext.control_eval_context at lib/inspec/profile_context.rb:58
-    #0  #<Class:Inspec::ControlEvalContext>.create(profile_context#Inspec::ProfileContext, resources_dsl#Module) at lib/inspec/control_eval_context.rb:41
-
-## A profile context is created
-
-Like many things in InSpec core, a profile context is an anonymous class. (verify)
-
-Additionally, a control_eval_context is created.  It is an instance of an anonymous class; it has a class<->relationship with its profile context.  See `lib/inspec/control_eval_context.rb`.
-
-## Each file's contents are instance eval'd against the control_eval_context
-
-### DSL methods are executed at this time
-
-So, if you have a control file with `title` in it, that will call the title method that was defined at `lib/inspec/control_eval_context.rb:60`.  Importantly, this also includes the `control` DSL keyword, and also the `describe` keyword (used for bare describes).
-
-### Each control and their block are wrapped in an anonymous class
-
-The anonymous class generator is located at `lib/inspec/control_eval_context.rb:24`.  At this point, the terminology switches from `control` to `rule`.  Each context class inherits from Inspec::Rule, which provides the constructor.
-
-The control context class also gets extended with the resource DSL, so anything in the source code for the control can use the resource DSL.  This includes all resource names, but importantly, the `describe` DSL keyword.
-
-Finally, Inspec::Rule provides the control DSL - impact, title, desc, ref, and tags.
-
-### The block is instance_eval'd against the control context class
-
-See `lib/inspec/rule.rb:50`.  We're now in two levels of instance eval'ing - the file is gradually being eval'd against the profile context anonymous class, and the current control's block is being instance eval'd against a control context anonymous class.
-
-At this stage, control-level metadata (impact, title, refs, tags, desc) are evaluated and set as instance vars on the control.
-
-Any "loose" ruby in the control is also executed at this point.
-
-And, the describe and describe.one blocks are executed.
-
-### TODO: describe blocks are *not* instance-evaled
-
-### The control is registered with the profile
-
-Using the method register_control (dynamically defined on the control eval context), we check for various skip conditions.  If none of them apply, the control is then registered with the profile context using register_rule.
-
-ProfileContext.register_rule's main job is to determine the full ID of the control (within the context of the profile) and either add it to the controls list, or (if another control with the same ID exists), merge it.  (This is where overriding happens).
-
-Note: can skip a control with:
-Inspec::Rule.set_skip_rule(control, msg)
-
-## What else?

data/docs/dev/filtertable-internals.md

@@ -1,353 +0,0 @@
-# Internals of FilterTable
-
-If you just want to _use_ FilterTable, see filtertable-usage.md .  Reading this may make you more confused, not less.
-
-## What makes this hard?
-
-FilterTable was created in 2016 in an attempt to consolidate the pluralization features of several resources.  They each had slightly different feature-sets, and were all in the wild, so FilterTable exposes some extensive side-effects to provide those features.
-
-Additionally, the ways in which the classes relate is not straightforward.
-
-## Where is the code?
-
-The main FilterTable code is in [utils/filter.rb](https://github.com/chef/inspec/blob/master/lib/utils/filter.rb).
-
-Also educational is the unit test for Filtertable, at test/unit/utils/filter_table_test.rb .  Recent work has focused on using functional tests to exercise FilterTable; see test/unit/mocks/profiles/filter_table and test/functional/filter_table_test.rb .
-
-The file utils/filter_array.rb appears to be unrelated.
-
-## What are the classes involved?
-
-### FilterTable::Factory
-
-This class is responsible for the definition of the filtertable.  It provides the methods that are used by the resource author to configure the filtertable.
-
-FilterTable::Factory initializes three instance variables:
-```
-  @filter_methods = []
-  @custom_properties = {}
-  @resource = nil # This appears to be unused
-```
-
-### FilterTable::Table
-
-This is the actual innards of the implementation.  The Factory's goal is to configure a Table subclass and attach it to the resource you are authoring.  The table is a container for the raw data your resource provides, and performs filtration services.
-
-### FilterTable::ExceptionCatcher
-
-TODO
-
-## What are the major entry points? (FilterTable::Factory)
-
-A resource class using FilterTable typically will call a sequence similar to this, in the class body:
-
-```
-  filter = FilterTable.create
-        .register_column(:thing_ids, field: :thing_id)
-        .install_filter_methods_on_resource(self, :table)
-```
-
-Legacy code might look like this:
-```
-  filter = FilterTable.create
-  filter.add_accessor(:entries)
-        .add(:exists?) { |x| !x.entries.empty? }
-        .add(:count) { |x| x.entries.count }
-        .add(:thing_ids, field: :thing_id)
-        .connect(self, :table)
-```
-
-### create
-
-Returns a blank instance of a FilterTable::Factory.  It also adds a default implementation of `where` `raw_data`, and `entries` using `register_filter_method`, `count` using `register_custom_property`, and `exist?` using `register_custom_matcher`.
-
-### register\_filter\_method
-
-Legacy name (alias): `add_accessor`
-
-This simply pushes the provided method name onto the `@filter_methods` instance variable array.  See "filter_method" behavior section below for what this does.
-
-After adding the method name to the array, it returns `self` - the FilterTable::Factory instance - so that method chaining will work.
-
-### register\_column
-
-Legacy name (alias): `add`
-
-This is currently simply an alias for `register_custom_property`.  See it for details.  By calling it with a distinctive name, we'll be able to add functionality in the future (especially around introspection).
-
-### register\_custom\_matcher
-
-Legacy name (alias): `add`
-
-This is currently simply an alias for `register_custom_property`.  See it for details. By calling it with a distinctive name, we'll be able to add functionality in the future (especially around introspection).
-
-### register\_custom\_property
-
-Legacy name (alias): `add`
-
-This method has very complex behavior, ans should likely be split into several use cases.  `register_custom_property` requires a symbol (which will be used as a method name _to be added to the resource class_), then also accepts a block and/or additional args.  These things - name, block, and opts - are packed into a simple Struct called a CustomPropertyType. The name stored in the Struct will be `opts[:field]` if provided, and the method name if not.
-
-The CustomPropertyType Struct is then appended to the Hash `@custom_properties`, keyed on the method name provided.  `self` is then returned for method chaining.
-
-The implementation of the custom property method is generated by `create_custom_property_body`, and varies based on whether a block was provided to `register_custom_property`.
-
-#### Behavior when a block is provided
-
-This behavior is implemented by lines 398-404.
-
-If a block is provided, it is turned into a Lambda and used as the method body.
-
-The block will be provided two arguments (though most users only use the first):
-1. The FilterTable::Table instance that wraps the raw data.
-2. An optional value used as an additional opportunity to filter.
-
-For example, this is common in legacy code:
-```
-filter.add(:exists?) { |x| !x.entries.empty? }
-```
-
-Here, `x` is the Table instance, which exposes the `entries` method (which returns an array, one entry for each raw data row).
-
-You could also implement a more sophisticated property, which semantically should re-filter the table based on the candidate value, and return the new table.
-
-```
-filter.add(:smaller_than) { |table, threshold| table.where { some_field <= threshold } }
-```
-
-```
-things.smaller_than(12)
-```
-
-If you provide _both_ a block and opts, only the block is used, and the options are ignored.
-
-#### Behavior when no block is provided
-
-If you do not provide a block, you _must_ provide a `:field` option (though that does no appear to be enforced). The behavior is to define a method with the name provided, that has a conditional return type. The method body is defined in lines 306-423.
-
-If called without arguments, it returns an array of the values in the raw data for that column.
-```
-things.thing_ids => [1,2,3,4]
-```
-
-If called with an argument, it instead calls `where` passing the name of the field and the argument, effectively filtering.
-```
-things.thing_ids(2) => FilterTable::Table that only contains a row where thing_id = 2
-```
-
-If called with a block, it passes the block to where.
-```
-things.thing_ids { some_code } => Same as things.where { some_code }
-```
-
-POSSIBLE BUG: I think this case is broken; it certainly seems ill-advised.
-
-#### Known Options
-
-You can provide options to `register_custom_property` / `add`, after the desired method name.
-
-##### field
-
-This is the most common option, and is mandatory if a block is not provided.  It selects an implementation in which the desired method will be defined such that it returns an array of the row values using the specified key.  In other words, this acts as a "column fetcher", like in SQL: "SELECT some_column FROM some_table"
-
-Internally, (line 271-278), a Struct type is created to represent a row of raw data.  The struct's attribute list is taken from the `field` options passed to `register_custom_property` / `add`.  This new type is stored as `row_eval_context_type`.  It is used as the evaluation context for block-mode `where` calls. 
-
-* No checking is performed to see if the field name is actually a column in the raw data (the raw data hasn't been fetched yet, so we can't check).
-* You can't have two `register_custom_property` / `add` calls that reference the same field, because the Struct would see that as a duplicate attribute.
-
-POSSIBLE BUG: We could deduplicate the field names when defining the Struct, thus allowing multiple properties to use the same field.
-
-##### style
-
-The `style` option is intended to effect post-processing of the return value from the generated method.  To date there is only one recognized value, `:simple`, which `flatten`s, `uniq`s, and `compact`s the array value of the property.  This is implemented on line 416.
-
-No other values for `:style` have been seen.
-
-##### lazy
-
-This option implements column-wise lazy loading. The value of the option is expected to a lambda expecting 3 arguments: row (a Hash representing a row of the raw data), condition (a sought value to filter for), and table (a reference to the FilterTable::Table subclass, which may be used for context).
-
-See the usage guide for details on the usage of the lazy mechanism; this document will examine the internals.
-
-### install_filter_methods_on_resource
-
-Legacy name (alias): connect
-
-This method is called like this:
-
-```
-filter.install_filter_methods_on_resource(self, :data_fetching_method_name)
-```
-
-`filter` is an instance of FilterTable::Factory.  `self` is a reference to the resource class you are authoring. `data_fetching_method_name` is a symbol, the name of a method that will return the actual data to be processed by the FilterTable - as an array of hashes.
-
-Note that 'connect' does not refer to Connectors.
-
-`register_custom_property` and `register_filter_method` did nothing other than add register names for methods that we'd like to have added to the resource class.  No filtering ability is present, nor are the methods defined, at this point.
-
-So, `install_filter_methods_on_resource`/`connect`'s job is to actually install everything.
-
-#### Defines a special Struct type to support block-mode where
-
-At lines 270-278, a new Struct type `row_eval_context_type` is defined, with attributes for each of the known table fields.  We're careful to filter out any fields that have a block implementation, because they cannot be accessed as a row value, and so should not be present on the row context. The motivation for this struct type is to implement the block-mode behavior of `where`.  Because each struct represents a row, and it has the attributes (accessors) for the fields, block-mode `where` is implemented by `instance_eval`ing against each row as a struct.
-
-Additionally, an instance variable, `@criteria_string` is defined, with an accessor. `to_s` is implemented, using `@criteria_string`, or `super` if not defined.  I guess we then rely on the `Struct` class to stringify.
-
-`@criteria_string` is a trace - a string indicating the filter criteria used to create the table.  I found no location where this per-row trace data was used.
-
-Additionally, an instance variable is setup to refer to the filter table later.  This is required for lazy-loading columns.
-
-Table fields are determined by listing the `field_name`s of the CustomProperties.
-
-BUG: this means that any `register_custom_property` / `add` call that uses a block but not options will end up with an attribute in the row Struct.  Thus, `filter.add(:exists?) { ... }` results in a row Struct that includes an attribute named `exists?` which may be undesired. This attribute will never have a value, because when the structs are instantiated, the block for the field is not called.
-
-#### Re-pack the "connectors"
-
-On lines 280-282, the list of custom properties ("connectors", registered using the `register_custom_property` / `add` method) are repacked into an array of hashes of two elements - the desired method name and the lambda that will be used as the method body.  The lambda is created by the private method `create_custom_property_body`; see `register_custom_property` for discussion about how the implementation behaves.
-
-#### Subclass FilterTable::Table into an anonymous class
-
-At line 286, create the local var `table_class`, which refers to an anonymous class that subclasses FilterTable::Table.  The class is opened and two groups of methods are defined.
-
-Lines 288-290 install the "custom_property" methods, using the names and lambdas determined on line 281.
-
-Lines 292-294 allow the Table subclass to introspect on the CustomProperties by slipping a reference to it in the class body, forming a closure.
-
-Line 296-303 define a method, `create_eval_context_for_row`.  This is used when executing a block-mode `where`; see line 120.
-
-#### Setup the row context struct for lazy loading
-
-If you have a lazy field named `color` and it has not yet been populated, we need to trigger it to populate the first time it is read.  If a block-mode where is used (`my_resource.where { color == :red }`), then we have to intercept the Struct's default `getter method`, and call the lazy column's lambda.
-
-Lines 306-329 do exactly that, by defining methods on the Struct subclass we're using for context.  We continue to rely on the default Struct setter (`[]=`) and getter at the end (`[]`).
-
-#### Install methods on the resource
-
-Lines 337-348 install the "filter_methods" and "custom properties" methods onto the resource that you are authoring.
-
-Line 337-338 collects the names of the methods to define - by agglomerating the names of the "filter_methods" and "custom properties" methods.  They are treated the same.
-
-Line 339 uses `send` with a block to call `define_method` on the resource class that you're authoring.  Using a block with `send` is undocumented, but is treated as an implicit argument (per StackOverflow) , so the end result is that the block is used as the body for the new method being defined.
-
-The method body is wrapped in an exception-catching facility that catches skipped or failed resource exceptions and wraps them in a specialized exception catcher class. TBD: understand this better.
-
-Line 342 constructs an instance of the anonymous FilterTable::Table subclass defined at 284.  It passes three args:
-
-1. `self`. A reference to the resource instance.
-2. The return value of calling the data fetcher method (that is an array of hashes, the raw data).
-3. The string ' with', which is probably informing the criteria stringification. The extra space is intentional, as it follows the resource name: 'my_things with color == :red' might be a result.
-
-On line 343, we then immediately call a method on that "FilterTable::Table subclass instance". The method name is the same as the one we're defining on the resource - but we're calling it on the Table.  Recall we defined all the "custom_property" methods on the Table subclass at line 288-290.  The method gets called with any args or block passed, and since it's the last thing, it provides the return value.
-
-## What is its behavior? (FilterTable::Table)
-
-Assume that your resource has a method, `fetch_data`, which returns a fixed array:
-
-```
- [
-   { id: 1, name: 'Dani', color: 'blue' },
-   { id: 2, name: 'Mike', color: 'red' },
-   { id: 3, name: 'Erika', color: 'green' },
- ]
-```
-
-Assume that you then perform this sequence in your resource class body:
-
-```
-filter = FilterTable.create
-filter.register_filter_method(:entries)
-filter.register_filter_method(:where)
-filter.register_custom_property(:exists?) { |x| !x.exists.empty? }
-filter.register_custom_property(:names, field: :name)
-filter.install_filter_methods_on_resource(self, :fetch_data)
-```
-
-Legacy code equivalent:
-
-```
-filter = FilterTable.create
-filter.add_accessor(:entries)
-filter.add_accessor(:where)
-filter.add(:exists?) { |x| !x.exists.empty? }
-filter.add(:names, field: :name)
-filter.connect(self, :fetch_data)
-```
-
-We know from the above exploration of `install_filter_methods_on_resource` / `connect` that we now have several new methods on the resource class, all of which delegate to the FilterTable::Table implementation.
-
-### FilterTable::Table constructor and internals
-
-Factory calls the FilterTable::Table constructor at 87-93 with three args. Table stores them into instance vars:
- * @resource_instance - this was passed in as `self` from line 342
- * @raw_data - an array of hashes
- * @criteria_string - This looks to be stringification trace data; the string ' with' was passed in by Factory.
- * @populated_lazy_columns = a hash, by lazy field name, with boolean values.  This is set true if `populate_lazy_field` is called on a field.
-
-The first three get exposed via `attr_reader`s.
-
-### `entries` behavior
-
-From usage, I expect entries to return a structure that resembles an array of hashes representing the (filtered) data.
-
-#### A new method `entries` is defined on the resource class
-
-That is performed by Factory#connect line 339.
-
-#### It delegates to FilterTable::Table#entries
-
-This is a real method defined in filter.rb line 155.
-
-It loops over the provided raw data (@raw_data) and builds an array, calling `create_eval_context_for_row` (see Factory lines 297-303) on each row; also appending a stringification trace to each entry.  The array is returned.
-
-#### `entries` conclusion
-
-Not Surprising: It does behave as expected - an array of Hash-like structs representing the table.  I don't know why it adds in the per-row stringification data - I've never seen that used.
-
-Surprising: this is a real method with a concrete implementation.  That means that you can't call `filter.add_accessor` with arbitrary method names - `:entries` means something very specific.
-
-Surprising: I would not recommend this method be used for data access; instead I would recommend using `raw_data`.  
-
-### `where` behavior
-
-From usage, I expect this to take either method params or a block (both of which are magical), perform filtering, and return some object that contains only the filtered rows.
-
-So, what happens when you call `register_filter_method(:where)` and then call `resource.where`?
-
-#### A new method `where` is defined on the resource class
-
-That is performed by Factory#connect line 339.
-
-#### It delegates to FilterTable::Table#where
-
-Like `entries`, this is a real implemented method on FilterTable::Table, at line 98.
-
-The method accepts all params as the local var `conditions` which defaults to an empty Hash. A block, if any, is also explicitly assigned the name `block`.
-
-The implementation opens with two guard clauses, both of which will return `self` (which is the FilterTable::Table subclass instance).
-
-MISFEATURE: The first guard clause simply returns the Table if `conditions` is not a Hash.  That would mean that someone called it like: `thing.where(:apples, :bananas, :cantaloupes)`.  That misuse is silently ignored; I think we should probably throw a ResourceFailed or something.
-
-The second guard clause is a sensible degenerate case - return the existing Table if there are no conditions and no block.  So `thing.where` is OK.
-
-Line 103 initializes a local var, `new_criteria_string`, which again is a stringification tracker.
-
-Line 104 initializes a var to track the `filtered_raw_data`.
-
-Lines 108-113 loop over the provided Hash `conditions`. If the requested field is lazy, it requests that it be populated (note that `populate_lazy_field` is idempotent - it won't fetch a field twice).  Next, it repeatedly down-filters `filtered_raw_data` by calling the private method `filter_raw_data` on it.  `filter_raw_data` does some syntactic sugaring for common types, Integers and Floats and Regexp matching.  Additionally, the line 108-113 loop builds up the stringification tracker, `new_criteria_string`, by stringifying the field name and target value.
-
-Line 118-135 begins work if a filtration block has been provided.  At this point, `filtered_raw_data` has been initialized with the raw data, and (if method params were provided) has also been filtered down.
-
-Line 120 filters the rows of the raw data using an interesting approach. Each row is inflated to a Struct using `create_eval_context_for_row` (see line 297). Then the provided block is `instance_eval`'d against the Struct.  Because the Struct was defined with attributes (that is, accessor methods) for each declared field name (from FilterTable::Factory#register_custom_property), you can use field names in the block, and each row-as-struct will be able to respond.  If the field happened to be lazy, we'll call our custom getter from lines 306-329.
-
-_That just explained a major spooky side-effect for me._
-
-Lines 125-134 do something with stringification tracing.  TODO.
-
-Finally, at line 137, the FilterTable::Table anonymous subclass is again used to construct a new instance, passing on the resource reference, the newly filtered raw data table, and the newly adjusted stringification tracer.
-
-That new Table instance is returned, and thus `where` allows you to chain.
-
-#### `where` conclusion
-
-Unsurprising: How where works with method params.
-Surprising: How where works in block mode, `instance_eval`'ing against each row-as-Struct.
-Surprising: You can use method-mode and block-mode together if you want.